Skip to contentSkip to conversation

libevdev: bump version to 1.4.4

PATCH New Peter Seiderer 2 participants 4 messages Oct 11, 2015 – Oct 12, 2015

lore
Share & tools
lore

Peter Seiderer

author
#0 lore raw

PATCH v2 1/2 libevdev: bump version to 1.4.4

From [1]:

A couple of cleanups, one notable fix: we now transparently fix invalid ABS_MT_TRACKING_ID ranges to something sensible.

The touchpad-edge-detector tool prints out suggested hwdb rules for resolution overrides. And since the resolution is the main thing to fix on a device, the libevdev-tweak-device now has a --resolution argument to quickly set the resolution on the x/y axes.

[1] http://lists.freedesktop.org/archives/input-tools/2015-August/001210.html

Signed-off-by Peter Seiderer <[email protected]>

---
Changes v1 -> v2:
- no changes

---
 package/libevdev/libevdev.hash | 4 ++--
 package/libevdev/libevdev.mk   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
package/libevdev/libevdev.hash +2 -2
index 1b7897d..1e44bf8 100644
@@ -1,2 +1,2 @@
-# Hash from http://lists.freedesktop.org/archives/input-tools/2015-June/001171.html
-sha256 1c418b26fd78b0e9900872be2f77fb5311c877b34ec5c75efd1b670ed627969b libevdev-1.4.3.tar.xz
+# Hash from http://lists.freedesktop.org/archives/input-tools/2015-August/001210.html
+sha256 ed9979369b6a6e28f5897d099538549ecffb2b7c00c1b717eb77c31d85bc45a9 libevdev-1.4.4.tar.xz
package/libevdev/libevdev.mk +1 -1
index 082a7cc..d9a2be6 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBEVDEV_VERSION = 1.4.3
+LIBEVDEV_VERSION = 1.4.4
 LIBEVDEV_SITE = http://www.freedesktop.org/software/libevdev
 LIBEVDEV_SOURCE = libevdev-$(LIBEVDEV_VERSION).tar.xz
 LIBEVDEV_LICENSE = X11
Signature · 1 line
2.1.4
author
#1 lore raw

PATCH v2 2/2 libevdev: disable runtime tests

Add new configure option '--disable-runtime-tests' and use it do disable runtime tests which fail to compile on some uclibc configurations.

Fixes [1], [2]:
test-libevdev-init.c: In function 'test_set_clock_id':
test-libevdev-init.c:493: error: 'CLOCK_MONOTONIC_RAW' undeclared (first use in this function)

and compile failure for !BR2_USE_MMU configuration:
test-main.c:(.text+0x8): undefined reference to `_fork'

[1] http://autobuild.buildroot.net/results/0d0/0d0a987471ce8e9f76fc96e0ae8f0bfeadb45028/
[2] http://autobuild.buildroot.net/results/939/9392033f1b8d2c8e4e8791c90918dabbe28a7067/

Signed-off-by Peter Seiderer <[email protected]>

---
Changes v1 -> v2:
- remove silly debug stuff from added patch

---
 ...onfigure-add-disable-runtime-tests-option.patch | 42 ++++++++++++++++++++++
 package/libevdev/libevdev.mk                       |  5 +++
 2 files changed, 47 insertions(+)
 create mode 100644 package/libevdev/0001-configure-add-disable-runtime-tests-option.patch
package/libevdev/0001-configure-add-disable-runtime-tests-option.patch new file +42 -0
new file mode 100644
index 0000000..405dff0
@@ -0,0 +1,42 @@
+From 95527e43845a5063a6125d7779a30d44c3b437ac Mon Sep 17 00:00:00 2001
+From: Peter Seiderer <[email protected]>
+Date: Sun, 11 Oct 2015 13:33:19 +0200
+Subject: [PATCH] configure: add '--disable-runtime-tests' option
+
+Signed-off-by: Peter Seiderer <[email protected]>
+---
+ configure.ac | 11 +++++++++--
+ 1 file changed, 9 insertions(+), 2 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index 54a2510..286737b 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -74,7 +74,14 @@ else
+ 	AC_MSG_WARN([check not found - skipping building unit tests])
+ fi
+ AM_CONDITIONAL(HAVE_VALGRIND, [test "x$VALGRIND" != "x"])
+-AM_CONDITIONAL(ENABLE_RUNTIME_TESTS, [test "x$HAVE_CHECK" = "xyes"])
++
++AC_ARG_ENABLE([runtime-tests],
++	AS_HELP_STRING([--disable-runtime-tests], [Disable runtime tests]))
++AS_IF([test "x$enable_runtime_tests" != "xno"],
++	[enable_runtime_tests=yes],
++	[enable_runtime_tests=no])
++
++AM_CONDITIONAL(ENABLE_RUNTIME_TESTS, [test "x${enable_runtime_tests}x$HAVE_CHECK" = "xyesxyes"])
+ AM_CONDITIONAL(ENABLE_STATIC_LINK_TEST, [test "x$enable_static" = "xyes"])
+ 
+ with_cflags=""
+@@ -159,7 +166,7 @@ AC_MSG_RESULT([
+ 	       Libdir				${libdir}
+ 
+ 	       Build documentation		${have_doxygen}
+-	       Enable unit-tests		${HAVE_CHECK}
++	       Enable unit-tests		${HAVE_CHECK} (runtime-tests: ${enable_runtime_tests})
+ 	       Enable profiling			${enable_gcov}
+ 	       Static library symbol check	${static_symbol_leaks_test}
+ 	       ])
+-- 
+2.1.4
+
package/libevdev/libevdev.mk +5 -0
index d9a2be6..97d8a92 100644
@@ -10,9 +10,14 @@ LIBEVDEV_SOURCE = libevdev-$(LIBEVDEV_VERSION).tar.xz
 LIBEVDEV_LICENSE = X11
 LIBEVDEV_LICENSE_FILES = COPYING
 
+# patch touches configure.ac
+LIBEVDEV_AUTORECONF = YES
+
 # Uses PKG_CHECK_MODULES() in configure.ac
 LIBEVDEV_DEPENDENCIES = host-pkgconf
 
 LIBEVDEV_INSTALL_STAGING = YES
 
+LIBEVDEV_CONF_OPTS += --disable-runtime-tests
+
 $(eval $(autotools-package))
Signature · 1 line
2.1.4
Applied
#2 lore raw

PATCH v2 2/2 libevdev: disable runtime tests

Dear Peter Seiderer,

Quoted 15 lines · Peter Seiderer

Add new configure option '--disable-runtime-tests' and use it do disable runtime tests which fail to compile on some uclibc configurations.

Fixes [1], [2]:
test-libevdev-init.c: In function 'test_set_clock_id':
test-libevdev-init.c:493: error: 'CLOCK_MONOTONIC_RAW' undeclared (first use in this function)

and compile failure for !BR2_USE_MMU configuration:
test-main.c:(.text+0x8): undefined reference to `_fork'

[1] http://autobuild.buildroot.net/results/0d0/0d0a987471ce8e9f76fc96e0ae8f0bfeadb45028/
[2] http://autobuild.buildroot.net/results/939/9392033f1b8d2c8e4e8791c90918dabbe28a7067/

Signed-off-by Peter Seiderer <[email protected]>
Quoted 8 lines

---
Changes v1 -> v2:
- remove silly debug stuff from added patch

---
 ...onfigure-add-disable-runtime-tests-option.patch | 42 ++++++++++++++++++++++
 package/libevdev/libevdev.mk                       |  5 +++
 2 files changed, 47 insertions(+)
 create mode 100644 package/libevdev/0001-configure-add-disable-runtime-tests-option.patch

Applied, but please submit the patch upstream (or ask upstream to implement a different solution for the problem).

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Applied
#3 lore raw

PATCH v2 1/2 libevdev: bump version to 1.4.4

In reply to Peter Seiderer

Dear Peter Seiderer,

Quoted 12 lines · Peter Seiderer

From [1]:

A couple of cleanups, one notable fix: we now transparently fix invalid ABS_MT_TRACKING_ID ranges to something sensible.

The touchpad-edge-detector tool prints out suggested hwdb rules for resolution overrides. And since the resolution is the main thing to fix on a device, the libevdev-tweak-device now has a --resolution argument to quickly set the resolution on the x/y axes.

[1] http://lists.freedesktop.org/archives/input-tools/2015-August/001210.html

Quoted 8 lines
Signed-off-by Peter Seiderer <[email protected]>

---
Changes v1 -> v2:
- no changes

---
 package/libevdev/libevdev.hash | 4 ++--
 package/libevdev/libevdev.mk   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com