pyqtgraph: new package
A message that is not in the archive (sent off-list or not yet received): Re: [Buildroot] [PATCH 2/2] Add new package PyQtGraph
PATCH v2 1/1 pyqtgraph: new package
---
Applied modifications suggested by Arnout:
package/python-pyqtgraph/Config.in now depends on the new variable:
BR2_PACKAGE_PYTHON_NUMPY_ARCH_DEPENDS.
package/python-pyqtgraph/Config.in selects Qt/PyQt.
comment all dependencies.
--- package/Config.in | 1 + package/python-pyqtgraph/Config.in | 22 ++++++++++++++++++++++ package/python-pyqtgraph/python-pyqtgraph.hash | 5 +++++ package/python-pyqtgraph/python-pyqtgraph.mk | 15 +++++++++++++++ 4 files changed, 43 insertions(+) create mode 100644 package/python-pyqtgraph/Config.in create mode 100644 package/python-pyqtgraph/python-pyqtgraph.hash create mode 100644 package/python-pyqtgraph/python-pyqtgraph.mk
package/Config.in +1 -0
@@ -645,6 +645,7 @@ menu "external python modules" source "package/python-pyparsing/Config.in" source "package/python-pypcap/Config.in" source "package/python-pyqt/Config.in" + source "package/python-pyqtgraph/Config.in" source "package/python-pyratemp/Config.in" source "package/python-pyro/Config.in" source "package/python-pyroute2/Config.in"
package/python-pyqtgraph/Config.in new file +22 -0
@@ -0,0 +1,22 @@ +comment "python-pyqtgraph requires a (e)glibc toolchain w/ wchar and C++" + depends on BR2_PACKAGE_PYTHON_NUMPY_ARCH_DEPENDS + depends on BR2_USE_MMU + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS + +config BR2_PACKAGE_PYTHON_PYQTGRAPH + bool "python-pyqtgraph" + depends on BR2_PACKAGE_PYTHON_NUMPY_ARCH_DEPENDS + depends on BR2_USE_MMU # pyqt -> qt + depends on BR2_INSTALL_LIBSTDCPP # pyqt -> qt + depends on BR2_TOOLCHAIN_HAS_THREADS # pyqt -> qt + select BR2_PACKAGE_PYTHON_PYQT + select BR2_PACKAGE_PYTHON_NUMPY # runtime dependency + select BR2_PACKAGE_PYTHON_PYEXPAT # runtime dependency + select BR2_PACKAGE_QT_SVG # runtime dependency + select BR2_PACKAGE_QT_GUI_MODULE + help + Pyqtgraph is a pure Python graphics and GUI library built on PyQt4, + PySide and Numpy. + + Official website: + http://www.pyqtgraph.org/
package/python-pyqtgraph/python-pyqtgraph.hash new file +5 -0
@@ -0,0 +1,5 @@ +# From http://www.pyqtgraph.org/downloads +md5 6e2efa185b6b9227dfe16fefd921a8ec pyqtgraph-0.9.10.tar.gz + +# Locally calculated: +sha256 4c0589774e3c8b0c374931397cf6356b9cc99a790215d1917bb7f015c6f0729a pyqtgraph-0.9.10.tar.gz
package/python-pyqtgraph/python-pyqtgraph.mk new file +15 -0
@@ -0,0 +1,15 @@ +################################################################################ +# +# python-pyqtgraph +# +################################################################################ + +PYTHON_PYQTGRAPH_VERSION = 0.9.10 +PYTHON_PYQTGRAPH_SOURCE = pyqtgraph-$(PYTHON_PYQTGRAPH_VERSION).tar.gz +PYTHON_PYQTGRAPH_SITE = http://www.pyqtgraph.org/downloads +PYTHON_PYQTGRAPH_LICENSE = MIT +PYTHON_PYQTGRAPH_LICENSE_FILES = COPYING +PYTHON_PYQTGRAPH_SETUP_TYPE = distutils +PYTHON_PYQTGRAPH_DEPENDENCIES = python-pyqt + +$(eval $(python-package))
Signature · 1 line
1.7.10.4
PATCH v2 1/1 pyqtgraph: new package
Dear Guillaume William Bres,
Thanks for this new version. Though I believe it still has some issues (see below).
package/python-pyqtgraph/Config.in line 1
Quoted 7 lines · Guillaume William Bres
package/python-pyqtgraph/Config.in new file +1
-0@@ -0,0 +1,22 @@ +comment "python-pyqtgraph requires a (e)glibc toolchain w/ wchar and C++"
So the comment says that you need eglibc with wchar and C++.
package/python-pyqtgraph/Config.in line 4
Quoted 3 lines
package/python-pyqtgraph/Config.in new file +3
-0+ depends on BR2_PACKAGE_PYTHON_NUMPY_ARCH_DEPENDS + depends on BR2_USE_MMU + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
But the dependencies have absolutely nothing to do with the comment. Can you explain?
What you need is:
comment "python-pyqtgraph requires a toolchain w/ C++, threads"
depends on BR2_PACKAGE_PYTHON_NUMPY_ARCH_DEPENDS depends on BR2_USE_MMU
depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
package/python-pyqtgraph/Config.in line 14
Quoted 10 lines
package/python-pyqtgraph/Config.in new file +10
-0+ +config BR2_PACKAGE_PYTHON_PYQTGRAPH + bool "python-pyqtgraph" + depends on BR2_PACKAGE_PYTHON_NUMPY_ARCH_DEPENDS + depends on BR2_USE_MMU # pyqt -> qt + depends on BR2_INSTALL_LIBSTDCPP # pyqt -> qt + depends on BR2_TOOLCHAIN_HAS_THREADS # pyqt -> qt + select BR2_PACKAGE_PYTHON_PYQT + select BR2_PACKAGE_PYTHON_NUMPY # runtime dependency + select BR2_PACKAGE_PYTHON_PYEXPAT # runtime dependency
python-pyqt supports both Python 2 and Python 3. By doing this select here, you break things if Python 3 is used. So you have two options:
* If python-pyqtgraph only works with Python 2, add a "depends on BR2_PACKAGE_PYTHON"
* If python-pyqtgraph works with both Python 2 and Python 3, you should:
select BR2_PACKAGE_PYTHON_PYEXPAT if BR2_PACKAGE_PYTHON select BR2_PACKAGE_PYTHON3_PYEXPAT if BR2_PACKAGE_PYTHON3
(and of course do a build + run test with Python 3)
Quoted 26 lines
package/python-pyqtgraph/Config.in new file +8
-0+ select BR2_PACKAGE_QT_SVG # runtime dependency + select BR2_PACKAGE_QT_GUI_MODULE + help + Pyqtgraph is a pure Python graphics and GUI library built on PyQt4, + PySide and Numpy. + + Official website: + http://www.pyqtgraph.org/package/python-pyqtgraph/python-pyqtgraph.hash new file +5
-0@@ -0,0 +1,5 @@ +# From http://www.pyqtgraph.org/downloads +md5 6e2efa185b6b9227dfe16fefd921a8ec pyqtgraph-0.9.10.tar.gz + +# Locally calculated: +sha256 4c0589774e3c8b0c374931397cf6356b9cc99a790215d1917bb7f015c6f0729a pyqtgraph-0.9.10.tar.gzpackage/python-pyqtgraph/python-pyqtgraph.mk new file +1
-0@@ -0,0 +1,15 @@ +################################################################################
package/python-pyqtgraph/python-pyqtgraph.mk line 11
Quoted 10 lines
package/python-pyqtgraph/python-pyqtgraph.mk new file +10
-0+# +# python-pyqtgraph +# +################################################################################ + +PYTHON_PYQTGRAPH_VERSION = 0.9.10 +PYTHON_PYQTGRAPH_SOURCE = pyqtgraph-$(PYTHON_PYQTGRAPH_VERSION).tar.gz +PYTHON_PYQTGRAPH_SITE = http://www.pyqtgraph.org/downloads +PYTHON_PYQTGRAPH_LICENSE = MIT +PYTHON_PYQTGRAPH_LICENSE_FILES = COPYING
There is no file named COPYING in the source. It's named LICENSE.txt.
Could you fix those issues and post an updated version?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH v2 1/1 pyqtgraph: new package
Dear Guillaume William Bres,
Why did you reply to buildroot-request at busybox.net and not to the normal mailing list address buildroot at busybox.net ?
Quoted 7 lines · Guillaume William Bres
__On10/12/2015 02:54 PM, Thomas Petazzoni :_So the comment says that you need eglibc with wchar and C++. But the dependencies have absolutely nothing to do with the
comment. Can you explain?These were Arnout's corrections for Patch v1/.//
Hum, I'm not sure why, but at least the comment should be consistent with the dependencies.
Quoted 2 lines
I thought COPYING was a Buildroot command (I copied that line from other packages), now I know it's the name of the license file.
For all details about the Buildroot variables, look at the manual. All of them are documented.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com