perf hists browser: Add 'm' key for context menu display
Namhyung Kim
maintainerPATCH 1/1 perf hists browser: Add 'm' key for context menu display
With horizontal scrolling, the left/right arrow keys are used to scroll columns and ENTER/ESC keys are used to enter/exit menu. However if callchain is recorded, the ENTER key is used to toggle callchain expansion so there's no way to display menu. Use 'm' key to display the menu for this case.
--- tools/perf/ui/browsers/hists.c | 2 ++ 1 file changed, 2 insertions(+)
tools/perf/ui/browsers/hists.c +2 -0
@@ -1769,6 +1769,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,"E Expand all callchains\n" \"F Toggle percentage of filtered entries\n" \"H Display column headers\n" \ +"m Display context menu\n" \"S Zoom into current Processor Socket\n" \/* help messages are sorted by lexical order of the hotkey */
@@ -1934,6 +1935,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,continue ;case K_ENTER :case K_RIGHT : +case 'm' :/* menu */ break ;case K_ESC :
Signature · 1 line
2.6.1
Em Tue, Oct 13, 2015 at 09:02:01AM +0900, Namhyung Kim escreveu:
Quoted 5 lines
With horizontal scrolling, the left/right arrow keys are used to scroll columns and ENTER/ESC keys are used to enter/exit menu. However if callchain is recorded, the ENTER key is used to toggle callchain expansion so there's no way to display menu. Use 'm' key to display the menu for this case.
Thanks, applied.
- Arnaldo
Quoted 27 lines
Signed-off-by Namhyung Kim <[email protected]>--- tools/perf/ui/browsers/hists.c | 2 ++ 1 file changed, 2 insertions(+)tools/perf/ui/browsers/hists.c +2
-0@@ -1769,6 +1769,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,"E Expand all callchains\n" \"F Toggle percentage of filtered entries\n" \"H Display column headers\n" \ +"m Display context menu\n" \"S Zoom into current Processor Socket\n" \/* help messages are sorted by lexical order of the hotkey */ @@ -1934,6 +1935,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,continue ;case K_ENTER :case K_RIGHT : +case 'm' :/* menu */ break ;case K_ESC :Signature · 1 line
2.6.1
tip-bot for Namhyung Kim
merge botperf hists browser: Add 'm' key for context menu display
Commit-ID: 31eb4360546b4bd890f349db01295a173c09b0fb Gitweb: http://git.kernel.org/tip/31eb4360546b4bd890f349db01295a173c09b0fb Author: Namhyung Kim <[email protected]> AuthorDate: Tue, 13 Oct 2015 09:02:01 +0900 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 12 Oct 2015 23:29:14 -0300
perf hists browser: Add 'm' key for context menu display
With horizontal scrolling, the left/right arrow keys are used to scroll columns and ENTER/ESC keys are used to enter/exit menu. However if callchain is recorded, the ENTER key is used to toggle callchain expansion so there's no way to display menu. Use 'm' key to display the menu for this case.
--- tools/perf/ui/browsers/hists.c | 2 ++ 1 file changed, 2 insertions(+)
tools/perf/ui/browsers/hists.c +2 -0
@@ -1769,6 +1769,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,"E Expand all callchains\n" \"F Toggle percentage of filtered entries\n" \"H Display column headers\n" \ +"m Display context menu\n" \"S Zoom into current Processor Socket\n" \/* help messages are sorted by lexical order of the hotkey */
@@ -1935,6 +1936,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,continue ;case K_ENTER :case K_RIGHT : +case 'm' :/* menu */ break ;case K_ESC :