ALSA: pcm: harmless underflow issue in snd_pcm_sw_params()

"params->tstamp_mode" is a user supplied int. We cap the maximum but allow negative values by mistake. It's harmless but static checkers complain.

Signed-off-by Dan Carpenter <[email protected]>

sound/core/pcm_native.c +2 -1

index 75888dd..4863af5 100644
@@ -650,7 +650,8 @@ static int snd_pcm_sw_params(struct snd_pcm_substream *substream,
 	}
 	snd_pcm_stream_unlock_irq(substream);
 
-	if (params->tstamp_mode > SNDRV_PCM_TSTAMP_LAST)
+	if (params->tstamp_mode < 0 ||
+	    params->tstamp_mode > SNDRV_PCM_TSTAMP_LAST)
 		return -EINVAL;
 	if (params->proto >= SNDRV_PROTOCOL_VERSION(2, 0, 12) &&
 	    params->tstamp_type > SNDRV_PCM_TSTAMP_TYPE_LAST)

Quoted 6 lines · Dan Carpenter

"params->tstamp_mode" is a user supplied int. We cap the maximum but allow negative values by mistake. It's harmless but static checkers complain.

Signed-off-by Dan Carpenter <[email protected]>

You already sent the same fix and it was applied in the commit 145d92e77e6f.