mk: Quote $(KERNELCC) to allow ccache builds
PATCH 1/1 mk: Quote $(KERNELCC) to allow ccache builds
Otherwise building with KERNELCC="ccache gcc" will fail:
== Build lib/librte_eal/linuxapp/igb_uio /usr/src/linux-headers-3.13.0-63-generic/arch/x86/Makefile:98: stack protector enabled but no compiler support /usr/src/linux-headers-3.13.0-63-generic/arch/x86/Makefile:113: CONFIG_X86_X32 enabled but no binutils support
ccache: invalid option -- 'p'
Usage:
ccache [options]
ccache compiler [compiler options]
compiler [compiler options] (via symbolic link)
Options:
-c, --cleanup delete old files and recalculate size counters
(normally not needed as this is done automatically)
-C, --clear clear the cache completely
-F, --max-files=N set maximum number of files in cache to N (use 0 for
no limit)
-M, --max-size=SIZE set maximum size of cache to SIZE (use 0 for no
limit; available suffixes: G, M and K; default
suffix: G)
-s, --show-stats show statistics summary
-z, --zero-stats zero statistics counters
-h, --help print this help text
-V, --version print version and copyright information
--- mk/rte.module.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mk/rte.module.mk +1 -1
@@ -78,7 +78,7 @@ build: _postbuild $(MODULE).ko: $(SRCS_LINKS) @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \ - CC=$(KERNELCC) CROSS_COMPILE=$(CROSS) V=$(if $V,1,0) + CC="$(KERNELCC)" CROSS_COMPILE=$(CROSS) V=$(if $V,1,0) # install module in $(RTE_OUTPUT)/kmod $(RTE_OUTPUT)/kmod/$(MODULE).ko: $(MODULE).ko
Signature · 1 line
1.9.1
Ping?
This is one of three outstanding DPDK patches I have which hasn't seen any activitiy in a while. Is there a list of pending applies somewhere to monitor activity?
// Simon
Quoted 44 lines · On Thu, 24 Sep 2015 09:43:28 +0200 Simon Kagstrom…
Otherwise building with KERNELCC="ccache gcc" will fail:
== Build
lib/librte_eal/linuxapp/igb_uio/usr/src/linux-headers-3.13.0-63-generic/arch/x86/Makefile:98: stack protector enabled but no compiler support/usr/src/linux-headers-3.13.0-63-generic/arch/x86/Makefile:113:CONFIG_X86_X32enabled but no binutils support
ccache: invalid option -- 'p'
Usage:
ccache [options]
ccache compiler [compiler options]
compiler [compiler options] (via symbolic link)Options:
-c, --cleanup delete old files and recalculate size counters
(normally not needed as this is done automatically)
-C, --clear clear the cache completely
-F, --max-files=N set maximum number of files in cache to N (use 0 for
no limit)
-M, --max-size=SIZE set maximum size of cache to SIZE (use 0 for no
limit; available suffixes: G, M and K; default
suffix: G)
-s, --show-stats show statistics summary
-z, --zero-stats zero statistics counters-h, --help print this help text
-V, --version print version and copyright informationSigned-off-by Simon Kagstrom <[email protected]>--- mk/rte.module.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mk/rte.module.mk +1
-1@@ -78,7 +78,7 @@ build: _postbuild $(MODULE).ko: $(SRCS_LINKS) @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \ - CC=$(KERNELCC) CROSS_COMPILE=$(CROSS) V=$(if $V,1,0) + CC="$(KERNELCC)" CROSS_COMPILE=$(CROSS) V=$(if $V,1,0) # install module in $(RTE_OUTPUT)/kmod $(RTE_OUTPUT)/kmod/$(MODULE).ko: $(MODULE).ko
Olivier MATZ
Acked-byHi Simon,
Sorry for not having answered before.
Quoted 5 lines · Simon Kagstrom
Ping?
This is one of three outstanding DPDK patches I have which hasn't seen any activitiy in a while. Is there a list of pending applies somewhere to monitor activity?
There is the patchwork tool:
http://dpdk.org/dev/patchwork/project/dpdk/list/
Quoted 23 lines
Quoted 23 lines
Otherwise building with KERNELCC="ccache gcc" will fail:
== Build
lib/librte_eal/linuxapp/igb_uio/usr/src/linux-headers-3.13.0-63-generic/arch/x86/Makefile:98: stack protector enabled but no compiler support/usr/src/linux-headers-3.13.0-63-generic/arch/x86/Makefile:113:CONFIG_X86_X32enabled but no binutils support
ccache: invalid option -- 'p'
Usage:
ccache [options]
ccache compiler [compiler options]
compiler [compiler options] (via symbolic link)Options:
-c, --cleanup delete old files and recalculate size counters
(normally not needed as this is done automatically)
-C, --clear clear the cache completely
-F, --max-files=N set maximum number of files in cache to N (use 0 for
no limit)
-M, --max-size=SIZE set maximum size of cache to SIZE (use 0 for no
limit; available suffixes: G, M and K; default
suffix: G)
-s, --show-stats show statistics summary
-z, --zero-stats zero statistics counters
Quoted 4 lines
Quoted 4 lines
-h, --help print this help text
-V, --version print version and copyright informationSigned-off-by Simon Kagstrom <[email protected]>
Quoted 1 line · Olivier MATZ
Sorry for not having answered before.
Thanks for looking at it now though!
Quoted 6 lines
Quoted 3 lines
This is one of three outstanding DPDK patches I have which hasn't seen any activitiy in a while. Is there a list of pending applies somewhere to monitor activity?
There is the patchwork tool:
http://dpdk.org/dev/patchwork/project/dpdk/list/
Thanks! I knew about it, but forgot to look there. It would be nice to have tags to signify e.g., for-v2.2, candidate-v2.2 etc. like you can have on github to easier see where patches are going, but perhaps patchwork doesn't work that way.
Is the process to ping old patches like this on the mailing list? Two of the patches (this one included) I have outstanding are build fixes for use in our build environment, so it would be nice to them upstreamed.
// Simon
2015-10-13 14:39, Simon Kågström:
Quoted 8 lines · Olivier MATZ
Quoted 2 lines
There is the patchwork tool:
http://dpdk.org/dev/patchwork/project/dpdk/list/Thanks! I knew about it, but forgot to look there. It would be nice to have tags to signify e.g., for-v2.2, candidate-v2.2 etc. like you can have on github to easier see where patches are going, but perhaps patchwork doesn't work that way.
No it's not needed currently because every patches in this mailing-list target an integration in the main branch for the next release. Exceptions must be notified.
Quoted 1 line
Is the process to ping old patches like this on the mailing list?
Yes it is the responsibility of the developer and the maintainer to get reviews. Please check in the MAINTAINERS file who to contact.
Quoted 2 lines
Two of the patches (this one included) I have outstanding are build fixes for use in our build environment, so it would be nice to them upstreamed.
Waiting for integration of your patches, maybe you have some free time to help other developers by making reviews ;)
Thanks
Quoted 6 lines · Thomas Monjalon
2015-10-13 14:39, Simon Kågström:
Quoted 2 lines
Two of the patches (this one included) I have outstanding are build fixes for use in our build environment, so it would be nice to them upstreamed.
Waiting for integration of your patches, maybe you have some free time to help other developers by making reviews ;)
Waiting for integration is not my only work-task :-)
Anyway, I have too superficial knowledge about DPDK to chime in with relevant comments in most cases, but I'll comment if I feel I can contribute.
// Simon
Thomas Monjalon
AppliedQuoted 3 lines
Quoted 1 line
Quoted 1 line
Signed-off-by Simon Kagstrom <[email protected]>Acked-by Olivier Matz <[email protected]>
Applied, thanks