Skip to contentSkip to conversation

perf: Correctly identify anon_hugepage when generating map

PATCH In review Yannick Brosseau 2 participants 2 messages Oct 8, 2015 – Oct 13, 2015 perf events

lore
Share & tools
lore

Yannick Brosseau

author
#0 lore raw

PATCH 1/1 perf: Correctly identify anon_hugepage when generating map

When parsing /proc/xxx/maps, the sscanf in perf_event__synthesize_mmap_events truncate the map name at the space in "/anon_hugepage (deleted)". is_anon_memory then only receive the string "/anon_hugepage" and do not detect it. We change is_anon_memory to only compare the first part of the string effectively ignoring if the (deleted) part is there or not.

Signed-off-by Yannick Brosseau <[email protected]>
---
 tools/perf/util/map.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/perf/util/map.c +2 -2
index b1c475d..9f7face 100644
@@ -26,8 +26,8 @@ const char *map_type__name[MAP__NR_TYPES] = {
 static inline int is_anon_memory(const char *filename)
 {
 	return !strcmp(filename, "//anon") ||
-	       !strcmp(filename, "/dev/zero (deleted)") ||
-	       !strcmp(filename, "/anon_hugepage (deleted)");
+	       !strncmp(filename, "/dev/zero", sizeof("/dev/zero")) ||
+	       !strncmp(filename, "/anon_hugepage", sizeof("/anon_hugepage"));
 }
 
 static inline int is_no_dso_memory(const char *filename)
Signature · 1 line
2.6.0
maintainer
#1 lore raw

Em Wed, Oct 07, 2015 at 05:31:46PM -0700, Yannick Brosseau escreveu:

Quoted 8 lines

When parsing /proc/xxx/maps, the sscanf in perf_event__synthesize_mmap_events truncate the map name at the space in "/anon_hugepage (deleted)". is_anon_memory then only receive the string "/anon_hugepage" and do not detect it. We change is_anon_memory to only compare the first part of the string effectively ignoring if the (deleted) part is there or not.

+++ b/tools/perf/util/map.c

tools/perf/util/map.c const char *map_type__name[MAP__NR_TYPES] = { · line 30

Quoted 7 lines
tools/perf/util/map.c +2 -2
@@ -26,8 +26,8 @@ const char *map_type__name[MAP__NR_TYPES] = {
 static inline int is_anon_memory(const char *filename)
 {
 	return !strcmp(filename, "//anon") ||
-	       !strcmp(filename, "/dev/zero (deleted)") ||
-	       !strcmp(filename, "/anon_hugepage (deleted)");
+	       !strncmp(filename, "/dev/zero", sizeof("/dev/zero")) ||
+	       !strncmp(filename, "/anon_hugepage", sizeof("/anon_hugepage"));

Have you tested this?

[acme@zoo ~]$ cat strncmp_sizeof.c
#include <string.h>
#include <stdio.h>

int main(void)
{

#define pattern "/anon_hugepage"
	size_t sz = sizeof(pattern);

	return printf("sizeof=%zd\nstrncmp(sz    )=%d\nstrncmp(sz - 1)=%d\n", sz,
			strncmp("/anon_hugepage (deleted)", pattern, sz),
			strncmp("/anon_hugepage (deleted)", pattern, sz - 1));
}

[acme@zoo ~]$ make strncmp_sizeof
cc strncmp_sizeof.c -o strncmp_sizeof
[acme@zoo ~]$ ./strncmp_sizeof
sizeof=15
strncmp(sz )=32
strncmp(sz - 1)=0
[acme@zoo ~]$

Hint, you're not considering the '\0'.

- Arnaldo