mplayer: needs zlib

Otherwise it will fail to compile with an error message like this one:

libavcodec/pngdec.c:35:18: fatal error: zlib.h: No such file or directory

 #include <zlib.h>
                  ^

compilation terminated.

Signed-off-by Vicente Olivert Riera <[email protected]>

---
 package/mplayer/Config.in  |    1 +
 package/mplayer/mplayer.mk |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)

package/mplayer/Config.in +1 -0

index 7a8b03f..80ad7f1 100644
@@ -6,6 +6,7 @@ config BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
 		|| BR2_microblaze || BR2_nios2)
 	# Broken support for <ARMv5
 	depends on !BR2_ARM_CPU_ARMV4
+	select BR2_PACKAGE_ZLIB
 
 config BR2_PACKAGE_MPLAYER
 	bool "mplayer"

package/mplayer/mplayer.mk +0 -0

index d896b35..0f5ced5 100644

While this solution is simple, I am not sure if this is the right one. It is in fact perfectly possible to build mplayer without zlib, by doing:

+MPLAYER_CONF_OPTS += --disable-decoder=apng --disable-encoder=apng --disable-decoder=tdsc

So in fact, zlib is only needed for two decoders/encoders in the ffmpeg code. However, it is not really clear to me how to handle this
properly: there is one configure script at the top-level directory, and then another one in the ffmpeg/ directory. And it is really the ffmpeg encoders/decoders that have this zlib requirement (and probably others?).

So, simple solution is to make zlib mandatory (which is reasonable:
zlib is small, and probably already part of most systems). However, I wonder if there are not some other dependencies for certain encoders/decoders.

Bernd, Gustavo, do you have some suggestions ?

Quoted 14 lines · Thomas Petazzoni

While this solution is simple, I am not sure if this is the right one. It is in fact perfectly possible to build mplayer without zlib, by doing:

+MPLAYER_CONF_OPTS += --disable-decoder=apng --disable-encoder=apng --disable-decoder=tdsc

So in fact, zlib is only needed for two decoders/encoders in the ffmpeg code. However, it is not really clear to me how to handle this
properly: there is one configure script at the top-level directory, and then another one in the ffmpeg/ directory. And it is really the ffmpeg encoders/decoders that have this zlib requirement (and probably others?).

Quoted 6 lines

So, simple solution is to make zlib mandatory (which is reasonable:
zlib is small, and probably already part of most systems). However, I wonder if there are not some other dependencies for certain encoders/decoders.

Bernd, Gustavo, do you have some suggestions ?

Hi Bernd, Thomas, Vicente.
Both apng and tdsc are on the same family of codecs, they're basically animated-image formats, apng being animated png, and tdsc being a form of animated jpeg.
Since in general we don't require any special deps for mplayer (and it doesn't require them most of the time) i'd say being able to build without zlib would be desirable, specially since these formats are unlikely to normally be used via mplayer (they probably weren't an available feature with 1.1.x)
So using an autodep on zlib seems better IMO.

Regards.

and why not disable apng and tdsc unconditionally? As you said, "these formats are unlikely to normally be used via mplayer", so if someone needs support for them, a future patch could do the work.

Regards,

Vincent.

Quoted 7 lines · Vicente Olivert Riera

and why not disable apng and tdsc unconditionally? As you said, "these formats are unlikely to normally be used via mplayer", so if someone needs support for them, a future patch could do the work.

Regards,

Vincent.

Hi Vincent.
Well, you could just do:

ifeq ($(BR2_PACKAGE_ZLIB),y)
MPLAYER_DEPENDENCIES += zlib
else
MPLAYER_CONF_OPTS += --disable-decoder=apng --disable-encoder=apng --disable-decoder=tdsc
endif

Can't you?
Regards.

Otherwise it will fail to compile with an error message like this one:

libavcodec/pngdec.c:35:18: fatal error: zlib.h: No such file or directory

 #include <zlib.h>
                  ^

compilation terminated.

Signed-off-by Vicente Olivert Riera <[email protected]>

---
 package/mplayer/Config.in  |    1 +
 package/mplayer/mplayer.mk |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)

package/mplayer/Config.in +1 -0

index 7a8b03f..80ad7f1 100644
@@ -6,6 +6,7 @@ config BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
 		|| BR2_microblaze || BR2_nios2)
 	# Broken support for <ARMv5
 	depends on !BR2_ARM_CPU_ARMV4
+	select BR2_PACKAGE_ZLIB
 
 config BR2_PACKAGE_MPLAYER
 	bool "mplayer"

package/mplayer/mplayer.mk +1 -1

index d896b35..0f5ced5 100644
@@ -7,7 +7,7 @@
 MPLAYER_VERSION = 1.2
 MPLAYER_SOURCE = MPlayer-$(MPLAYER_VERSION).tar.xz
 MPLAYER_SITE = http://www.mplayerhq.hu/MPlayer/releases
-MPLAYER_DEPENDENCIES = host-pkgconf
+MPLAYER_DEPENDENCIES = host-pkgconf zlib
 MPLAYER_LICENSE = GPLv2
 MPLAYER_LICENSE_FILES = LICENSE Copyright
 MPLAYER_CFLAGS = $(TARGET_CFLAGS)

Signature · 6 lines

1.7.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot