mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs
PATCH 1/1 mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs
This patch adds the mfd cell info for axp288 power key device.
--- drivers/mfd/axp20x.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
drivers/mfd/axp20x.c +20 -0
@@ -161,6 +161,21 @@ static struct resource axp22x_pek_resources[] = { }, }; +static struct resource axp288_power_button_resources[] = { + { + .name ="PEK_DBR" , + .start =AXP288_IRQ_POKN , + .end =AXP288_IRQ_POKN , + .flags =IORESOURCE_IRQ , + }, + { + .name ="PEK_DBF" , + .start =AXP288_IRQ_POKP , + .end =AXP288_IRQ_POKP , + .flags =IORESOURCE_IRQ , + }, +}; +static struct resource axp288_fuel_gauge_resources[] = { { .start =AXP288_IRQ_QWBTU ,
@@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = { .resources = axp288_fuel_gauge_resources, }, { + .name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */ + .num_resources = ARRAY_SIZE(axp288_power_button_resources), + .resources = axp288_power_button_resources, + }, + { .name = "axp288_pmic_acpi", }, };
Signature · 1 line
1.7.10.4
Quoted 35 lines · Borun Fu
This patch adds the mfd cell info for axp288 power key device.
Signed-off-by Borun Fu <[email protected]>Signed-off-by Fei Yang <[email protected]>--- drivers/mfd/axp20x.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)drivers/mfd/axp20x.c +15
-0@@ -161,6 +161,21 @@ static struct resource axp22x_pek_resources[] = { }, }; +static struct resource axp288_power_button_resources[] = { + { + .name ="PEK_DBR" , + .start =AXP288_IRQ_POKN , + .end =AXP288_IRQ_POKN , + .flags =IORESOURCE_IRQ , + }, + { + .name ="PEK_DBF" , + .start =AXP288_IRQ_POKP , + .end =AXP288_IRQ_POKP , + .flags =IORESOURCE_IRQ , + }, +}; +static struct resource axp288_fuel_gauge_resources[] = { { .start =AXP288_IRQ_QWBTU ,
drivers/mfd/axp20x.c static struct mfd_cell axp288_cells[] = { · line 590
Quoted 4 lines
drivers/mfd/axp20x.c +1
-0@@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = { .resources = axp288_fuel_gauge_resources, }, { + .name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
Doesn't this change insinuate that?
If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right?
Quoted 7 lines
drivers/mfd/axp20x.c +4
-0+ .num_resources = ARRAY_SIZE(axp288_power_button_resources), + .resources = axp288_power_button_resources, + }, + { .name = "axp288_pmic_acpi", }, };
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Quoted 11 lines
drivers/mfd/axp20x.c static struct mfd_cell axp288_cells[] = { · line 590
Quoted 8 lines
static struct resource axp288_fuel_gauge_resources[] = {
drivers/mfd/axp20x.c +1
-0{ .start = AXP288_IRQ_QWBTU,@@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = { .resources = axp288_fuel_gauge_resources, }, { + .name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */Doesn't this change insinuate that?
Quoted 2 lines
If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right?
Are you suggesting to remove the comment? Just want to make sure I understand you correctly.
Quoted 7 lines
drivers/mfd/axp20x.c static struct mfd_cell axp288_cells[] = { · line 597
Quoted 7 lines
drivers/mfd/axp20x.c +4
-0+ .num_resources = ARRAY_SIZE(axp288_power_button_resources), + .resources = axp288_power_button_resources, + }, + { .name = "axp288_pmic_acpi", }, };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay� ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m���� ������?�I�
Quoted 11 lines · Fei
Quoted 11 lines
drivers/mfd/axp20x.c static struct mfd_cell axp288_cells[] = { · line 590
Quoted 8 lines
static struct resource axp288_fuel_gauge_resources[] = {
drivers/mfd/axp20x.c +1
-0{ .start = AXP288_IRQ_QWBTU,@@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = { .resources = axp288_fuel_gauge_resources, }, { + .name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */Doesn't this change insinuate that?
Quoted 3 lines
Quoted 1 line
If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right?
Are you suggesting to remove the comment? Just want to make sure I understand you correctly.
I am.
Quoted 8 lines
Quoted 7 lines
Quoted 7 lines
drivers/mfd/axp20x.c +4
-0+ .num_resources = ARRAY_SIZE(axp288_power_button_resources), + .resources = axp288_power_button_resources, + }, + { .name = "axp288_pmic_acpi", }, };
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
So the patch will be refined to remove the comment as follows. Any else comments? @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
.resources = axp288_fuel_gauge_resources,
},
{
+ .name = "axp20x-pek",
+ .num_resources = ARRAY_SIZE(axp288_power_button_resources),
+ .resources = axp288_power_button_resources,
+ },
+ {
.name = "axp288_pmic_acpi",
},
};
Quoted 28 lines · Lee Jones
Quoted 11 lines · Fei
Quoted 11 lines
drivers/mfd/axp20x.c static struct mfd_cell axp288_cells[] = { · line 590
Quoted 8 lines
static struct resource axp288_fuel_gauge_resources[] = {
drivers/mfd/axp20x.c +1
-0{ .start = AXP288_IRQ_QWBTU,@@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = { .resources = axp288_fuel_gauge_resources, }, { + .name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */Doesn't this change insinuate that?
Quoted 3 lines
Quoted 1 line
If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right?
Are you suggesting to remove the comment? Just want to make sure I understand you correctly.
I am.
Quoted 8 lines
Quoted 7 lines
Quoted 7 lines
drivers/mfd/axp20x.c +4
-0+ .num_resources = ARRAY_SIZE(axp288_power_button_resources), + .resources = axp288_power_button_resources, + }, + { .name = "axp288_pmic_acpi", }, };
Quoted 2 lines · Borun Fu
So the patch will be refined to remove the comment as follows. Any else comments?
Please don't top post. If you have a comment about something that was said, please make your comment directly _after_ it (a.k.a inline).
drivers/mfd/axp20x.c static struct mfd_cell axp288_cells[] = { · line 597
Quoted 12 lines
drivers/mfd/axp20x.c +5
-0@@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = { .resources = axp288_fuel_gauge_resources, }, { + .name = "axp20x-pek", + .num_resources = ARRAY_SIZE(axp288_power_button_resources), + .resources = axp288_power_button_resources, + }, + { .name = "axp288_pmic_acpi", }, };
No need to do this. It doesn't save anyone any time.
Just resubmit the next version of the patch.
Quoted 29 lines · Lee Jones
Quoted 28 lines · Fei
Quoted 12 lines
Quoted 12 lines
drivers/mfd/axp20x.c static struct mfd_cell axp288_cells[] = { · line 590
Quoted 9 lines
static struct resource axp288_fuel_gauge_resources[] = {
drivers/mfd/axp20x.c +1
-0{ .start = AXP288_IRQ_QWBTU,@@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = { .resources = axp288_fuel_gauge_resources, }, { + .name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */Doesn't this change insinuate that?
Quoted 3 lines
Quoted 1 line
If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right?
Are you suggesting to remove the comment? Just want to make sure I understand you correctly.
I am.
Quoted 8 lines
Quoted 7 lines
Quoted 7 lines
drivers/mfd/axp20x.c +4
-0+ .num_resources = ARRAY_SIZE(axp288_power_button_resources), + .resources = axp288_power_button_resources, + }, + { .name = "axp288_pmic_acpi", }, };
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog