Skip to contentSkip to conversation

Staging: rtl8188eu: rf_cfg: Remove useless cast

PATCH In review Shivani Bhardwaj 2 participants 2 messages Oct 14, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: rtl8188eu: rf_cfg: Remove useless cast

Type conversion of variables can be done by compiler implicitly so, explicit conversions should be removed.
Semantic patch used:
@@
type T;
T e;
identifier x;
@@

* T x = (T)e;

---
 drivers/staging/rtl8188eu/hal/rf_cfg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/hal/rf_cfg.c +1 -1
index 954cade..067649a 100644
@@ -188,7 +188,7 @@ static void rtl8188e_config_rf_reg(struct adapter *adapt,
 	u32 addr, u32 data)
 {
 	u32 content = 0x1000; /*RF Content: radio_a_txt*/
-	u32 maskforphyset = (u32)(content & 0xE000);
+	u32 maskforphyset = content & 0xE000;
 
 	rtl_rfreg_delay(adapt, RF90_PATH_A, addr | maskforphyset,
 			RFREG_OFFSET_MASK,
Signature · 1 line
2.1.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Shivani Bhardwaj

Type conversion of variables can be done by compiler implicitly so, explicit conversions should be removed.
Semantic patch used:
@@
type T;
T e;
identifier x;
@@

Quoted 3 lines

* T x = (T)e;

Quoted 26 lines
---
 drivers/staging/rtl8188eu/hal/rf_cfg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/hal/rf_cfg.c +1 -2
index 954cade..067649a 100644
@@ -188,7 +188,7 @@ static void rtl8188e_config_rf_reg(struct adapter *adapt,
        u32 addr, u32 data)
 {
        u32 content = 0x1000; /*RF Content: radio_a_txt*/
-       u32 maskforphyset = (u32)(content & 0xE000);
+       u32 maskforphyset = content & 0xE000;
 
        rtl_rfreg_delay(adapt, RF90_PATH_A, addr | maskforphyset,
                        RFREG_OFFSET_MASK,
--

2.1.0

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151014185111.GA29205%40ubuntu.
For more options, visit https://groups.google.com/d/optout.