drivers: gpio: omap: add support for parsing additional gpio parameters
PATCH 1/1 drivers: gpio: omap: add support for parsing additional gpio parameters
With DM_GPIO, gpio parameters like ACTIVE_(LOW/HIGH) are to be parsed in xlate gpio drivers-ops. Since xlate is not implemented in omap_gpio driver, the driver considers all gpio to be ACTIVE_HIGH which is the default case and fails to return actual gpio status for ACTIVE_LOW gpios. So adding .xlate ops to omap_gpio.
--- drivers/gpio/omap_gpio.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/gpio/omap_gpio.c +11 -0
@@ -25,6 +25,7 @@#include <asm/io.h> #include <asm/errno.h> #include <malloc.h> +#include <dt-bindings/gpio/gpio.h> DECLARE_GLOBAL_DATA_PTR ;
@@ -276,12 +277,22 @@ static int omap_gpio_get_function(struct udevice *dev, unsigned offset)return GPIOF_INPUT ; } +static int omap_gpio_xlate (struct udevice *dev,struct gpio_desc *desc, +struct fdtdec_phandle_args *args) +{ + desc->offset = args->args[0 ]; + desc->flags = args->args[1 ] &GPIO_ACTIVE_LOW ?GPIOD_ACTIVE_LOW :0 ; + +return 0 ; +} +static const struct dm_gpio_ops gpio_omap_ops = { .direction_input = omap_gpio_direction_input, .direction_output = omap_gpio_direction_output, .get_value = omap_gpio_get_value, .set_value = omap_gpio_set_value, .get_function = omap_gpio_get_function, + .xlate = omap_gpio_xlate, };static int omap_gpio_probe (struct udevice *dev)
Signature · 1 line
2.6.1.133.gf5b6079
PATCH 1/1 drivers: gpio: omap: add support for parsing additional gpio parameters
Quoted 8 lines · Mugunthan V N
With
DM_GPIO, gpio parameters likeACTIVE_(LOW/HIGH)are to be parsed in xlate gpio drivers-ops. Since xlate is not implemented inomap_gpiodriver, the driver considers all gpio to beACTIVE_HIGHwhich is the default case and fails to return actual gpio status forACTIVE_LOWgpios. So adding .xlate ops toomap_gpio.Signed-off-by Mugunthan V N <[email protected]>
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151015/e24a7d4e/attachment.sig>
PATCH 1/1 drivers: gpio: omap: add support for parsing additional gpio parameters
In reply to Mugunthan V NQuoted 11 lines · Mugunthan V N
With
DM_GPIO, gpio parameters likeACTIVE_(LOW/HIGH)are to be parsed in xlate gpio drivers-ops. Since xlate is not implemented inomap_gpiodriver, the driver considers all gpio to beACTIVE_HIGHwhich is the default case and fails to return actual gpio status forACTIVE_LOWgpios. So adding .xlate ops toomap_gpio.Signed-off-by Mugunthan V N <[email protected]>--- drivers/gpio/omap_gpio.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
Quoted 10 lines · Mugunthan V N
With
DM_GPIO, gpio parameters likeACTIVE_(LOW/HIGH)are to be parsed in xlate gpio drivers-ops. Since xlate is not implemented inomap_gpiodriver, the driver considers all gpio to beACTIVE_HIGHwhich is the default case and fails to return actual gpio status forACTIVE_LOWgpios. So adding .xlate ops toomap_gpio.Signed-off-by Mugunthan V N <[email protected]>Reviewed-by Tom Rini <[email protected]>Reviewed-by Simon Glass <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151022/6fa17d28/attachment-0001.sig>