Skip to contentSkip to conversation

sqlcipher: disable tcl support

PATCH New Gustavo Zacarias 2 participants 2 messages Oct 15, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sqlcipher: disable tcl support

In commit b1dcb1c2 a fix was attempted at fixing a build failure where sqlcipher finds the distribution tcl and tries to build against it. sqlcipher has two tcl usage scenarios: host-tcl which is required to actually build it, and target tcl to build bindings.
Since cross-compilation of the bindings isn't clean it fails as well, and since it wasn't a feature before either just disable it completely, since the wrong fix makes the sqlcipher build failures worse. Fixes:
http://autobuild.buildroot.net/results/fc0/fc0528de7fed2f34f503fe8dd8b4c21ded0d6dff/

---
 package/sqlcipher/sqlcipher.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/sqlcipher/sqlcipher.mk +1 -1
index fadec22..196f162 100644
@@ -15,7 +15,7 @@ SQLCIPHER_CONF_ENV = \
 
 SQLCIPHER_CONF_OPTS = \
 	--enable-threadsafe \
-	--with-tcl=$(HOST_DIR)/usr/lib
+	--disable-tcl
 
 SQLCIPHER_CFLAGS += -DSQLITE_HAS_CODEC # Required according to the README
 SQLCIPHER_CONF_ENV += LIBS="-lcrypto -lz"
Signature · 1 line
2.4.9
#1 lore raw

PATCH 1/1 sqlcipher: disable tcl support

Dear Gustavo Zacarias,

Quoted 10 lines · Gustavo Zacarias

In commit b1dcb1c2 a fix was attempted at fixing a build failure where sqlcipher finds the distribution tcl and tries to build against it. sqlcipher has two tcl usage scenarios: host-tcl which is required to actually build it, and target tcl to build bindings.
Since cross-compilation of the bindings isn't clean it fails as well, and since it wasn't a feature before either just disable it completely, since the wrong fix makes the sqlcipher build failures worse. Fixes:
http://autobuild.buildroot.net/results/fc0/fc0528de7fed2f34f503fe8dd8b4c21ded0d6dff/

Quoted 4 lines
---
 package/sqlcipher/sqlcipher.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com