Skip to contentSkip to conversation

ARM: at91: pm: at91_pm_suspend_in_sram() must be 8-byte aligned

PATCH New Alexandre Belloni 3 participants 3 messages Oct 16, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: at91: pm: at91_pm_suspend_in_sram() must be 8-byte aligned

From: Patrick Doyle <[email protected]>

fncpy() requires that the source and the destination are both 8-byte aligned.

---
 arch/arm/mach-at91/pm_suspend.S | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-at91/pm_suspend.S +2 -0
index 0d95f488b47a..a25defda3d22 100644
@@ -80,6 +80,8 @@ tmp2	.req	r5
  *	@r2: base address of second SDRAM Controller or 0 if not present
  *	@r3: pm information
  */
+/* at91_pm_suspend_in_sram must be 8-byte aligned per the requirements of fncpy() */
+	.align 3
 ENTRY(at91_pm_suspend_in_sram)
 	/* Save registers on stack */
 	stmfd	sp!, {r4 - r12, lr}
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 ARM: at91: pm: at91_pm_suspend_in_sram() must be 8-byte aligned

Hi,

Quoted 7 lines · Alexandre Belloni

From: Patrick Doyle <[email protected]>

fncpy() requires that the source and the destination are both 8-byte aligned.

Additional tags:

Fixes d94e688cae56 ("ARM: at91/pm: move the copying the sram function to the sram initialization phase")
Cc <[email protected]> # 4.1+

Sylvain

#2 lore raw

PATCH 1/1 ARM: at91: pm: at91_pm_suspend_in_sram() must be 8-byte aligned

Le 16/10/2015 13:22, Sylvain Rochet a ?crit :

Quoted 8 lines

Hi,

Quoted 5 lines · Alexandre Belloni

From: Patrick Doyle <[email protected]>

fncpy() requires that the source and the destination are both 8-byte aligned.

Quoted 7 lines
Quoted 2 lines

Additional tags:

Fixes d94e688cae56 ("ARM: at91/pm: move the copying the sram function to the sram initialization phase")
Cc <[email protected]> # 4.1+

Absolutely: thanks Sylvain.

Thank you to Patrick for having found this issue.

Best regards,

Signature · 1 line
Nicolas Ferre