gmediarender: new package

PATCH Superseded kei-k at ca2.so-net.ne.jp 2 participants 8 messages Oct 16, 2015 – Oct 19, 2015

lore

Share & tools

lore

kei-k at ca2.so-net.ne.jp

author

2015-10-16 12:54 UTC #0 lore raw

PATCH 1/1 gmediarender: new package

gmediarender is UPnP (DLNA) rendere based on gstreamer.

Signed-off-by Hiroshi Kawashima <[email protected]>

---
 package/Config.in                      |    1 +
 package/gmediarender/Config.in         |   15 +++++++++++++++
 package/gmediarender/gmediarender.hash |    2 ++
 package/gmediarender/gmediarender.mk   |   16 ++++++++++++++++
 4 files changed, 34 insertions(+), 0 deletions(-)
 create mode 100644 package/gmediarender/Config.in
 create mode 100644 package/gmediarender/gmediarender.hash
 create mode 100644 package/gmediarender/gmediarender.mk

package/Config.in +1 -0

index 8e3c64a..396d757 100644
@@ -14,6 +14,7 @@ menu "Audio and video applications"
 	source "package/ffmpeg/Config.in"
 	source "package/flac/Config.in"
 	source "package/flite/Config.in"
+	source "package/gmediarender/Config.in"
 	source "package/gstreamer/Config.in"
 	source "package/gstreamer1/Config.in"
 	source "package/jack2/Config.in"

package/gmediarender/Config.in new file +15 -0

new file mode 100644
index 0000000..d2cd9d7
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_GMEDIARENDER
+	bool "gmediarender"
+	depends on BR2_USE_WCHAR # gstreamer
+	depends on BR2_TOOLCHAIN_HAS_THREADS # gstreamer, libupnp
+	depends on BR2_USE_MMU # gstreamer
+	select BR2_PACKAGE_GSTREAMER
+	select BR2_PACKAGE_LIBUPNP
+	help
+	  UPnP (DLNA) media renderer based on gstreamer
+
+	  http://gmrender.nongnu.org/
+
+comment "gmediarender needs a toolchain w/ wchar, threads"
+	depends on BR2_USE_MMU
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS

package/gmediarender/gmediarender.hash new file +2 -0

new file mode 100644
index 0000000..f181770
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 85d3251ce3095394d389b56f8b47e7f79e906022e51ce92a4cf822ee2a5fee2c  gmediarender-0.0.6.tar.bz2

package/gmediarender/gmediarender.mk new file +16 -0

new file mode 100644
index 0000000..e383786
@@ -0,0 +1,16 @@
+################################################################################
+#
+# gmediarender
+#
+################################################################################
+
+GMEDIARENDER_VERSION = 0.0.6
+GMEDIARENDER_SOURCE = gmediarender-$(GMEDIARENDER_VERSION).tar.bz2
+GMEDIARENDER_SITE = http://savannah.nongnu.org/download/gmrender
+GMEDIARENDER_AUTORECONF = YES
+GMEDIARENDER_LICENSE = GPLv2
+GMEDIARENDER_LICENSE_FILES = COPYING
+GMEDIARENDER_DEPENDENCIES = gstreamer libupnp
+GMEDIARENDER_CONF_OPTS = --with-libupnp=$(STAGING_DIR)/usr LIBS="-lixml"
+
+$(eval $(autotools-package))

Signature · 4 lines

1.7.1

============================================================
    Hiroshi Kawashima

Thomas Petazzoni

2015-10-16 14:50 UTC #1 lore raw

PATCH 1/1 gmediarender: new package

Hello,

Thanks for this new contribution! It looks pretty good, but as usual I have some comments/questions.

First, can you fix your e-mail client or git send-email configuration so that your "From:" is:

Hiroshi Kawashima <[email protected]>

instead of just:

kei-k at ca2.so-net.ne.jp

The From: field is used to indicate the author of the patch in the Git history, so it's nicer when there's a full name rather than just the e-mail address.

Quoted 18 lines · On Fri, 16 Oct 2015 21:54:41 +0900, kei-k at ca2.so-net.ne.jp wrote:

package/Config.in +1 -0

index 8e3c64a..396d757 100644
@@ -14,6 +14,7 @@ menu "Audio and video applications"
 	source "package/ffmpeg/Config.in"
 	source "package/flac/Config.in"
 	source "package/flite/Config.in"
+	source "package/gmediarender/Config.in"
 	source "package/gstreamer/Config.in"
 	source "package/gstreamer1/Config.in"
 	source "package/jack2/Config.in"

package/gmediarender/Config.in new file +0 -0

new file mode 100644
index 0000000..d2cd9d7

package/gmediarender/Config.in line 6

Quoted 6 lines

package/gmediarender/Config.in new file +6 -0

@@ -0,0 +1,15 @@
+config BR2_PACKAGE_GMEDIARENDER
+	bool "gmediarender"
+	depends on BR2_USE_WCHAR # gstreamer
+	depends on BR2_TOOLCHAIN_HAS_THREADS # gstreamer, libupnp
+	depends on BR2_USE_MMU # gstreamer
+	select BR2_PACKAGE_GSTREAMER

So it really only supports GStreamer 0.10.x (which is deprecated) and not GStreamer 1.x ?

Quoted 23 lines

package/gmediarender/Config.in new file +9 -0

+	select BR2_PACKAGE_LIBUPNP
+	help
+	  UPnP (DLNA) media renderer based on gstreamer
+
+	  http://gmrender.nongnu.org/
+
+comment "gmediarender needs a toolchain w/ wchar, threads"
+	depends on BR2_USE_MMU
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS

package/gmediarender/gmediarender.hash new file +2 -0

new file mode 100644
index 0000000..f181770
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 85d3251ce3095394d389b56f8b47e7f79e906022e51ce92a4cf822ee2a5fee2c  gmediarender-0.0.6.tar.bz2

package/gmediarender/gmediarender.mk new file +0 -0

new file mode 100644
index 0000000..e383786

package/gmediarender/gmediarender.mk line 10

Quoted 10 lines

package/gmediarender/gmediarender.mk new file +10 -0

@@ -0,0 +1,16 @@
+################################################################################
+#
+# gmediarender
+#
+################################################################################
+
+GMEDIARENDER_VERSION = 0.0.6
+GMEDIARENDER_SOURCE = gmediarender-$(GMEDIARENDER_VERSION).tar.bz2
+GMEDIARENDER_SITE = http://savannah.nongnu.org/download/gmrender
+GMEDIARENDER_AUTORECONF = YES

Can you add a justification for the AUTORECONF = YES here (in a comment above the line) ?

package/gmediarender/gmediarender.mk line 11

Quoted 1 line

package/gmediarender/gmediarender.mk new file +1 -0
+GMEDIARENDER_LICENSE = GPLv2

License is actually GPLv2+.

package/gmediarender/gmediarender.mk line 14

Quoted 3 lines

package/gmediarender/gmediarender.mk new file +3 -0

+GMEDIARENDER_LICENSE_FILES = COPYING
+GMEDIARENDER_DEPENDENCIES = gstreamer libupnp
+GMEDIARENDER_CONF_OPTS = --with-libupnp=$(STAGING_DIR)/usr LIBS="-lixml"

Which package provides the ixml library ?

Thanks!

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Hiroshi Kawashima

author

2015-10-17 00:58 UTC #2 lore raw

PATCH 1/1 gmediarender: new package

Dear Thomas.
Thank you for your comment.

Quoted 10 lines · Thomas Petazzoni

Hello,
Thanks for this new contribution! It looks pretty good, but as usual I have some comments/questions.
First, can you fix your e-mail client or git send-email configuration so that your "From:" is:
Hiroshi Kawashima <[email protected]>

Quoted 7 lines

instead of just:
kei-k at ca2.so-net.ne.jp
The From: field is used to indicate the author of the patch in the Git history, so it's nicer when there's a full name rather than just the e-mail address.

Sure.
I think fixed it since this e-mail.

[snip]

Quoted 9 lines

package/gmediarender/Config.in line 6
Quoted 6 lines
package/gmediarender/Config.in new file +6 -0
+config BR2_PACKAGE_GMEDIARENDER
+	bool "gmediarender"
+	depends on BR2_USE_WCHAR # gstreamer
+	depends on BR2_TOOLCHAIN_HAS_THREADS # gstreamer, libupnp
+	depends on BR2_USE_MMU # gstreamer
+	select BR2_PACKAGE_GSTREAMER
So it really only supports GStreamer 0.10.x (which is deprecated) and not GStreamer 1.x ?

Ok, let me check.

[snip]

Quoted 7 lines

package/gmediarender/gmediarender.mk line 10
Quoted 4 lines
package/gmediarender/gmediarender.mk new file +4 -0
+GMEDIARENDER_VERSION = 0.0.6
+GMEDIARENDER_SOURCE = gmediarender-$(GMEDIARENDER_VERSION).tar.bz2
+GMEDIARENDER_SITE = http://savannah.nongnu.org/download/gmrender
+GMEDIARENDER_AUTORECONF = YES
Can you add a justification for the AUTORECONF = YES here (in a comment above the line) ?

Ok, let me check again if really need this.

Quoted 3 lines

Quoted 1 line
+GMEDIARENDER_LICENSE = GPLv2
License is actually GPLv2+.

Thank you, I will correct this.

Quoted 5 lines

package/gmediarender/gmediarender.mk line 14
Quoted 3 lines
package/gmediarender/gmediarender.mk new file +3 -0
+GMEDIARENDER_LICENSE_FILES = COPYING
+GMEDIARENDER_DEPENDENCIES = gstreamer libupnp
+GMEDIARENDER_CONF_OPTS = --with-libupnp=$(STAGING_DIR)/usr LIBS="-lixml"
Which package provides the ixml library ?

libixml is provided by libupnp package.

Regards,
Kawashima
============================================================
Hiroshi Kawashima

Hiroshi Kawashima

author

2015-10-18 00:49 UTC #3 lore raw

PATCH 1/1 gmediarender: new package

Dear Thomas.
Thank you for your review and comment.

1) This project is old and last update is 2007, so it still depsnds on gstreamer 0.10.x.
2) AUTORECONF is not needed actually.

I will send new v2 patch later.

Regards,
Kawashima

Quoted 13 lines

[snip]
Quoted 9 lines
package/gmediarender/Config.in line 6
Quoted 6 lines
package/gmediarender/Config.in new file +6 -0
+config BR2_PACKAGE_GMEDIARENDER
+	bool "gmediarender"
+	depends on BR2_USE_WCHAR # gstreamer
+	depends on BR2_TOOLCHAIN_HAS_THREADS # gstreamer, libupnp
+	depends on BR2_USE_MMU # gstreamer
+	select BR2_PACKAGE_GSTREAMER
So it really only supports GStreamer 0.10.x (which is deprecated) and not GStreamer 1.x ?
Ok, let me check.
[snip]

Quoted 8 lines

Quoted 7 lines
package/gmediarender/gmediarender.mk line 10
Quoted 4 lines
package/gmediarender/gmediarender.mk new file +4 -0
+GMEDIARENDER_VERSION = 0.0.6
+GMEDIARENDER_SOURCE = gmediarender-$(GMEDIARENDER_VERSION).tar.bz2
+GMEDIARENDER_SITE = http://savannah.nongnu.org/download/gmrender
+GMEDIARENDER_AUTORECONF = YES
Can you add a justification for the AUTORECONF = YES here (in a comment above the line) ?
Ok, let me check again if really need this.

============================================================
Hiroshi Kawashima

Thomas Petazzoni

2015-10-18 07:20 UTC #4 lore raw

PATCH 1/1 gmediarender: new package

Hiroshi,

Quoted 1 line · Hiroshi Kawashima

Thank you for your review and comment.

Thanks for your feedback.

Quoted 2 lines

1) This project is old and last update is 2007, so it still depsnds on gstreamer 0.10.x.

Then is it really useful to package this in Buildroot? I'm a bit worried about adding packages that rely only on GStreamer 0.10. GStreamer 0.10 is deprecated, and we should rather start thinking of removing it from Buildroot rather than adding more packages that depend on it.

Maybe you should consider some other application than gmediarender for your project ?

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Hiroshi Kawashima

author

2015-10-19 12:03 UTC #5 lore raw

PATCH 1/1 gmediarender: new package

Dear Thomas.

Thank you for your comment and suggestion.
I agree with your opinion, abondon this.

I find out good successor project of gmediarender, gmrender-resurrect hosted on github.

It is maintained and has improved functionarity (eg. OpenHome support etc), of course it is compatible with gstreamer v1.0.x.

I will send patch later for this.

Thank you,
Kawashima

Quoted 17 lines · Thomas Petazzoni

Hiroshi,
Quoted 1 line · Hiroshi Kawashima
Thank you for your review and comment.
Thanks for your feedback.
Quoted 2 lines
1) This project is old and last update is 2007, so it still depsnds on gstreamer 0.10.x.
Then is it really useful to package this in Buildroot? I'm a bit worried about adding packages that rely only on GStreamer 0.10. GStreamer 0.10 is deprecated, and we should rather start thinking of removing it from Buildroot rather than adding more packages that depend on it.

Quoted 13 lines

Maybe you should consider some other application than gmediarender for your project ?
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

============================================================
Hiroshi Kawashima

Thomas Petazzoni

2015-10-19 12:06 UTC #6 lore raw

PATCH 1/1 gmediarender: new package

Dear Hiroshi Kawashima,

Quoted 5 lines · Hiroshi Kawashima

Dear Thomas.
Thank you for your comment and suggestion.
I agree with your opinion, abondon this.

Quoted 7 lines

I find out good successor project of gmediarender, gmrender-resurrect hosted on github.
It is maintained and has improved functionarity (eg. OpenHome support etc), of course it is compatible with gstreamer v1.0.x.
I will send patch later for this.

Thanks! Can you mark your patch as "Rejected" in patchwork then?

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

kei

author

2015-10-19 12:22 UTC #7 lore raw

PATCH 1/1 gmediarender: new package

Sure, done.

Quoted 25 lines

2015/10/19 21:06?Thomas Petazzoni <[email protected]> ?????
Dear Hiroshi Kawashima,
Quoted 5 lines · Hiroshi Kawashima
Dear Thomas.
Thank you for your comment and suggestion.
I agree with your opinion, abondon this.
Quoted 7 lines
I find out good successor project of gmediarender, gmrender-resurrect hosted on github.
It is maintained and has improved functionarity (eg. OpenHome support etc), of course it is compatible with gstreamer v1.0.x.
I will send patch later for this.
Thanks! Can you mark your patch as "Rejected" in patchwork then?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com