staging: r8723au: move * to be adjacent to pointer name
PATCH 1/1 staging: r8723au: move * to be adjacent to pointer name
Move * in pointer types to be adjacent to pointer names per Linux coding style.
Addresses checkpatch.pl: ERROR: "foo* bar" should be "foo *bar"
---
Question to reviewers:
Are checkpatch.pl CHECK errors permitted in a patch?
ie. This driver has a lot of pre-existing CamelCase CHECKs that appear when my pre-commit hook executes. I'd like to submit other changes without addressing the CamelCase simultaneously.
What is the recommendation in such cases?
drivers/staging/rtl8723au/core/rtw_ieee80211.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/staging/rtl8723au/core/rtw_ieee80211.c +5 -4
@@ -348,9 +348,9 @@ int rtw_generate_ie23a(struct registry_priv *pregistrypriv) {u8 wireless_mode;int sz =0 , rateLen; -struct wlan_bssid_ex * pdev_network = &pregistrypriv->dev_network; -u8 * ie = pdev_network->IEs; -u16 cap; +struct wlan_bssid_ex *pdev_network = &pregistrypriv->dev_network; +u8 *ie = pdev_network->IEs; +u16 cap; pdev_network->tsf =0 ;
@@ -444,7 +444,8 @@ static int rtw_get_wpa2_cipher_suite(const u8 *s)return 0 ; } -int rtw_parse_wpa_ie23a (const u8 * wpa_ie,int wpa_ie_len,int *group_cipher,int *pairwise_cipher,int *is_8021x) +int rtw_parse_wpa_ie23a (const u8 *wpa_ie,int wpa_ie_len,int *group_cipher, +int *pairwise_cipher,int *is_8021x) {int i, ret = _SUCCESS;int left, count;
Signature · 1 line
2.1.4
PATCH RESEND 1/1 staging: r8723au: move * to be adjacent to pointer name
Move * in pointer types to be adjacent to pointer names per Linux coding style.
Addresses checkpatch.pl: ERROR: "foo* bar" should be "foo *bar"
---
(Rebased and resending)
Question to reviewers:
Are checkpatch.pl CHECK errors permitted in a patch?
ie. This driver has a lot of pre-existing CamelCase CHECKs that appear when my pre-commit hook executes. I'd like to submit other changes without addressing the CamelCase simultaneously.
What is the recommendation in such cases?
drivers/staging/rtl8723au/core/rtw_ieee80211.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/staging/rtl8723au/core/rtw_ieee80211.c +5 -4
@@ -348,9 +348,9 @@ int rtw_generate_ie23a(struct registry_priv *pregistrypriv) {u8 wireless_mode;int sz =0 , rateLen; -struct wlan_bssid_ex * pdev_network = &pregistrypriv->dev_network; -u8 * ie = pdev_network->IEs; -u16 cap; +struct wlan_bssid_ex *pdev_network = &pregistrypriv->dev_network; +u8 *ie = pdev_network->IEs; +u16 cap; pdev_network->tsf =0 ;
@@ -444,7 +444,8 @@ static int rtw_get_wpa2_cipher_suite(const u8 *s)return 0 ; } -int rtw_parse_wpa_ie23a (const u8 * wpa_ie,int wpa_ie_len,int *group_cipher,int *pairwise_cipher,int *is_8021x) +int rtw_parse_wpa_ie23a (const u8 *wpa_ie,int wpa_ie_len,int *group_cipher, +int *pairwise_cipher,int *is_8021x) {int i, ret = _SUCCESS;int left, count;
Signature · 1 line
2.1.4
Quoted 10 lines · Alison Schofield
Move * in pointer types to be adjacent to pointer names per Linux coding style.
Addresses checkpatch.pl: ERROR: "foo* bar" should be "foo *bar"
Signed-off-by Alison Schofield <[email protected]>---
(Rebased and resending)
Quoted 7 lines
Question to reviewers:
Are checkpatch.pl CHECK errors permitted in a patch?
ie. This driver has a lot of pre-existing CamelCase CHECKs that appear when my pre-commit hook executes. I'd like to submit other changes without addressing the CamelCase simultaneously.What is the recommendation in such cases?
Submitting the patch is OK. Fixing Camel Case problems is a very non-local transformation, and your change would get completely lost if you did that as well.
julia
Quoted 42 lines
drivers/staging/rtl8723au/core/rtw_ieee80211.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)drivers/staging/rtl8723au/core/rtw_ieee80211.c +5
-4@@ -348,9 +348,9 @@ int rtw_generate_ie23a(struct registry_priv *pregistrypriv) {u8 wireless_mode;int sz =0 , rateLen; -struct wlan_bssid_ex * pdev_network = &pregistrypriv->dev_network; -u8 * ie = pdev_network->IEs; -u16 cap; +struct wlan_bssid_ex *pdev_network = &pregistrypriv->dev_network; +u8 *ie = pdev_network->IEs; +u16 cap; pdev_network->tsf =0 ;@@ -444,7 +444,8 @@ static int rtw_get_wpa2_cipher_suite(const u8 *s)return 0 ; } -int rtw_parse_wpa_ie23a (const u8 * wpa_ie,int wpa_ie_len,int *group_cipher,int *pairwise_cipher,int *is_8021x) +int rtw_parse_wpa_ie23a (const u8 *wpa_ie,int wpa_ie_len,int *group_cipher, +int *pairwise_cipher,int *is_8021x) {int i, ret = _SUCCESS;int left, count;Signature · 8 lines
2.1.4 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1445125163-2116-1-git-send-email-amsfield22%40gmail.com. For more options, visit https://groups.google.com/d/optout.