Skip to contentSkip to conversation

spi: cadence_qspi: Fix fdt read of spi-max-frequency

PATCH New Chin Liang See 2 participants 4 messages Oct 16, 2015 – Oct 17, 2015 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Chin Liang See

author
#1 lore raw

PATCH v4 2/5 spi: cadence_qspi: Fix fdt read of spi-max-frequency

#2 lore raw

PATCH v4 2/5 spi: cadence_qspi: Fix fdt read of spi-max-frequency

Quoted 20 lines · Chin Liang See

From 4a91b5a380e7d3178d4378df79224442c79278bb Mon Sep 17 00:00:00 2001
From: Chin Liang See <[email protected]>
Date: Fri, 16 Oct 2015 16:35:10 +0800
Subject: [PATCH v4 2/5] spi: cadence_qspi: Fix fdt read of spi-max-frequency

Fix the fdt read for spi-max-frequency as it's contained in the child node. Current state of code is always returning default value.

Signed-off-by Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Vikas Manocha <[email protected]>
Cc Jagannadh Teki <[email protected]>
Cc Pavel Machek <[email protected]>
Acked-by Marek Vasut <[email protected]>
Acked-by Pavel Machek <[email protected]>
Quoted 3 lines

---
Changes for v4
- use the newly created fdtdec_get_uint

This patch depends on 5/5, so this will break bisect . Please do reorder the patches , most likely such that 5/5 goes in first and the rest follows.

Best regards,
Marek Vasut

author
#3 lore raw

PATCH v4 2/5 spi: cadence_qspi: Fix fdt read of spi-max-frequency

Hi Marek,

Quoted 25 lines · marex at denx.de
Quoted 20 lines · Chin Liang See

From 4a91b5a380e7d3178d4378df79224442c79278bb Mon Sep 17 00:00:00 2001
From: Chin Liang See <[email protected]>
Date: Fri, 16 Oct 2015 16:35:10 +0800
Subject: [PATCH v4 2/5] spi: cadence_qspi: Fix fdt read of spi-max-frequency

Fix the fdt read for spi-max-frequency as it's contained in the child node. Current state of code is always returning default value.

Signed-off-by Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Vikas Manocha <[email protected]>
Cc Jagannadh Teki <[email protected]>
Cc Pavel Machek <[email protected]>
Acked-by Marek Vasut <[email protected]>
Acked-by Pavel Machek <[email protected]>
Quoted 3 lines

---
Changes for v4
- use the newly created fdtdec_get_uint

Quoted 4 lines

This patch depends on 5/5, so this will break bisect . Please do reorder the patches , most likely such that 5/5 goes in first and the rest follows.

Sure, I can do the patches order re-shuffling.

Thanks
Chin Liang

Quoted 2 lines

Best regards,
Marek Vasut

#4 lore raw

PATCH v4 2/5 spi: cadence_qspi: Fix fdt read of spi-max-frequency

Quoted 1 line · Chin Liang See

Hi Marek,

Hi!

Quoted 26 lines · marex at denx.de
Quoted 25 lines · Chin Liang See
Quoted 23 lines

From 4a91b5a380e7d3178d4378df79224442c79278bb Mon Sep 17 00:00:00 2001
From: Chin Liang See <[email protected]>
Date: Fri, 16 Oct 2015 16:35:10 +0800
Subject: [PATCH v4 2/5] spi: cadence_qspi: Fix fdt read of spi-max-frequency

Fix the fdt read for spi-max-frequency as it's contained in the child node. Current state of code is always returning default value.

Signed-off-by Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Vikas Manocha <[email protected]>
Cc Jagannadh Teki <[email protected]>
Cc Pavel Machek <[email protected]>
Acked-by Marek Vasut <[email protected]>
Acked-by Pavel Machek <[email protected]>

---
Changes for v4
- use the newly created fdtdec_get_uint

Quoted 5 lines
Quoted 3 lines

This patch depends on 5/5, so this will break bisect . Please do reorder the patches , most likely such that 5/5 goes in first and the rest follows.

Sure, I can do the patches order re-shuffling.

Thanks! Ideally, I think you can even send those patches separatelly and note that the QSPI series depends on the FDT patch.

Best regards,
Marek Vasut