Skip to contentSkip to conversation

netfilter: fix Kconfig dependencies for nft_dup_ipv{4,6}

PATCH In review Arnd Bergmann 2 participants 2 messages Oct 16, 2015 – Oct 17, 2015

Subsystems (2)
Networking netfilter
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 netfilter: fix Kconfig dependencies for nft_dup_ipv{4,6}

nft_dup_ipv4 and nft_dup_ipv6 select the respective nf_dup_ipv{4,6} drivers, which must not be built-in if nf_conntrack is a loadable module, otherwise we get a link error:

net/built-in.o: In function `nf_dup_ipv6':
(.text+0xdef20): undefined reference to `nf_conntrack_untracked'

The dependency was fixed for the nf_dup_* modules recently, but this patch adds the same dependency to the nft_dup_* modules for the (hopefully) complete fix.

Signed-off-by Arnd Bergmann <[email protected]>
Fixes 6ece90f9a13e ("netfilter: fix Kconfig dependencies for nf_dup_ipv{4,6}")

---
found on ARM randconfig builds

net/ipv4/netfilter/Kconfig +1 -0
index a35584176535..c187c60e3e0c 100644
@@ -60,6 +60,7 @@ config NFT_REJECT_IPV4
 
 config NFT_DUP_IPV4
 	tristate "IPv4 nf_tables packet duplication support"
+	depends on !NF_CONNTRACK || NF_CONNTRACK
 	select NF_DUP_IPV4
 	help
 	  This module enables IPv4 packet duplication support for nf_tables.
net/ipv6/netfilter/Kconfig +1 -0
index f6a024e141e5..e10a04c9cdc7 100644
@@ -49,6 +49,7 @@ config NFT_REJECT_IPV6
 
 config NFT_DUP_IPV6
 	tristate "IPv6 nf_tables packet duplication support"
+	depends on !NF_CONNTRACK || NF_CONNTRACK
 	select NF_DUP_IPV6
 	help
 	  This module enables IPv6 packet duplication support for nf_tables.
maintainer
#1 lore raw
Quoted 10 lines · Arnd Bergmann

nft_dup_ipv4 and nft_dup_ipv6 select the respective nf_dup_ipv{4,6} drivers, which must not be built-in if nf_conntrack is a loadable module, otherwise we get a link error:

net/built-in.o: In function `nf_dup_ipv6':
(.text+0xdef20): undefined reference to `nf_conntrack_untracked'

The dependency was fixed for the nf_dup_* modules recently, but this patch adds the same dependency to the nft_dup_* modules for the (hopefully) complete fix.

Already have this patch for this enqueued here:

http://git.kernel.org/cgit/linux/kernel/git/pablo/nf.git/commit/?id=6ece90f9a13e2592cbd6634f74bcb306169b5ab6

Will be submitting this to David asap. Thanks anyway.