Staging: mt29f_spinand: Remove space after a cast
Subsystems (2)
PATCH 1/1 Staging: mt29f_spinand: Remove space after a cast
Modify retval to reflect removal of space during cast operation. Checkpatch found this issue.
CHECK: No space is necessary after a cast
--- drivers/staging/mt29f_spinand/mt29f_spinand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/mt29f_spinand/mt29f_spinand.c +1 -1
@@ -594,7 +594,7 @@ static int spinand_erase_block(struct spi_device *spi_nand, u16 block_id)if (retval <0 ) {dev_err (&spi_nand->dev,"error %d reading status register\n" , - (int ) retval); + (int )retval);return retval; }
Signature · 1 line
1.9.1
Quoted 1 line · Eva Rachel Retuya
Modify retval to reflect removal of space during cast operation.
Thanks for your patch. However, the commit message is a bit confusing. Retval is not modified. Actually, there is not much to say beyond what you have in the subject line. Maybe you could say "Remove the unneeded space before retval".
Please send v2.
julia
Quoted 32 lines
Checkpatch found this issue.
CHECK: No space is necessary after a cast
Signed-off-by Eva Rachel Retuya <[email protected]>--- drivers/staging/mt29f_spinand/mt29f_spinand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/mt29f_spinand/mt29f_spinand.c +1
-1@@ -594,7 +594,7 @@ static int spinand_erase_block(struct spi_device *spi_nand, u16 block_id)if (retval <0 ) {dev_err (&spi_nand->dev,"error %d reading status register\n" , - (int ) retval); + (int )retval);return retval; }Signature · 8 lines
1.9.1 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151017155226.GA6368%40Socrates-Mint. For more options, visit https://groups.google.com/d/optout.
Quoted 4 lines · Julia Lawall
Quoted 1 line · Eva Rachel Retuya
Modify retval to reflect removal of space during cast operation.
Quoted 9 lines
Thanks for your patch. However, the commit message is a bit confusing. Retval is not modified. Actually, there is not much to say beyond what you have in the subject line. Maybe you could say "Remove the unneeded space before retval".
Please send v2.
julia
Sorry I made it confusing. I will revise according to your suggestion. Thank you for the feedback!
Eva