Skip to contentSkip to conversation

uclibc: clean-up test suite build command

PATCH New Alexey Brodkin 2 participants 2 messages Apr 20, 2015 – Oct 18, 2015

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 uclibc: clean-up test suite build command

Starting from uClibc 0.9.32 "test_compile" target builds tests flawlessly. For 0.9.31 it lead to build failure, but now when AVR32 support was dropped I think this change worth applying.

Cc Peter Korsgaard <[email protected]>
Cc Gustavo Zacarias <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Thomas De Schampheleire <[email protected]>

---

This is just a re-send of v1 (https://patchwork.ozlabs.org/patch/365705/)
so no changes at all.

It still applies flawlessly on current master.

I build tested it on ARC and ARM. Note on ARM uClibc tests (BR2_UCLIBC_INSTALL_TEST_SUITE) will be only compiled without errors with uClibc-ng (BR2_UCLIBC_VERSION_NG), either BR2_UCLIBC_VERSION_0_9_33 or BR2_UCLIBC_VERSION_SNAPSHOT will fail on testsuite compilation but that has nothing to do with current patch I think.

---
 package/uclibc/uclibc.mk | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
package/uclibc/uclibc.mk +2 -4
index 72a46d9..c599379 100644
@@ -395,12 +395,10 @@ endef
 
 ifeq ($(BR2_UCLIBC_INSTALL_TEST_SUITE),y)
 define UCLIBC_BUILD_TEST_SUITE
-	$(MAKE1) -C $(@D)/test \
+	$(MAKE1) -C $(@D) \
 		$(UCLIBC_MAKE_FLAGS) \
-		ARCH_CFLAGS=-I$(STAGING_DIR)/usr/include \
 		UCLIBC_ONLY=1 \
-		TEST_INSTALLED_UCLIBC=1 \
-		compile
+		test_compile
 endef
 endif
 
Signature · 1 line
2.1.0
#1 lore raw

PATCH v2 1/1 uclibc: clean-up test suite build command

Dear Alexey Brodkin,

Quoted 10 lines · Alexey Brodkin

Starting from uClibc 0.9.32 "test_compile" target builds tests flawlessly. For 0.9.31 it lead to build failure, but now when AVR32 support was dropped I think this change worth applying.

Cc Peter Korsgaard <[email protected]>
Cc Gustavo Zacarias <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Thomas De Schampheleire <[email protected]>

---

Applied, thanks. Yes, long delay, but better late than never!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com