Skip to contentSkip to conversation

Staging: emxx_udc: Add space around operator.

PATCH In review Navya Sri Nizamkari 2 participants 3 messages Oct 19, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Staging: emxx_udc: Add space around operator.

Add a space around '>>' operator.
Problem found using checkpatch.

---
Changes in v2:
-Make commit message better.

 drivers/staging/emxx_udc/emxx_udc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/emxx_udc/emxx_udc.c +1 -1
index 0492747..60604c8 100644
@@ -211,7 +211,7 @@ static u32 _nbu2ss_get_begin_ram_address(struct nbu2ss_udc *udc)
 		}
 
 		if ((data >> 16) > last_ram_adr)
-			last_ram_adr = data>>16;
+			last_ram_adr = data >> 16;
 	}
 
 	return last_ram_adr + use_ram_size;
Signature · 1 line
1.9.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 2 lines · Navya Sri Nizamkari

Add a space around '>>' operator.
Problem found using checkpatch.

Looks better, thanks.

Quoted 32 lines

---
Changes in v2:
-Make commit message better.

 drivers/staging/emxx_udc/emxx_udc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/emxx_udc/emxx_udc.c +1 -2
index 0492747..60604c8 100644
@@ -211,7 +211,7 @@ static u32 _nbu2ss_get_begin_ram_address(struct nbu2ss_udc *udc)
 		}
 
 		if ((data >> 16) > last_ram_adr)
-			last_ram_adr = data>>16;
+			last_ram_adr = data >> 16;
 	}
 
 	return last_ram_adr + use_ram_size;
--

1.9.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151019065438.GA5680%40navya.
For more options, visit https://groups.google.com/d/optout.

#2 lore raw
Quoted 52 lines · Julia Lawall
Quoted 2 lines · Navya Sri Nizamkari

Add a space around '>>' operator.
Problem found using checkpatch.

Looks better, thanks.

Reviewed-by Julia Lawall <[email protected] <javascript:>>

Thanks for reviewing.

Review

Quoted 10 lines
Signed-off-by Navya Sri Nizamkari <[email protected] <javascript:>>

---
Changes in v2:
-Make commit message better.

 drivers/staging/emxx_udc/emxx_udc.c | 2 +- 
 1 file changed, 1 insertion(+), 1 deletion(-) 
(quoted diff) +0 -0

b/drivers/staging/emxx_udc/emxx_udc.c

drivers/staging/emxx_udc/emxx_udc.c static u32 _nbu2ss_get_begin_ram_address(struct

Quoted 4 lines

index 0492747..60604c8 100644

drivers/staging/emxx_udc/emxx_udc.c +0 -0
@@ -211,7 +211,7 @@ static u32 _nbu2ss_get_begin_ram_address(struct 

nbu2ss_udc *udc)

Quoted 13 lines
drivers/staging/emxx_udc/emxx_udc.c +1 -1
                 } 
 
                 if ((data >> 16) > last_ram_adr) 
-                        last_ram_adr = data>>16; 
+                        last_ram_adr = data >> 16; 
         } 
 
         return last_ram_adr + use_ram_size; 
Signature · 4 lines
1.9.1 

-- 
You received this message because you are subscribed to the Google 

Groups "outreachy-kernel" group.

Quoted 1 line

To unsubscribe from this group and stop receiving emails from it, send

an email to [email protected] <javascript:>.

Quoted 1 line

To post to this group, send email to [email protected]

<javascript:>.

Quoted 1 line

To view this discussion on the web visit

https://groups.google.com/d/msgid/outreachy-kernel/20151019065438.GA5680%40navya.

Quoted 2 lines

For more options, visit https://groups.google.com/d/optout.