Skip to contentSkip to conversation

mfd: arizona: signedness bug in arizona_runtime_suspend()

PATCH Applied Dan Carpenter 3 participants 3 messages Oct 19, 2015

Subsystems (3)
Kernel janitors Multifunction devices (MFD) Wolfson microelectronics drivers
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 mfd: arizona: signedness bug in arizona_runtime_suspend()

The "jd_active" variable needs to be signed for the error handling to work.

Fixes 143e5887ae57 ('mfd: arizona: factor out checking of jack detection state')
Signed-off-by Dan Carpenter <[email protected]>
drivers/mfd/arizona-core.c +1 -1
index 4e49210..d474732 100644
@@ -628,7 +628,7 @@ err:
 static int arizona_runtime_suspend(struct device *dev)
 {
 	struct arizona *arizona = dev_get_drvdata(dev);
-	unsigned int jd_active = 0;
+	int jd_active = 0;
 	int ret;
 
 	dev_dbg(arizona->dev, "Entering AoD mode\n");
Applied
#2 lore raw
In reply to Dan Carpenter

export fullname=drivers/mfd/arizona-core.c
# From Dan's script
git log --oneline --no-merges mainline/master -- $fullname | head -n 10

3762aed mfd: arizona: Fixup some formatting/white space errors 6887b04 mfd: arizona: Add support for WM8998 and WM1814
16f6a0d mfd: arizona: Fix race between runtime suspend and IRQs 72e4316 mfd: arizona: Fix initialisation of the PM runtime 1115092 mfd: arizona: Fix race between runtime suspend and IRQs 8019ff6 regmap: Use reg_sequence for multi_reg_write / register_patch fc027d1 mfd: arizona: Split INx_MODE into two fields
121c075 mfd: wm5110: Add delay before releasing reset line e6cb734 mfd: arizona: Add better support for system suspend 96129a0 mfd: wm5110: Set DCVDD voltage to 1.175V before entering sleep mode

Each of the $subject lines above start with a capital letter. ;)

Quoted 5 lines · Dan Carpenter

The "jd_active" variable needs to be signed for the error handling to work.

Fixes 143e5887ae57 ('mfd: arizona: factor out checking of jack detection state')
Signed-off-by Dan Carpenter <[email protected]>

Applied, thanks.

Quoted 13 lines
drivers/mfd/arizona-core.c +1 -1
index 4e49210..d474732 100644
@@ -628,7 +628,7 @@ err:
 static int arizona_runtime_suspend(struct device *dev)
 {
 	struct arizona *arizona = dev_get_drvdata(dev);
-	unsigned int jd_active = 0;
+	int jd_active = 0;
 	int ret;
 
 	dev_dbg(arizona->dev, "Entering AoD mode\n");
Signature · 8 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html