Skip to contentSkip to conversation

rte_ether: clarify rte_eth_set_queue_rate_limit tx_rate parameter

PATCH Applied Simon Kagstrom 3 participants 4 messages Oct 20, 2015 – Nov 4, 2015

lore
Share & tools
lore

Simon Kagstrom

author
#0 lore raw

PATCH 1/1 rte_ether: clarify rte_eth_set_queue_rate_limit tx_rate parameter

The tx_rate unit is Mbps.

Gleaned from the ixgbe implementation, the 82599 datasheet and the use in test-pmd.

Signed-off-by Simon Kagstrom <[email protected]>
---
 lib/librte_ether/rte_ethdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_ether/rte_ethdev.h +1 -1
index 8a8c82b..ff9aab7 100644
@@ -3021,7 +3021,7 @@ int rte_eth_mirror_rule_reset(uint8_t port_id,
  * @param queue_idx
  *   The queue id.
  * @param tx_rate
- *   The tx rate allocated from the total link speed for this queue.
+ *   The tx rate in Mbps. Allocated from the total port link speed.
  * @return
  *   - (0) if successful.
  *   - (-ENOTSUP) if hardware doesn't support this feature.
Signature · 1 line
1.9.1
author
#1 lore raw

Ping?

// Simon

Quoted 24 lines · Simon Kagstrom

The tx_rate unit is Mbps.

Gleaned from the ixgbe implementation, the 82599 datasheet and the use in test-pmd.

Signed-off-by Simon Kagstrom <[email protected]>
---
 lib/librte_ether/rte_ethdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_ether/rte_ethdev.h +1 -1
index 8a8c82b..ff9aab7 100644
@@ -3021,7 +3021,7 @@ int rte_eth_mirror_rule_reset(uint8_t port_id,
  * @param queue_idx
  *   The queue id.
  * @param tx_rate
- *   The tx rate allocated from the total link speed for this queue.
+ *   The tx rate in Mbps. Allocated from the total port link speed.
  * @return
  *   - (0) if successful.
  *   - (-ENOTSUP) if hardware doesn't support this feature.
#2 lore raw
Quoted 15 lines · On Wed, 4 Nov 2015 08:51:03 +0100 Simon Kågström…

Ping?

// Simon

Quoted 10 lines · Simon Kagstrom

The tx_rate unit is Mbps.

Gleaned from the ixgbe implementation, the 82599 datasheet and the use in test-pmd.

Signed-off-by Simon Kagstrom <[email protected]>
---
 lib/librte_ether/rte_ethdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines
Quoted 6 lines
lib/librte_ether/rte_ethdev.h +0 -0
index 8a8c82b..ff9aab7 100644

lib/librte_ether/rte_ethdev.h int rte_eth_mirror_rule_reset(uint8_t port_id, · line 3027

Quoted 8 lines
lib/librte_ether/rte_ethdev.h +1 -1
@@ -3021,7 +3021,7 @@ int rte_eth_mirror_rule_reset(uint8_t port_id,
  * @param queue_idx
  *   The queue id.
  * @param tx_rate
- *   The tx rate allocated from the total link speed for this queue.
+ *   The tx rate in Mbps. Allocated from the total port link speed.
  * @return
  *   - (0) if successful.
  *   - (-ENOTSUP) if hardware doesn't support this feature.

You can check for status of any/all patches in patchwork:
http://dpdk.org/dev/patchwork/project/dpdk/list/