Skip to contentSkip to conversation

mtd: maps: rbtx4939-flash: fix compile error

PATCH In review Brian Norris 2 participants 3 messages Oct 19, 2015 – Oct 20, 2015 Memory technology devices (MTD)

lore
Share & tools
lore

Brian Norris

author
#0 lore raw

PATCH 1/1 mtd: maps: rbtx4939-flash: fix compile error

We got the syntax wrong here. Compile tested this time!

Error:

drivers/mtd/maps/rbtx4939-flash.c: In function 'rbtx4939_flash_probe':

Quoted 1 line
Quoted 1 line

drivers/mtd/maps/rbtx4939-flash.c:99:11: error: request for member 'dev' in something not a structure or union

     info->mtd.dev.parent = &dev->dev;
              ^
Fixes 9aa7e50276c1 ("mtd: maps: rbtx4939-flash: show parent device in sysfs")
Reported-by kbuild test robot <[email protected]>
Signed-off-by Brian Norris <[email protected]>
Cc Frans Klaver <[email protected]>
---
 drivers/mtd/maps/rbtx4939-flash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/maps/rbtx4939-flash.c +1 -1
index 18ee361455a2..3a06ecfc55ff 100644
@@ -96,7 +96,7 @@ static int rbtx4939_flash_probe(struct platform_device *dev)
 		err = -ENXIO;
 		goto err_out;
 	}
-	info->mtd.dev.parent = &dev->dev;
+	info->mtd->dev.parent = &dev->dev;
 	err = mtd_device_parse_register(info->mtd, NULL, NULL, pdata->parts,
 					pdata->nr_parts);
Signature · 1 line
2.6.0.rc2.230.g3dd15c0
#1 lore raw
Quoted 8 lines · Brian Norris

We got the syntax wrong here. Compile tested this time!

Error:

   drivers/mtd/maps/rbtx4939-flash.c: In function 'rbtx4939_flash_probe':
Quoted 1 line
Quoted 1 line

drivers/mtd/maps/rbtx4939-flash.c:99:11: error: request for member 'dev' in something not a structure or union

     info->mtd.dev.parent = &dev->dev;
              ^

*Sigh*

Thanks Brian.

Frans

Quoted 24 lines
Fixes 9aa7e50276c1 ("mtd: maps: rbtx4939-flash: show parent device in sysfs")
Reported-by kbuild test robot <[email protected]>
Signed-off-by Brian Norris <[email protected]>
Cc Frans Klaver <[email protected]>
---
 drivers/mtd/maps/rbtx4939-flash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/maps/rbtx4939-flash.c +1 -2
index 18ee361455a2..3a06ecfc55ff 100644
@@ -96,7 +96,7 @@ static int rbtx4939_flash_probe(struct platform_device *dev)
                err = -ENXIO;
                goto err_out;
        }
-       info->mtd.dev.parent = &dev->dev;
+       info->mtd->dev.parent = &dev->dev;
        err = mtd_device_parse_register(info->mtd, NULL, NULL, pdata->parts,
                                        pdata->nr_parts);
 
--

2.6.0.rc2.230.g3dd15c0

author
#2 lore raw
Quoted 6 lines · Frans Klaver
Quoted 4 lines · Brian Norris

We got the syntax wrong here. Compile tested this time!

Error:

Quoted 8 lines
Quoted 4 lines
   drivers/mtd/maps/rbtx4939-flash.c: In function 'rbtx4939_flash_probe':
Quoted 1 line
Quoted 1 line

drivers/mtd/maps/rbtx4939-flash.c:99:11: error: request for member 'dev' in something not a structure or union

     info->mtd.dev.parent = &dev->dev;
              ^

*Sigh*

Thanks Brian.

No problem. Applied.