Add more options to eudev package.

From de239fceb033d278ef70924bcea5c0a18b1f930d Mon Sep 17 00:00:00 2001
From: David Kosir <[email protected]>
Date: Tue, 20 Oct 2015 19:45:28 +0200
Subject: [PATCH 1/1] Add more options to eudev package.

Making possible to install only in /, avoiding /usr. Also, make opinional to use kmod.

Signed-off-by David Kosir <[email protected]>

---
 package/eudev/Config.in | 12 +++++++++++-
 package/eudev/eudev.mk  | 16 +++++++++++++---
 2 files changed, 24 insertions(+), 4 deletions(-)

package/eudev/Config.in +0 -0

index 76df409..2474444 100644

Review if BR2_PACKAGE_EUDEV · line 28

Quoted 11 lines

Userspace device daemon. This is a standalone version, independent of systemd. It is a fork maintained by Gentoo.

(quoted diff) +5 -0

@@ -22,6 +21,12 @@ if BR2_PACKAGE_EUDEV
 config BR2_PACKAGE_PROVIDES_UDEV
     default "eudev"
 
+config BR2_PACKAGE_EUDEV_AVOID_USR
+    bool "don't install to /usr"
+    help
+      Avoid installing to /usr, use (e)prefix=/
+      Useful when having separate /usr partition.

We recently committed an option to merge / and /usr. How does your change compare with that option?

See:

    http://git.buildroot.org/buildroot/commit/?id=c5bd8af65e50a51735eb112fed9cbe6337f14e06

Review config BR2_PACKAGE_EUDEV_ENABLE_HWDB · line 45

Quoted 9 lines

(quoted diff) +5 -0

@@ -33,6 +38,11 @@ config BR2_PACKAGE_EUDEV_ENABLE_HWDB
     help
       Enables hardware database installation to /etc/udev/hwdb.d
 
+config BR2_PACKAGE_EUDEV_ENABLE_KMOD
+    bool "enable kernel module support"
+    select BR2_PACKAGE_KMOD
+    help
+      Enable loadable kernel modules support (kmod)

In this case, what we usually do is:
- we do not add such option above;
- we enable the support if the corresponding package is enabled.

Which in this case would translate to a simple change in the .mk :

    ifeq ($(BR2_PACKAGE_KMOD),y)
    EUDEV_DEPENDENCIES += kmod
    EUDEV_CONF_OPTS += --enable-libkmod
    else
    EUDEV_CONF_OPTS += --disable-libkmod
    endif

And that's all (for kmod).

Care to split the patch in two and resend that?

In the meantime, I marked this patch as "cjhamges requested" in our patchwork.

Thanks! :-)

I've tried to make second patch better, but realized that it is more complicated than I thought.
Best solution I came with to add --libdir=/lib to EUDEV_CONF_OPTS I see that we already specify --libexecdir=/lib
That option would allow to use separate /usr, at least to start udev normaly at boot, before /usr is mounted.
I think that is good option as it would not break anything (at least what I see).
Do you have better idea?

Hello David,

Quoted 9 lines · David Kosir

I've tried to make second patch better, but realized that it is more complicated than I thought.
Best solution I came with to add --libdir=/lib to EUDEV_CONF_OPTS I see that we already specify --libexecdir=/lib
That option would allow to use separate /usr, at least to start udev normaly at boot, before /usr is mounted.
I think that is good option as it would not break anything (at least what I see).
Do you have better idea?

While I understand what you are trying to do, I am not sure we can support this in Buildroot upstream. You want eudev to be in / and not /usr, but maybe the next person will want this other package to be in / and not /usr. How do we handle this ? Add one more option to all packages ? Doesn't seem really maintainable.

I don't really have a good suggestion on how to solve this problem, but I'm pretty sure that adding an option to the eudev package is the right solution.

Best regards,

Thomas

Quoted 5 lines

While I understand what you are trying to do, I am not sure we can support this in Buildroot upstream. You want eudev to be in / and not /usr, but maybe the next person will want this other package to be in / and not /usr. How do we handle this ? Add one more option to all packages ? Doesn't seem really maintainable.

Actually, it makes sense to me to install it completely in / instead of /usr -
that would also remove the need to have all the --libdir etc. options that we currently pass. The way it's currently done, eudev's install anyway adds symlinks back from /lib/libudev.so to /usr/lib/libudev.so.

Hello,

Quoted 10 lines · Arnout Vandecappelle

Quoted 5 lines

While I understand what you are trying to do, I am not sure we can support this in Buildroot upstream. You want eudev to be in / and not /usr, but maybe the next person will want this other package to be in / and not /usr. How do we handle this ? Add one more option to all packages ? Doesn't seem really maintainable.

Actually, it makes sense to me to install it completely in / instead of /usr -
that would also remove the need to have all the --libdir etc. options that we currently pass. The way it's currently done, eudev's install anyway adds symlinks back from /lib/libudev.so to /usr/lib/libudev.so.

If we install it unconditionally in /, then it's fine with me. What I would dislike is to start having options for such things.

However, there is still the question: why eudev in /, and not any other package that other users may find important to have in / ? Where do we put the boundary ?

Quoted 3 lines

However, there is still the question: why eudev in /, and not any other package that other users may find important to have in / ? Where do we put the boundary ?

Because eudev is already installed mostly in / - as I said, even if libudev.so
is installed in /usr/lib, there's still a symlink created to point to it from /lib. Same for udevadm: installed in /usr/bin but a symlink is created from /bin. Basically, it's eudev itself that decides it should be in / in addition to /usr.

This patch looks good, but was not sent properly and did not appear in our
patch tracking system. Can you resubmit properly, using git send-email?

Quoted 9 lines

Quoted 3 lines

However, there is still the question: why eudev in /, and not any other package that other users may find important to have in / ? Where do we put the boundary ?

Because eudev is already installed mostly in / - as I said, even if libudev.so
is installed in /usr/lib, there's still a symlink created to point to it from /lib. Same for udevadm: installed in /usr/bin but a symlink is created from /bin. Basically, it's eudev itself that decides it should be in / in addition to /usr.

Exactly, you can check in src/libudevMakefile, install-exec-hook.

Quoted 2 lines

This patch looks good, but was not sent properly and did not appear in our
patch tracking system. Can you resubmit properly, using git send-email?

I will try it. I just copy-pasted in into gmail as send-mail was complaining about something regarding ssl. I guess that is why it didn't work.

Quoted 1 line

From aac359a0f280476ba9654e995dd4fd5565ffc22f Mon Sep 17 00:00:00 2001

From: David Kosir <[email protected]>
Date: Wed, 21 Oct 2015 12:06:58 +0200
Subject: [PATCH 1/1] Don't force kmod with eudev package

Signed-off-by David Kosir <[email protected]>

---
 package/eudev/Config.in |  1 -
 package/eudev/eudev.mk  | 12 +++++++++---
 2 files changed, 9 insertions(+), 4 deletions(-)

package/eudev/Config.in +0 -1

index 76df409..10f24c0 100644
@@ -7,7 +7,6 @@ config BR2_PACKAGE_EUDEV
     select BR2_PACKAGE_HAS_UDEV
     select BR2_PACKAGE_UTIL_LINUX
     select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
-    select BR2_PACKAGE_KMOD
     help
       Userspace device daemon. This is a standalone version,
       independent of systemd. It is a fork maintained by Gentoo.

package/eudev/eudev.mk +9 -3

index a005f45..455ce25 100644
@@ -24,12 +24,18 @@ EUDEV_CONF_OPTS =        \
     --sbindir=/sbin        \
     --libexecdir=/lib    \
     --with-firmware-path=/lib/firmware    \
-    --disable-introspection            \
-    --enable-libkmod
+    --disable-introspection
 
-EUDEV_DEPENDENCIES = host-gperf host-pkgconf util-linux kmod
+EUDEV_DEPENDENCIES = host-gperf host-pkgconf util-linux
 EUDEV_PROVIDES = udev
 
+ifeq ($(BR2_PACKAGE_KMOD),y)
+EUDEV_DEPENDENCIES += kmod
+EUDEV_CONF_OPTS += --enable-libkmod
+else
+EUDEV_CONF_OPTS += --disable-libkmod
+endif
+
 ifeq ($(BR2_ROOTFS_MERGED_USR),)
 EUDEV_CONF_OPTS += --with-rootlibdir=/lib --enable-split-usr
 endif

From de239fceb033d278ef70924bcea5c0a18b1f930d Mon Sep 17 00:00:00 2001
From: David Kosir <[email protected]>
Date: Tue, 20 Oct 2015 19:45:28 +0200
Subject: [PATCH 1/1] Add more options to eudev package.

Making possible to install only in /, avoiding /usr. Also, make opinional to use kmod.

Signed-off-by David Kosir <[email protected]>

---
 package/eudev/Config.in | 12 +++++++++++-
 package/eudev/eudev.mk  | 16 +++++++++++++---
 2 files changed, 24 insertions(+), 4 deletions(-)