Skip to contentSkip to conversation

clk: Remove clk_{register,unregister}_multiplier()

PATCH Applied Stephen Boyd 3 participants 3 messages Oct 21, 2015 – Oct 22, 2015 Common clk

lore
Share & tools
lore

Stephen Boyd

author
#0 lore raw

PATCH 1/1 clk: Remove clk_{register,unregister}_multiplier()

These APIs aren't used, so remove them. This can be reverted if we get a user at some point.

Cc Maxime Ripard <[email protected]>
Suggested-by Michael Turquette <[email protected]>
Signed-off-by Stephen Boyd <[email protected]>
---
 drivers/clk/clk-multiplier.c | 51 --------------------------------------------
 include/linux/clk-provider.h |  7 ------
 2 files changed, 58 deletions(-)
drivers/clk/clk-multiplier.c +0 -51
index 43ec269fcbff..fe7806506bf3 100644
@@ -128,54 +128,3 @@ const struct clk_ops clk_multiplier_ops = {
 	.set_rate	= clk_multiplier_set_rate,
 };
 EXPORT_SYMBOL_GPL(clk_multiplier_ops);
-
-struct clk *clk_register_multiplier(struct device *dev, const char *name,
-				    const char *parent_name,
-				    unsigned long flags,
-				    void __iomem *reg, u8 shift, u8 width,
-				    u8 clk_mult_flags, spinlock_t *lock)
-{
-	struct clk_init_data init;
-	struct clk_multiplier *mult;
-	struct clk *clk;
-
-	mult = kmalloc(sizeof(*mult), GFP_KERNEL);
-	if (!mult)
-		return ERR_PTR(-ENOMEM);
-
-	init.name = name;
-	init.ops = &clk_multiplier_ops;
-	init.flags = flags | CLK_IS_BASIC;
-	init.parent_names = &parent_name;
-	init.num_parents = 1;
-
-	mult->reg = reg;
-	mult->shift = shift;
-	mult->width = width;
-	mult->flags = clk_mult_flags;
-	mult->lock = lock;
-	mult->hw.init = &init;
-
-	clk = clk_register(dev, &mult->hw);
-	if (IS_ERR(clk))
-		kfree(mult);
-
-	return clk;
-}
-EXPORT_SYMBOL_GPL(clk_register_multiplier);
-
-void clk_unregister_multiplier(struct clk *clk)
-{
-	struct clk_multiplier *mult;
-	struct clk_hw *hw;
-
-	hw = __clk_get_hw(clk);
-	if (!hw)
-		return;
-
-	mult = to_clk_multiplier(hw);
-
-	clk_unregister(clk);
-	kfree(mult);
-}
-EXPORT_SYMBOL_GPL(clk_unregister_multiplier);
include/linux/clk-provider.h +0 -7
index e9a4d1ea556e..837cd7c7c8a7 100644
@@ -554,13 +554,6 @@ struct clk_multiplier {
 
 extern const struct clk_ops clk_multiplier_ops;
 
-struct clk *clk_register_multiplier(struct device *dev, const char *name,
-				    const char *parent_name,
-				    unsigned long flags,
-				    void __iomem *reg, u8 shift, u8 width,
-				    u8 clk_mult_flags, spinlock_t *lock);
-void clk_unregister_multiplier(struct clk *clk);
-
 /***
  * struct clk_composite - aggregate clock of mux, divider and gate clocks
  *
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Reviewed-by on v1 1/1
#1 lore raw

Hi!

Quoted 6 lines · Stephen Boyd

These APIs aren't used, so remove them. This can be reverted if we get a user at some point.

Cc Maxime Ripard <[email protected]>
Suggested-by Michael Turquette <[email protected]>
Signed-off-by Stephen Boyd <[email protected]>
Reviewed-by Maxime Ripard <[email protected]>

Thanks!
Maxime

Signature · 3 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Applied
#2 lore raw

Quoting Maxime Ripard (2015-10-22 01:36:47)

Quoted 8 lines

Hi!
=

Quoted 3 lines · Stephen Boyd

These APIs aren't used, so remove them. This can be reverted if we get a user at some point.
=

Quoted 6 lines
Quoted 3 lines
Cc Maxime Ripard <[email protected]>
Suggested-by Michael Turquette <[email protected]>
Signed-off-by Stephen Boyd <[email protected]>

=

Reviewed-by Maxime Ripard <[email protected]>

Applied.

Thanks,
Mike

Quoted 11 lines

=

Thanks!
Maxime
=

-- =

Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com