Skip to contentSkip to conversation

ASoC: wm8960: harmless underflow in wm8960_put_deemph()

PATCH In review Dan Carpenter 2 participants 2 messages Oct 13, 2015 – Oct 22, 2015

Subsystems (4)
Sound Kernel janitors ASoC Wolfson microelectronics drivers
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 ASoC: wm8960: harmless underflow in wm8960_put_deemph()

Valid values of "deemph" are zero and one, but we accidentally allow negative values as well. It's harmless but we may as well fix it.

Signed-off-by Dan Carpenter <[email protected]>
sound/soc/codecs/wm8960.c +1 -1
index e3b7d0c..dc47c2f 100644
@@ -201,7 +201,7 @@ static int wm8960_put_deemph(struct snd_kcontrol *kcontrol,
 {
 	struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
 	struct wm8960_priv *wm8960 = snd_soc_codec_get_drvdata(codec);
-	int deemph = ucontrol->value.integer.value[0];
+	unsigned int deemph = ucontrol->value.integer.value[0];
 
 	if (deemph > 1)
 		return -EINVAL;
maintainer
#1 lore raw
Quoted 2 lines · Dan Carpenter

Valid values of "deemph" are zero and one, but we accidentally allow negative values as well. It's harmless but we may as well fix it.

This appears to duplicate the patch sent immediately before it?