ACPI: Introduce CPU performance controls using CPPC

Hello Ashwin Chaugule,

The patch 337aadff8e45: "ACPI: Introduce CPU performance controls using CPPC" from Oct 2, 2015, leads to the following static checker warning:

drivers/acpi/cppc_acpi.c:527 acpi_cppc_processor_probe()
warn: overwrite may leak 'cpc_ptr'

drivers/acpi/cppc_acpi.c

   426          cpc_ptr = kzalloc(sizeof(struct cpc_desc), GFP_KERNEL);
   427          if (!cpc_ptr) {
   428                  ret = -ENOMEM;
   429                  goto out_buf_free;
   430          }
   431
   432          /* First entry is NumEntries. */
   433          cpc_obj = &out_obj->package.elements[0];
   434          if (cpc_obj->type == ACPI_TYPE_INTEGER) {
   435                  num_ent = cpc_obj->integer.value;
   436          } else {
   437                  pr_debug("Unexpected entry type(%d) for NumEntries\n",
   438                                  cpc_obj->type);
   439                  goto out_free;
   440          }

[ snip ]

   523          kfree(output.pointer);
   524          return 0;
   525
   526  out_free:
   527          cpc_ptr = per_cpu(cpc_desc_ptr, pr->id);

Why do we have this line? Maybe it is left over and should be deleted?

Gah! You're right. This is a left over and should be deleted. I can send the fix to Rafael, if you dont have one ready to send?

Quoted 2 lines · Ashwin Chaugule

Gah! You're right. This is a left over and should be deleted. I can send the fix to Rafael, if you dont have one ready to send?

Can you send it? Please give me a Reported-by tag.

The patch 337aadff8e45: "ACPI: Introduce CPU performance controls using CPPC" from Oct 2, 2015, leads to the following static checker warning:

drivers/acpi/cppc_acpi.c:527 acpi_cppc_processor_probe()
warn: overwrite may leak 'cpc_ptr'

Fix warning by removing bogus per cpu ptr dereference.

Reported-by Dan Carpenter <[email protected]>

Signed-off-by Ashwin Chaugule <[email protected]>

---
 drivers/acpi/cppc_acpi.c | 1 -
 1 file changed, 1 deletion(-)

drivers/acpi/cppc_acpi.c +0 -0

index 0bbf84b..8ca4c2c 100644