Skip to contentSkip to conversation

lustre: obdclass: fix sparse warning

PATCH In review Paul Davies C 2 participants 2 messages Oct 24, 2015 – Oct 25, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lustre: obdclass: fix sparse warning

This patch fixes the following warnings given by the sparse:

drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:424:5: warning: symbol 'class_procfs_init' was not declared. Should it be static? drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:460:5: warning: symbol 'class_procfs_clean' was not declared. Should it be static? drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:161:5: warning: symbol 'obd_sysctl_init' was not declared. Should it be static? drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:166:6: warning: symbol 'obd_sysctl_clean' was not declared. Should it be static?

---
 drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 4 ++--
 drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/lustre/lustre/obdclass/linux/linux-module.c +2 -2
index 6218ef3..45d92c2 100644
@@ -421,7 +421,7 @@ static struct attribute_group lustre_attr_group = {
 	.attrs = lustre_attrs,
 };
 
-int class_procfs_init(void)
+static int class_procfs_init(void)
 {
 	int rc = -ENOMEM;
 	struct dentry *file;
@@ -457,7 +457,7 @@ out:
 	return rc;
 }
 
-int class_procfs_clean(void)
+static int class_procfs_clean(void)
 {
 	if (debugfs_lustre_root != NULL)
 		debugfs_remove_recursive(debugfs_lustre_root);
drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c +2 -2
index 1515163..6f13f21 100644
@@ -158,11 +158,11 @@ static struct attribute_group lustre_attr_group = {
 	.attrs = lustre_attrs,
 };
 
-int obd_sysctl_init(void)
+static int obd_sysctl_init(void)
 {
 	return sysfs_create_group(lustre_kobj, &lustre_attr_group);
 }
 
-void obd_sysctl_clean(void)
+static void obd_sysctl_clean(void)
 {
 }
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 7 lines · Paul Davies C

This patch fixes the following warnings given by the sparse:

drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:424:5: warning: symbol 'class_procfs_init' was not declared. Should it be static? drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:460:5: warning: symbol 'class_procfs_clean' was not declared. Should it be static? drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:161:5: warning: symbol 'obd_sysctl_init' was not declared. Should it be static? drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:166:6: warning: symbol 'obd_sysctl_clean' was not declared. Should it be static?

Quoted 5 lines
---
 drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 4 ++--
 drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

This doesn't apply to my staging-testing branch of staging.git.

Please rebase and resend, if it is still needed.

thanks,

greg k-h