efl bump to 1.15.2

There is no advantage for efl related packages to share the same version number anymore (except for Efl and Elementary).

Here are the version number used for the 1.15 stable release:
EFL 1.15.2
Elementary 1.15.2
Emotion Generic Players 1.15.0
Evas Generic Loaders 1.15.0
Python-EFL 1.15.0

Also, we usually do not have a sub-directory for a family of related packages which don't share the same version number, so move expedite to the package directory. Expedite now appears in the "Graphic libraries and applications (graphic/text)" in the Kconfig menu.

In a followup patch, expedite will be downloaded directly from the 1.15 branch in the git repository since there is no new tarball release after 1.7.0.

Signed-off-by Romain Naour <[email protected]>

---
v5: fixes typos (ThomasP)
Use depends on BR2_PACKAGE_EFL instead of select (ThomasP)
v4: improve the commit log (ThomasP)
move expedite to "Graphic applications" under "Graphic libraries and applications" menu (ThomasP) fix package comment dependency on BR2_USE_MMU

---
 package/Config.in                      | 1 +
 package/efl/Config.in                  | 1 -
 package/{efl => }/expedite/Config.in   | 1 +
 package/{efl => }/expedite/expedite.mk | 0
 4 files changed, 2 insertions(+), 1 deletion(-)
 rename package/{efl => }/expedite/Config.in (95%)
 rename package/{efl => }/expedite/expedite.mk (100%)

package/Config.in +1 -0

index 2f74439..c3b9a7a 100644
@@ -219,6 +219,7 @@ endmenu
 menu "Graphic libraries and applications (graphic/text)"
 
 comment "Graphic applications"
+	source "package/expedite/Config.in"
 	source "package/fswebcam/Config.in"
 	source "package/glmark2/Config.in"
 	source "package/gnuplot/Config.in"

package/efl/Config.in +0 -1

index 3d31a26..cb91660 100644
@@ -10,7 +10,6 @@ menuconfig BR2_PACKAGE_EFL
 
 if BR2_PACKAGE_EFL
 
-source "package/efl/expedite/Config.in"
 source "package/efl/libeina/Config.in"
 source "package/efl/libecore/Config.in"
 source "package/efl/libeet/Config.in"

package/expedite/Config.in renamed from package/efl/expedite/Config.in +1 -0

similarity index 95%
rename from package/efl/expedite/Config.in
rename to package/expedite/Config.in
index 1e12108..de6a056 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_EXPEDITE
 	select BR2_PACKAGE_LIBEINA
 	select BR2_PACKAGE_LIBEVAS
 	select BR2_PACKAGE_LIBEET
+	depends on BR2_PACKAGE_EFL
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libevas
 	help

package/expedite/expedite.mk renamed from package/efl/expedite/expedite.mk +0 -0

similarity index 100%
rename from package/efl/expedite/expedite.mk
rename to package/expedite/expedite.mk

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

As for expedite package, there is no advantage for efl related packages to share the same version number anymore (except for efl and libelementary).

Also, we usually do not have a sub-directory for a family of related packages which doen't share the same version number, so move libevas-generic-loaders to package directory. Libevas-generic-loaders appear now in "Libraries" -> "Graphics" in the Kconfig menu.

While at it, remove BR2_USE_WCHAR dependency since the efl package already depend on it.

Signed-off-by Romain Naour <[email protected]>

---
v5: Use depends on BR2_PACKAGE_EFL instead of select (ThomasP)
v4: improve the commit log (ThomasP)
move libevas-generic-loaders to "Libraries" -> "Graphics" (ThomasP) fix package comment dependency on BR2_USE_MMU

---
 package/Config.in                                                   | 1 +
 package/efl/Config.in                                               | 1 -
 package/{efl => }/libevas-generic-loaders/Config.in                 | 6 +++---
 .../{efl => }/libevas-generic-loaders/libevas-generic-loaders.mk    | 0
 4 files changed, 4 insertions(+), 4 deletions(-)
 rename package/{efl => }/libevas-generic-loaders/Config.in (79%)
 rename package/{efl => }/libevas-generic-loaders/libevas-generic-loaders.mk (100%)

package/Config.in +1 -0

index c3b9a7a..8ecb2df 100644
@@ -819,6 +819,7 @@ menu "Graphics"
 	source "package/libdri2/Config.in"
 	source "package/libdrm/Config.in"
 	source "package/libexif/Config.in"
+	source "package/libevas-generic-loaders/Config.in"
 	source "package/libfm/Config.in"
 	source "package/libfm-extra/Config.in"
 	source "package/libfreeimage/Config.in"

package/efl/Config.in +0 -1

index cb91660..7ce5a36 100644
@@ -16,7 +16,6 @@ source "package/efl/libeet/Config.in"
 source "package/efl/libefreet/Config.in"
 source "package/efl/libeio/Config.in"
 source "package/efl/libevas/Config.in"
-source "package/efl/libevas-generic-loaders/Config.in"
 source "package/efl/libembryo/Config.in"
 source "package/efl/libedje/Config.in"
 source "package/efl/libethumb/Config.in"

package/libevas-generic-loaders/Config.in renamed from package/efl/libevas-generic-loaders/Config.in +3 -3

similarity index 79%
rename from package/efl/libevas-generic-loaders/Config.in
rename to package/libevas-generic-loaders/Config.in
index 3f7581f..d0c3cf4 100644
@@ -2,6 +2,7 @@ config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS
 	bool "libevas generic loaders"
 	select BR2_PACKAGE_LIBEINA
 	select BR2_PACKAGE_ZLIB
+	depends on BR2_PACKAGE_EFL
 	help
 	  These are additional "generic" loaders for Evas that are
 	  stand-alone executables that evas may run from its generic

@@ -15,15 +16,14 @@ config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_SVG
 	bool "SVG loader"
 	select BR2_PACKAGE_LIBRSVG
 	select BR2_PACKAGE_CAIRO
-	depends on BR2_USE_WCHAR # librsvg -> glib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # librsvg -> glib2
 	depends on BR2_INSTALL_LIBSTDCPP # librsvg -> pango
 	depends on BR2_ARCH_HAS_ATOMICS # cairo
 	help
 	  This option enables the Evas generic SVG loader
 
-comment "SVG loader needs a toolchain w/ wchar, threads, C++"
+comment "SVG loader needs a toolchain w/ threads, C++"
 	depends on BR2_ARCH_HAS_ATOMICS
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
 
 endif

package/libevas-generic-loaders/libevas-generic-loaders.mk renamed from package/efl/libevas-generic-loaders/libevas-generic-loaders.mk +0 -0

similarity index 100%
rename from package/efl/libevas-generic-loaders/libevas-generic-loaders.mk
rename to package/libevas-generic-loaders/libevas-generic-loaders.mk

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:

Quoted 4 lines

As for expedite package, there is no advantage for efl related packages to share the same version number anymore (except for efl and libelementary).

Quoted 8 lines

Also, we usually do not have a sub-directory for a family of related packages which doen't share the same version number, so move libevas-generic-loaders to package directory. Libevas-generic-loaders appear now in "Libraries" -> "Graphics" in the Kconfig menu.

While at it, remove BR2_USE_WCHAR dependency since the efl package already depend on it.

Are you sure that libevas-generic-loaders does not itself depend on wchar?

If it does, then please keep the dependency, even if it is automatically inherited through the dependency on EFL. This is so, in case EFL loses its dependency on wchar, libevas-generic-loaders would still have its own.

If it is not needed, then:

    Reviewed-by: "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Le 25/10/2015 13:56, Yann E. MORIN a ?crit :

Quoted 17 lines

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:

Quoted 4 lines

As for expedite package, there is no advantage for efl related packages to share the same version number anymore (except for efl and libelementary).

Quoted 8 lines

Also, we usually do not have a sub-directory for a family of related packages which doen't share the same version number, so move libevas-generic-loaders to package directory. Libevas-generic-loaders appear now in "Libraries" -> "Graphics" in the Kconfig menu.

While at it, remove BR2_USE_WCHAR dependency since the efl package already depend on it.

Are you sure that libevas-generic-loaders does not itself depend on wchar?

Quoted 4 lines

If it does, then please keep the dependency, even if it is automatically inherited through the dependency on EFL. This is so, in case EFL loses its dependency on wchar, libevas-generic-loaders would still have its own.

libevas-generic-loaders doesn't use wchar by itself, it's a reverse dependency that come from librsvg which is required for svg support only.

So, IIUC when a package A select a package B, we must propagate all reverse dependencies of the package B when the package A already depends on them implicitly (i.e when using a depends on BR2_PACKAGE_C).

Also, in the libevas-generic-loaders bump I removed two other dependencies for the same reason (BR2_TOOLCHAIN_HAS_THREADS and BR2_INSTALL_LIBSTDCPP):
http://lists.busybox.net/pipermail/buildroot/2015-October/142950.html

Romain, All,

On 2015-10-25 20:21 +0100, Romain Naour spake thusly:

Quoted 18 lines

Le 25/10/2015 13:56, Yann E. MORIN a ?crit :

Quoted 17 lines

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:

Quoted 4 lines

As for expedite package, there is no advantage for efl related packages to share the same version number anymore (except for efl and libelementary).

Quoted 8 lines

Also, we usually do not have a sub-directory for a family of related packages which doen't share the same version number, so move libevas-generic-loaders to package directory. Libevas-generic-loaders appear now in "Libraries" -> "Graphics" in the Kconfig menu.

While at it, remove BR2_USE_WCHAR dependency since the efl package already depend on it.

Are you sure that libevas-generic-loaders does not itself depend on wchar?

Quoted 7 lines

Quoted 4 lines

If it does, then please keep the dependency, even if it is automatically inherited through the dependency on EFL. This is so, in case EFL loses its dependency on wchar, libevas-generic-loaders would still have its own.

libevas-generic-loaders doesn't use wchar by itself, it's a reverse dependency that come from librsvg which is required for svg support only.

OK, so if libevas-generic-loader does not need it, and does not have to inherit it through one of its select, then dropping is OK.

Quoted 3 lines

So, IIUC when a package A select a package B, we must propagate all reverse dependencies of the package B when the package A already depends on them implicitly (i.e when using a depends on BR2_PACKAGE_C).

I'm not sure I groked what you wrote, so here's a litle example. Say you have a pacakge foo that needs bar and bar needs threads; here's how you'd express it:

config foo
bool "foo"
depends on threads # bar
select bar

config bar
bool "bar"
depends on threads

Now, if package foo also needs threads for itself, here's how you'd express it:

config foo
bool "foo"
depends on threads
select bar

config bar
bool "bar"
depends on threads

Note that the threads dependency in foo no longer has the '# bar' comment.

Quoted 3 lines

Also, in the libevas-generic-loaders bump I removed two other dependencies for the same reason (BR2_TOOLCHAIN_HAS_THREADS and BR2_INSTALL_LIBSTDCPP):
http://lists.busybox.net/pipermail/buildroot/2015-October/142950.html

Hmm... I may have missed properly checkign that. If libevas-generic-loader does not need threads or C++, then you can indeed drop them. However, if it needs it, you must depend on them, even if you inherit them from the EFL dependency.

Looking at the libevas-generic-loader code, it seems there is no need for threads, so you can drop it.

As for C++, evas-generic-loader needs it: first, tis configure.ac has AC_PROG_CXX, and it has one C++ file, src/pdf/main.cpp. So you have to keep the dependency on C++.

Regards,
Yann E. MORIN.

Le 25/10/2015 22:04, Yann E. MORIN a ?crit :

Quoted 1 line

On 2015-10-25 20:21 +0100, Romain Naour spake thusly:

Quoted 8 lines

Quoted 3 lines

So, IIUC when a package A select a package B, we must propagate all reverse dependencies of the package B when the package A already depends on them implicitly (i.e when using a depends on BR2_PACKAGE_C).

I'm not sure I groked what you wrote, so here's a litle example. Say you have a pacakge foo that needs bar and bar needs threads; here's how you'd express it:

Quoted 8 lines

config foo
bool "foo"
depends on threads # bar
select bar

config bar
bool "bar"
depends on threads

In my example based on libevas-generic-loaders, I had 3 packages:

config foo
bool "foo"
depends on threads

config bar
bool "bar"
depends on foo
[depends on threads # baz]
select baz

config baz
bool "baz"
depends on threads

So foo and baz depends on threads, bar depends on foo.
The question is do we need to add [depends on threads # baz] for bar in that case ? bar implicitly depends on threads thanks to foo dependency.

So, what I understand after your comment is that we must keep the reverse dependency on threads for the package bar because it select baz.

Ok, I'll look at it latter the week, I'll try to resend a new series before the next week-end.

This new host-package provide edje_cc, embryo_cc and eet binaries that will be used by the upcomming libefl packages which will contain the new version of efl libraries.

Signed-off-by Romain Naour <[email protected]>

---
v4: keep efl as a sub-directory.
rename this new package to libefl since we want to keep a efl and elementary version in sync.
v3: remove trailing slash (Vicente Bergas)

    bump to 1.15.2
---
 package/efl/libefl/libefl.hash |  2 ++
 package/efl/libefl/libefl.mk   | 75 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 77 insertions(+)
 create mode 100644 package/efl/libefl/libefl.hash
 create mode 100644 package/efl/libefl/libefl.mk

package/efl/libefl/libefl.hash new file +2 -0

new file mode 100644
index 0000000..7ac26f4
@@ -0,0 +1,2 @@
+# From https://download.enlightenment.org/rel/libs/efl/efl-1.15.2.tar.xz.sha256
+sha256	dd738f19f454621a7fa1fdb4c008457c170989f5f0c535edfed7b6773ae6c2a4	efl-1.15.2.tar.xz

package/efl/libefl/libefl.mk new file +2 -0

new file mode 100644
index 0000000..4dca733
@@ -0,0 +1,75 @@
+################################################################################
+#

package/efl/libefl/libefl.mk new file +62 -0

+################################################################################
+#
+# host-libefl
+#
+################################################################################
+
+# We want to build only some host tools used later in the build.
+# Actually we want: edje_cc, embryo_cc and eet.
+
+# Host dependencies:
+# * host-dbus: for Eldbus
+# * host-freetype: for libevas
+# * host-libglib2: for libecore
+# * host-libjpeg, host-libpng: for libevas image loader
+# * host-lua: disable luajit dependency
+HOST_LIBEFL_DEPENDENCIES = \
+	host-pkgconf \
+	host-dbus \
+	host-freetype \
+	host-libglib2 \
+	host-libjpeg \
+	host-libpng \
+	host-lua \
+	host-zlib
+
+# Configure options:
+# --disable-audio, --disable-multisense remove libsndfile dependency.
+# --disable-cxx-bindings: disable C++11 bindings.
+# --disable-fontconfig: remove dependency on fontconfig.
+# --disable-fribidi: remove dependency on libfribidi.
+# --disable-gstreamer1: remove dependency on gtreamer 1.0.
+# --disable-libeeze: remove libudev dependency.
+# --disable-libmount: remove dependency on host-util-linux libmount.
+# --disable-physics: remove Bullet dependency.
+# --enable-image-loader-gif=no: disable Gif dependency.
+# --enable-image-loader-tiff=no: disable Tiff dependency.
+# --enable-lua-old: disable Elua and remove luajit dependency.
+# --with-crypto=none: remove dependencies on openssl or gnutls.
+# --with-x11=none: remove dependency on X.org.
+#   Yes I really know what I am doing.
+HOST_LIBEFL_CONF_OPTS += \
+	--disable-audio \
+	--disable-cxx-bindings \
+	--disable-fontconfig \
+	--disable-fribidi \
+	--disable-gstreamer1 \
+	--disable-libeeze \
+	--disable-libmount \
+	--disable-multisense \
+	--disable-physics \
+	--enable-image-loader-gif=no \
+	--enable-image-loader-jpeg=yes \
+	--enable-image-loader-png=yes \
+	--enable-image-loader-tiff=no \
+	--enable-lua-old \
+	--with-crypto=none \
+	--with-glib=yes \
+	--with-opengl=none \
+	--with-x11=none \
+	--enable-i-really-know-what-i-am-doing-and-that-this-will-probably-break-things-and-i-will-fix-them-myself-and-send-patches-aba
+
+$(eval $(host-autotools-package))

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:

Quoted 34 lines

This new host-package provide edje_cc, embryo_cc and eet binaries that will be used by the upcomming libefl packages which will contain the new version of efl libraries.

Signed-off-by Romain Naour <[email protected]>

---
v4: keep efl as a sub-directory.
rename this new package to libefl since we want to keep a efl and elementary version in sync.
v3: remove trailing slash (Vicente Bergas)

    bump to 1.15.2
---
 package/efl/libefl/libefl.hash |  2 ++
 package/efl/libefl/libefl.mk   | 75 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 77 insertions(+)
 create mode 100644 package/efl/libefl/libefl.hash
 create mode 100644 package/efl/libefl/libefl.mk

package/efl/libefl/libefl.hash new file +2 -0

new file mode 100644
index 0000000..7ac26f4
@@ -0,0 +1,2 @@
+# From https://download.enlightenment.org/rel/libs/efl/efl-1.15.2.tar.xz.sha256
+sha256	dd738f19f454621a7fa1fdb4c008457c170989f5f0c535edfed7b6773ae6c2a4	efl-1.15.2.tar.xz

package/efl/libefl/libefl.mk new file +2 -0

new file mode 100644
index 0000000..4dca733
@@ -0,0 +1,75 @@
+################################################################################
+#

package/efl/libefl/libefl.mk line 12

Quoted 10 lines

package/efl/libefl/libefl.mk new file +10 -0

+# libefl
+#
+################################################################################
+
+# hardcode the version here since the bump to 1.15 is not complete in Buildroot
+LIBEFL_VERSION = 1.15.2
+LIBEFL_SOURCE = efl-$(LIBEFL_VERSION).tar.xz
+LIBEFL_SITE = http://download.enlightenment.org/rel/libs/efl
+LIBEFL_LICENSE = BSD-2c, LGPLv2.1+, GPLv2+
+LIBEFL_LICENSE_FILES = COPYING

There are much more license files:

    LIBEFL_LICENSE_FILES = \
        COPYING \
        licenses/COPYING.BSD \
        licenses/COPYING.FTL \
        licenses/COPYING.GPL \
        licenses/COPYING.LGPL \
        licenses/COPYING.SMALL

We may also want to add COMPLIANCE to this list, since it has a few suggestions about legal info.

Regards,
Yann E. MORIN.

Quoted 69 lines

package/efl/libefl/libefl.mk new file +62 -0

+################################################################################
+#
+# host-libefl
+#
+################################################################################
+
+# We want to build only some host tools used later in the build.
+# Actually we want: edje_cc, embryo_cc and eet.
+
+# Host dependencies:
+# * host-dbus: for Eldbus
+# * host-freetype: for libevas
+# * host-libglib2: for libecore
+# * host-libjpeg, host-libpng: for libevas image loader
+# * host-lua: disable luajit dependency
+HOST_LIBEFL_DEPENDENCIES = \
+	host-pkgconf \
+	host-dbus \
+	host-freetype \
+	host-libglib2 \
+	host-libjpeg \
+	host-libpng \
+	host-lua \
+	host-zlib
+
+# Configure options:
+# --disable-audio, --disable-multisense remove libsndfile dependency.
+# --disable-cxx-bindings: disable C++11 bindings.
+# --disable-fontconfig: remove dependency on fontconfig.
+# --disable-fribidi: remove dependency on libfribidi.
+# --disable-gstreamer1: remove dependency on gtreamer 1.0.
+# --disable-libeeze: remove libudev dependency.
+# --disable-libmount: remove dependency on host-util-linux libmount.
+# --disable-physics: remove Bullet dependency.
+# --enable-image-loader-gif=no: disable Gif dependency.
+# --enable-image-loader-tiff=no: disable Tiff dependency.
+# --enable-lua-old: disable Elua and remove luajit dependency.
+# --with-crypto=none: remove dependencies on openssl or gnutls.
+# --with-x11=none: remove dependency on X.org.
+#   Yes I really know what I am doing.
+HOST_LIBEFL_CONF_OPTS += \
+	--disable-audio \
+	--disable-cxx-bindings \
+	--disable-fontconfig \
+	--disable-fribidi \
+	--disable-gstreamer1 \
+	--disable-libeeze \
+	--disable-libmount \
+	--disable-multisense \
+	--disable-physics \
+	--enable-image-loader-gif=no \
+	--enable-image-loader-jpeg=yes \
+	--enable-image-loader-png=yes \
+	--enable-image-loader-tiff=no \
+	--enable-lua-old \
+	--with-crypto=none \
+	--with-glib=yes \
+	--with-opengl=none \
+	--with-x11=none \
+	--enable-i-really-know-what-i-am-doing-and-that-this-will-probably-break-things-and-i-will-fix-them-myself-and-send-patches-aba
+
+$(eval $(host-autotools-package))

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Add the libefl package which contains an updated version of the following libraries:
libecore, libedje, libeet, libfreet, libeina, libeio, libembryo, libthumb and libevas. It also contains eldbus, ephysics, and escape, see [1].

For now, the bump to efl 1.15.x is not complete.
This allows to build at least a default configuration whithout X11 support or graphics acceleration.
This support will be added by a follow up patches in the series.

Also, add BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG config option in order to select all recommended packages that allows to build efl-core whithout the extra-long --enable-i-really-know-what-i-am-doing...

At the end of the configure script, the summary tab will show that alsa support is allways disabled even if alsa-utils has been build before efl-core package.

"Ecore_Audio.....: yes (-alsa +pulseaudio +sndfile)" This is intentional.

An initial runtime test has been done under Qemu with a glibc x86 toolchain.

An additional runtime test has been done with a uClibc-ng 1.0.5 toolchain patched with [2] in order to add mkstemps() which is used by Eina library. This patch has been upstreamed in uClubc-ng 1.0.6 release.

Another test has been done with a musl toolchain by Vicente Bergas (Thanks!)

Add a dependency on threads support since clearly efl libraries are not even built without thread support [3].

[1] See https://phab.enlightenment.org/phame/live/3/post/efl_1_8/
[2] http://mailman.uclibc-ng.org/pipermail/devel/2015-August/000432.html
[3] https://git.enlightenment.org/core/efl.git/tree/configure.ac#n5032

Signed-off-by Romain Naour <[email protected]>

Cc Vicente Bergas <[email protected]>

---
v4: rename to libefl
EFL needs a toolchain with threads support
v3: fix same typo again
Add a note about multisense support
v2: remove glibc only dependency
update commit log accordingly
fix typo in Config.in (Vicente Bergas)

Vicente, can you test this new series and resend your Tested-By tag ? Thanks !

---
 package/efl/Config.in        |  16 +++--
 package/efl/libefl/Config.in |  65 +++++++++++++++++
 package/efl/libefl/libefl.mk | 161 +++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 237 insertions(+), 5 deletions(-)
 create mode 100644 package/efl/libefl/Config.in

package/efl/Config.in +8 -3

index 7ce5a36..2860cd6 100644
@@ -1,8 +1,12 @@
 menuconfig BR2_PACKAGE_EFL
 	bool "Enlightenment Foundation Libraries"
-	depends on BR2_USE_WCHAR
-	# libeina uses madvise(). To revisit when bumping EFL to 1.8
-	depends on BR2_USE_MMU
+	depends on BR2_INSTALL_LIBSTDCPP # libefl
+	depends on BR2_PACKAGE_HAS_UDEV # libefl -> libudev
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libefl
+	depends on BR2_USE_MMU # libefl
+	depends on BR2_USE_WCHAR # libefl
+	depends on !BR2_STATIC_LIBS # libefl
+	select BR2_PACKAGE_LIBEFL
 	help
 	  Enlightenment Foundation Libraries
 

@@ -13,6 +17,7 @@ if BR2_PACKAGE_EFL
 source "package/efl/libeina/Config.in"
 source "package/efl/libecore/Config.in"
 source "package/efl/libeet/Config.in"
+source "package/efl/libefl/Config.in"
 source "package/efl/libefreet/Config.in"
 source "package/efl/libeio/Config.in"
 source "package/efl/libevas/Config.in"

package/efl/Config.in +1 -0

+	depends on BR2_USE_MMU

package/efl/libefl/Config.in new file +2 -0

new file mode 100644
index 0000000..2b758f0
@@ -0,0 +1,65 @@
+config BR2_PACKAGE_LIBEFL
+	bool "libefl"

package/efl/libefl/Config.in new file +6 -0

+	help
+	  Enlightenment Foundation Libraries
+
+	  https://enlightenment.org
+
+if BR2_PACKAGE_LIBEFL

package/efl/libefl/libefl.mk +87 -0

index 4dca733..781f397 100644
@@ -11,6 +11,167 @@ LIBEFL_SITE = http://download.enlightenment.org/rel/libs/efl
 LIBEFL_LICENSE = BSD-2c, LGPLv2.1+, GPLv2+
 LIBEFL_LICENSE_FILES = COPYING
 
+LIBEFL_INSTALL_STAGING = YES
+
+LIBEFL_DEPENDENCIES = host-pkgconf host-libefl dbus freetype jpeg lua udev zlib
+
+# Configure options:
+# --disable-cxx-bindings: disable C++11 bindings.
+# --enable-lua-old: disable Elua and remove luajit dependency.
+# --with-x11=none: remove dependency on X.org.
+LIBEFL_CONF_OPTS = \
+	--with-edje-cc=$(HOST_DIR)/usr/bin/edje_cc \
+	--with-eolian-gen=$(HOST_DIR)/usr/bin/eolian_gen \
+	--disable-cxx-bindings \
+	--enable-lua-old \
+	--with-x11=none
+
+# Disable untested configuration warning.
+ifeq ($(BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG),)
+LIBEFL_CONF_OPTS += --enable-i-really-know-what-i-am-doing-and-that-this-will-probably-break-things-and-i-will-fix-them-myself-and-send-patches-aba
+endif
+
+# Libmount is used heavily inside Eeze for support of removable devices etc.
+# and disabling this will hurt support for Enlightenment and its filemanager.
+ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBMOUNT),y)
+LIBEFL_DEPENDENCIES += util-linux
+LIBEFL_CONF_OPTS += --enable-libmount
+else
+LIBEFL_CONF_OPTS += --disable-libmount
+endif
+
+# If fontconfig is disabled, this is going to make general font
+# searching not work, and only some very direct 'load /path/file.ttf'
+# will work alongside some old-school ttf file path searching. This
+# is very likely not what you want, so highly reconsider turning
+# fontconfig off. Having it off will lead to visual problems like
+# missing text in many UI areas etc.
+ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
+LIBEFL_CONF_OPTS += --enable-fontconfig
+LIBEFL_DEPENDENCIES += fontconfig
+else
+LIBEFL_CONF_OPTS += --disable-fontconfig
+endif
+
+# Fribidi is used for handling right-to-left text (like Arabic,
+# Hebrew, Farsi, Persian etc.) and is very likely not a feature
+# you want to disable unless you know for absolute certain you
+# will never encounter and have to display such scripts. Also
+# note that we don't test with fribidi disabled so you may also
+# trigger code paths with bugs that are never normally used.
+ifeq ($(BR2_PACKAGE_LIBFRIBIDI),y)
+LIBEFL_CONF_OPTS += --enable-fribidi
+LIBEFL_DEPENDENCIES += libfribidi
+else
+LIBEFL_CONF_OPTS += --disable-fribidi
+endif
+
+# If Gstreamer 1.x support is disabled, it will heavily limit your media
+# support options and render some functionality as useless, leading to
+# visible application bugs.
+ifeq ($(BR2_PACKAGE_GSTREAMER1)$(BR2_PACKAGE_GST1_PLUGINS_BASE),yy)
+LIBEFL_CONF_OPTS += --enable-gstreamer1
+LIBEFL_DEPENDENCIES += gstreamer1 gst1-plugins-base
+else
+LIBEFL_CONF_OPTS += --disable-gstreamer1
+endif
+
+# You have chosen to disable physics support. This disables lots of
+# core functionality and is effectively never tested. You are going
+# to find features that suddenly don't work and as a result cause
+# a series of breakages. This is simply not tested so you are on
+# your own in terms of ensuring everything works if you do this
+ifeq ($(BR2_PACKAGE_BULLET),y)
+LIBEFL_CONF_OPTS += --enable-physics
+LIBEFL_DEPENDENCIES += bullet
+else
+LIBEFL_CONF_OPTS += --disable-physics
+endif
+
+# You disabled audio support in Ecore. This is not tested and may
+# Create bugs for you due to it creating untested code paths.
+# Reconsider disabling audio.
+ifeq ($(BR2_PACKAGE_LIBSNDFILE),y)
+LIBEFL_CONF_OPTS += --enable-audio
+LIBEFL_DEPENDENCIES += libsndfile
+else
+LIBEFL_CONF_OPTS += --disable-audio
+endif
+

package/efl/libefl/libefl.mk +20 -0

+else
+LIBEFL_CONF_OPTS += --enable-image-loader-jpeg=no
+endif
+
+ifeq ($(BR2_PACKAGE_LIBEFL_GIF),y)
+LIBEFL_CONF_OPTS += --enable-image-loader-gif=yes
+LIBEFL_DEPENDENCIES += giflib
+else
+LIBEFL_CONF_OPTS += --enable-image-loader-gif=no
+endif
+
+ifeq ($(BR2_PACKAGE_LIBEFL_TIFF),y)
+LIBEFL_CONF_OPTS += --enable-image-loader-tiff=yes
+LIBEFL_DEPENDENCIES += tiff
+else
+LIBEFL_CONF_OPTS += --enable-image-loader-tiff=no
+endif
+
+$(eval $(autotools-package))
+
 ################################################################################
 #
 # host-libefl

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:

Quoted 85 lines

Add the libefl package which contains an updated version of the following libraries:
libecore, libedje, libeet, libfreet, libeina, libeio, libembryo, libthumb and libevas. It also contains eldbus, ephysics, and escape, see [1].

For now, the bump to efl 1.15.x is not complete.
This allows to build at least a default configuration whithout X11 support or graphics acceleration.
This support will be added by a follow up patches in the series.

Also, add BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG config option in order to select all recommended packages that allows to build efl-core whithout the extra-long --enable-i-really-know-what-i-am-doing...

At the end of the configure script, the summary tab will show that alsa support is allways disabled even if alsa-utils has been build before efl-core package.

"Ecore_Audio.....: yes (-alsa +pulseaudio +sndfile)" This is intentional.

An initial runtime test has been done under Qemu with a glibc x86 toolchain.

An additional runtime test has been done with a uClibc-ng 1.0.5 toolchain patched with [2] in order to add mkstemps() which is used by Eina library. This patch has been upstreamed in uClubc-ng 1.0.6 release.

Another test has been done with a musl toolchain by Vicente Bergas (Thanks!)

Add a dependency on threads support since clearly efl libraries are not even built without thread support [3].

[1] See https://phab.enlightenment.org/phame/live/3/post/efl_1_8/
[2] http://mailman.uclibc-ng.org/pipermail/devel/2015-August/000432.html
[3] https://git.enlightenment.org/core/efl.git/tree/configure.ac#n5032

Signed-off-by Romain Naour <[email protected]>

Cc Vicente Bergas <[email protected]>

---
v4: rename to libefl
EFL needs a toolchain with threads support
v3: fix same typo again
Add a note about multisense support
v2: remove glibc only dependency
update commit log accordingly
fix typo in Config.in (Vicente Bergas)

Vicente, can you test this new series and resend your Tested-By tag ? Thanks !

---
 package/efl/Config.in        |  16 +++--
 package/efl/libefl/Config.in |  65 +++++++++++++++++
 package/efl/libefl/libefl.mk | 161 +++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 237 insertions(+), 5 deletions(-)
 create mode 100644 package/efl/libefl/Config.in

package/efl/Config.in +8 -3

index 7ce5a36..2860cd6 100644
@@ -1,8 +1,12 @@
 menuconfig BR2_PACKAGE_EFL
 	bool "Enlightenment Foundation Libraries"
-	depends on BR2_USE_WCHAR
-	# libeina uses madvise(). To revisit when bumping EFL to 1.8
-	depends on BR2_USE_MMU
+	depends on BR2_INSTALL_LIBSTDCPP # libefl
+	depends on BR2_PACKAGE_HAS_UDEV # libefl -> libudev
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libefl
+	depends on BR2_USE_MMU # libefl
+	depends on BR2_USE_WCHAR # libefl
+	depends on !BR2_STATIC_LIBS # libefl
+	select BR2_PACKAGE_LIBEFL
 	help
 	  Enlightenment Foundation Libraries
 

@@ -13,6 +17,7 @@ if BR2_PACKAGE_EFL
 source "package/efl/libeina/Config.in"
 source "package/efl/libecore/Config.in"
 source "package/efl/libeet/Config.in"
+source "package/efl/libefl/Config.in"
 source "package/efl/libefreet/Config.in"
 source "package/efl/libeio/Config.in"
 source "package/efl/libevas/Config.in"

@@ -24,5 +29,6 @@ source "package/efl/libedbus/Config.in"
 

package/efl/Config.in source "package/efl/libedbus/Config.in" · line 33

Quoted 6 lines

package/efl/Config.in +2 -2

 endif # BR2_PACKAGE_EFL
 
-comment "EFL needs a toolchain w/ wchar"
-	depends on !BR2_USE_WCHAR
+comment "EFL needs udev /dev management and a toolchain w/ C++, dynamic library, threads, wchar"
+	depends on !BR2_PACKAGE_HAS_UDEV || !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR

Please, split this very long line...

Quoted 10 lines

package/efl/Config.in +1 -0

+	depends on BR2_USE_MMU

package/efl/libefl/Config.in new file +2 -0

new file mode 100644
index 0000000..2b758f0
@@ -0,0 +1,65 @@
+config BR2_PACKAGE_LIBEFL
+	bool "libefl"

package/efl/libefl/Config.in line 12

Quoted 10 lines

package/efl/libefl/Config.in new file +10 -0

+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_PACKAGE_HAS_UDEV # libudev
+	depends on BR2_TOOLCHAIN_HAS_THREADS # untested without threads
+	depends on BR2_USE_MMU
+	depends on BR2_USE_WCHAR # use wchar_t
+	depends on !BR2_STATIC_LIBS # dlfcn.h
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_FREETYPE
+	select BR2_PACKAGE_JPEG # Emile needs libjpeg
+	select BR2_PACKAGE_LUA # Evas lua 5.1 or 5.2

You can not select Lua, as it is a provider of the virtual package
luainterpreter: it is not alowed to select the provider of a virtual package, see the manual:
http://buildroot.org/downloads/manual/manual.html#_notes_on_depending_on_a_specific_provider

If your package really requires a specific provider, then you?ll have to make your package depends on this provider; you can not select a provider.

You'll have to make libefl (and efl) both depend on BR2_PACKAGE_LUA.

That's unfortunate, but the manual has explanations on why this is so.

Quoted 11 lines

package/efl/libefl/Config.in new file +10 -0

+	help
+	  Enlightenment Foundation Libraries
+
+	  https://enlightenment.org
+
+if BR2_PACKAGE_LIBEFL
+
+config BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
+	bool "Use recommended and tested configurations"
+	select BR2_PACKAGE_BULLET

package/efl/libefl/Config.in line 28

Quoted 6 lines

package/efl/libefl/Config.in new file +6 -0

+	select BR2_PACKAGE_FONTCONFIG
+	select BR2_PACKAGE_GSTREAMER1
+	select BR2_PACKAGE_GST1_PLUGINS_BASE
+	select BR2_PACKAGE_LIBFRIBIDI
+	select BR2_PACKAGE_LIBSNDFILE
+	select BR2_PACKAGE_PULSEAUDIO

You forgot to propagate P.A.'s dependency on BR2_ARCH_HAS_ATOMICS.

package/efl/libefl/Config.in line 35

Quoted 8 lines

package/efl/libefl/Config.in new file +7 -0

+	select BR2_PACKAGE_UTIL_LINUX
+	select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
+	default y
+	help
+	  Avoid to use untested or not recommended configurations,
+	  otherwise we need to add a very long and obscure option
+	  to start the build.

No need to explain the nitty-gritty implementation details on why this is so. Just state something like:

Enable the basic set of recommended features.

Without that, the EFL developpers consider the build to be potentially broken and won't provide any support for it.

This turns on the following features:

- util-linux' libmount: Libmount is used heavily inside Eeze for support of removable devices etc... and disabling this will hurt support for Enlightenment and its filemanager.

- fontconfig: If fontconfig is disabled, this is going to make general font searching not work, and only some very direct 'load /path/file.ttf' will work alongside some old-school ttf file path searching. This is very likely not what you want, so highly reconsider turning fontconfig off. Having it off will lead to visual problems like missing text in many UI areas etc...

And so on, you get the idea. ;-)

Drop the corresponding comment in the .mk file. It is better to thave those comments in the Config.in, so the user can actually see them and act accordingly.

[--SNIP--]

Quoted 100 lines

package/efl/libefl/libefl.mk +92 -0

index 4dca733..781f397 100644
@@ -11,6 +11,167 @@ LIBEFL_SITE = http://download.enlightenment.org/rel/libs/efl
 LIBEFL_LICENSE = BSD-2c, LGPLv2.1+, GPLv2+
 LIBEFL_LICENSE_FILES = COPYING
 
+LIBEFL_INSTALL_STAGING = YES
+
+LIBEFL_DEPENDENCIES = host-pkgconf host-libefl dbus freetype jpeg lua udev zlib
+
+# Configure options:
+# --disable-cxx-bindings: disable C++11 bindings.
+# --enable-lua-old: disable Elua and remove luajit dependency.
+# --with-x11=none: remove dependency on X.org.
+LIBEFL_CONF_OPTS = \
+	--with-edje-cc=$(HOST_DIR)/usr/bin/edje_cc \
+	--with-eolian-gen=$(HOST_DIR)/usr/bin/eolian_gen \
+	--disable-cxx-bindings \
+	--enable-lua-old \
+	--with-x11=none
+
+# Disable untested configuration warning.
+ifeq ($(BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG),)
+LIBEFL_CONF_OPTS += --enable-i-really-know-what-i-am-doing-and-that-this-will-probably-break-things-and-i-will-fix-them-myself-and-send-patches-aba
+endif
+
+# Libmount is used heavily inside Eeze for support of removable devices etc.
+# and disabling this will hurt support for Enlightenment and its filemanager.
+ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBMOUNT),y)
+LIBEFL_DEPENDENCIES += util-linux
+LIBEFL_CONF_OPTS += --enable-libmount
+else
+LIBEFL_CONF_OPTS += --disable-libmount
+endif
+
+# If fontconfig is disabled, this is going to make general font
+# searching not work, and only some very direct 'load /path/file.ttf'
+# will work alongside some old-school ttf file path searching. This
+# is very likely not what you want, so highly reconsider turning
+# fontconfig off. Having it off will lead to visual problems like
+# missing text in many UI areas etc.
+ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
+LIBEFL_CONF_OPTS += --enable-fontconfig
+LIBEFL_DEPENDENCIES += fontconfig
+else
+LIBEFL_CONF_OPTS += --disable-fontconfig
+endif
+
+# Fribidi is used for handling right-to-left text (like Arabic,
+# Hebrew, Farsi, Persian etc.) and is very likely not a feature
+# you want to disable unless you know for absolute certain you
+# will never encounter and have to display such scripts. Also
+# note that we don't test with fribidi disabled so you may also
+# trigger code paths with bugs that are never normally used.
+ifeq ($(BR2_PACKAGE_LIBFRIBIDI),y)
+LIBEFL_CONF_OPTS += --enable-fribidi
+LIBEFL_DEPENDENCIES += libfribidi
+else
+LIBEFL_CONF_OPTS += --disable-fribidi
+endif
+
+# If Gstreamer 1.x support is disabled, it will heavily limit your media
+# support options and render some functionality as useless, leading to
+# visible application bugs.
+ifeq ($(BR2_PACKAGE_GSTREAMER1)$(BR2_PACKAGE_GST1_PLUGINS_BASE),yy)
+LIBEFL_CONF_OPTS += --enable-gstreamer1
+LIBEFL_DEPENDENCIES += gstreamer1 gst1-plugins-base
+else
+LIBEFL_CONF_OPTS += --disable-gstreamer1
+endif
+
+# You have chosen to disable physics support. This disables lots of
+# core functionality and is effectively never tested. You are going
+# to find features that suddenly don't work and as a result cause
+# a series of breakages. This is simply not tested so you are on
+# your own in terms of ensuring everything works if you do this
+ifeq ($(BR2_PACKAGE_BULLET),y)
+LIBEFL_CONF_OPTS += --enable-physics
+LIBEFL_DEPENDENCIES += bullet
+else
+LIBEFL_CONF_OPTS += --disable-physics
+endif
+
+# You disabled audio support in Ecore. This is not tested and may
+# Create bugs for you due to it creating untested code paths.
+# Reconsider disabling audio.
+ifeq ($(BR2_PACKAGE_LIBSNDFILE),y)
+LIBEFL_CONF_OPTS += --enable-audio
+LIBEFL_DEPENDENCIES += libsndfile
+else
+LIBEFL_CONF_OPTS += --disable-audio
+endif
+
+# The only audio output method supported by Ecore right now is via
+# Pulseaudio. You have disabled that and likely have broken a whole
+# bunch of things in the process. Reconsider your configure options.
+# NOTE: multisense support is automatically enabled with pulseaudio.
+ifeq ($(BR2_PACKAGE_PULSEAUDIO),y)

package/efl/libefl/libefl.mk LIBEFL_SITE = http://download.enlightenment.org/rel/libs/efl · line 110

Quoted 5 lines

package/efl/libefl/libefl.mk +5 -0

+LIBEFL_CONF_OPTS += --enable-pulseaudio
+LIBEFL_DEPENDENCIES += pulseaudio
+else
+LIBEFL_CONF_OPTS += --disable-pulseaudio
+endif

As I previously suggested, move all the above comments to the Config.in file, to help user make an enlighted (muahahaha!) decision.

package/efl/libefl/libefl.mk LIBEFL_SITE = http://download.enlightenment.org/rel/libs/efl · line 113

Quoted 3 lines

package/efl/libefl/libefl.mk +2 -0

+# There is no alsa support yet in Ecore_Audio.
+# configure will disable alsa support even if alsa-lib is selected.

So what? Having this comment stand alone is not much use. You should probably add "LIBEFL_CONF_OPTS += --disable-alsa", then, no?

package/efl/libefl/libefl.mk LIBEFL_SITE = http://download.enlightenment.org/rel/libs/efl · line 124

Quoted 11 lines

package/efl/libefl/libefl.mk +10 -0

+ifeq ($(BR2_PACKAGE_TSLIB),y)
+LIBEFL_DEPENDENCIES += tslib
+LIBEFL_CONF_OPTS += --enable-tslib
+else
+LIBEFL_CONF_OPTS += --disable-tslib
+endif
+
+ifeq ($(BR2_PACKAGE_LIBGLIB2),y)
+LIBEFL_DEPENDENCIES += libglib2
+# we can also say "always"

Useless comment, drop it.

package/efl/libefl/libefl.mk LIBEFL_SITE = http://download.enlightenment.org/rel/libs/efl · line 135

Quoted 12 lines

package/efl/libefl/libefl.mk +11 -0

+LIBEFL_CONF_OPTS += --with-glib=yes
+else
+LIBEFL_CONF_OPTS += --with-glib=no
+endif
+
+# Prefer openssl (the default) over gnutls.
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LIBEFL_DEPENDENCIES += openssl
+LIBEFL_CONF_OPTS += --with-crypto=openssl
+else
+ifeq ($(BR2_PACKAGE_GNUTLS)$(BR2_PACKAGE_LIBGCRYPT),yy)

use the else ifeq construct rather than nested if-blocks, ...

package/efl/libefl/libefl.mk LIBEFL_SITE = http://download.enlightenment.org/rel/libs/efl · line 142

Quoted 7 lines

package/efl/libefl/libefl.mk +7 -0

+LIBEFL_DEPENDENCIES += gnutls libgcrypt
+LIBEFL_CONF_OPTS += --with-crypto=gnutls \
+	--with-libgcrypt-prefix=$(STAGING_DIR)/usr
+else
+LIBEFL_CONF_OPTS += --with-crypto=none
+endif
+endif # BR2_PACKAGE_OPENSSL

.. you'll gain one endif here.

package/efl/libefl/libefl.mk LIBEFL_SITE = http://download.enlightenment.org/rel/libs/efl · line 154

Quoted 12 lines

package/efl/libefl/libefl.mk +11 -0

+# image loader: handle only loaders that requires dependencies.
+# All other loaders are builded by default statically.
+ifeq ($(BR2_PACKAGE_LIBEFL_PNG),y)
+LIBEFL_CONF_OPTS += --enable-image-loader-png=yes
+LIBEFL_DEPENDENCIES += libpng
+else
+LIBEFL_CONF_OPTS += --enable-image-loader-png=no
+endif
+
+ifeq ($(BR2_PACKAGE_LIBEFL_JPEG),y)
+LIBEFL_CONF_OPTS += --enable-image-loader-jpeg=yes

Maybe add a comment that the 'jpeg' dependency is already covered as a global dependency of libefl. Otherwise, it is strange to not see it here (I only remembered it because I previously checked if the dependencies of jpeg were prorerly propagated).

Regards,
Yann E. MORIN.

Quoted 30 lines

package/efl/libefl/libefl.mk +20 -0

+else
+LIBEFL_CONF_OPTS += --enable-image-loader-jpeg=no
+endif
+
+ifeq ($(BR2_PACKAGE_LIBEFL_GIF),y)
+LIBEFL_CONF_OPTS += --enable-image-loader-gif=yes
+LIBEFL_DEPENDENCIES += giflib
+else
+LIBEFL_CONF_OPTS += --enable-image-loader-gif=no
+endif
+
+ifeq ($(BR2_PACKAGE_LIBEFL_TIFF),y)
+LIBEFL_CONF_OPTS += --enable-image-loader-tiff=yes
+LIBEFL_DEPENDENCIES += tiff
+else
+LIBEFL_CONF_OPTS += --enable-image-loader-tiff=no
+endif
+
+$(eval $(autotools-package))
+
 ################################################################################
 #
 # host-libefl

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

...the comments line start to be very long, should I do something like:

comment "EFL needs Lua, udev /dev management and a toolchain w/ C++, dynamic library, threads, wchar"

	depends on !BR2_PACKAGE_LUA || !BR2_PACKAGE_HAS_UDEV || !BR2_INSTALL_LIBSTDCPP \
		|| BR2_STATIC_LIBS  || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
	depends on BR2_USE_MMU

Workaround a build issue with eldbus-codegen:

  CCLD     bin/eldbus/eldbus-codegen
  CXXLD    bin/eolian_cxx/eolian_cxx
  CCLD     lib/ecore_x/ecore_x_vsync
  CCLD     lib/evas/common/libevas_op_blend_sse3.la
  CCLD     lib/evas/common/libevas_convert_rgb_32.la
  CCLD     lib/ecore_ipc/libecore_ipc.la

[...]/i686-ctng-linux-gnu/bin/ld: warning: libefl.so.1, needed by lib/ecore/.libs/libecore.so, not found (try using -rpath or -rpath-link) lib/ecore/.libs/libecore.so: undefined reference to `efl_control_suspend_set'
lib/ecore/.libs/libecore.so: undefined reference to `efl_control_interface_get'
collect2: error: ld returned 1 exit status
Makefile:19135: recipe for target 'bin/eldbus/eldbus-codegen' failed
make[6]: *** [bin/eldbus/eldbus-codegen] Error 1

A dependency on libefl seems to be missing for eldbus but by regenerating eldbus-codegen build correctly.

Reported upstream: https://phab.enlightenment.org/T2718

Also, gettextize is needed since *.po files were generated with an "old" gettext version (0.18):

Making all in po
*** error: gettext infrastructure mismatch: using a Makefile.in.in from gettext version 0.18 but the autoconf macros are from gettext version 0.19 Makefile:149: recipe for target 'check-macro-version' failed

Signed-off-by Romain Naour <[email protected]>

---
v4: rename to libefl
v3: fix gettextize

---
 package/efl/libefl/libefl.mk | 5 +++++
 1 file changed, 5 insertions(+)

package/efl/libefl/libefl.mk +5 -0

index 781f397..609ae6a 100644
@@ -15,6 +15,11 @@ LIBEFL_INSTALL_STAGING = YES
 
 LIBEFL_DEPENDENCIES = host-pkgconf host-libefl dbus freetype jpeg lua udev zlib
 
+# regenerate the configure script:
+# https://phab.enlightenment.org/T2718
+LIBEFL_AUTORECONF = YES
+LIBEFL_GETTEXTIZE = YES
+
 # Configure options:
 # --disable-cxx-bindings: disable C++11 bindings.
 # --enable-lua-old: disable Elua and remove luajit dependency.

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Harfbuzz allow to enable complex text shaping and layouting support in efl libraries.

Also, it one of the "highly recommended" dependecies according to the README but disabling it doesn't need the --enable-i-really-know-what-i-am-doing... option. That's why harfbuzz is not added to BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG.

Signed-off-by Romain Naour <[email protected]>

---
v4: rename to libefl
improve commit log.

---
 package/efl/libefl/libefl.mk | 7 +++++++
 1 file changed, 7 insertions(+)

package/efl/libefl/libefl.mk +7 -0

index 609ae6a..2e42bb7 100644
@@ -117,6 +117,13 @@ endif
 # There is no alsa support yet in Ecore_Audio.
 # configure will disable alsa support even if alsa-lib is selected.
 
+ifeq ($(BR2_PACKAGE_HARFBUZZ),y)
+LIBEFL_DEPENDENCIES += harfbuzz
+LIBEFL_CONF_OPTS += --enable-harfbuzz=yes
+else
+LIBEFL_CONF_OPTS += --enable-harfbuzz=no
+endif
+
 ifeq ($(BR2_PACKAGE_TSLIB),y)
 LIBEFL_DEPENDENCIES += tslib
 LIBEFL_CONF_OPTS += --enable-tslib

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

See:
https://www.enlightenment.org/about-wayland

Signed-off-by Romain Naour <[email protected]>

---
v4: rename to libefl

---
 package/efl/libefl/Config.in | 1 +
 package/efl/libefl/libefl.mk | 7 +++++++
 2 files changed, 8 insertions(+)

package/efl/libefl/Config.in +1 -0

index 2b758f0..07aee42 100644
@@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBEFL
 	select BR2_PACKAGE_FREETYPE
 	select BR2_PACKAGE_JPEG # Emile needs libjpeg
 	select BR2_PACKAGE_LUA # Evas lua 5.1 or 5.2
+	select BR2_PACKAGE_LIBXKBCOMMON if BR2_PACKAGE_WAYLAND
 	help
 	  Enlightenment Foundation Libraries
 

package/efl/libefl/libefl.mk +7 -0

index 2e42bb7..c697e41 100644
@@ -153,6 +153,13 @@ LIBEFL_CONF_OPTS += --with-crypto=none
 endif
 endif # BR2_PACKAGE_OPENSSL
 
+ifeq ($(BR2_PACKAGE_WAYLAND),y)
+LIBEFL_DEPENDENCIES += wayland libxkbcommon
+LIBEFL_CONF_OPTS += --enable-wayland=yes
+else
+LIBEFL_CONF_OPTS += --enable-wayland=no
+endif
+
 # image loader: handle only loaders that requires dependencies.
 # All other loaders are builded by default statically.
 ifeq ($(BR2_PACKAGE_LIBEFL_PNG),y)

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Curl is listed as an dependency in the README:
https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n453

Signed-off-by Romain Naour <[email protected]>

---
v4: rename to libefl

---
 package/efl/libefl/Config.in | 1 +
 package/efl/libefl/libefl.mk | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

package/efl/libefl/Config.in +0 -0

index 07aee42..29aef05 100644

package/efl/libefl/Config.in +0 -0

 	select BR2_PACKAGE_LUA # Evas lua 5.1 or 5.2
 	select BR2_PACKAGE_LIBXKBCOMMON if BR2_PACKAGE_WAYLAND
 	help

package/efl/libefl/libefl.mk +0 -0

index c697e41..b26f848 100644

package/efl/libefl/libefl.mk +0 -0

 # regenerate the configure script:
 # https://phab.enlightenment.org/T2718

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:

Quoted 16 lines

Curl is listed as an dependency in the README:
https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n453

Signed-off-by Romain Naour <[email protected]>

---
v4: rename to libefl

---
 package/efl/libefl/Config.in | 1 +
 package/efl/libefl/libefl.mk | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

package/efl/libefl/Config.in +0 -0

index 07aee42..29aef05 100644

package/efl/libefl/Config.in config BR2_PACKAGE_LIBEFL · line 12

Quoted 4 lines

package/efl/libefl/Config.in +1 -0

@@ -9,6 +9,7 @@ config BR2_PACKAGE_LIBEFL
 	select BR2_PACKAGE_DBUS
 	select BR2_PACKAGE_FREETYPE
 	select BR2_PACKAGE_JPEG # Emile needs libjpeg
+	select BR2_PACKAGE_LIBCURL # eina_module, runtime dependency

If it is a runtime dependency, ...

Quoted 8 lines

package/efl/libefl/Config.in +0 -0

 	select BR2_PACKAGE_LUA # Evas lua 5.1 or 5.2
 	select BR2_PACKAGE_LIBXKBCOMMON if BR2_PACKAGE_WAYLAND
 	help

package/efl/libefl/libefl.mk +0 -0

index c697e41..b26f848 100644

package/efl/libefl/libefl.mk LIBEFL_LICENSE_FILES = COPYING · line 17

Quoted 6 lines

package/efl/libefl/libefl.mk +2 -1

@@ -13,7 +13,8 @@ LIBEFL_LICENSE_FILES = COPYING
 
 LIBEFL_INSTALL_STAGING = YES
 
-LIBEFL_DEPENDENCIES = host-pkgconf host-libefl dbus freetype jpeg lua udev zlib
+LIBEFL_DEPENDENCIES = host-pkgconf host-libefl dbus freetype jpeg libcurl lua \
+	udev zlib

... then why do you add it to build dependencies?

Moreover, it looks more like a build dependency, given the number of calls to the libcurl functions throughout the libelf code. Can you confirm whether this is only a runtime dependency or a build dependency?

Regards,
Yann E. MORIN.

Quoted 9 lines

package/efl/libefl/libefl.mk +0 -0

 # regenerate the configure script:
 # https://phab.enlightenment.org/T2718

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

util-linux libblkid is listed as an dependency in the README:
https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n478

Signed-off-by Romain Naour <[email protected]>

---
v4: rename to libefl

---
 package/efl/libefl/Config.in | 1 +
 package/efl/libefl/libefl.mk | 5 +++++
 2 files changed, 6 insertions(+)

package/efl/libefl/Config.in +1 -0

index 29aef05..5c65744 100644
@@ -29,6 +29,7 @@ config BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
 	select BR2_PACKAGE_LIBSNDFILE
 	select BR2_PACKAGE_PULSEAUDIO
 	select BR2_PACKAGE_UTIL_LINUX
+	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
 	select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
 	default y
 	help

package/efl/libefl/libefl.mk +0 -0

index b26f848..c7ecf51 100644

package/efl/libefl/libefl.mk +1 -0

+
 # If fontconfig is disabled, this is going to make general font
 # searching not work, and only some very direct 'load /path/file.ttf'
 # will work alongside some old-school ttf file path searching. This

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:

Quoted 28 lines

util-linux libblkid is listed as an dependency in the README:
https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n478

Signed-off-by Romain Naour <[email protected]>

---
v4: rename to libefl

---
 package/efl/libefl/Config.in | 1 +
 package/efl/libefl/libefl.mk | 5 +++++
 2 files changed, 6 insertions(+)

package/efl/libefl/Config.in +1 -0

index 29aef05..5c65744 100644
@@ -29,6 +29,7 @@ config BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
 	select BR2_PACKAGE_LIBSNDFILE
 	select BR2_PACKAGE_PULSEAUDIO
 	select BR2_PACKAGE_UTIL_LINUX
+	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
 	select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
 	default y
 	help

package/efl/libefl/libefl.mk +0 -0

index b26f848..c7ecf51 100644

package/efl/libefl/libefl.mk else · line 49

Quoted 4 lines

package/efl/libefl/libefl.mk +1 -0

@@ -46,6 +46,11 @@ else
 LIBEFL_CONF_OPTS += --disable-libmount
 endif
 
+# libblkid is part of required tools, see EFL's README.

If it is indeed a required dependency, fold this in the patch adding libefl.

package/efl/libefl/libefl.mk else · line 52

Quoted 3 lines

package/efl/libefl/libefl.mk +3 -0

+ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBBLKID),y)
+LIBEFL_DEPENDENCIES += util-linux
+endif

Besides, no need to make it conditional: it will always be 'y' since you select it.

Regards,
Yann E. MORIN.

Quoted 11 lines

package/efl/libefl/libefl.mk +1 -0

+
 # If fontconfig is disabled, this is going to make general font
 # searching not work, and only some very direct 'load /path/file.ttf'
 # will work alongside some old-school ttf file path searching. This

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

WebP is a new image format that provides lossless and lossy compression for images on the web. So enabling webp support in efl libraries allow to loads images using WebP.

Also, it one of the "highly recommended" dependecies [1] according to the README but disabling it doesn't need the --enable-i-really-know-what-i-am-doing... option. That's why BR2_PACKAGE_LIBEFL_WEBP is not added to BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG.

[1] https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n486

Signed-off-by Romain Naour <[email protected]>

---
v4: rename to libefl
improve commit log

---
 package/efl/libefl/Config.in | 5 +++++
 package/efl/libefl/libefl.mk | 7 +++++++
 2 files changed, 12 insertions(+)

package/efl/libefl/Config.in +0 -0

index 5c65744..c72ea7e 100644

package/efl/libefl/Config.in +3 -0

+	help
+	  This enables the loader code that loads images using WebP.
+
 endif # BR2_PACKAGE_LIBEFL

package/efl/libefl/libefl.mk +7 -0

index c7ecf51..9633630 100644
@@ -195,6 +195,13 @@ else
 LIBEFL_CONF_OPTS += --enable-image-loader-tiff=no
 endif
 
+ifeq ($(BR2_PACKAGE_LIBEFL_WEBP),y)
+LIBEFL_CONF_OPTS += --enable-image-loader-webp=yes
+LIBEFL_DEPENDENCIES += webp
+else
+LIBEFL_CONF_OPTS += --enable-image-loader-webp=no
+endif
+
 $(eval $(autotools-package))
 
 ################################################################################

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Add an config option to enable frame buffer support in the efl libraries.

From the README [1]:
This requires linux frame-buffer support, headers etc. This supports basic frame-buffers like /dev/fb as well as input via /dev/input for keyboards and mice in a basic way.

[1] https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n521

Signed-off-by Romain Naour <[email protected]>

---
v4: rename to libefl
improve commit log

---
 package/efl/libefl/Config.in | 5 +++++
 package/efl/libefl/libefl.mk | 6 ++++++
 2 files changed, 11 insertions(+)

package/efl/libefl/Config.in +5 -0

index c72ea7e..e25911f 100644
@@ -37,6 +37,11 @@ config BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
 	  otherwise we need to add a very long and obscure option
 	  to start the build.
 
+comment "libecore video support"
+
+config BR2_PACKAGE_LIBEFL_FB
+	bool "libecore framebuffer support"
+
 comment "libevas loaders"
 
 config BR2_PACKAGE_LIBEFL_PNG

package/efl/libefl/libefl.mk +6 -0

index 9633630..3a4aab1 100644
@@ -166,6 +166,12 @@ else
 LIBEFL_CONF_OPTS += --enable-wayland=no
 endif
 
+ifeq ($(BR2_PACKAGE_LIBEFL_FB),y)
+LIBEFL_CONF_OPTS += --enable-fb=yes
+else
+LIBEFL_CONF_OPTS += --enable-fb=no
+endif
+
 # image loader: handle only loaders that requires dependencies.
 # All other loaders are builded by default statically.
 ifeq ($(BR2_PACKAGE_LIBEFL_PNG),y)

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:

Quoted 8 lines

Add an config option to enable frame buffer support in the efl libraries.

From the README [1]:
This requires linux frame-buffer support, headers etc. This supports basic frame-buffers like /dev/fb as well as input via /dev/input for keyboards and mice in a basic way.

Quoted 3 lines

[1] https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n521

Signed-off-by Romain Naour <[email protected]>

Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 48 lines

---
v4: rename to libefl
improve commit log

---
 package/efl/libefl/Config.in | 5 +++++
 package/efl/libefl/libefl.mk | 6 ++++++
 2 files changed, 11 insertions(+)

package/efl/libefl/Config.in +5 -0

index c72ea7e..e25911f 100644
@@ -37,6 +37,11 @@ config BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
 	  otherwise we need to add a very long and obscure option
 	  to start the build.
 
+comment "libecore video support"
+
+config BR2_PACKAGE_LIBEFL_FB
+	bool "libecore framebuffer support"
+
 comment "libevas loaders"
 
 config BR2_PACKAGE_LIBEFL_PNG

package/efl/libefl/libefl.mk +6 -0

index 9633630..3a4aab1 100644
@@ -166,6 +166,12 @@ else
 LIBEFL_CONF_OPTS += --enable-wayland=no
 endif
 
+ifeq ($(BR2_PACKAGE_LIBEFL_FB),y)
+LIBEFL_CONF_OPTS += --enable-fb=yes
+else
+LIBEFL_CONF_OPTS += --enable-fb=no
+endif
+
 # image loader: handle only loaders that requires dependencies.
 # All other loaders are builded by default statically.
 ifeq ($(BR2_PACKAGE_LIBEFL_PNG),y)

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 10 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Add an config option to enable frame buffer support in the efl libraries.

From the README [1]:
This requires linux frame-buffer support, headers etc. This supports basic frame-buffers like /dev/fb as well as input via /dev/input for keyboards and mice in a basic way.

[1] https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n521

Signed-off-by Romain Naour <[email protected]>

---
v4: rename to libefl
improve commit log

---
 package/efl/libefl/Config.in | 5 +++++
 package/efl/libefl/libefl.mk | 6 ++++++
 2 files changed, 11 insertions(+)

package/efl/libefl/Config.in +5 -0

index c72ea7e..e25911f 100644
@@ -37,6 +37,11 @@ config BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
 	  otherwise we need to add a very long and obscure option
 	  to start the build.
 
+comment "libecore video support"
+
+config BR2_PACKAGE_LIBEFL_FB
+	bool "libecore framebuffer support"
+
 comment "libevas loaders"
 
 config BR2_PACKAGE_LIBEFL_PNG

package/efl/libefl/libefl.mk +6 -0

index 9633630..3a4aab1 100644
@@ -166,6 +166,12 @@ else
 LIBEFL_CONF_OPTS += --enable-wayland=no
 endif
 
+ifeq ($(BR2_PACKAGE_LIBEFL_FB),y)
+LIBEFL_CONF_OPTS += --enable-fb=yes
+else
+LIBEFL_CONF_OPTS += --enable-fb=no
+endif
+
 # image loader: handle only loaders that requires dependencies.
 # All other loaders are builded by default statically.
 ifeq ($(BR2_PACKAGE_LIBEFL_PNG),y)

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

From: Vicente Bergas <[email protected]>

From [1]:
When running terminology, a message appears in eina_module_load with:
could not dlopen("/usr/lib/ecore_evas/engines/fb/v-1.15/module.so", Error relocating /usr/lib/ecore_evas/engines/fb/v-1.15/module.so:
ecore_fb_ts_shutdown: symbol not found): RTLD_NOW
It seems like the EAPI macro has no effect...

A patch from Ross Vandegrift has been posted on enlightenment mailing list [2], but it's not yet an upstream patch.

[1] http://sourceforge.net/p/enlightenment/mailman/message/34493376
[2] http://sourceforge.net/p/enlightenment/mailman/message/34492801

Signed-off-by Vicente Bergas <[email protected]>

[Romain: use a git formated patch and add a commit log]

Signed-off-by Romain Naour <[email protected]>

---
v4: move the patch to libefl
improve the commit log
v3: new patch

---
 ...ecore_fb_private.h-define-EAPI-before-use.patch | 64 ++++++++++++++++++++++
 1 file changed, 64 insertions(+)
 create mode 100644 package/efl/libefl/0001-ecore_fb_private.h-define-EAPI-before-use.patch

package/efl/libefl/0001-ecore_fb_private.h-define-EAPI-before-use.patch new file +64 -0

new file mode 100644
index 0000000..81d14f9
@@ -0,0 +1,64 @@
+From 2fb4fdf641e67e49b87a3524038a694c8dd0ba4e Mon Sep 17 00:00:00 2001
+From: Vicente Bergas <[email protected]>
+Date: Fri, 9 Oct 2015 23:35:20 +0200
+Subject: [PATCH] ecore_fb_private.h: define EAPI before use
+
+From [1]:
+When running terminology, a message appears in eina_module_load with:
+could not dlopen("/usr/lib/ecore_evas/engines/fb/v-1.15/module.so",
+Error relocating /usr/lib/ecore_evas/engines/fb/v-1.15/module.so:
+ecore_fb_ts_shutdown: symbol not found): RTLD_NOW
+It seems like the EAPI macro has no effect...
+
+A patch from Ross Vandegrift has been posted on enlightenment mailing
+list [2], but it's not yet an upstream patch.
+
+[1] http://sourceforge.net/p/enlightenment/mailman/message/34493376
+[2] http://sourceforge.net/p/enlightenment/mailman/message/34492801
+
+Signed-off-by: Vicente Bergas <[email protected]>
+[Romain:
+  - Add a commit log
+  - Add a link to the enlightenment mailing list
+  - Add Vicente's SoB line]
+Signed-off-by: Romain Naour <[email protected]>
+---
+ src/lib/ecore_fb/ecore_fb_private.h | 17 +++++++++++++++++
+ 1 file changed, 17 insertions(+)
+
+diff --git a/src/lib/ecore_fb/ecore_fb_private.h b/src/lib/ecore_fb/ecore_fb_private.h
+index f7dc0c6..f54c8d2 100644
+--- a/src/lib/ecore_fb/ecore_fb_private.h
++++ b/src/lib/ecore_fb/ecore_fb_private.h
+@@ -33,6 +33,20 @@
+ 
+ #include <Ecore_Fb.h>
+ 
++#ifdef EAPI
++# undef EAPI
++#endif
++
++#ifdef __GNUC__
++# if __GNUC__ >= 4
++#  define EAPI __attribute__ ((visibility("default")))
++# else
++#  define EAPI
++# endif
++#else
++# define EAPI
++#endif
++
+ /* ecore_fb_li.c */
+ struct _Ecore_Fb_Input_Device
+ {
+@@ -92,4 +106,7 @@ void ecore_fb_vt_shutdown(void);
+ #define TS_GET_CAL 0x8014660a
+ #endif
+   
++#undef EAPI
++#define EAPI
++
+ #endif
+-- 
+2.4.3
+

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Like for webp format, add an option to enable the JPEG 2000 codec support in the efl libraries.

Signed-off-by Romain Naour <[email protected]>

---
v4: rename to libefl
improve commit log

---
 package/efl/libefl/Config.in | 7 +++++++
 package/efl/libefl/libefl.mk | 7 +++++++
 2 files changed, 14 insertions(+)

package/efl/libefl/Config.in +7 -0

index e25911f..53adea2 100644
@@ -51,6 +51,13 @@ config BR2_PACKAGE_LIBEFL_PNG
 	  This enables the loader code that loads png files using
 	  libpng.
 
+config BR2_PACKAGE_LIBEFL_JP2K
+	bool "libevas jp2k loader"
+	select BR2_PACKAGE_OPENJPEG
+	help
+	  This enables the loader code that loads jp2k files using
+	  openjpeg.
+
 config BR2_PACKAGE_LIBEFL_JPEG
 	bool "libevas jpeg loader"
 	help

package/efl/libefl/libefl.mk +7 -0

index 3a4aab1..e53470d 100644
@@ -201,6 +201,13 @@ else
 LIBEFL_CONF_OPTS += --enable-image-loader-tiff=no
 endif
 
+ifeq ($(BR2_PACKAGE_LIBEFL_JP2K),y)
+LIBEFL_CONF_OPTS += --enable-image-loader-jp2k=yes
+LIBEFL_DEPENDENCIES += openjpeg
+else
+LIBEFL_CONF_OPTS += --enable-image-loader-jp2k=no
+endif
+
 ifeq ($(BR2_PACKAGE_LIBEFL_WEBP),y)
 LIBEFL_CONF_OPTS += --enable-image-loader-webp=yes
 LIBEFL_DEPENDENCIES += webp

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:

Quoted 2 lines

Like for webp format, add an option to enable the JPEG 2000 codec support in the efl libraries.

Suddenly, I wonder why you added a bunch of image loaders in the first patch adding libelf, but you add a few more such loaders in separate patches.

Can't you do either:
- introduce all of them as separate patches, or
- introduce all of them in the first patch adding libefl?

Or is there an underlying good reason to do as you did?

Regards,
Yann E. MORIN.

Quoted 52 lines

Signed-off-by Romain Naour <[email protected]>

---
v4: rename to libefl
improve commit log

---
 package/efl/libefl/Config.in | 7 +++++++
 package/efl/libefl/libefl.mk | 7 +++++++
 2 files changed, 14 insertions(+)

package/efl/libefl/Config.in +7 -0

index e25911f..53adea2 100644
@@ -51,6 +51,13 @@ config BR2_PACKAGE_LIBEFL_PNG
 	  This enables the loader code that loads png files using
 	  libpng.
 
+config BR2_PACKAGE_LIBEFL_JP2K
+	bool "libevas jp2k loader"
+	select BR2_PACKAGE_OPENJPEG
+	help
+	  This enables the loader code that loads jp2k files using
+	  openjpeg.
+
 config BR2_PACKAGE_LIBEFL_JPEG
 	bool "libevas jpeg loader"
 	help

package/efl/libefl/libefl.mk +7 -0

index 3a4aab1..e53470d 100644
@@ -201,6 +201,13 @@ else
 LIBEFL_CONF_OPTS += --enable-image-loader-tiff=no
 endif
 
+ifeq ($(BR2_PACKAGE_LIBEFL_JP2K),y)
+LIBEFL_CONF_OPTS += --enable-image-loader-jp2k=yes
+LIBEFL_DEPENDENCIES += openjpeg
+else
+LIBEFL_CONF_OPTS += --enable-image-loader-jp2k=no
+endif
+
 ifeq ($(BR2_PACKAGE_LIBEFL_WEBP),y)
 LIBEFL_CONF_OPTS += --enable-image-loader-webp=yes
 LIBEFL_DEPENDENCIES += webp

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Like for webp format, add an option to enable the JPEG 2000 codec support in the efl libraries.

Signed-off-by Romain Naour <[email protected]>

---
v4: rename to libefl
improve commit log

---
 package/efl/libefl/Config.in | 7 +++++++
 package/efl/libefl/libefl.mk | 7 +++++++
 2 files changed, 14 insertions(+)

package/efl/libefl/Config.in +7 -0

index e25911f..53adea2 100644
@@ -51,6 +51,13 @@ config BR2_PACKAGE_LIBEFL_PNG
 	  This enables the loader code that loads png files using
 	  libpng.
 
+config BR2_PACKAGE_LIBEFL_JP2K
+	bool "libevas jp2k loader"
+	select BR2_PACKAGE_OPENJPEG
+	help
+	  This enables the loader code that loads jp2k files using
+	  openjpeg.
+
 config BR2_PACKAGE_LIBEFL_JPEG
 	bool "libevas jpeg loader"
 	help

package/efl/libefl/libefl.mk +7 -0

index 3a4aab1..e53470d 100644
@@ -201,6 +201,13 @@ else
 LIBEFL_CONF_OPTS += --enable-image-loader-tiff=no
 endif
 
+ifeq ($(BR2_PACKAGE_LIBEFL_JP2K),y)
+LIBEFL_CONF_OPTS += --enable-image-loader-jp2k=yes
+LIBEFL_DEPENDENCIES += openjpeg
+else
+LIBEFL_CONF_OPTS += --enable-image-loader-jp2k=no
+endif
+
 ifeq ($(BR2_PACKAGE_LIBEFL_WEBP),y)
 LIBEFL_CONF_OPTS += --enable-image-loader-webp=yes
 LIBEFL_DEPENDENCIES += webp

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Add an option to enable X11 support in libecore without graphic acceleration. libecore can use xlib or xcb support but the latter in not recommended by efl developpers.

Also, set x-includes and x-libraries configure option for cross-compiling. Previous efl versions had cross-compilation issue (poisoned paths) if these options are not passed to configure script.

In order to remove the dependency on libXp wich is no longer bundled in recent X11 release [1], backport an upstream patch [2] to remove xprint usage.

[1] http://www.x.org/wiki/Releases/ModuleVersions
[2] https://git.enlightenment.org/core/efl.git/commit/?h=efl-1.15&id=434572355c7e929b84210b2f795634d38f13c913

Signed-off-by Romain Naour <[email protected]>

package/efl/libefl/Config.in +30 -0

index 53adea2..8356fa1 100644
@@ -42,6 +42,47 @@ comment "libecore video support"
 config BR2_PACKAGE_LIBEFL_FB
 	bool "libecore framebuffer support"
 
+config BR2_PACKAGE_LIBEFL_X
+	bool "libecore X support"
+	depends on BR2_PACKAGE_XORG7
+	select BR2_PACKAGE_XLIB_LIBX11
+	select BR2_PACKAGE_XLIB_LIBXEXT
+
+if BR2_PACKAGE_LIBEFL_X
+
+choice
+	prompt "select libecore XLIB/XCB support"
+
+config BR2_PACKAGE_LIBEFL_X_XLIB
+	bool "libecore XLIB support"
+	select BR2_PACKAGE_XLIB_LIBXCOMPOSITE
+	select BR2_PACKAGE_XLIB_LIBXCURSOR
+	select BR2_PACKAGE_XLIB_LIBXDAMAGE
+	select BR2_PACKAGE_XLIB_LIBXINERAMA
+	select BR2_PACKAGE_XLIB_LIBXP
+	select BR2_PACKAGE_XLIB_LIBXRANDR
+	select BR2_PACKAGE_XLIB_LIBXRENDER
+	select BR2_PACKAGE_XLIB_LIBXSCRNSAVER
+	select BR2_PACKAGE_XLIB_LIBXTST
+	select BR2_PACKAGE_XPROTO_GLPROTO
+
+config BR2_PACKAGE_LIBEFL_X_XCB
+	bool "libecore XCB support"
+	depends on !BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
+	select BR2_PACKAGE_LIBXCB
+	select BR2_PACKAGE_XCB_UTIL_IMAGE # xcb-image.pc
+	select BR2_PACKAGE_XCB_UTIL_KEYSYMS # xcb-keysyms.pc

package/efl/libefl/libefl.mk +7 -0

 # Disable untested configuration warning.
 ifeq ($(BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG),)

@@ -172,6 +173,65 @@ else
 LIBEFL_CONF_OPTS += --enable-fb=no
 endif
 
+ifeq ($(BR2_PACKAGE_LIBEFL_X),y)
+LIBEFL_CONF_OPTS += --with-x=$(STAGING_DIR) \
+	--x-includes=$(STAGING_DIR)/usr/include \
+	--x-libraries=$(STAGING_DIR)/usr/lib \
+	--with-opengl=none
+
+LIBEFL_DEPENDENCIES += \

package/efl/libefl/libefl.mk +25 -0

+	xlib_libXinerama \
+	xlib_libXrandr \
+	xlib_libXrender \
+	xlib_libXScrnSaver \
+	xlib_libXtst
+LIBEFL_CONF_OPTS += --with-x11=xlib
+endif
+
+# xcb-util-image to provide xcb-image.pc
+# xcb-util-renderutil to provide xcb-renderutil.pc
+# xcb-util-wm to provide xcb-icccm.pc
+# xcb-util-keysyms to provide xcb-keysyms.pc
+ifeq ($(BR2_PACKAGE_LIBEFL_X_XCB),y)
+LIBEFL_DEPENDENCIES += libxcb \
+	xcb-util-image \
+	xcb-util-keysyms \
+	xcb-util-renderutil \
+	xcb-util-wm
+# You have chosen to use XCB instead of Xlib. It is a myth that XCB
+# is amazingly faster than Xlib (when used sensibly). It can be
+# faster in a few corner cases on startup of an app, but it comes
+# with many downsides. One of those is more complex code inside
+# ecore_x, which is far less tested in XCB mode than Xlib. Also
+# the big catch is that OpenGL support basically requires Xlib anyway
+# so if you want OpenGL in X11, you need Xlib regardless and so you

package/efl/libefl/libefl.mk +3 -0

+LIBEFL_CONF_OPTS += --with-x11=xcb
+endif
+
 # image loader: handle only loaders that requires dependencies.
 # All other loaders are builded by default statically.
 ifeq ($(BR2_PACKAGE_LIBEFL_PNG),y)

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:

Quoted 8 lines

Add an option to enable X11 support in libecore without graphic acceleration. libecore can use xlib or xcb support but the latter in not recommended by efl developpers.

Also, set x-includes and x-libraries configure option for cross-compiling. Previous efl versions had cross-compilation issue (poisoned paths) if these options are not passed to configure script.

Quoted 8 lines

In order to remove the dependency on libXp wich is no longer bundled in recent X11 release [1], backport an upstream patch [2] to remove xprint usage.

[1] http://www.x.org/wiki/Releases/ModuleVersions
[2] https://git.enlightenment.org/core/efl.git/commit/?h=efl-1.15&id=434572355c7e929b84210b2f795634d38f13c913

Signed-off-by Romain Naour <[email protected]>

[--SNIP--]

Quoted 38 lines

package/efl/libefl/Config.in +30 -0

index 53adea2..8356fa1 100644
@@ -42,6 +42,47 @@ comment "libecore video support"
 config BR2_PACKAGE_LIBEFL_FB
 	bool "libecore framebuffer support"
 
+config BR2_PACKAGE_LIBEFL_X
+	bool "libecore X support"
+	depends on BR2_PACKAGE_XORG7
+	select BR2_PACKAGE_XLIB_LIBX11
+	select BR2_PACKAGE_XLIB_LIBXEXT
+
+if BR2_PACKAGE_LIBEFL_X
+
+choice
+	prompt "select libecore XLIB/XCB support"
+
+config BR2_PACKAGE_LIBEFL_X_XLIB
+	bool "libecore XLIB support"
+	select BR2_PACKAGE_XLIB_LIBXCOMPOSITE
+	select BR2_PACKAGE_XLIB_LIBXCURSOR
+	select BR2_PACKAGE_XLIB_LIBXDAMAGE
+	select BR2_PACKAGE_XLIB_LIBXINERAMA
+	select BR2_PACKAGE_XLIB_LIBXP
+	select BR2_PACKAGE_XLIB_LIBXRANDR
+	select BR2_PACKAGE_XLIB_LIBXRENDER
+	select BR2_PACKAGE_XLIB_LIBXSCRNSAVER
+	select BR2_PACKAGE_XLIB_LIBXTST
+	select BR2_PACKAGE_XPROTO_GLPROTO
+
+config BR2_PACKAGE_LIBEFL_X_XCB
+	bool "libecore XCB support"
+	depends on !BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
+	select BR2_PACKAGE_LIBXCB
+	select BR2_PACKAGE_XCB_UTIL_IMAGE # xcb-image.pc
+	select BR2_PACKAGE_XCB_UTIL_KEYSYMS # xcb-keysyms.pc

package/efl/libefl/Config.in comment "libecore video support" · line 84

Quoted 10 lines

package/efl/libefl/Config.in +10 -0

+	select BR2_PACKAGE_XCB_UTIL_RENDERUTIL # xcb-renderutil.pc
+	select BR2_PACKAGE_XCB_UTIL_WM # xcb-icccm.pc
+	select BR2_PACKAGE_XLIB_LIBX11
+
+comment "for libecore XCB support disable recommended configurations"
+	depends on BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
+
+endchoice
+
+endif # BR2_PACKAGE_LIBEFL_X

Make that a single choice:

choice
bool "X11 support"

config BR2_PACKAGE_LIBEFL_X_NONE
bool "none"

config BR2_PACKAGE_LIBEFL_X_XLIB
bool "xlib"

config BR2_PACKAGE_LIBEFL_X_XCB
bool "xcb"

endchoice # X11 support

Of course, with the appropriate depends/selects and comment.

package/efl/libefl/libefl.mk LIBEFL_DEPENDENCIES = host-pkgconf host-libefl dbus freetype jpeg libcurl lua \ · line 21

Quoted 13 lines

package/efl/libefl/Config.in +0 -0

 comment "libevas loaders"
 
 config BR2_PACKAGE_LIBEFL_PNG

package/efl/libefl/libefl.mk +1 -0

index e53470d..6a1a8ae 100644
@@ -18,6 +18,7 @@ LIBEFL_DEPENDENCIES = host-pkgconf host-libefl dbus freetype jpeg libcurl lua \
 
 # regenerate the configure script:
 # https://phab.enlightenment.org/T2718
+# configure.ac patched by 0002-ecore_x-Remove-XPrint-usage.patch

This comment might become misleading in the future, in case it we no longer patch configure.ac. What about:

# Regenerate the autotools:
# - to fix an issue in eldbus-codegen: https://phab.enlightenment.org/T2718
# - to remove dependency on libXp: https://phab.enlightenment.org/D3150

Quoted 3 lines

package/efl/libefl/libefl.mk +0 -0

 LIBEFL_AUTORECONF = YES
 LIBEFL_GETTEXTIZE = YES
 

package/efl/libefl/libefl.mk LIBEFL_CONF_OPTS = \ · line 34

Quoted 6 lines

package/efl/libefl/libefl.mk +1 -1

@@ -30,7 +31,7 @@ LIBEFL_CONF_OPTS = \
 	--with-eolian-gen=$(HOST_DIR)/usr/bin/eolian_gen \
 	--disable-cxx-bindings \
 	--enable-lua-old \
-	--with-x11=none
+	--enable-lua-old

Now we've got --enable-lua-old twice. ;-)

Quoted 14 lines

package/efl/libefl/libefl.mk +7 -0

 # Disable untested configuration warning.
 ifeq ($(BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG),)

@@ -172,6 +173,65 @@ else
 LIBEFL_CONF_OPTS += --enable-fb=no
 endif
 
+ifeq ($(BR2_PACKAGE_LIBEFL_X),y)
+LIBEFL_CONF_OPTS += --with-x=$(STAGING_DIR) \
+	--x-includes=$(STAGING_DIR)/usr/include \
+	--x-libraries=$(STAGING_DIR)/usr/lib \
+	--with-opengl=none
+
+LIBEFL_DEPENDENCIES += \

package/efl/libefl/libefl.mk else · line 192

Quoted 10 lines

package/efl/libefl/libefl.mk +10 -0

+	xlib_libX11 \
+	xlib_libXext
+else
+LIBEFL_CONF_OPTS += --with-x=no \
+	--with-x11=none
+endif
+
+ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB),y)
+LIBEFL_DEPENDENCIES += \
+	xlib_libX11 \

xlib_libx11 already a dependency, above.

package/efl/libefl/libefl.mk else · line 196

Quoted 4 lines

package/efl/libefl/libefl.mk +4 -0

+	xlib_libXcomposite \
+	xlib_libXcursor \
+	xlib_libXdamage \
+	xlib_libXext \

Ditto.

Quoted 25 lines

package/efl/libefl/libefl.mk +25 -0

+	xlib_libXinerama \
+	xlib_libXrandr \
+	xlib_libXrender \
+	xlib_libXScrnSaver \
+	xlib_libXtst
+LIBEFL_CONF_OPTS += --with-x11=xlib
+endif
+
+# xcb-util-image to provide xcb-image.pc
+# xcb-util-renderutil to provide xcb-renderutil.pc
+# xcb-util-wm to provide xcb-icccm.pc
+# xcb-util-keysyms to provide xcb-keysyms.pc
+ifeq ($(BR2_PACKAGE_LIBEFL_X_XCB),y)
+LIBEFL_DEPENDENCIES += libxcb \
+	xcb-util-image \
+	xcb-util-keysyms \
+	xcb-util-renderutil \
+	xcb-util-wm
+# You have chosen to use XCB instead of Xlib. It is a myth that XCB
+# is amazingly faster than Xlib (when used sensibly). It can be
+# faster in a few corner cases on startup of an app, but it comes
+# with many downsides. One of those is more complex code inside
+# ecore_x, which is far less tested in XCB mode than Xlib. Also
+# the big catch is that OpenGL support basically requires Xlib anyway
+# so if you want OpenGL in X11, you need Xlib regardless and so you

package/efl/libefl/libefl.mk else · line 231

Quoted 10 lines

package/efl/libefl/libefl.mk +10 -0

+# gain nothing really in terms of speed and no savings in memory
+# because Xlib is still linked, loaded and used, BUT instead you
+# have OpenGL drivers working with an hybrid XCB/Xlib (mostly XCB)
+# toolkit and this is basically never tested by anyone working on
+# the OpenGL drivers, so you will have bugs. Do not enable XCB
+# and use OpenGL. XCB is only useful if you wish to shave a few Kb
+# off the memory footprint of a whole system and live with less
+# tested code, and possibly unimplemented features in ecore_x. To
+# remove the XCB setup, remove the --with-x11=xcb option to
+# configure.

Why this big comment? At best, it belongs to the help text of BR2_PACKAGE_LIBEFL_X_XCB in the Config.in.

Also, I guess you're only quoting the EFL developers here, so you should state so and add a pointer to that message upstream:

https://git.enlightenment.org/core/efl.git/tree/configure.ac#n5002

But if it were purely on me, I would just drop it.

Regards,
Yann E. MORIN.

Quoted 13 lines

package/efl/libefl/libefl.mk +3 -0

+LIBEFL_CONF_OPTS += --with-x11=xcb
+endif
+
 # image loader: handle only loaders that requires dependencies.
 # All other loaders are builded by default statically.
 ifeq ($(BR2_PACKAGE_LIBEFL_PNG),y)

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Le 25/10/2015 16:01, Yann E. MORIN a ?crit :

Quoted 17 lines

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:

Quoted 16 lines

Add an option to enable X11 support in libecore without graphic acceleration. libecore can use xlib or xcb support but the latter in not recommended by efl developpers.

Also, set x-includes and x-libraries configure option for cross-compiling. Previous efl versions had cross-compilation issue (poisoned paths) if these options are not passed to configure script.

In order to remove the dependency on libXp wich is no longer bundled in recent X11 release [1], backport an upstream patch [2] to remove xprint usage.

[1] http://www.x.org/wiki/Releases/ModuleVersions
[2] https://git.enlightenment.org/core/efl.git/commit/?h=efl-1.15&id=434572355c7e929b84210b2f795634d38f13c913

Signed-off-by Romain Naour <[email protected]>

Quoted 32 lines

Quoted 13 lines

package/efl/libefl/libefl.mk +13 -0

+ifeq ($(BR2_PACKAGE_LIBEFL_X_XCB),y)
+LIBEFL_DEPENDENCIES += libxcb \
+	xcb-util-image \
+	xcb-util-keysyms \
+	xcb-util-renderutil \
+	xcb-util-wm
+# You have chosen to use XCB instead of Xlib. It is a myth that XCB
+# is amazingly faster than Xlib (when used sensibly). It can be
+# faster in a few corner cases on startup of an app, but it comes
+# with many downsides. One of those is more complex code inside
+# ecore_x, which is far less tested in XCB mode than Xlib. Also
+# the big catch is that OpenGL support basically requires Xlib anyway
+# so if you want OpenGL in X11, you need Xlib regardless and so you

package/efl/libefl/libefl.mk else · line 231

Quoted 10 lines

package/efl/libefl/libefl.mk +10 -0

+# gain nothing really in terms of speed and no savings in memory
+# because Xlib is still linked, loaded and used, BUT instead you
+# have OpenGL drivers working with an hybrid XCB/Xlib (mostly XCB)
+# toolkit and this is basically never tested by anyone working on
+# the OpenGL drivers, so you will have bugs. Do not enable XCB
+# and use OpenGL. XCB is only useful if you wish to shave a few Kb
+# off the memory footprint of a whole system and live with less
+# tested code, and possibly unimplemented features in ecore_x. To
+# remove the XCB setup, remove the --with-x11=xcb option to
+# configure.

Why this big comment? At best, it belongs to the help text of BR2_PACKAGE_LIBEFL_X_XCB in the Config.in.

Also, I guess you're only quoting the EFL developers here, so you should state so and add a pointer to that message upstream:

https://git.enlightenment.org/core/efl.git/tree/configure.ac#n5002

Quoted 1 line

But if it were purely on me, I would just drop it.

Well, I'm wondering if I should keep XCB support in this package since it's not a "recommended" configuration. I kept it only because it was already there with efl 1.7.10 package.

Thoughts ?

Allow to enable graphic acceleration using OpenGL or OpenGLES with efl libraries.

Signed-off-by Romain Naour <[email protected]>

---
v4: rename libefl
improve commit log

---
 package/efl/libefl/Config.in | 26 ++++++++++++++++++++++++++
 package/efl/libefl/libefl.mk | 17 +++++++++++++++--
 2 files changed, 41 insertions(+), 2 deletions(-)

package/efl/libefl/Config.in +16 -0

index 8356fa1..a3b6f0e 100644
@@ -81,6 +81,32 @@ comment "for libecore XCB support disable recommended configurations"
 
 endchoice
 
+if BR2_PACKAGE_LIBEFL_X_XLIB
+
+choice
+	prompt "select libevas OpenGL support"
+
+config BR2_PACKAGE_LIBEFL_X_XLIB_GLX_FULL
+	bool "libevas OpenGL full support"
+	depends on BR2_PACKAGE_HAS_LIBGL
+
+comment "libevas OpenGLES support needs libgl"
+	depends on !BR2_PACKAGE_HAS_LIBGL
+
+config BR2_PACKAGE_LIBEFL_X_XLIB_GLX_ES
+	bool "libevas OpenGLES support"
+	depends on BR2_PACKAGE_HAS_LIBGLES
+

package/efl/libefl/Config.in +0 -0

 endif # BR2_PACKAGE_LIBEFL_X
 
 comment "libevas loaders"

package/efl/libefl/libefl.mk +15 -2

index 6a1a8ae..e275699 100644
@@ -176,8 +176,7 @@ endif
 ifeq ($(BR2_PACKAGE_LIBEFL_X),y)
 LIBEFL_CONF_OPTS += --with-x=$(STAGING_DIR) \
 	--x-includes=$(STAGING_DIR)/usr/include \
-	--x-libraries=$(STAGING_DIR)/usr/lib \
-	--with-opengl=none
+	--x-libraries=$(STAGING_DIR)/usr/lib
 
 LIBEFL_DEPENDENCIES += \
 	xlib_libX11 \

@@ -187,6 +186,20 @@ LIBEFL_CONF_OPTS += --with-x=no \
 	--with-x11=none
 endif
 
+ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB_GLX_FULL),y)
+LIBEFL_CONF_OPTS += --with-opengl=full
+LIBEFL_DEPENDENCIES += libgl
+endif
+
+ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB_GLX_ES),y)
+LIBEFL_CONF_OPTS += --with-opengl=es
+LIBEFL_DEPENDENCIES += libgles
+endif
+
+ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB_GLX_NONE),y)
+LIBEFL_CONF_OPTS += --with-opengl=none
+endif
+
 ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB),y)
 LIBEFL_DEPENDENCIES += \
 	xlib_libX11 \

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:

Quoted 36 lines

Allow to enable graphic acceleration using OpenGL or OpenGLES with efl libraries.

Signed-off-by Romain Naour <[email protected]>

---
v4: rename libefl
improve commit log

---
 package/efl/libefl/Config.in | 26 ++++++++++++++++++++++++++
 package/efl/libefl/libefl.mk | 17 +++++++++++++++--
 2 files changed, 41 insertions(+), 2 deletions(-)

package/efl/libefl/Config.in +16 -0

index 8356fa1..a3b6f0e 100644
@@ -81,6 +81,32 @@ comment "for libecore XCB support disable recommended configurations"
 
 endchoice
 
+if BR2_PACKAGE_LIBEFL_X_XLIB
+
+choice
+	prompt "select libevas OpenGL support"
+
+config BR2_PACKAGE_LIBEFL_X_XLIB_GLX_FULL
+	bool "libevas OpenGL full support"
+	depends on BR2_PACKAGE_HAS_LIBGL
+
+comment "libevas OpenGLES support needs libgl"
+	depends on !BR2_PACKAGE_HAS_LIBGL
+
+config BR2_PACKAGE_LIBEFL_X_XLIB_GLX_ES
+	bool "libevas OpenGLES support"
+	depends on BR2_PACKAGE_HAS_LIBGLES
+

package/efl/libefl/Config.in comment "for libecore XCB support disable recommended configurations" · line 109

Quoted 10 lines

package/efl/libefl/Config.in +10 -0

+comment "libevas OpenGLES support needs libgles"
+	depends on !BR2_PACKAGE_HAS_LIBGLES
+
+config BR2_PACKAGE_LIBEFL_X_XLIB_GLX_NONE
+	bool "libevas disable OpenGL support"
+
+endchoice
+
+endif # BR2_PACKAGE_LIBEFL_X_XLIB
+

Here is a proposal to rewrite the option names and prompts:

choice
bool "OpenGL support"
default BR2_PACKAGE_LIBEFL_X_XLIB_OPENGL if BR2_PACKAGE_HAS_LIBGL
default BR2_PACKAGE_LIBEFL_X_XLIB_OPENGLES if BR2_PACKAGE_HAS_LIBGLES help
libevas can be configured to use HW acceleration with OpenGL or OpenGLES.

config BR2_PACKAGE_LIBEFL_X_XLIB_OPENGL_NONE
bool "none"

config BR2_PACKAGE_LIBEFL_X_XLIB_OPENGL
bool "opengl"
depends on BR2_PACKAGE_HAS_LIBGL

comment "opengl support needs an OpenGL provider"
depends on !BR2_PACKAGE_HAS_LIBGL

config BR2_PACKAGE_LIBEFL_X_XLIB_OPENGLES
bool "opengles"
depends on BR2_PACKAGE_HAS_LIBGLES

comment "opengles support needs an opengles provider"
depends on !BR2_PACKAGE_HAS_LIBGLES

endchoice

If you fell inclined into adoptiong this, update the corresponding options in the .mk, of course.

Regards,
Yann E. MORIN.

Quoted 45 lines

package/efl/libefl/Config.in +0 -0

 endif # BR2_PACKAGE_LIBEFL_X
 
 comment "libevas loaders"

package/efl/libefl/libefl.mk +15 -2

index 6a1a8ae..e275699 100644
@@ -176,8 +176,7 @@ endif
 ifeq ($(BR2_PACKAGE_LIBEFL_X),y)
 LIBEFL_CONF_OPTS += --with-x=$(STAGING_DIR) \
 	--x-includes=$(STAGING_DIR)/usr/include \
-	--x-libraries=$(STAGING_DIR)/usr/lib \
-	--with-opengl=none
+	--x-libraries=$(STAGING_DIR)/usr/lib
 
 LIBEFL_DEPENDENCIES += \
 	xlib_libX11 \

@@ -187,6 +186,20 @@ LIBEFL_CONF_OPTS += --with-x=no \
 	--with-x11=none
 endif
 
+ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB_GLX_FULL),y)
+LIBEFL_CONF_OPTS += --with-opengl=full
+LIBEFL_DEPENDENCIES += libgl
+endif
+
+ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB_GLX_ES),y)
+LIBEFL_CONF_OPTS += --with-opengl=es
+LIBEFL_DEPENDENCIES += libgles
+endif
+
+ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB_GLX_NONE),y)
+LIBEFL_CONF_OPTS += --with-opengl=none
+endif
+
 ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB),y)
 LIBEFL_DEPENDENCIES += \
 	xlib_libX11 \

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

X11 XInput v2.2+ support is one of the recommended feature for the efl libraries:
https://git.enlightenment.org/core/efl.git/tree/README?h=efl-1.15#n490

Signed-off-by Romain Naour <[email protected]>

---
v4: rename to libefl
improve commit log
v3: new patch

---
 package/efl/libefl/libefl.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

package/efl/libefl/libefl.mk +0 -0

index e275699..02c9005 100644

package/efl/libefl/libefl.mk +0 -0

 LIBEFL_DEPENDENCIES += \
 	xlib_libX11 \

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

systemd it one of the "highly recommended" dependecies according to the README [1] but disabling it doesn't need the --enable-i-really-know-what-i-am-doing... option. That's why systemd is not added to BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG.

[1] https://git.enlightenment.org/core/efl.git/tree/README?h=efl-1.15#n491

Signed-off-by Romain Naour <[email protected]>

---
v4: rename to libefl
improve commit log
v3: new patch

---
 package/efl/libefl/libefl.mk | 7 +++++++
 1 file changed, 7 insertions(+)

package/efl/libefl/libefl.mk +0 -0

index 02c9005..c26c9c5 100644

package/efl/libefl/libefl.mk +0 -0

 # If fontconfig is disabled, this is going to make general font
 # searching not work, and only some very direct 'load /path/file.ttf'
 # will work alongside some old-school ttf file path searching. This

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:

Quoted 9 lines

systemd it one of the "highly recommended" dependecies according to the README [1] but disabling it doesn't need the --enable-i-really-know-what-i-am-doing... option. That's why systemd is not added to BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG.

[1] https://git.enlightenment.org/core/efl.git/tree/README?h=efl-1.15#n491

Signed-off-by Romain Naour <[email protected]>

Reviewed-by "Yann E. MORIN" <[email protected]>

However, see a comment, below...

Quoted 13 lines

---
v4: rename to libefl
improve commit log
v3: new patch

---
 package/efl/libefl/libefl.mk | 7 +++++++
 1 file changed, 7 insertions(+)

package/efl/libefl/libefl.mk +0 -0

index 02c9005..c26c9c5 100644

package/efl/libefl/libefl.mk ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBBLKID),y) · line 60

Quoted 9 lines

package/efl/libefl/libefl.mk +6 -0

@@ -52,6 +52,13 @@ ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBBLKID),y)
 LIBEFL_DEPENDENCIES += util-linux
 endif
 
+ifeq ($(BR2_PACKAGE_SYSTEMD),y)
+LIBEFL_CONF_OPTS += --enable-systemd
+LIBEFL_DEPENDENCIES += systemd
+else
+LIBEFL_CONF_OPTS += --disable-systemd
+endif

You're adding optional dependencies with various patches; that's perfectly good.

However, I woiuld like that all those optional features be forcibly disabled form the first patch adding libefl. Then each of your patches would transform the hard-coded --disable-XXXX into conditional blocks (with or without Config.in options).

Regards,
Yann E. MORIN.

Quoted 10 lines

package/efl/libefl/libefl.mk +0 -0

 # If fontconfig is disabled, this is going to make general font
 # searching not work, and only some very direct 'load /path/file.ttf'
 # will work alongside some old-school ttf file path searching. This

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

SDL support can't be used with OpenGLES.

Signed-off-by Romain Naour <[email protected]>

---
v5: new patch added since sdl2 package is new available

---
 package/efl/libefl/Config.in |  7 +++++++
 package/efl/libefl/libefl.mk | 11 +++++++++++
 2 files changed, 18 insertions(+)

package/efl/libefl/Config.in +0 -0

index a3b6f0e..44860a2 100644

package/efl/libefl/Config.in +0 -0

 comment "libevas OpenGLES support needs libgl"
 	depends on !BR2_PACKAGE_HAS_LIBGL

package/efl/libefl/libefl.mk +0 -0

index c26c9c5..8ddca64 100644
@@ -180,6 +180,17 @@ else
 LIBEFL_CONF_OPTS += --enable-fb=no
 endif
 

package/efl/libefl/libefl.mk +0 -0

 # --enable-xinput22 is recommended
 ifeq ($(BR2_PACKAGE_LIBEFL_X),y)
 LIBEFL_CONF_OPTS += --with-x=$(STAGING_DIR) \

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:

Quoted 18 lines

SDL support can't be used with OpenGLES.

Signed-off-by Romain Naour <[email protected]>

---
v5: new patch added since sdl2 package is new available

---
 package/efl/libefl/Config.in |  7 +++++++
 package/efl/libefl/libefl.mk | 11 +++++++++++
 2 files changed, 18 insertions(+)

package/efl/libefl/Config.in +0 -0

index a3b6f0e..44860a2 100644
@@ -42,6 +42,12 @@ comment "libecore video support"
 config BR2_PACKAGE_LIBEFL_FB
 	bool "libecore framebuffer support"
 

package/efl/libefl/Config.in comment "libecore video support" · line 46

Quoted 2 lines

package/efl/libefl/Config.in +2 -0

+config BR2_PACKAGE_LIBEFL_SDL2
+	bool "libevas SDL2 support"

FB and X11 refere to libecore, but SDL2 refer to libevas. Is that an oversight, or is that correct?

However, I would simply drop it, to have just:

FB support
SDL2 support
X11 support

package/efl/libefl/Config.in choice · line 98

Quoted 13 lines

package/efl/libefl/Config.in +5 -0

+	# SDL support is not available with OpenGLES.
+	depends on !BR2_PACKAGE_LIBEFL_X_XLIB_GLX_ES
+	select BR2_PACKAGE_SDL2
+
 config BR2_PACKAGE_LIBEFL_X
 	bool "libecore X support"
 	depends on BR2_PACKAGE_XORG7

@@ -89,6 +95,7 @@ choice
 config BR2_PACKAGE_LIBEFL_X_XLIB_GLX_FULL
 	bool "libevas OpenGL full support"
 	depends on BR2_PACKAGE_HAS_LIBGL
+	select BR2_PACKAGE_LIBGLU if BR2_PACKAGE_LIBEFL_SDL2 # evas depends on libglu header in evas_engine.c

I have troubles understanding this set of options.

So, with the current code, one may select SDL2 and not X11. Is that a viable situation?

If so, then OpenGL support will never be available, since OpenGL depends on X11 being enabled. Is that OK? Don't you need to unhide the OpenGL choice for SDL2 too?

Did I miss something?

Quoted 11 lines

package/efl/libefl/Config.in +0 -0

 comment "libevas OpenGLES support needs libgl"
 	depends on !BR2_PACKAGE_HAS_LIBGL

package/efl/libefl/libefl.mk +0 -0

index c26c9c5..8ddca64 100644
@@ -180,6 +180,17 @@ else
 LIBEFL_CONF_OPTS += --enable-fb=no
 endif
 

package/efl/libefl/libefl.mk else · line 192

Quoted 10 lines

package/efl/libefl/libefl.mk +10 -0

+ifeq ($(BR2_PACKAGE_LIBEFL_SDL2),y)
+LIBEFL_CONF_OPTS += --enable-sdl=yes
+LIBEFL_DEPENDENCIES += sdl2
+else
+LIBEFL_CONF_OPTS += --enable-sdl=no
+endif
+
+ifeq ($(BR2_PACKAGE_EFL_X_XLIB_GLX_FULL)$(BR2_PACKAGE_EFL_SDL2),yy)
+EFL_DEPENDENCIES += libglu
+endif

Hmm.. It seems that SDL2 can be over X11, right?

So, how does SDL2 compare to FB and X11? Is it at the same "level" (i.e. a rendering backend talking to the hardwware), or is it layered on-top of X11?

Regards,
Yann E. MORIN.

Quoted 10 lines

package/efl/libefl/libefl.mk +0 -0

 # --enable-xinput22 is recommended
 ifeq ($(BR2_PACKAGE_LIBEFL_X),y)
 LIBEFL_CONF_OPTS += --with-x=$(STAGING_DIR) \

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Use the newly added libefl package wich provide a new version of libeina.

Also, update the upstream url and add a hash file.

While at it, remove BR2_TOOLCHAIN_HAS_THREADS and BR2_INSTALL_LIBSTDCPP dependencies since the efl package already depend on them.

Signed-off-by Romain Naour <[email protected]>

---
v5: Use depends on BR2_PACKAGE_EFL instead of select (ThomasP)
v4: rename to libefl
improve commit log
add a dependency on threads
v3: remove trailing slash (Vicente Bergas)
v2: bump to 1.15
remove glibc only dependency

---
 package/libevas-generic-loaders/Config.in                    | 9 +--------
 package/libevas-generic-loaders/libevas-generic-loaders.hash | 2 ++
 package/libevas-generic-loaders/libevas-generic-loaders.mk   | 9 +++++----
 3 files changed, 8 insertions(+), 12 deletions(-)
 create mode 100644 package/libevas-generic-loaders/libevas-generic-loaders.hash

package/libevas-generic-loaders/Config.in +1 -8

index d0c3cf4..5b9f009 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS
 	bool "libevas generic loaders"
-	select BR2_PACKAGE_LIBEINA
 	select BR2_PACKAGE_ZLIB
 	depends on BR2_PACKAGE_EFL
 	help

@@ -8,7 +7,7 @@ config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS
 	  stand-alone executables that evas may run from its generic
 	  loader module.
 
-	  http://trac.enlightenment.org/e/wiki/Evas_Generic_Loaders
+	  https://www.enlightenment.org/
 
 if BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS
 

@@ -16,14 +15,8 @@ config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_SVG
 	bool "SVG loader"
 	select BR2_PACKAGE_LIBRSVG
 	select BR2_PACKAGE_CAIRO
-	depends on BR2_TOOLCHAIN_HAS_THREADS # librsvg -> glib2
-	depends on BR2_INSTALL_LIBSTDCPP # librsvg -> pango
 	depends on BR2_ARCH_HAS_ATOMICS # cairo
 	help
 	  This option enables the Evas generic SVG loader
 
-comment "SVG loader needs a toolchain w/ threads, C++"
-	depends on BR2_ARCH_HAS_ATOMICS
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
-
 endif

package/libevas-generic-loaders/libevas-generic-loaders.hash new file +2 -0

new file mode 100644
index 0000000..32723ba
@@ -0,0 +1,2 @@
+# From https://download.enlightenment.org/rel/libs/evas_generic_loaders/evas_generic_loaders-1.15.0.tar.xz.sha256
+sha256	1e539e4d4d4e1590345caeb7fdd84f47ec7cd63bb76b6b7107a87420a401fd7f	evas_generic_loaders-1.15.0.tar.xz

package/libevas-generic-loaders/libevas-generic-loaders.mk +5 -4

index ac6b1cc..d8ab252 100644
@@ -4,17 +4,18 @@
 #
 ################################################################################
 
-LIBEVAS_GENERIC_LOADERS_VERSION = 1.7.10
-LIBEVAS_GENERIC_LOADERS_SOURCE = evas_generic_loaders-$(LIBEVAS_GENERIC_LOADERS_VERSION).tar.bz2
-LIBEVAS_GENERIC_LOADERS_SITE = http://download.enlightenment.org/releases
+LIBEVAS_GENERIC_LOADERS_VERSION = 1.15.0
+LIBEVAS_GENERIC_LOADERS_SOURCE = evas_generic_loaders-$(LIBEVAS_GENERIC_LOADERS_VERSION).tar.xz
+LIBEVAS_GENERIC_LOADERS_SITE = http://download.enlightenment.org/rel/libs/evas_generic_loaders
 LIBEVAS_GENERIC_LOADERS_LICENSE = GPLv2
 LIBEVAS_GENERIC_LOADERS_LICENSE_FILES = COPYING
 
 LIBEVAS_GENERIC_LOADERS_INSTALL_STAGING = YES
 
-LIBEVAS_GENERIC_LOADERS_DEPENDENCIES = libeina zlib
+LIBEVAS_GENERIC_LOADERS_DEPENDENCIES = libefl zlib
 
 # For now, we only support the SVG loader
+# poppler >= 0.32 is not supported with libevas-generic-loaders 1.14.0
 LIBEVAS_GENERIC_LOADERS_CONF_OPTS += \
 	--disable-poppler \
 	--disable-spectre \

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:

Quoted 3 lines

Use the newly added libefl package wich provide a new version of libeina.

Quoted 6 lines

Also, update the upstream url and add a hash file.

While at it, remove BR2_TOOLCHAIN_HAS_THREADS and BR2_INSTALL_LIBSTDCPP dependencies since the efl package already depend on them.

Signed-off-by Romain Naour <[email protected]>

Reviewed-by "Yann E. MORIN" <[email protected]>

libraw it's one of the "highly recommended" dependecies according to the README [1].

[1] https://git.enlightenment.org/core/evas_generic_loaders.git/tree/README?id=v1.15.0#n31

Signed-off-by Romain Naour <[email protected]>

---
v4: improve commit log

---
 package/libevas-generic-loaders/Config.in                  | 5 +++++
 package/libevas-generic-loaders/libevas-generic-loaders.mk | 9 +++++++--
 2 files changed, 12 insertions(+), 2 deletions(-)

package/libevas-generic-loaders/Config.in +0 -0

index 5b9f009..26166a8 100644

package/libevas-generic-loaders/Config.in +3 -0

+	help
+	  This option enables the Evas generic Libraw loader
+
 config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_SVG
 	bool "SVG loader"
 	select BR2_PACKAGE_LIBRSVG

package/libevas-generic-loaders/libevas-generic-loaders.mk +7 -2

index d8ab252..4665ded 100644
@@ -14,14 +14,19 @@ LIBEVAS_GENERIC_LOADERS_INSTALL_STAGING = YES
 
 LIBEVAS_GENERIC_LOADERS_DEPENDENCIES = libefl zlib
 
-# For now, we only support the SVG loader
 # poppler >= 0.32 is not supported with libevas-generic-loaders 1.14.0
 LIBEVAS_GENERIC_LOADERS_CONF_OPTS += \
 	--disable-poppler \
 	--disable-spectre \
-	--disable-libraw \
 	--disable-gstreamer
 
+ifeq ($(BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_LIBRAW),y)
+LIBEVAS_GENERIC_LOADERS_DEPENDENCIES += libraw
+LIBEVAS_GENERIC_LOADERS_CONF_OPTS += --enable-libraw
+else
+LIBEVAS_GENERIC_LOADERS_CONF_OPTS += --disable-libraw
+endif
+
 ifeq ($(BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_SVG),y)
 LIBEVAS_GENERIC_LOADERS_DEPENDENCIES += librsvg cairo
 LIBEVAS_GENERIC_LOADERS_CONF_OPTS += --enable-svg

Signature · 6 lines

2.4.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot