Late Samsung DT updates for v4.4

Hi Arnd, Olof, Kevin

Here is late pull-request for v4.4, please pull.

If any problems, please kindly let me know.
See you in Seoul next week ;-)

Thanks,
Kukjin

The following changes since commit df829b06f0079165d9dc7719af8f8a7da852fe51:

ARM: dts: Use GPIO constants for flags cells in exynos5440 boards
(2015-10-08 07:39:58 +0900)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
tags/samsung-dt-2

for you to fetch changes up to d6b9aea67f40e138e972b17c7c658bc3c8ac2459:

MAINTAINERS: Add documentation and dt-bindings for exynos stuff
(2015-10-24 05:07:26 +0900)

----------------------------------------------------------------
Samsung 2nd DT updates for v4.4

- use exynos5420-dw-mshc instead of exynos5250 for exynos3250
- add DISP1 clocks and the DISP1 power domain of two closk on exynos5250 (clock commit got Stephen's ack)
- add vbus regulators on exynos3250, exynos4210 and exynos4412 boards
- fix typo in regulator enable GPIO property on s5pv20-aquila and goni
- document: correct the example of exynos power domain clocks
- document: consolidate exynos SoC dt-bindings and non-Samsung boards related compatibles (FriendlyARM, Google, Hardkernel and Insignal)
- update MAINTAINER entries accordingly (documentation)

----------------------------------------------------------------
Jaehoon Chung (1):
ARM: dts: use exynos5420-dw-mshc compatible for exynos3250

Krzysztof Kozlowski (4):
dt-bindings: Correct the example for Exynos power domain clocks
dt-bindings: Consolidate Exynos SoC bindings
dt-bindings: EXYNOS: Document compatibles from other vendors
MAINTAINERS: Add documentation and dt-bindings for exynos stuff

Laurent Pinchart (2):
ARM: dts: Fix typo in regulator enable GPIO property in s5pv210-aquila
ARM: dts: Fix typo in regulator enable GPIO property in s5pv210-goni

Marek Szyprowski (1):
ARM: dts: Add vbus regulator to USB2 phy nodes on exynos3250,
exynos4210 and exynos4412 boards

Tomeu Vizoso (2):
clk: samsung: exynos5250: Add DISP1 clocks
ARM: dts: Add clocks to DISP1 domain in exynos5250

 .../devicetree/bindings/arm/samsung-boards.txt     | 27 ---------
 .../bindings/arm/samsung/samsung-boards.txt        | 69
++++++++++++++++++++++
 .../devicetree/bindings/iommu/samsung,sysmmu.txt   |  2 +-
 .../power_domain.txt => power/pd-samsung.txt}      |  5 +-
 MAINTAINERS                                        |  4 ++
 arch/arm/boot/dts/exynos3250-monk.dts              |  1 +
 arch/arm/boot/dts/exynos3250-rinato.dts            |  1 +
 arch/arm/boot/dts/exynos3250.dtsi                  |  4 +-
 arch/arm/boot/dts/exynos4210-trats.dts             |  2 +-
 arch/arm/boot/dts/exynos4210-universal_c210.dts    |  2 +-
 arch/arm/boot/dts/exynos4412-trats2.dts            |  1 +
 arch/arm/boot/dts/exynos5250.dtsi                  |  4 ++
 arch/arm/boot/dts/s5pv210-aquila.dts               |  2 +-
 arch/arm/boot/dts/s5pv210-goni.dts                 |  4 +-
 drivers/clk/samsung/clk-exynos5250.c               | 14 ++++-
 include/dt-bindings/clock/exynos5250.h             |  4 +-
 16 files changed, 106 insertions(+), 40 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/samsung-boards.txt
 create mode 100644
Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
 rename Documentation/devicetree/bindings/{arm/exynos/power_domain.txt

=> power/pd-samsung.txt} (93%)

The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f:

Linux 4.3-rc1 (2015-09-12 16:35:56 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
tags/samsung-dt64

for you to fetch changes up to c60ce7fe82c46d9480b85858828e3042dfe6c9bf:

arm64: dts: Add BUS1 instance pinctrl support for exynos7 (2015-10-08
07:18:33 +0900)

----------------------------------------------------------------
Samsung arm64 DT update for v4.4

- add BUS1 instance pinctrl support on exynos7 SoC

----------------------------------------------------------------
Alim Akhtar (1):
arm64: dts: Add BUS1 instance pinctrl support for exynos7

 arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 103
++++++++++++++++++++++++
 arch/arm64/boot/dts/exynos/exynos7.dtsi         |   7 ++
 2 files changed, 110 insertions(+)

Merged, thanks.

-Olof

The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f:

Linux 4.3-rc1 (2015-09-12 16:35:56 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
tags/samsung-soc

for you to fetch changes up to 97d5c7a77e39ab96a2a6137de0e35dd6e3f38325:

Documentation: EXYNOS: Update bootloader interface on exynos542x
(2015-10-24 04:43:31 +0900)

----------------------------------------------------------------
Samsung SoC updates for v4.4

- use PWM lookup table with pwm_add_table() for the following boards : s3c24xx h1940 and rx1950
: s3c64xx smdk6410, crag6410, hmt and smartq
- document: update bootloader interface on exynos542x

----------------------------------------------------------------
Krzysztof Kozlowski (1):
Documentation: EXYNOS: Update bootloader interface on exynos542x

Thierry Reding (6):
ARM: S3C24XX: Use PWM lookup table for mach-h1940
ARM: S3C24XX: Use PWM lookup table for mach-rx1950
ARM: S3C64XX: Use PWM lookup table for smdk6410
ARM: S3C64XX: Use PWM lookup table for mach-crag6410
ARM: S3C64XX: Use PWM lookup table for mach-hmt
ARM: S3C64XX: Use PWM lookup table for mach-smartq

 Documentation/arm/Samsung/Bootloader-interface.txt |  5 +++--
 arch/arm/mach-s3c24xx/mach-h1940.c                 | 10 +++++++---
 arch/arm/mach-s3c24xx/mach-rx1950.c                |  8 ++++++--
 arch/arm/mach-s3c64xx/dev-backlight.c              |  4 ----
 arch/arm/mach-s3c64xx/mach-crag6410.c              |  9 +++++++--
 arch/arm/mach-s3c64xx/mach-hmt.c                   |  9 +++++++--
 arch/arm/mach-s3c64xx/mach-smartq.c                |  9 +++++++--
 arch/arm/mach-s3c64xx/mach-smdk6410.c              |  8 +++++++-
 8 files changed, 44 insertions(+), 18 deletions(-)

Merged, thanks.

-Olof

The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f:

Linux 4.3-rc1 (2015-09-12 16:35:56 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
tags/samsung-driver

for you to fetch changes up to c612d5a7785b307df96938d590c3a1edfb624ccf:

cpufreq: s5pv210: remove superfluous CONFIG_PM ifdefs (2015-10-24
04:34:50 +0900)

----------------------------------------------------------------
Samsung driver udpates for v4.4

- add support for exynos SROM controller DT based driver (drivers/soc/samsung/exynos-srom.c)
: Since the exynos SROM registers are used during Suspend to RAM
so the exynos SROM driver handles the S2R and then we can remove static mapping for SROM registers.
: Pankaj tested boot and S2R functionality on Peach-Pi chromebook : Pavel tested on SMDK5410 board
: Krzysztof tested on Trats2 (exynos4412) board
- update Maintainer entry accordingly
- remove superfluous CONFIG_PM ifdefs with Viresh's ack

----------------------------------------------------------------
Bartlomiej Zolnierkiewicz (1):
cpufreq: s5pv210: remove superfluous CONFIG_PM ifdefs

Pankaj Dubey (8):
ARM: EXYNOS: remove unused static mapping of CMU for exynos5
ARM: EXYNOS: code cleanup in map.h
dt-bindings: add exynos-srom device tree binding
ARM: dts: add SROM device node for exynos4
ARM: dts: add SROM device node for exynos5
drivers: soc: add support for exynos SROM driver
MAINTAINERS: add maintainers entry for drivers/soc/samsung
ARM: EXYNOS: Remove SROM related register settings from mach-exynos

 .../bindings/arm/samsung/exynos-srom.txt           |  12 ++
 MAINTAINERS                                        |   1 +
 arch/arm/boot/dts/exynos4.dtsi                     |   5 +
 arch/arm/boot/dts/exynos5.dtsi                     |   5 +
 arch/arm/mach-exynos/Kconfig                       |   2 +
 arch/arm/mach-exynos/exynos.c                      |  22 ---
 arch/arm/mach-exynos/include/mach/map.h            |   8 -
 arch/arm/mach-exynos/regs-srom.h                   |  53 -------
 arch/arm/mach-exynos/suspend.c                     |  20 +--
 arch/arm/plat-samsung/include/plat/map-s5p.h       |   1 -
 drivers/cpufreq/s5pv210-cpufreq.c                  |   2 -
 drivers/soc/Kconfig                                |   1 +
 drivers/soc/Makefile                               |   1 +
 drivers/soc/samsung/Kconfig                        |  13 ++
 drivers/soc/samsung/Makefile                       |   1 +
 drivers/soc/samsung/exynos-srom.c                  | 175
+++++++++++++++++++++
 drivers/soc/samsung/exynos-srom.h                  |  51 ++++++
 17 files changed, 269 insertions(+), 104 deletions(-)
 create mode 100644
Documentation/devicetree/bindings/arm/samsung/exynos-srom.txt
 delete mode 100644 arch/arm/mach-exynos/regs-srom.h
 create mode 100644 drivers/soc/samsung/Kconfig
 create mode 100644 drivers/soc/samsung/Makefile
 create mode 100644 drivers/soc/samsung/exynos-srom.c
 create mode 100644 drivers/soc/samsung/exynos-srom.h

Hi Olof and Kukjin,

I see that this pull request was not pulled yet. (Un)Fortunately I spotted one mistake in DTS changes above - the length of mapped region is too small by one word. This does not produce any visible effect but actually is wrong because driver will read from unmapped memory.

The question is - do you prefer us to send a following up patch or to fix it by amending the commit?

Here is a fix which can be squashed into these two commits:
-- >8 --
Subject: [PATCH] ARM: dts: Fix size of mapped SROMC memory region on
exynos[45]

The SROMC memory region contains 5 registers so the size of mapped memory should be 0x14 instead of 0x10.

---
 arch/arm/boot/dts/exynos4.dtsi | 2 +-
 arch/arm/boot/dts/exynos5.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

index 2f31f773b096..ffda7f5118cd 100644
@@ -78,7 +78,7 @@
 
 	sromc at 12570000 {
 		compatible = "samsung,exynos-srom";
-		reg = <0x12570000 0x10>;
+		reg = <0x12570000 0x14>;
 	};
 
 	mipi_phy: video-phy at 10020710 {

index b5d3437922c5..fb52d16fba33 100644
@@ -32,7 +32,7 @@
 
 	sromc at 12250000 {
 		compatible = "samsung,exynos-srom";
-		reg = <0x12250000 0x10>;
+		reg = <0x12250000 0x14>;
 	};
 
 	combiner: interrupt-controller at 10440000 {

1.9.1

Hello!

By the way, since we are discussing fixing these commits...
After hardcoded SROMc handling has been removed, Exynos5410-based machines stopped handling it entirely, because the description
has never been added to exynos5410.dtsi (which does not include exynos5.dtsi). Shouldn't the description be added there too?

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia

No, it is not needed.
The Exynos5410 in current form does not have suspend capability. During boot you should see in dmesg:
Failed to find PMU node
coming from mach-exynos/suspend.c.

In suspend.c there is no compatible for Exynos5410.

Best regards,
Krzysztof

Hello!

Indeed. By the way, can this be a reason why reboot stopped working? It worked in v4.1. Isn't this a regression? Ok, nevertheless, here is v3 of my patchset.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia

The noticeable change between v4.1 and v4.2 was for example:
c4241a582d22 ("ARM: EXYNOS: use PS_HOLD based poweroff for all supported SoCs")

Can you try whether reverting it fixes the issue?

I don't recall any other changes which could affect Exynos5410.

Best regards,
Krzysztof

Hello!

First of all, sorry for misinforming you. It was not v4.1 which worked, but 3.18 one. I never ran 4.1 on this board, it's my
memory's fault...
Second, the commit which actually broke 5410 is 8cfc7fdd33080e30b86d21b1a8c9ad0686427ddc ("ARM: EXYNOS: move restart code into pmu
driver"). And we don't have 5410 PMU description in our DT, that's the problem.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia

Yeah, I started looking now at why I didn't merge it since I had just not touched it nor replied to it.

It looks like it contains an slight jumble of patches. It modifies DT contents, which we always ask to get in the dt branch.

Please resend after -rc1 and we'll merge this for 4.5.

Thanks,

-Olof

The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f:

Linux 4.3-rc1 (2015-09-12 16:35:56 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
tags/samsung-defconfig

for you to fetch changes up to f0864f843f0249f3e16e1a9af7152d7aa8070b10:

ARM: multi_v7_defconfig: Enable rtl8152 ethernet driver for Odroid-XU4
(2015-10-24 04:13:12 +0900)

----------------------------------------------------------------
Samsung defconfig udpates for v4.4

- exynos_defconfig
: enable USB Video Class for Peach boards.
: enable DWC2 USB and USB ethernet gadget
: enable LEDs (LEGS_GPIO and LEDS_PWM)for Odroid-XU3/XU4 : enable RTL8152 for Odroid-XU4
: enable WiFi-Ex as a module instead of build-in : disable temporal simplefb support (FB_SIMPLE) because
exynos DRM driver can support it now

- multi_v7_defconfig
: enable DWC2 USB and USB ethernet gadget
: enable RTL8152 for Odroid-XU4

----------------------------------------------------------------
Anand Moon (3):
ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4
ARM: exynos_defconfig: Enable rtl8152 ethernet driver for Odroid-XU4
ARM: multi_v7_defconfig: Enable rtl8152 ethernet driver for Odroid-XU4

Javier Martinez Canillas (3):
ARM: exynos_defconfig: Enable USB Video Class support
ARM: exynos_defconfig: Disable simplefb support
ARM: exynos_defconfig: Enable WiFi-Ex as a module instead built-in

Marek Szyprowski (2):
ARM: exynos_defconfig: Enable DWC2 USB driver and USB ethernet gadget
ARM: multi_v7_defconfig: Enable DWC2 USB driver and USB ethernet
gadget

 arch/arm/configs/exynos_defconfig   | 18 +++++++++++++++---
 arch/arm/configs/multi_v7_defconfig |  3 +++
 2 files changed, 18 insertions(+), 3 deletions(-)

Merged, thanks.

-Olof

Merged, thanks.

-Olof