ARM: v7-M: Use ret_to_user_from_irq in PendSV handler
PATCH 1/1 ARM: v7-M: Use ret_to_user_from_irq in PendSV handler
The PendSV handler calls v7m_exception_entry which disables IRQs. Therefore, since IRQs are already disabled, the PendSV handler can return using ret_to_user_from_irq.
---
Tested on a NXP LPC43xx platform.
arch/arm/kernel/entry-v7m.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/kernel/entry-v7m.S +1 -1
@@ -88,7 +88,7 @@ __pendsv_entry: @ execute the pending work, including reschedule get_thread_info tsk mov why, #0 - b ret_to_user + b ret_to_user_from_irq ENDPROC(__pendsv_entry) /*
Signature · 1 line
2.5.2
PATCH 1/1 ARM: v7-M: Use ret_to_user_from_irq in PendSV handler
Quoted 5 lines · Ezequiel Garcia
The PendSV handler calls
v7m_exception_entrywhich disables IRQs. Therefore, since IRQs are already disabled, the PendSV handler can return usingret_to_user_from_irq.Signed-off-by Ezequiel Garcia <[email protected]>
Looks right. How did you notice this?
Best regards
Uwe
Quoted 23 lines
---
Tested on a NXP LPC43xx platform.arch/arm/kernel/entry-v7m.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/kernel/entry-v7m.S +1
-1@@ -88,7 +88,7 @@ __pendsv_entry: @ execute the pending work, including reschedule get_thread_info tsk mov why, #0 - b ret_to_user + b ret_to_user_from_irq ENDPROC(__pendsv_entry) /*Signature · 1 line
2.5.2
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH 1/1 ARM: v7-M: Use ret_to_user_from_irq in PendSV handler
Quoted 8 lines · Uwe Kleine-K?nig
Quoted 5 lines · Ezequiel Garcia
The PendSV handler calls
v7m_exception_entrywhich disables IRQs. Therefore, since IRQs are already disabled, the PendSV handler can return usingret_to_user_from_irq.Signed-off-by Ezequiel Garcia <[email protected]>Looks right. How did you notice this?
Just reading the code.
Quoted 2 lines
Acked-by Uwe Kleine-K?nig <[email protected]>
Thanks, I'll queue this in Russell's patch tracking system.
Signature · 2 lines
Ezequiel Garc?a, VanguardiaSur www.vanguardiasur.com.ar