Skip to contentSkip to conversation

Staging: wilc1000: Prefer eth_broadcast_addr over memset()

PATCH Superseded Punit Vara 2 participants 2 messages Oct 27, 2015 Staging

lore
Share & tools
lore

Punit Vara

author
#0 lore raw

PATCH v2 1/1 Staging: wilc1000: Prefer eth_broadcast_addr over memset()

This patch is to the host_interface.c that fixes up following warning by checkpatch:

-prefer eth_broadcast_addr() over memset()

---
 drivers/staging/wilc1000/host_interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wilc1000/host_interface.c +1 -1
index 5f81eab..53e21cd 100644
@@ -4642,7 +4642,7 @@ s32 host_int_del_station(struct host_if_drv *hif_drv, const u8 *pu8MacAddr)
 	msg.drv = hif_drv;
 
 	if (!pu8MacAddr)
-		memset(pstrDelStationMsg->mac_addr, 255, ETH_ALEN);
+		eth_broadcast_addr(pstrDelStationMsg->mac_addr);
 	else
 		memcpy(pstrDelStationMsg->mac_addr, pu8MacAddr, ETH_ALEN);
 
Signature · 1 line
2.5.3
maintainer
#1 lore raw
Quoted 9 lines · Punit Vara

This patch is to the host_interface.c that fixes up following warning by checkpatch:

-prefer eth_broadcast_addr() over memset()

---
 drivers/staging/wilc1000/host_interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

What changed from v1?

Always put that information here below the --- line so that we know.

Please fix up and resend.

thanks,

greg k-h