Skip to contentSkip to conversation

libv4l: fix a typo to not override the LIBV4L_DEPENDENCIES variable

PATCH New Vicente Olivert Riera 3 participants 3 messages Oct 29, 2015

lore
Share & tools
lore

Vicente Olivert Riera

author
#0 lore raw

PATCH 1/2 libv4l: fix a typo to not override the LIBV4L_DEPENDENCIES variable

Otherwise host-pkgconf will not be installed and the configure script will fail with an error like this one:

./configure: line 16346: PKG_PROG_PKG_CONFIG: command not found [snip]
./configure: line 20511: syntax error near unexpected token X11,' ./configure: line 20511: PKG_CHECK_MODULES(X11, x11, x11_pkgconfig=yes, x11_pkgconfig=no)'

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/libv4l/libv4l.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
package/libv4l/libv4l.mk +1 -1
index 9442467..89d1d00 100644
@@ -13,7 +13,7 @@ LIBV4L_CONF_OPTS = --disable-doxygen-doc
 
 # patch touches Makefile.am (and needs host-gettext for autoreconf)
 LIBV4L_AUTORECONF= YES
-LIBV4L_DEPENDENCIES = host-gettext
+LIBV4L_DEPENDENCIES += host-gettext
 
 # fix uclibc-ng configure/compile
 LIBV4L_CONF_ENV = ac_cv_prog_cc_c99='-std=gnu99'
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/2 libv4l: fix a typo to not override the LIBV4L_DEPENDENCIES variable

Hello Vicente,

Quoted 19 lines · Vicente Olivert Riera

Otherwise host-pkgconf will not be installed and the configure script will fail with an error like this one:

./configure: line 16346: PKG_PROG_PKG_CONFIG: command not found [snip]
./configure: line 20511: syntax error near unexpected token X11,' ./configure: line 20511: PKG_CHECK_MODULES(X11, x11, x11_pkgconfig=yes, x11_pkgconfig=no)'

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/libv4l/libv4l.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
package/libv4l/libv4l.mk +0 -0
index 9442467..89d1d00 100644

package/libv4l/libv4l.mk LIBV4L_CONF_OPTS = --disable-doxygen-doc · line 19

Quoted 8 lines
package/libv4l/libv4l.mk +1 -1
@@ -13,7 +13,7 @@ LIBV4L_CONF_OPTS = --disable-doxygen-doc
 
 # patch touches Makefile.am (and needs host-gettext for autoreconf)
 LIBV4L_AUTORECONF= YES
-LIBV4L_DEPENDENCIES = host-gettext
+LIBV4L_DEPENDENCIES += host-gettext
 
 # fix uclibc-ng configure/compile
 LIBV4L_CONF_ENV = ac_cv_prog_cc_c99='-std=gnu99'

Thanks for spotting my mistake....

Tested-by Peter Seiderer <[email protected]>

Regards,
Peter

#2 lore raw

PATCH 1/2 libv4l: fix a typo to not override the LIBV4L_DEPENDENCIES variable

In reply to Vicente Olivert Riera
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vicente" == Vicente Olivert Riera <[email protected]> writes:

Otherwise host-pkgconf will not be installed and the configure script will fail with an error like this one:

Quoted 7 lines

./configure: line 16346: PKG_PROG_PKG_CONFIG: command not found [snip]
./configure: line 20511: syntax error near unexpected token X11,' ./configure: line 20511: PKG_CHECK_MODULES(X11, x11, x11_pkgconfig=yes, x11_pkgconfig=no)'

Signed-off-by Vicente Olivert Riera <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard