Skip to contentSkip to conversation

common: simply code

PATCH New Peng Fan 3 participants 3 messages Oct 29, 2015 – Oct 30, 2015

lore
Share & tools
lore

Peng Fan

author
#0 lore raw

PATCH 1/1 common: simply code

get_clocks is wrapped by CONFIG_FSL_CLK and CONFIG_M68K in seperate piece code. They can be merged into one snippet.

Signed-off-by Peng Fan <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>
Cc Bin Meng <[email protected]>
Cc Alexey Brodkin <[email protected]>
Cc "angelo at sysam.it" <[email protected]>
Cc Daniel Schwierzeck <[email protected]>
Cc Stephen Warren <[email protected]>
Cc "Andreas Bie?mann" <[email protected]>
---
 common/board_f.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
common/board_f.c +1 -4
index 486e828..7bc05b1 100644
@@ -806,10 +806,7 @@ static init_fnc_t init_sequence_f[] = {
 #if defined(CONFIG_BOARD_POSTCLK_INIT)
 	board_postclk_init,
 #endif
-#ifdef CONFIG_FSL_CLK
-	get_clocks,
-#endif
-#ifdef CONFIG_M68K
+#if defined(CONFIG_FSL_CLK) || defined(CONFIG_M68K)
 	get_clocks,
 #endif
 	env_init,		/* initialize environment */
Signature · 1 line
1.8.4
#1 lore raw

PATCH 1/1 common: simply code

Quoted 12 lines · Peng Fan

get_clocks is wrapped by CONFIG_FSL_CLK and CONFIG_M68K in seperate piece code. They can be merged into one snippet.

Signed-off-by Peng Fan <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>
Cc Bin Meng <[email protected]>
Cc Alexey Brodkin <[email protected]>
Cc "angelo at sysam.it" <[email protected]>
Cc Daniel Schwierzeck <[email protected]>
Cc Stephen Warren <[email protected]>
Cc "Andreas Bie?mann" <[email protected]>
Quoted 3 lines
---
 common/board_f.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

nit: I think it would be better to use a subject like "common:
Simplify get_clocks() #ifdef".

Reviewed-by Simon Glass <[email protected]>
#2 lore raw

PATCH 1/1 common: simply code

Quoted 17 lines · Simon Glass
Quoted 12 lines · Peng Fan

get_clocks is wrapped by CONFIG_FSL_CLK and CONFIG_M68K in seperate piece code. They can be merged into one snippet.

Signed-off-by Peng Fan <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>
Cc Bin Meng <[email protected]>
Cc Alexey Brodkin <[email protected]>
Cc "angelo at sysam.it" <[email protected]>
Cc Daniel Schwierzeck <[email protected]>
Cc Stephen Warren <[email protected]>
Cc "Andreas Bie?mann" <[email protected]>
Quoted 3 lines
---
 common/board_f.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
Quoted 2 lines

nit: I think it would be better to use a subject like "common:
Simplify get_clocks() #ifdef".

Thanks, will take your suggestion and send out v2.

Regards,
Peng.

Quoted 2 lines
Reviewed-by Simon Glass <[email protected]>