Staging: lustre: ldlm_pool: Remove unneeded wrapper functions
PATCH 1/1 Staging: lustre: ldlm_pool: Remove unneeded wrapper functions
Remove the wrapper functions ldlm_pl2ns(), ldlm_pool_get_limit(), ldlm_pool_set_limit() and replace their calls with the functions that they wrapped.
Signed-off-by Shivani Bhardwaj <[email protected]>
--- drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 46 +++++++++----------------- 1 file changed, 15 insertions(+), 31 deletions(-)
drivers/staging/lustre/lustre/ldlm/ldlm_pool.c +15 -31
@@ -176,11 +176,6 @@ enum { LDLM_POOL_LAST_STAT }; -static inline struct ldlm_namespace *ldlm_pl2ns (struct ldlm_pool *pl) -{ - return container_of(pl, struct ldlm_namespace, ns_pool); -} -/** * Calculates suggested grant_step in % of available locks for passed * \a period. This is later used in grant_plan calculations.
@@ -213,22 +208,6 @@ static inline int ldlm_pool_t2gsp(unsigned int t) }/** -* Returns current \a pl limit. -*/ -static __u32 ldlm_pool_get_limit (struct ldlm_pool *pl) -{ -return atomic_read (&pl->pl_limit); -} - -/** -* Sets passed \a limit to \a pl. -*/ -static void ldlm_pool_set_limit (struct ldlm_pool *pl,__u32 limit) -{ -atomic_set (&pl->pl_limit, limit); -} - -/** * Recalculates next stats on passed \a pl. * * \pre ->pl_lock is locked.
@@ -254,7 +233,8 @@ static void ldlm_pool_recalc_stats(struct ldlm_pool *pl) }/** -* Sets SLV and Limit from ldlm_pl2ns(pl)->ns_obd tp passed \a pl. +* Sets SLV and Limit from container_of(pl, struct ldlm_namespace, +* ns_pool)->ns_obd tp passed \a pl. */ static void ldlm_cli_pool_pop_slv (struct ldlm_pool *pl) {
@@ -264,11 +244,11 @@ static void ldlm_cli_pool_pop_slv(struct ldlm_pool *pl)* Get new SLV and Limit from obd which is updated with coming * RPCs. */ - obd =ldlm_pl2ns (pl)->ns_obd; + obd = container_of(pl, struct ldlm_namespace, ns_pool)->ns_obd;LASSERT (obd !=NULL );read_lock (&obd->obd_pool_lock); pl->pl_server_lock_volume = obd->obd_pool_slv; -ldlm_pool_set_limit (pl, obd->obd_pool_limit); +atomic_set (&pl->pl_limit, obd->obd_pool_limit);read_unlock (&obd->obd_pool_lock); }
@@ -304,7 +284,8 @@ static int ldlm_cli_pool_recalc(struct ldlm_pool *pl)/* * Do not cancel locks in case lru resize is disabled for this ns. */ -if (!ns_connect_lru_resize (ldlm_pl2ns (pl))) { + if (!ns_connect_lru_resize(container_of(pl, struct ldlm_namespace, + ns_pool))) { ret =0 ; goto out; }
@@ -315,7 +296,8 @@ static int ldlm_cli_pool_recalc(struct ldlm_pool *pl)* It may be called when SLV has changed much, this is why we do not * take into account pl->pl_recalc_time here. */ - ret =ldlm_cancel_lru (ldlm_pl2ns (pl),0 ,LCF_ASYNC ,LDLM_CANCEL_LRUR ); + ret = ldlm_cancel_lru(container_of(pl, struct ldlm_namespace, ns_pool), +0 ,LCF_ASYNC ,LDLM_CANCEL_LRUR ); out:spin_lock (&pl->pl_lock);
@@ -341,7 +323,7 @@ static int ldlm_cli_pool_shrink(struct ldlm_pool *pl,struct ldlm_namespace *ns;int unused; - ns =ldlm_pl2ns (pl); + ns = container_of(pl, struct ldlm_namespace, ns_pool);/* * Do not cancel locks in case lru resize is disabled for this ns.
@@ -453,7 +435,7 @@ static int lprocfs_pool_state_seq_show(struct seq_file *m, void *unused)spin_lock (&pl->pl_lock); slv = pl->pl_server_lock_volume; clv = pl->pl_client_lock_volume; - limit =ldlm_pool_get_limit (pl); + limit =atomic_read (&pl->pl_limit); granted =atomic_read (&pl->pl_granted); grant_rate =atomic_read (&pl->pl_grant_rate); cancel_rate =atomic_read (&pl->pl_cancel_rate);
@@ -558,7 +540,8 @@ static struct kobj_type ldlm_pl_ktype = {static int ldlm_pool_sysfs_init (struct ldlm_pool *pl) { -struct ldlm_namespace *ns =ldlm_pl2ns (pl); + struct ldlm_namespace *ns = container_of(pl, struct ldlm_namespace, + ns_pool);int err;init_completion (&pl->pl_kobj_unregister);
@@ -570,7 +553,8 @@ static int ldlm_pool_sysfs_init(struct ldlm_pool *pl)static int ldlm_pool_debugfs_init (struct ldlm_pool *pl) { -struct ldlm_namespace *ns =ldlm_pl2ns (pl); + struct ldlm_namespace *ns = container_of(pl, struct ldlm_namespace, + ns_pool);struct dentry *debugfs_ns_parent;struct lprocfs_vars pool_vars[2 ];char *var_name =NULL ;
@@ -685,7 +669,7 @@ int ldlm_pool_init(struct ldlm_pool *pl, struct ldlm_namespace *ns,snprintf (pl->pl_name,sizeof (pl->pl_name),"ldlm-pool-%s-%d" ,ldlm_ns_name (ns), idx); -ldlm_pool_set_limit (pl,1 ); +atomic_set (&pl->pl_limit,1 ); pl->pl_server_lock_volume =0 ; pl->pl_ops = &ldlm_cli_pool_ops; pl->pl_recalc_period =LDLM_POOL_CLI_DEF_RECALC_PERIOD ;
Signature · 1 line
2.1.0
Greg KH
maintainerQuoted 3 lines · Shivani Bhardwaj
Remove the wrapper functions
ldlm_pl2ns(),ldlm_pool_get_limit(),ldlm_pool_set_limit()and replace their calls with the functions that they wrapped.
Please break this up into one-patch-per-thing you replace, not a bunch all at once.
thanks,
greg k-h