ARM: at91/dt: sama5d4: Add support for DENX MA5D4 SoM and EVK
Subsystems (3)
PATCH 1/1 ARM: at91/dt: sama5d4: Add support for DENX MA5D4 SoM and EVK
Add support for the DENX MA5D4 SoM and MA5D4EVK board. The system consists of a SoM with eMMC, SPI NOR for booting, 2x SPI CAN chip and an EVK with microSD slot, 2x UART, 2x CAN port, 3x USB port, LEDs and expansion headers.
--- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi | 140 +++++++++++++++++++++++ arch/arm/boot/dts/at91-sama5d4_ma5d4evk.dts | 170 ++++++++++++++++++++++++++++ 3 files changed, 311 insertions(+) create mode 100644 arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi create mode 100644 arch/arm/boot/dts/at91-sama5d4_ma5d4evk.dts
arch/arm/boot/dts/Makefile +1 -0
@@ -48,6 +48,7 @@ dtb-$(CONFIG_SOC_SAM_V7) += \ sama5d34ek.dtb \ sama5d35ek.dtb \ sama5d36ek.dtb \ + at91-sama5d4_ma5d4evk.dtb \ at91-sama5d4_xplained.dtb \ at91-sama5d4ek.dtb dtb-$(CONFIG_ARCH_ATLAS6) += \
arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi new file +140 -0
140 lines not on this page · raw message
arch/arm/boot/dts/at91-sama5d4_ma5d4evk.dts new file +170 -0
170 lines not on this page · raw message
Signature · 1 line
2.1.4
PATCH 1/1 ARM: at91/dt: sama5d4: Add support for DENX MA5D4 SoM and EVK
Hi Marek,
arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi line 26
Quoted 5 lines · Marek Vasut
arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi new file +5
-0+ clocks { + #address-cells = <1>; + #size-cells = <1>; + ranges; +
You probably don't need those three properties
arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi line 31
Quoted 5 lines
arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi new file +5
-0+ main_clock: clock at 0 { + compatible = "atmel,osc", "fixed-clock"; + clock-frequency = <12000000>; + }; +
likewise, if you don't need to boot on older kernels, I'd suggest removing clock at 0.
arch/arm/boot/dts/at91-sama5d4_ma5d4evk.dts line 20
Quoted 6 lines
arch/arm/boot/dts/at91-sama5d4_ma5d4evk.dts new file +6
-0+/ { + model = "DENX MA5D4EVK"; + compatible = "denx,ma5d4evk", "atmel,sama5d4", "atmel,sama5"; + + chosen { + bootargs = "ignore_loglevel earlyprintk";
I think you don't really want to enforce those options, especially earlyprintk as it can lead to a crash if UART_PHYS is not set properly (for example, I usually boot the same kernel on sama5d3 and sama5d4).
Signature · 3 lines
Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 ARM: at91/dt: sama5d4: Add support for DENX MA5D4 SoM and EVK
Quoted 1 line · Alexandre Belloni
Hi Marek,
Hi!
Quoted 8 lines · Marek Vasut
arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi line 26
Quoted 5 lines
arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi new file +5
-0+ clocks { + #address-cells = <1>; + #size-cells = <1>; + ranges; +You probably don't need those three properties
Truth to be told, I copied those from sama5d4ek.dts , but I think you're right, they make no sense in this context.
Quoted 8 lines
arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi line 31
Quoted 5 lines
arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi new file +5
-0+ main_clock: clock at 0 { + compatible = "atmel,osc", "fixed-clock"; + clock-frequency = <12000000>; + }; +likewise, if you don't need to boot on older kernels, I'd suggest removing clock at 0.
Consider this fixed, I certainly don't plan to boot anything old(er).
Quoted 10 lines
arch/arm/boot/dts/at91-sama5d4_ma5d4evk.dts line 20
Quoted 6 lines
arch/arm/boot/dts/at91-sama5d4_ma5d4evk.dts new file +6
-0+/ { + model = "DENX MA5D4EVK"; + compatible = "denx,ma5d4evk", "atmel,sama5d4", "atmel,sama5"; + + chosen { + bootargs = "ignore_loglevel earlyprintk";I think you don't really want to enforce those options, especially earlyprintk as it can lead to a crash if
UART_PHYSis not set properly (for example, I usually boot the same kernel on sama5d3 and sama5d4).
Same here, fixed.
Thanks for the review! I will wait a bit and then submit a V2.
Best regards,
Marek Vasut