Skip to contentSkip to conversation

ACPI: Honor ACPI _CCA attribute setting

PATCH Dennis Chen 3 participants 4 messages Nov 2, 2015 – Nov 3, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw
Quoted 32 lines · Suravee Suthikulpanit

From: Jeremy Linton <[email protected]>

ACPI configurations can now mark devices as noncoherent, support that choice.

NOTE: This is required to support USB on ARM Juno Development Board.

CC Bjorn Helgaas <[email protected]>
CC Catalin Marinas <[email protected]>
CC Rob Herring <[email protected]>
CC Will Deacon <[email protected]>
CC Rafael J. Wysocki <[email protected]>
---
 include/acpi/acpi_bus.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
include/acpi/acpi_bus.h +1 -1
index d11eff8..0f131d2 100644
@@ -407,7 +407,7 @@ static inline bool acpi_check_dma(struct acpi_device *adev, bool *coherent)
 	 * case 1. Do not support and disable DMA.
 	 * case 2. Support but rely on arch-specific cache maintenance for
 	 *         non-coherence DMA operations.
-	 * Currently, we implement case 1 above.
+	 * Currently, we implement case 2 above.
 	 *
 	 * For the case when _CCA is missing (i.e. cca_seen=0) and
 	 * platform specifies ACPI_CCA_REQUIRED, we do not support DMA,

include/acpi/acpi_bus.h static inline bool acpi_check_dma(struct acpi_device *adev, bool *coherent) · line 422

Quoted 9 lines
include/acpi/acpi_bus.h +2 -1
@@ -415,7 +415,8 @@ static inline bool acpi_check_dma(struct acpi_device *adev, bool *coherent)
 	 *
 	 * See acpi_init_coherency() for more info.
 	 */
-	if (adev->flags.coherent_dma) {
+	if (adev->flags.coherent_dma ||
+	    (adev->flags.cca_seen && IS_ENABLED(CONFIG_ARM64))) {
 		ret = true;
 		if (coherent)
 			*coherent = adev->flags.coherent_dma;

Hi Suravee,

The acpi_check_dma function has been removed in patch 6 of this patch set, why it is still be used here, am I missing something? If the acpi_check_dma will be used in the future, personally I'd like to use IS_ENABLED(CONFIG_ACPI_CCA_REQUIRED) while not CONFIG_ARM64 macro here, or since _CCA attribute is arch-specific, it's reasonable to leave the _CCA handling policy to the arch-specific code. For example, with a link weak function like acpi_arch_check_dma() as a default handling if no arch-specific code provided, the actual _CCA handling will be implemented in the ARM, Intel or other Arch if required.

Thanks,
Dennis

Quoted 9 lines
Signature · 7 lines
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
#1 lore raw

Hi Dennis,

Quoted 45 lines · Dennis Chen
Quoted 32 lines · Suravee Suthikulpanit

From: Jeremy Linton <[email protected]>

ACPI configurations can now mark devices as noncoherent, support that choice.

NOTE: This is required to support USB on ARM Juno Development Board.

CC Bjorn Helgaas <[email protected]>
CC Catalin Marinas <[email protected]>
CC Rob Herring <[email protected]>
CC Will Deacon <[email protected]>
CC Rafael J. Wysocki <[email protected]>
---
  include/acpi/acpi_bus.h | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
include/acpi/acpi_bus.h +1 -1
index d11eff8..0f131d2 100644
@@ -407,7 +407,7 @@ static inline bool acpi_check_dma(struct acpi_device *adev, bool *coherent)
  	 * case 1. Do not support and disable DMA.
  	 * case 2. Support but rely on arch-specific cache maintenance for
  	 *         non-coherence DMA operations.
-	 * Currently, we implement case 1 above.
+	 * Currently, we implement case 2 above.
  	 *
  	 * For the case when _CCA is missing (i.e. cca_seen=0) and
  	 * platform specifies ACPI_CCA_REQUIRED, we do not support DMA,

include/acpi/acpi_bus.h static inline bool acpi_check_dma(struct acpi_device *adev, bool *coherent) · line 422

Quoted 9 lines
include/acpi/acpi_bus.h +2 -1
@@ -415,7 +415,8 @@ static inline bool acpi_check_dma(struct acpi_device *adev, bool *coherent)
  	 *
  	 * See acpi_init_coherency() for more info.
  	 */
-	if (adev->flags.coherent_dma) {
+	if (adev->flags.coherent_dma ||
+	    (adev->flags.cca_seen && IS_ENABLED(CONFIG_ARM64))) {
  		ret = true;
  		if (coherent)
  			*coherent = adev->flags.coherent_dma;

Hi Suravee,

Quoted 2 lines

The acpi_check_dma function has been removed in patch 6 of this patch set, why it is still be used here, am I missing something? If the acpi_check_dma will be used in the future, personally I'd like

I think this patch just to let people know that there is case that arch-specific cache maintenance is still needed for ACPI (such as Juno board), and in the later patches will cover this case.

acpi_check_dma() will be replaced by acpi_get_dma_attr(), and in acpi_get_dma_attr() will cover that case and will be easily understood. (Suravee, correct me if I'm wrong :) )

Quoted 4 lines

to use IS_ENABLED(CONFIG_ACPI_CCA_REQUIRED) while not CONFIG_ARM64 macro here, or since _CCA attribute is arch-specific, it's reasonable to leave the _CCA handling policy to the arch-specific code. For example, with a link weak function like acpi_arch_check_dma() as a default handling if no arch-specific code provided, the actual _CCA handling will be implemented in the ARM, Intel or other Arch if required.

Actually Intel platform don't need _CCA and it's coherent in default, since _CCA is in ACPI spec, I would like it's handled in ACPI core.

Thanks
Hanjun

#2 lore raw

Hi Dennis / Hanjun,

Quoted 56 lines · Hanjun Guo

Hi Dennis,

Quoted 48 lines · Dennis Chen
Quoted 42 lines · Suravee Suthikulpanit

From: Jeremy Linton <[email protected]>

ACPI configurations can now mark devices as noncoherent, support that choice.

NOTE: This is required to support USB on ARM Juno Development Board.

CC Bjorn Helgaas <[email protected]>
CC Catalin Marinas <[email protected]>
CC Rob Herring <[email protected]>
CC Will Deacon <[email protected]>
CC Rafael J. Wysocki <[email protected]>
---
  include/acpi/acpi_bus.h | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
include/acpi/acpi_bus.h +1 -1
index d11eff8..0f131d2 100644
@@ -407,7 +407,7 @@ static inline bool acpi_check_dma(struct
 acpi_device *adev, bool *coherent)
       * case 1. Do not support and disable DMA.
       * case 2. Support but rely on arch-specific cache maintenance for
       *         non-coherence DMA operations.
-     * Currently, we implement case 1 above.
+     * Currently, we implement case 2 above.
       *
       * For the case when _CCA is missing (i.e. cca_seen=0) and

* platform specifies ACPI_CCA_REQUIRED, we do not support DMA,

include/acpi/acpi_bus.h +2 -1
@@ -415,7 +415,8 @@ static inline bool acpi_check_dma(struct
 acpi_device *adev, bool *coherent)
       *
       * See acpi_init_coherency() for more info.
       */
-    if (adev->flags.coherent_dma) {
+    if (adev->flags.coherent_dma ||
+        (adev->flags.cca_seen && IS_ENABLED(CONFIG_ARM64))) {
          ret = true;
          if (coherent)
Quoted 1 line
              *coherent = adev->flags.coherent_dma;

Hi Suravee,

Quoted 4 lines

The acpi_check_dma function has been removed in patch 6 of this patch set, why it is still be used
here, am I missing something? If the acpi_check_dma will be used in the future, personally I'd like

Quoted 8 lines

I think this patch just to let people know that there is case that arch-specific cache maintenance is still needed for ACPI (such as Juno board), and in the later patches will cover this case.

acpi_check_dma() will be replaced by acpi_get_dma_attr(), and in acpi_get_dma_attr() will cover that case and will be easily understood. (Suravee, correct me if I'm wrong :) )

Thanks Hanjun for filling in the info.

Yes, this is mainly to document the logic changes required by Juno, which would be more clear than just merging this change in the later patch.

Quoted 2 lines
Quoted 2 lines

to use IS_ENABLED(CONFIG_ACPI_CCA_REQUIRED) while not CONFIG_ARM64 macro here,

We could have used CONFIG_ACPI_CCA_REQUIRED here, but this will be replaced by logic in patch 5, and removed in patch 6 anyways. So, I think it is okay. Eventually, the rest of the logic will be using CONFIG_ACPI_CCA_REQUIRED.

or since _CCA attribute

Quoted 7 lines
Quoted 6 lines

is arch-specific, it's reasonable to leave the _CCA handling policy to the arch-specific code. For example,
with a link weak function like acpi_arch_check_dma() as a default handling if no arch-specific code
provided, the actual _CCA handling will be implemented in the ARM, Intel or other Arch if required.

Quoted 6 lines

Actually Intel platform don't need _CCA and it's coherent in default, since _CCA is in ACPI spec, I would like it's handled in ACPI core.

Thanks
Hanjun

I also agree with Hanjun that the CCA parsing should be handled by the ACPI core driver. Since we are using the CONFIG_ACPI_CCA_REQUIRED, we should not need to have arch-specific code. If the ACPI spec gets more complicate in the future, we can revisit this. :)

Thanks,
Suravee

#3 lore raw
Quoted 68 lines · Suravee Suthikulanit

Hi Dennis / Hanjun,

Quoted 56 lines · Hanjun Guo

Hi Dennis,

Quoted 48 lines · Dennis Chen
Quoted 42 lines · Suravee Suthikulpanit

From: Jeremy Linton <[email protected]>

ACPI configurations can now mark devices as noncoherent, support that choice.

NOTE: This is required to support USB on ARM Juno Development Board.

CC Bjorn Helgaas <[email protected]>
CC Catalin Marinas <[email protected]>
CC Rob Herring <[email protected]>
CC Will Deacon <[email protected]>
CC Rafael J. Wysocki <[email protected]>
---
 include/acpi/acpi_bus.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
include/acpi/acpi_bus.h +1 -1
index d11eff8..0f131d2 100644
@@ -407,7 +407,7 @@ static inline bool acpi_check_dma(struct
 acpi_device *adev, bool *coherent)
      * case 1. Do not support and disable DMA.
      * case 2. Support but rely on arch-specific cache maintenance for
      *         non-coherence DMA operations.
-     * Currently, we implement case 1 above.
+     * Currently, we implement case 2 above.
      *
      * For the case when _CCA is missing (i.e. cca_seen=0) and

* platform specifies ACPI_CCA_REQUIRED, we do not support DMA,

include/acpi/acpi_bus.h +2 -1
@@ -415,7 +415,8 @@ static inline bool acpi_check_dma(struct
 acpi_device *adev, bool *coherent)
      *
      * See acpi_init_coherency() for more info.
      */
-    if (adev->flags.coherent_dma) {
+    if (adev->flags.coherent_dma ||
+        (adev->flags.cca_seen && IS_ENABLED(CONFIG_ARM64))) {
         ret = true;
         if (coherent)
Quoted 1 line
             *coherent = adev->flags.coherent_dma;

Hi Suravee,

Quoted 4 lines

The acpi_check_dma function has been removed in patch 6 of this patch set, why it is still be used
here, am I missing something? If the acpi_check_dma will be used in the future, personally I'd like

Quoted 8 lines

I think this patch just to let people know that there is case that arch-specific cache maintenance is still needed for ACPI (such as Juno board), and in the later patches will cover this case.

acpi_check_dma() will be replaced by acpi_get_dma_attr(), and in acpi_get_dma_attr() will cover that case and will be easily understood. (Suravee, correct me if I'm wrong :) )

Quoted 6 lines

Thanks Hanjun for filling in the info.

Yes, this is mainly to document the logic changes required by Juno, which would be more clear than just merging this change in the later patch.

Clear.

Quoted 20 lines
Quoted 2 lines
Quoted 2 lines

to use IS_ENABLED(CONFIG_ACPI_CCA_REQUIRED) while not CONFIG_ARM64 macro here,

We could have used CONFIG_ACPI_CCA_REQUIRED here, but this will be replaced by logic in patch 5, and removed in patch 6 anyways. So, I think it is okay. Eventually, the rest of the logic will be using CONFIG_ACPI_CCA_REQUIRED.

or since _CCA attribute

Quoted 11 lines
Quoted 6 lines

is arch-specific, it's reasonable to leave the _CCA handling policy to the arch-specific code. For example,
with a link weak function like acpi_arch_check_dma() as a default handling if no arch-specific code
provided, the actual _CCA handling will be implemented in the ARM, Intel or other Arch if required.

Actually Intel platform don't need _CCA and it's coherent in default, since _CCA is in ACPI spec, I would like it's handled in ACPI core.

Quoted 9 lines
Quoted 2 lines

Thanks
Hanjun

I also agree with Hanjun that the CCA parsing should be handled by the ACPI core driver. Since we are using the CONFIG_ACPI_CCA_REQUIRED, we should not need to have arch-specific code. If the ACPI spec gets more complicate in the future, we can revisit this. :)

Hmm, seems I have no objection currently if we only think about intel and arm arch. Things maybe a little bit complicated if more Archs becomes ACPI awareness, if any. Good to see the patch set upstream soon :) Thank you Suravee and Hanjun.

Quoted 3 lines

Thanks,
Suravee