Skip to contentSkip to conversation

b43: removal of B43_PCMCIA

DISCUSSION Valentin Rothberg 2 participants 2 messages Nov 2, 2015

lore
Share & tools
lore
#0 lore raw

Hi Rafal,

your commit 399500da18f7 ("ssb: pick PCMCIA host code support from b43 driver") has shown up in today's Linux next tree (i.e., next-20151102) and removes the Kconfig option B43_PCMCIA and references on it in the code. However the commit misses to remove the following reference:

drivers/net/wireless/b43/main.c:5829:#ifdef CONFIG_B43_PCMCIA
drivers/net/wireless/b43/main.c-5830- feat_pcmcia = "M";
drivers/net/wireless/b43/main.c-5831-#endif

Is it by purpose? In case not, I can send a trivial patch to remove those three lines.

I detected the issue with scripts/checkkconfigsymbols.py.

Kind regards,
Valentin

#1 lore raw
Quoted 5 lines · Valentin Rothberg

your commit 399500da18f7 ("ssb: pick PCMCIA host code support from b43 driver") has shown up in today's Linux next tree (i.e., next-20151102) and removes the Kconfig option B43_PCMCIA and references on it in the code. However the commit misses to remove the following reference:

Quoted 8 lines

drivers/net/wireless/b43/main.c:5829:#ifdef CONFIG_B43_PCMCIA
drivers/net/wireless/b43/main.c-5830- feat_pcmcia = "M";
drivers/net/wireless/b43/main.c-5831-#endif

Is it by purpose? In case not, I can send a trivial patch to remove those three lines.

I detected the issue with scripts/checkkconfigsymbols.py.

Nice catch, please remove that line from main.c.

Signature · 1 line
Rafał