Skip to contentSkip to conversation

qed: Add link support

DISCUSSION Dan Carpenter 1 participant 1 message Nov 3, 2015 Kernel janitors

lore
Share & tools
lore
#0 lore raw

Hello Yuval Mintz,

The patch cc875c2e4f34: "qed: Add link support" from Oct 26, 2015, leads to the following static checker warning:

drivers/net/ethernet/qlogic/qed/qed_main.c:940 qed_set_link()
warn: bitwise AND condition is false here

drivers/net/ethernet/qlogic/qed/qed_main.c
925 link_params = qed_mcp_get_link_params(hwfn);
926 if (params->override_flags & QED_LINK_OVERRIDE_SPEED_AUTONEG)
927 link_params->speed.autoneg = params->autoneg;
928 if (params->override_flags & QED_LINK_OVERRIDE_SPEED_ADV_SPEEDS) {
929 link_params->speed.advertised_speeds = 0;
930 if ((params->adv_speeds & SUPPORTED_1000baseT_Half) ||
931 (params->adv_speeds & SUPPORTED_1000baseT_Full))
932 link_params->speed.advertised_speeds | 933 NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_1G;
934 if (params->adv_speeds & SUPPORTED_10000baseKR_Full)
935 link_params->speed.advertised_speeds | 936 NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_10G;
937 if (params->adv_speeds & SUPPORTED_40000baseLR4_Full)
938 link_params->speed.advertised_speeds | 939 NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_40G;
940 if (params->adv_speeds & 0)

                            ^^^^^^^^^^^^^^^^^^^^^^

False.

941 link_params->speed.advertised_speeds | 942 NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_50G;
943 if (params->adv_speeds & 0)

                            ^^^^^^^^^^^^^^^^^^^^^^

False.

944 link_params->speed.advertised_speeds | 945 NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_100G;
946 }

regards,
dan carpenter