Skip to contentSkip to conversation

boost: fix sparc64 compile, set the correct instruction-set

PATCH New Waldemar Brodkorb 2 participants 4 messages Nov 3, 2015 – Nov 8, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 boost: fix sparc64 compile, set the correct instruction-set

The default for sparc is v7, which doesn't work for sparc64. Use ultrasparc for sparc64.
Fixes following autobuild errors:
http://autobuild.buildroot.net/results/0cad0a6eddc153098bb6d1501afd1cf4a57a82d1/

---
 package/boost/boost.mk |    4 ++++
 1 file changed, 4 insertions(+)
package/boost/boost.mk +4 -0
index 80325b0..d91baf1 100644
@@ -89,6 +89,10 @@ BOOST_OPTS += toolset=gcc \
 	     abi=$(BOOST_ABI) \
 	     variant=$(if $(BR2_ENABLE_DEBUG),debug,release)
 
+ifeq ($(BR2_sparc64),y)
+BOOST_OPTS += architecture=sparc instruction-set=ultrasparc
+endif
+
 # By default, Boost build and installs both the shared and static
 # variants. Override that if we want static only or shared only.
 ifeq ($(BR2_STATIC_LIBS),y)
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 boost: fix sparc64 compile, set the correct instruction-set

Dear Waldemar Brodkorb,

package/boost/boost.mk BOOST_OPTS += toolset=gcc \ · line 94

Quoted 3 lines · Waldemar Brodkorb
package/boost/boost.mk +3 -0
+ifeq ($(BR2_sparc64),y)
+BOOST_OPTS += architecture=sparc instruction-set=ultrasparc
+endif

We're not setting architecture= nor instruction-set= for any other architecture. Should we do so ?

Should the instruction-set be set to BR2_GCC_TARGET_TUNE ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 boost: fix sparc64 compile, set the correct instruction-set

Hi,
Thomas Petazzoni wrote,

Quoted 4 lines

Dear Waldemar Brodkorb,

On Tue, 3 Nov 2015 22:03:14 +0100, Waldemar Brodkorb wrote:

Quoted 8 lines

package/boost/boost.mk BOOST_OPTS += toolset=gcc \ · line 94

Quoted 3 lines
package/boost/boost.mk +3 -0
+ifeq ($(BR2_sparc64),y)
+BOOST_OPTS += architecture=sparc instruction-set=ultrasparc
+endif

We're not setting architecture= nor instruction-set= for any other architecture. Should we do so ?

Should the instruction-set be set to BR2_GCC_TARGET_TUNE ?

You mean BR2_GCC_TARGET_CPU? No, because leon3 is not set in boost.

To do minimal damage to other architectures, I would just set it for sparc/sparc64. The boost architecture does not always match the buildroot architecture name. (f.e. ppc is power)

I think 0003-Remove-bogus-c3-cpu-varant-for-SPARC.patch could be removed, when a correct setting is used for sparc32.

best regards
Waldemar

#3 lore raw

PATCH 1/1 boost: fix sparc64 compile, set the correct instruction-set

In reply to Waldemar Brodkorb

Dear Waldemar Brodkorb,

Quoted 9 lines · Waldemar Brodkorb

The default for sparc is v7, which doesn't work for sparc64. Use ultrasparc for sparc64.
Fixes following autobuild errors:
http://autobuild.buildroot.net/results/0cad0a6eddc153098bb6d1501afd1cf4a57a82d1/

---
 package/boost/boost.mk |    4 ++++
 1 file changed, 4 insertions(+)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com