pkg-generic: use correct variable name for tar extraction exclusions
PATCH 1/1 pkg-generic: use correct variable name for tar extraction exclusions
The only users of this feature are in package/gcc, but they were using $(2)_TAR_EXCLUDES instead of pkg-generic's $(2)_EXCLUDES. The former name makes more sense to me and is more readable, so let's just use that.
--- package/pkg-generic.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-generic.mk +1 -1
@@ -519,7 +519,7 @@ $(2)_EXTRACT_CMDS ?= \ $$(if $$($(2)_SOURCE),$$(INFLATE$$(suffix $$($(2)_SOURCE))) $$(DL_DIR)/$$($(2)_SOURCE) | \ $$(TAR) --strip-components=$$($(2)_STRIP_COMPONENTS) \ -C $$($(2)_DIR) \ - $$(foreach x,$$($(2)_EXCLUDES),--exclude='$$(x)' ) \ + $$(foreach x,$$($(2)_TAR_EXCLUDES),--exclude='$$(x)' ) \ $$(TAR_OPTIONS) -) # pre/post-steps hooks
Signature · 1 line
2.6.2
PATCH 1/1 pkg-generic: use correct variable name for tar extraction exclusions
Dear Steven Noonan,
Quoted 5 lines · Steven Noonan
The only users of this feature are in package/gcc, but they were using $(2)_TAR_EXCLUDES instead of pkg-generic's $(2)_EXCLUDES. The former name makes more sense to me and is more readable, so let's just use that.
Signed-off-by Steven Noonan <[email protected]>
Thanks for your patch. However, following your initial report, I had already fixed the problem. Moreover, your patch was making things work for gcc, but 1/ was breaking things for the external toolchain code which uses <pkg>_EXCLUDES and 2/ was not updating the Buildroot manual accordingly.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com