qlogic: qed: fix a test for MODE_MF_SI

PATCH Applied Dan Carpenter 3 participants 3 messages Nov 4, 2015 – Nov 5, 2015

Subsystems (4)

Networking Network drivers Kernel janitors QLogic QL4xxx Ethernet driver

lore

Share & tools

lore

Dan Carpenter

author

2015-11-04 13:29 UTC #0 lore raw

PATCH 1/1 qlogic: qed: fix a test for MODE_MF_SI

MODE_MF_SI is 9. We should be testing bit 9 instead of AND 0x9.

Fixes fe56b9e6a8d9 ('qed: Add module with basic common support')

Signed-off-by Dan Carpenter <[email protected]>

drivers/net/ethernet/qlogic/qed/qed_dev.c +1 -1

index b9b7b7e..774b223 100644
@@ -562,7 +562,7 @@ static int qed_hw_init_pf(struct qed_hwfn *p_hwfn,
 	}
 
 	/* Enable classification by MAC if needed */
-	if (hw_mode & MODE_MF_SI) {
+	if (hw_mode & (1 << MODE_MF_SI)) {
 		DP_VERBOSE(p_hwfn, NETIF_MSG_HW,
 			   "Configuring TAGMAC_CLS_TYPE\n");
 		STORE_RT_REG(p_hwfn,

Yuval Mintz

Acked-by on v1 1/1

2015-11-04 13:35 UTC #1 lore raw

Quoted 4 lines

MODE_MF_SI is 9. We should be testing bit 9 instead of AND 0x9.
Fixes fe56b9e6a8d9 ('qed: Add module with basic common support')
Signed-off-by Dan Carpenter <[email protected]>

True indeed. Thanks.

Acked-by Yuval Mintz <[email protected]>

David Miller

maintainer Applied

2015-11-05 03:06 UTC #2 lore raw

In reply to Dan Carpenter

From: Dan Carpenter <[email protected]>
Date: Wed, 4 Nov 2015 16:29:11 +0300

Quoted 4 lines

MODE_MF_SI is 9. We should be testing bit 9 instead of AND 0x9.
Fixes fe56b9e6a8d9 ('qed: Add module with basic common support')
Signed-off-by Dan Carpenter <[email protected]>

Applied.