Skip to contentSkip to conversation

VLC: depends on gst-plugins-bad only if gst is enabled

PATCH In review Rafaël Carré 3 participants 12 messages Nov 4, 2015 – Nov 6, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 VLC: depends on gst-plugins-bad only if gst is enabled

---
 meta-multimedia/recipes-multimedia/vlc/vlc.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta-multimedia/recipes-multimedia/vlc/vlc.inc +2 -2
index ee90ac8..b989849 100644
@@ -5,7 +5,7 @@ SECTION = "multimedia"
 LICENSE = "GPL-2.0"
 LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
-DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native gst-plugins-bad \
+DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
    virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
    tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
    libdvdcss libdvdread lua-native lua libidn libnotify gtk+ gnome-vfs \
@@ -54,7 +54,7 @@ PACKAGECONFIG[postproc] = "--enable-postproc,--disable-postproc,libpostproc"
 PACKAGECONFIG[opencv] = "--enable-opencv,--disable-opencv,opencv"
 PACKAGECONFIG[libva] = "--enable-libva --enable-avcodec,--disable-libva --disable-avcodec,libva libav"
 PACKAGECONFIG[speex] = "--enable-speex,--disable-speex,speex"
-PACKAGECONFIG[gstreamer] = "--enable-gst-decode,--disable-gst-decode,gstreamer1.0 gstreamer1.0-plugins-base"
+PACKAGECONFIG[gstreamer] = "--enable-gst-decode,--disable-gst-decode,gstreamer1.0 gstreamer1.0-plugins-base gst-plugins-bad"
 PACKAGECONFIG[vpx] = "--enable-vpx,--disable-vpx, libvpx"
 PACKAGECONFIG[qt4] = "--enable-qt,--disable-qt, qt4-x11-free"
 PACKAGECONFIG[freerdp] = "--enable-freerdp,--disable-freerdp, freerdp"
Signature · 1 line
2.5.0
#1 lore raw

PATCH 2/3 VLC: make libnotify a configurable dependency

---
 meta-multimedia/recipes-multimedia/vlc/vlc.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta-multimedia/recipes-multimedia/vlc/vlc.inc +2 -1
index b989849..ad5c81d 100644
@@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
    virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
    tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
-   libdvdcss libdvdread lua-native lua libidn libnotify gtk+ gnome-vfs \
+   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
    libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
    libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
    tiff xcb-util-keysyms samba"
@@ -58,6 +58,7 @@ PACKAGECONFIG[gstreamer] = "--enable-gst-decode,--disable-gst-decode,gstreamer1.
 PACKAGECONFIG[vpx] = "--enable-vpx,--disable-vpx, libvpx"
 PACKAGECONFIG[qt4] = "--enable-qt,--disable-qt, qt4-x11-free"
 PACKAGECONFIG[freerdp] = "--enable-freerdp,--disable-freerdp, freerdp"
+PACKAGECONFIG[notify] = "--enable-notify,--disable-notify, libnotify gtk+"
 
 do_configure_prepend() {
     cp ${STAGING_DATADIR}/libtool/config.* ${S}/autotools/ || true
Signature · 1 line
2.5.0
#2 lore raw

Re: [meta-multimedia][PATCH 2/3] VLC: make libnotify a configurable dependency

Quoted 18 lines · Rafaël Carré
---
 meta-multimedia/recipes-multimedia/vlc/vlc.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta-multimedia/recipes-multimedia/vlc/vlc.inc +1 -1
index b989849..ad5c81d 100644
@@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
    virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
    tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
-   libdvdcss libdvdread lua-native lua libidn libnotify gtk+ gnome-vfs \
+   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
    libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
    libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
    tiff xcb-util-keysyms samba"

meta-multimedia/recipes-multimedia/vlc/vlc.inc PACKAGECONFIG[gstreamer] = "--enable-gst-decode,--disable-gst-decode,gstreamer1. · line 61

Quoted 4 lines
meta-multimedia/recipes-multimedia/vlc/vlc.inc +1 -0
@@ -58,6 +58,7 @@ PACKAGECONFIG[gstreamer] = "--enable-gst-decode,--disable-gst-decode,gstreamer1.
 PACKAGECONFIG[vpx] = "--enable-vpx,--disable-vpx, libvpx"
 PACKAGECONFIG[qt4] = "--enable-qt,--disable-qt, qt4-x11-free"
 PACKAGECONFIG[freerdp] = "--enable-freerdp,--disable-freerdp, freerdp"
+PACKAGECONFIG[notify] = "--enable-notify,--disable-notify, libnotify gtk+"

Removing gtk+ from DEPENDS causes even more undeterministic dependencies:

vlc-2.2.1: vlc: configure was passed unrecognised options:
--disable-gnome-vfs [unknown-configure-option]
vlc-2.2.1: vlc rdepends on fontconfig, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on pixman, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on freetype, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libupnp, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on pango, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libvorbis, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on cairo, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libavc1394, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on harfbuzz, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libssh2, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on gdk-pixbuf, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on gnome-vfs, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libcroco, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libdvdnav, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on librsvg, but it isn't a build dependency? [build-deps]

Quoted 11 lines
meta-multimedia/recipes-multimedia/vlc/vlc.inc +0 -0
 do_configure_prepend() {
     cp ${STAGING_DATADIR}/libtool/config.* ${S}/autotools/ || true
Signature · 7 lines
2.5.0

-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#3 lore raw

Re: [meta-multimedia][PATCH 2/3] VLC: make libnotify a configurable dependency

Quoted 18 lines · Martin Jansa
Quoted 17 lines · Rafaël Carré
---
 meta-multimedia/recipes-multimedia/vlc/vlc.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta-multimedia/recipes-multimedia/vlc/vlc.inc +1 -1
index b989849..ad5c81d 100644
@@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
    virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
    tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
-   libdvdcss libdvdread lua-native lua libidn libnotify gtk+ gnome-vfs \
+   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
    libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
    libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
    tiff xcb-util-keysyms samba"
Quoted 8 lines

meta-multimedia/recipes-multimedia/vlc/vlc.inc PACKAGECONFIG[gstreamer] = "--enable-gst-decode,--disable-gst-decode,gstreamer1. · line 61

Quoted 5 lines
meta-multimedia/recipes-multimedia/vlc/vlc.inc +1 -0
@@ -58,6 +58,7 @@ PACKAGECONFIG[gstreamer] = "--enable-gst-decode,--disable-gst-decode,gstreamer1.
 PACKAGECONFIG[vpx] = "--enable-vpx,--disable-vpx, libvpx"
 PACKAGECONFIG[qt4] = "--enable-qt,--disable-qt, qt4-x11-free"
 PACKAGECONFIG[freerdp] = "--enable-freerdp,--disable-freerdp, freerdp"
+PACKAGECONFIG[notify] = "--enable-notify,--disable-notify, libnotify gtk+"

Removing gtk+ from DEPENDS causes even more undeterministic dependencies:

I would guess those real dependencies were hidden by gtk+ which depends on every single one of them.

Except maybe vorbis which was hidden by gstreamer plugins?

I agree that although depending on gtk+ is not fully nice neither correct, it makes
things deterministic.

So I guess I should rather add all the PACKAGECONFIG for these modules first and then move
those dependencies to their respective PACKAGECONFIG ?

How is your jenkins instance built: world first, then VLC ?

Should I check for additional automatic dependencies inside VLC or assume that
the list below is exhaustive?

Quoted 36 lines

vlc-2.2.1: vlc: configure was passed unrecognised options:
--disable-gnome-vfs [unknown-configure-option]
vlc-2.2.1: vlc rdepends on fontconfig, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on pixman, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on freetype, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libupnp, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on pango, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libvorbis, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on cairo, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libavc1394, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on harfbuzz, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libssh2, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on gdk-pixbuf, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on gnome-vfs, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libcroco, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libdvdnav, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on librsvg, but it isn't a build dependency? [build-deps]

Quoted 3 lines
meta-multimedia/recipes-multimedia/vlc/vlc.inc +0 -0
 do_configure_prepend() {
     cp ${STAGING_DATADIR}/libtool/config.* ${S}/autotools/ || true
#4 lore raw

Re: [meta-multimedia][PATCH 2/3] VLC: make libnotify a configurable dependency

Quoted 33 lines · Rafaël Carré
Quoted 18 lines · Martin Jansa
Quoted 17 lines · Rafaël Carré
---
 meta-multimedia/recipes-multimedia/vlc/vlc.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta-multimedia/recipes-multimedia/vlc/vlc.inc +1 -1
index b989849..ad5c81d 100644
@@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
    virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
    tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
-   libdvdcss libdvdread lua-native lua libidn libnotify gtk+ gnome-vfs \
+   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
    libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
    libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
    tiff xcb-util-keysyms samba"
Quoted 8 lines

meta-multimedia/recipes-multimedia/vlc/vlc.inc PACKAGECONFIG[gstreamer] = "--enable-gst-decode,--disable-gst-decode,gstreamer1. · line 61

Quoted 5 lines
meta-multimedia/recipes-multimedia/vlc/vlc.inc +1 -0
@@ -58,6 +58,7 @@ PACKAGECONFIG[gstreamer] = "--enable-gst-decode,--disable-gst-decode,gstreamer1.
 PACKAGECONFIG[vpx] = "--enable-vpx,--disable-vpx, libvpx"
 PACKAGECONFIG[qt4] = "--enable-qt,--disable-qt, qt4-x11-free"
 PACKAGECONFIG[freerdp] = "--enable-freerdp,--disable-freerdp, freerdp"
+PACKAGECONFIG[notify] = "--enable-notify,--disable-notify, libnotify gtk+"

Removing gtk+ from DEPENDS causes even more undeterministic dependencies:

I would guess those real dependencies were hidden by gtk+ which depends on every single one of them.

Except maybe vorbis which was hidden by gstreamer plugins?

Quoted 8 lines

I agree that although depending on gtk+ is not fully nice neither correct, it makes
things deterministic.

So I guess I should rather add all the PACKAGECONFIG for these modules first and then move
those dependencies to their respective PACKAGECONFIG ?

yes

Quoted 2 lines

How is your jenkins instance built: world first, then VLC ?

No, only in test-dependencies builds, this was just incremental world build, so the list doesn't have to be complete.

Quoted 3 lines

Should I check for additional automatic dependencies inside VLC or assume that
the list below is exhaustive?

It will cover most (maybe all) of them, because there weren't many changes in last increment, so it's a bit more likely that other recipes were already reused from sstate before vlc (one of recipes with modification) was built.

To test it properly I would need to run test-dependencies job, but that takes too long I cannot spare now when jethro release is close.

Regards,

Quoted 41 lines
Quoted 36 lines

vlc-2.2.1: vlc: configure was passed unrecognised options:
--disable-gnome-vfs [unknown-configure-option]
vlc-2.2.1: vlc rdepends on fontconfig, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on pixman, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on freetype, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libupnp, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on pango, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libvorbis, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on cairo, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libavc1394, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on harfbuzz, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libssh2, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on gdk-pixbuf, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on gnome-vfs, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libcroco, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on libdvdnav, but it isn't a build dependency? [build-deps]
vlc-2.2.1: vlc rdepends on librsvg, but it isn't a build dependency? [build-deps]

Quoted 3 lines
meta-multimedia/recipes-multimedia/vlc/vlc.inc +0 -0
 do_configure_prepend() {
     cp ${STAGING_DATADIR}/libtool/config.* ${S}/autotools/ || true
Signature · 4 lines
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#5 lore raw

Re: [meta-multimedia][PATCH 2/3] VLC: make libnotify a configurable dependency

Quoted 46 lines · Martin Jansa
Quoted 7 lines · Rafaël Carré
Quoted 6 lines · Martin Jansa

Review

Quoted 5 lines · Rafaël Carré
---
 meta-multimedia/recipes-multimedia/vlc/vlc.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/meta-multimedia/recipes-multimedia/vlc/vlc.inc

Quoted 4 lines
Quoted 4 lines

meta-multimedia/recipes-multimedia/vlc/vlc.inc LIC_FILES_CHKSUM =

Quoted 4 lines

index b989849..ad5c81d 100644

meta-multimedia/recipes-multimedia/vlc/vlc.inc +0 -0
@@ -8,7 +8,7 @@ LIC_FILES_CHKSUM =

"file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"

Quoted 4 lines
Quoted 4 lines

meta-multimedia/recipes-multimedia/vlc/vlc.inc LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"

Quoted 4 lines
meta-multimedia/recipes-multimedia/vlc/vlc.inc +0 -1
 DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
    virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
    tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
-   libdvdcss libdvdread lua-native lua libidn libnotify gtk+

gnome-vfs \

Quoted 5 lines
Quoted 5 lines

meta-multimedia/recipes-multimedia/vlc/vlc.inc PACKAGECONFIG[gstreamer] =

Quoted 5 lines
meta-multimedia/recipes-multimedia/vlc/vlc.inc +1 -0
+   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
    libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
    libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
    tiff xcb-util-keysyms samba"
@@ -58,6 +58,7 @@ PACKAGECONFIG[gstreamer] =

"--enable-gst-decode,--disable-gst-decode,gstreamer1.

Quoted 3 lines
Quoted 3 lines

meta-multimedia/recipes-multimedia/vlc/vlc.inc PACKAGECONFIG[gstreamer] = "--enable-gst-decode,--disable-gst-decode,gstreamer1.

Quoted 3 lines
meta-multimedia/recipes-multimedia/vlc/vlc.inc +0 -0
 PACKAGECONFIG[vpx] = "--enable-vpx,--disable-vpx, libvpx"
 PACKAGECONFIG[qt4] = "--enable-qt,--disable-qt, qt4-x11-free"
 PACKAGECONFIG[freerdp] = "--enable-freerdp,--disable-freerdp,

freerdp"

Quoted 1 line
Quoted 1 line

meta-multimedia/recipes-multimedia/vlc/vlc.inc PACKAGECONFIG[gstreamer] = · line 61

Quoted 1 line
meta-multimedia/recipes-multimedia/vlc/vlc.inc +1 -0
+PACKAGECONFIG[notify] = "--enable-notify,--disable-notify, libnotify

gtk+"

Quoted 5 lines
Quoted 3 lines

Removing gtk+ from DEPENDS causes even more undeterministic dependencies:

I would guess those real dependencies were hidden by gtk+ which depends

on

Quoted 9 lines

every single one of them.

Except maybe vorbis which was hidden by gstreamer plugins?

I agree that although depending on gtk+ is not fully nice neither correct, it makes
things deterministic.

Quoted 7 lines
Quoted 3 lines

So I guess I should rather add all the PACKAGECONFIG for these modules first and then move
those dependencies to their respective PACKAGECONFIG ?

yes

There are 112 AC_ARG_ENABLE clauses in configure.ac

<https://github.com/videolan/vlc/blob/master/configure.ac>... but adding PACKAGECONFIG for those that make sense has been on my list of TODO for a long time. Not all of them apply to our usage (winstore_app for instance). Testing all those options is one of the things that has held me back...so the approach of fixing what becomes broken has been the easier route.

At least there aren't a large amount of PKG_CHECK_MODULES which leads to endless patches to make it deterministic which other upstreams have zero interest in applying.

--Tim

#6 lore raw

Re: [meta-multimedia][PATCH 2/3] VLC: make libnotify a configurable dependency

Quoted 62 lines · Tim Orling
Quoted 46 lines · Martin Jansa
Quoted 7 lines · Rafaël Carré
Quoted 6 lines · Martin Jansa

Review

Quoted 5 lines · Rafaël Carré
---
 meta-multimedia/recipes-multimedia/vlc/vlc.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/meta-multimedia/recipes-multimedia/vlc/vlc.inc

Quoted 4 lines
Quoted 4 lines

meta-multimedia/recipes-multimedia/vlc/vlc.inc LIC_FILES_CHKSUM =

Quoted 4 lines

index b989849..ad5c81d 100644

meta-multimedia/recipes-multimedia/vlc/vlc.inc +0 -0
@@ -8,7 +8,7 @@ LIC_FILES_CHKSUM =

"file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"

Quoted 4 lines
Quoted 4 lines

meta-multimedia/recipes-multimedia/vlc/vlc.inc LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"

Quoted 4 lines
meta-multimedia/recipes-multimedia/vlc/vlc.inc +0 -1
 DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
    virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
    tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
-   libdvdcss libdvdread lua-native lua libidn libnotify gtk+

gnome-vfs \

Quoted 5 lines
Quoted 5 lines

meta-multimedia/recipes-multimedia/vlc/vlc.inc PACKAGECONFIG[gstreamer] =

Quoted 5 lines
meta-multimedia/recipes-multimedia/vlc/vlc.inc +1 -0
+   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
    libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
    libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
    tiff xcb-util-keysyms samba"
@@ -58,6 +58,7 @@ PACKAGECONFIG[gstreamer] =

"--enable-gst-decode,--disable-gst-decode,gstreamer1.

Quoted 3 lines
Quoted 3 lines

meta-multimedia/recipes-multimedia/vlc/vlc.inc PACKAGECONFIG[gstreamer] = "--enable-gst-decode,--disable-gst-decode,gstreamer1.

Quoted 3 lines
meta-multimedia/recipes-multimedia/vlc/vlc.inc +0 -0
 PACKAGECONFIG[vpx] = "--enable-vpx,--disable-vpx, libvpx"
 PACKAGECONFIG[qt4] = "--enable-qt,--disable-qt, qt4-x11-free"
 PACKAGECONFIG[freerdp] = "--enable-freerdp,--disable-freerdp,

freerdp"

Quoted 1 line
Quoted 1 line

meta-multimedia/recipes-multimedia/vlc/vlc.inc PACKAGECONFIG[gstreamer] = · line 61

Quoted 1 line
meta-multimedia/recipes-multimedia/vlc/vlc.inc +1 -0
+PACKAGECONFIG[notify] = "--enable-notify,--disable-notify, libnotify

gtk+"

Quoted 5 lines
Quoted 3 lines

Removing gtk+ from DEPENDS causes even more undeterministic dependencies:

I would guess those real dependencies were hidden by gtk+ which depends

on

Quoted 9 lines

every single one of them.

Except maybe vorbis which was hidden by gstreamer plugins?

I agree that although depending on gtk+ is not fully nice neither correct, it makes
things deterministic.

Quoted 7 lines
Quoted 3 lines

So I guess I should rather add all the PACKAGECONFIG for these modules first and then move
those dependencies to their respective PACKAGECONFIG ?

yes

There are 112 AC_ARG_ENABLE clauses in configure.ac

<https://github.com/videolan/vlc/blob/master/configure.ac>... but adding PACKAGECONFIG for those that make sense has been on my list of TODO for a long time. Not all of them apply to our usage (winstore_app for instance). Testing all those options is one of the things that has held me back...so the approach of fixing what becomes broken has been the easier route.

Quoted 3 lines

At least there aren't a large amount of PKG_CHECK_MODULES which leads to endless patches to make it deterministic which other upstreams have zero interest in applying.

There are a lot PKG_ENABLE_MODULES_VLC which call that macro though

Quoted 2 lines

--Tim

#7 lore raw

PATCH 3/3 VLC: drop gnome-vfs, it will be removed from upstream in VLC 3.0

In reply to Rafaël Carré
---
 meta-multimedia/recipes-multimedia/vlc/vlc.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-multimedia/recipes-multimedia/vlc/vlc.inc +1 -1
index ad5c81d..dddbb5b 100644
@@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
    virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
    tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
-   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
+   libdvdcss libdvdread lua-native lua libidn \
    libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
    libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
    tiff xcb-util-keysyms samba"
Signature · 1 line
2.5.0
#8 lore raw

Re: [meta-multimedia][PATCH 3/3] VLC: drop gnome-vfs, it will be removed from upstream in VLC 3.0

Quoted 1 line · Rafaël Carré

---

Is it still used in 2.2.1 version? we aren't using 3.0 yet:

./meta-multimedia/recipes-multimedia/vlc/vlc_2.2.1.bb

Quoted 24 lines
 meta-multimedia/recipes-multimedia/vlc/vlc.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-multimedia/recipes-multimedia/vlc/vlc.inc +1 -1
index ad5c81d..dddbb5b 100644
@@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
    virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
    tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
-   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
+   libdvdcss libdvdread lua-native lua libidn \
    libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
    libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
    tiff xcb-util-keysyms samba"
Signature · 7 lines
2.5.0

-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#9 lore raw

Re: [meta-multimedia][PATCH 3/3] VLC: drop gnome-vfs, it will be removed from upstream in VLC 3.0

Hello,

Quoted 4 lines · Martin Jansa
Quoted 1 line · Rafaël Carré

---

Is it still used in 2.2.1 version? we aren't using 3.0 yet:

Yes, that module is still present in 2.2 (2.2.1 and future 2.2.X versions).

I'm testing the waters here, as I couldn't build gnome-vfs, and since that module
is being removed from upstream (again, in future 3.0 version but not 2.2.X), I
didn't bother to add a PACKAGECONFIG knob for it.

With this patch the gnome-vfs module will still if gnome-vfs is present, although it will not load at runtime if gnome-vfs is not installed (without preventing the rest of VLC to work properly).

It would be in the same position than the libarchive, dvdnav, samba, ssh2 modules, etc
which coincidentally implement the capabilities that the deprecated (in gnome) gnome-vfs
provides :)

So this simple patch fixes my build failure and at the same time reduces future work for when
VLC 3.0 will be released.

What do you think?

Thanks for the feedback

Quoted 16 lines
Quoted 16 lines
 meta-multimedia/recipes-multimedia/vlc/vlc.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-multimedia/recipes-multimedia/vlc/vlc.inc +1 -1
index ad5c81d..dddbb5b 100644
@@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
    virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
    tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
-   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
+   libdvdcss libdvdread lua-native lua libidn \
    libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
    libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
    tiff xcb-util-keysyms samba"
#10 lore raw

Re: [meta-multimedia][PATCH 3/3] VLC: drop gnome-vfs, it will be removed from upstream in VLC 3.0

Quoted 26 lines · Rafaël Carré

Hello,

Quoted 4 lines · Martin Jansa
Quoted 1 line · Rafaël Carré

---

Is it still used in 2.2.1 version? we aren't using 3.0 yet:

Yes, that module is still present in 2.2 (2.2.1 and future 2.2.X versions).

I'm testing the waters here, as I couldn't build gnome-vfs, and since that module
is being removed from upstream (again, in future 3.0 version but not 2.2.X), I
didn't bother to add a PACKAGECONFIG knob for it.

With this patch the gnome-vfs module will still if gnome-vfs is present, although it will not load at runtime if gnome-vfs is not installed (without preventing the rest of VLC to work properly).

It would be in the same position than the libarchive, dvdnav, samba, ssh2 modules, etc
which coincidentally implement the capabilities that the deprecated (in gnome) gnome-vfs
provides :)

Quoted 6 lines

So this simple patch fixes my build failure and at the same time reduces future work for when
VLC 3.0 will be released.

What do you think?

NAK it's not acceptable to make gnome-vfs support undeterministic in 2.2.x just because some future 3.0 recipe won't use it.

We already have too many autodetected dependencies again, last bunch added by new 1394 recipes in meta-multimedia:
vlc-2.2.1: vlc rdepends on libavc1394, but it isn't a build dependency? [build-deps] vlc-2.2.1: vlc rdepends on libdvdnav, but it isn't a build dependency? [build-deps] vlc-2.2.1: vlc rdepends on libupnp, but it isn't a build dependency? [build-deps]

Add PACKAGECONFIG for it please and to get bonus points add PACKAGECONFIG for deps from QA issues above.

Quoted 24 lines

Thanks for the feedback

Quoted 16 lines
Quoted 16 lines
 meta-multimedia/recipes-multimedia/vlc/vlc.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-multimedia/recipes-multimedia/vlc/vlc.inc +1 -1
index ad5c81d..dddbb5b 100644
@@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
    virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
    tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
-   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
+   libdvdcss libdvdread lua-native lua libidn \
    libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
    libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
    tiff xcb-util-keysyms samba"
Signature · 4 lines
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#11 lore raw

Re: [meta-multimedia][PATCH 3/3] VLC: drop gnome-vfs, it will be removed from upstream in VLC 3.0

Quoted 9 lines · Martin Jansa
Quoted 8 lines · Rafaël Carré

Hello,

Quoted 4 lines · Martin Jansa
Quoted 1 line · Rafaël Carré

---

Is it still used in 2.2.1 version? we aren't using 3.0 yet:

Quoted 7 lines
Quoted 4 lines

Yes, that module is still present in 2.2 (2.2.1 and future 2.2.X versions).

What do you think?

NAK it's not acceptable to make gnome-vfs support undeterministic in 2.2.x just because some future 3.0 recipe won't use it.

Ok

Quoted 7 lines

We already have too many autodetected dependencies again, last bunch added by new 1394 recipes in meta-multimedia:
vlc-2.2.1: vlc rdepends on libavc1394, but it isn't a build dependency? [build-deps] vlc-2.2.1: vlc rdepends on libdvdnav, but it isn't a build dependency? [build-deps] vlc-2.2.1: vlc rdepends on libupnp, but it isn't a build dependency? [build-deps]

Add PACKAGECONFIG for it please and to get bonus points add

Done

Quoted 1 line

PACKAGECONFIG for deps from QA issues above.

I will take a deeper look as there are more than just those

Quoted 18 lines
Quoted 18 lines

Thanks for the feedback

Quoted 16 lines
Quoted 16 lines
 meta-multimedia/recipes-multimedia/vlc/vlc.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-multimedia/recipes-multimedia/vlc/vlc.inc +1 -1
index ad5c81d..dddbb5b 100644
@@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
    virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
    tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
-   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
+   libdvdcss libdvdread lua-native lua libidn \
    libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
    libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
    tiff xcb-util-keysyms samba"