Skip to contentSkip to conversation

ARM: dts: kirkwood: add Linksys EA3500

PATCH New Luka Perkov 5 participants 10 messages Nov 4, 2015 – Dec 18, 2015 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 2/4 ARM: dts: kirkwood: add Linksys EA3500

Based on dts files from OpenWrt.

---
 .../devicetree/bindings/arm/marvell,kirkwood.txt   |   1 +
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/kirkwood-ea3500.dts              | 149 +++++++++++++++++++++
 3 files changed, 151 insertions(+)
 create mode 100644 arch/arm/boot/dts/kirkwood-ea3500.dts
Documentation/devicetree/bindings/arm/marvell,kirkwood.txt +1 -0
index 7a99d4a..ed381a3 100644
@@ -50,6 +50,7 @@ board. Currently known boards are:
 "lacie,netspace_mini_v2"
 "lacie,netspace_v2"
 "linksys,ea4500"
+"linksys,ea3500"
 "marvell,db-88f6281-bp"
 "marvell,db-88f6282-bp"
 "marvell,mv88f6281gtw-ge"
arch/arm/boot/dts/Makefile +1 -0
index a16c04b..ebe5b73 100644
@@ -168,6 +168,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += \
 	kirkwood-ds411.dtb \
 	kirkwood-ds411j.dtb \
 	kirkwood-ds411slim.dtb \
+	kirkwood-ea3500.dtb \
 	kirkwood-ea4500.dtb \
 	kirkwood-goflexnet.dtb \
 	kirkwood-guruplug-server-plus.dtb \
arch/arm/boot/dts/kirkwood-ea3500.dts new file +149 -0

149 lines not on this page · raw message

Signature · 1 line
2.6.2
#2 lore raw

PATCH 2/4 ARM: dts: kirkwood: add Linksys EA3500

Hi Luka

Quoted 4 lines

"lacie,netspace_mini_v2"
"lacie,netspace_v2"
"linksys,ea4500"
+"linksys,ea3500"

Other way around please, to keep the sorted order.

arch/arm/boot/dts/kirkwood-ea3500.dts line 29

Quoted 2 lines
arch/arm/boot/dts/kirkwood-ea3500.dts new file +2 -0
+	chosen {
+		bootargs = "console=ttyS0,115200n8 earlyprintk";

stdout = ...

Quoted 5 lines

+&nand {

arch/arm/boot/dts/kirkwood-ea3500.dts new file +4 -0
+	status = "okay";
+	pinctrl-0 = <&pmx_nand>;
+	pinctrl-names = "default";
+

arch/arm/boot/dts/kirkwood-ea3500.dts line 118

Quoted 10 lines
arch/arm/boot/dts/kirkwood-ea3500.dts new file +10 -0
+	partition at 0 {
+		label = "u-boot";
+		reg = <0x0000000 0x80000>;
+		read-only;
+	};
+
+	partition at 80000 {
+		label = "u-boot environment";
+		reg = <0x80000 0x20000>;
+	};

Same hole?

arch/arm/boot/dts/kirkwood-ea3500.dts line 129

Quoted 10 lines
arch/arm/boot/dts/kirkwood-ea3500.dts new file +10 -0
+	partition at 200000 {
+		label = "kernel";
+		reg = <0x200000 0x200000>;
+	};
+
+	partition at 400000 {
+		label = "root";
+		reg = <0x400000 0x1200000>;
+	};
+};

Andrew

#3 lore raw

PATCH 2/4 ARM: dts: kirkwood: add Linksys EA3500

In reply to Luka Perkov
Quoted 1 line · Luka Perkov

Based on dts files from OpenWrt.

Hi Luka

Thanks for spending the time to submit these upstream.

It looks like a lot of the same comments apply to these files, so i won't keep repeat them.

One thing i did notice is that turning off the internal RTC is common, but there is no i2c RTC. Is this correct? Do these devices not have an RTC?
Thanks
Andrew

#5 lore raw

PATCH 3/4 ARM: dts: kirkwood: add Seagate GoFlex Home

In reply to a message not in the archive

Based on dts files from OpenWrt.

---
 .../devicetree/bindings/arm/marvell,kirkwood.txt   |   1 +
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/kirkwood-goflexhome.dts          | 127 +++++++++++++++++++++
 3 files changed, 129 insertions(+)
 create mode 100644 arch/arm/boot/dts/kirkwood-goflexhome.dts
Documentation/devicetree/bindings/arm/marvell,kirkwood.txt +1 -0
index ed381a3..37bd190 100644
@@ -72,6 +72,7 @@ board. Currently known boards are:
 "raidsonic,ib-nas6220-b"
 "raidsonic,ib-nas62x0"
 "seagate,dockstar"
+"seagate,goflexhome"
 "seagate,goflexnet"
 "synology,ds109"
 "synology,ds110jv10"
arch/arm/boot/dts/Makefile +1 -0
index ebe5b73..1d6fb0d 100644
@@ -170,6 +170,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += \
 	kirkwood-ds411slim.dtb \
 	kirkwood-ea3500.dtb \
 	kirkwood-ea4500.dtb \
+	kirkwood-goflexhome.dtb \
 	kirkwood-goflexnet.dtb \
 	kirkwood-guruplug-server-plus.dtb \
 	kirkwood-ib62x0.dtb \
arch/arm/boot/dts/kirkwood-goflexhome.dts new file +127 -0

127 lines not on this page · raw message

Signature · 1 line
2.6.2
#6 lore raw

PATCH 3/4 ARM: dts: kirkwood: add Seagate GoFlex Home

arch/arm/boot/dts/kirkwood-goflexhome.dts line 16

Quoted 2 lines
arch/arm/boot/dts/kirkwood-goflexhome.dts new file +2 -0
+	chosen {
+		bootargs = "console=ttyS0,115200n8 earlyprintk root=/dev/sda1 rootdelay=10";

It is not normal to specify the root device. Is this really required? And rootdelay is also unusual.

Quoted 5 lines
arch/arm/boot/dts/kirkwood-goflexhome.dts new file +5 -0
+		stdout-path = &uart0;
+	};
+
+	ocp at f1000000 {
+		pinctrl: pin-controller at 10000 {

arch/arm/boot/dts/kirkwood-goflexhome.dts line 31

Quoted 10 lines
arch/arm/boot/dts/kirkwood-goflexhome.dts new file +10 -0
+			pmx_usb_power_enable: pmx-usb-power-enable {
+				marvell,pins = "mpp29";
+				marvell,function = "gpio";
+			};
+			pmx_led_white: pmx-led-white {
+				marvell,pins = "mpp40";
+				marvell,function = "gpio";
+			};
+			pmx_led_green: pmx-led_green {
+				marvell,pins = "mpp46";

That last _ should be -..

Quoted 12 lines
arch/arm/boot/dts/kirkwood-goflexhome.dts new file +12 -0
+				marvell,function = "gpio";
+			};
+			pmx_led_orange: pmx-led-orange {
+				marvell,pins = "mpp47";
+				marvell,function = "gpio";
+			};
+		};
+		serial at 12000 {
+			status = "ok";
+		};
+
+		sata at 80000 {

arch/arm/boot/dts/kirkwood-goflexhome.dts line 53

Quoted 10 lines
arch/arm/boot/dts/kirkwood-goflexhome.dts new file +10 -0
+			status = "okay";
+			nr-ports = <2>;
+		};
+
+	};
+	gpio-leds {
+		compatible = "gpio-leds";
+
+		health {
+			label = "status:green:health";

This does not fit the naming convention. status should be the machine name.

Andrew

#7 lore raw

PATCH 3/4 ARM: dts: kirkwood: add Seagate GoFlex Home

In reply to Luka Perkov

Hi Luka,

Quoted 75 lines · Luka Perkov

Based on dts files from OpenWrt.

---
 .../devicetree/bindings/arm/marvell,kirkwood.txt   |   1 +
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/kirkwood-goflexhome.dts          | 127 +++++++++++++++++++++
 3 files changed, 129 insertions(+)
 create mode 100644 arch/arm/boot/dts/kirkwood-goflexhome.dts
Documentation/devicetree/bindings/arm/marvell,kirkwood.txt +1 -0
index ed381a3..37bd190 100644
@@ -72,6 +72,7 @@ board. Currently known boards are:
 "raidsonic,ib-nas6220-b"
 "raidsonic,ib-nas62x0"
 "seagate,dockstar"
+"seagate,goflexhome"
 "seagate,goflexnet"
 "synology,ds109"
 "synology,ds110jv10"
arch/arm/boot/dts/Makefile +1 -0
index ebe5b73..1d6fb0d 100644
@@ -170,6 +170,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += \
 	kirkwood-ds411slim.dtb \
 	kirkwood-ea3500.dtb \
 	kirkwood-ea4500.dtb \
+	kirkwood-goflexhome.dtb \
 	kirkwood-goflexnet.dtb \
 	kirkwood-guruplug-server-plus.dtb \
 	kirkwood-ib62x0.dtb \
arch/arm/boot/dts/kirkwood-goflexhome.dts new file +35 -0
new file mode 100644
index 0000000..5f933d4
@@ -0,0 +1,127 @@
+/dts-v1/;
+
+#include "kirkwood.dtsi"
+#include "kirkwood-6281.dtsi"
+
+/ {
+	model = "Seagate GoFlex Home";
+	compatible = "seagate,goflexhome", "marvell,kirkwood-88f6281", "marvell,kirkwood";
+
+	memory {
+		device_type = "memory";
+		reg = <0x00000000 0x8000000>;
+	};
+
+	chosen {
+		bootargs = "console=ttyS0,115200n8 earlyprintk root=/dev/sda1 rootdelay=10";
+		stdout-path = &uart0;
+	};
+
+	ocp at f1000000 {
+		pinctrl: pin-controller at 10000 {
+			pmx_usb_power_enable: pmx-usb-power-enable {
+				marvell,pins = "mpp29";
+				marvell,function = "gpio";
+			};
+			pmx_led_white: pmx-led-white {
+				marvell,pins = "mpp40";
+				marvell,function = "gpio";
+			};
+			pmx_led_green: pmx-led_green {
+				marvell,pins = "mpp46";
+				marvell,function = "gpio";
+			};
+			pmx_led_orange: pmx-led-orange {
+				marvell,pins = "mpp47";

arch/arm/boot/dts/kirkwood-goflexhome.dts line 45

Quoted 10 lines
arch/arm/boot/dts/kirkwood-goflexhome.dts new file +10 -0
+				marvell,function = "gpio";
+			};
+		};
+		serial at 12000 {
+			status = "ok";
+		};
+
+		sata at 80000 {
+			status = "okay";
+			nr-ports = <2>;

I think nr-ports should be set to 1. This device only allows to plug a single HDD and there is no eSATA connectors.

arch/arm/boot/dts/kirkwood-goflexhome.dts line 54

Quoted 9 lines
arch/arm/boot/dts/kirkwood-goflexhome.dts new file +9 -0
+		};
+
+	};
+	gpio-leds {
+		compatible = "gpio-leds";
+
+		health {
+			label = "status:green:health";
+			gpios = <&gpio1 14 1>;

It would be better to use GPIO_ACTIVE_LOW instead of 1. The same comment applies to the other LEDs.

arch/arm/boot/dts/kirkwood-goflexhome.dts line 64

Quoted 10 lines
arch/arm/boot/dts/kirkwood-goflexhome.dts new file +10 -0
+			linux,default-trigger = "default-on";
+		};
+		fault {
+			label = "status:orange:fault";
+			gpios = <&gpio1 15 1>;
+		};
+		misc {
+			label = "status:white:misc";
+			gpios = <&gpio1 8 1>;
+			linux,default-trigger = "ide-disk";

ide-disk ? Really ? There is no way this can be correct :)

Quoted 53 lines
arch/arm/boot/dts/kirkwood-goflexhome.dts new file +53 -0
+		};
+	};
+	regulators {
+		compatible = "simple-bus";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		pinctrl-0 = <&pmx_usb_power_enable>;
+		pinctrl-names = "default";
+
+		usb_power: regulator at 1 {
+			compatible = "regulator-fixed";
+			reg = <1>;
+			regulator-name = "USB Power";
+			regulator-min-microvolt = <5000000>;
+			regulator-max-microvolt = <5000000>;
+			enable-active-high;
+			regulator-always-on;
+			regulator-boot-on;
+			gpio = <&gpio0 29 GPIO_ACTIVE_HIGH>;
+		};
+	};
+};
+
+&nand {
+	chip-delay = <40>;
+	status = "okay";
+
+	partition at 0 {
+		label = "u-boot";
+		reg = <0x0000000 0x100000>;
+		read-only;
+	};
+
+	partition at 100000 {
+		label = "uImage";
+		reg = <0x0100000 0x400000>;
+	};
+
+	partition at 500000 {
+		label = "pogoplug";
+		reg = <0x0500000 0x2000000>;
+	};
+
+	partition at 2500000 {
+		label = "root";
+		reg = <0x02500000 0xd800000>;
+	};
+};
+
+&mdio {
+	status = "okay";
+
+	ethphy0: ethernet-phy at 0 {

arch/arm/boot/dts/kirkwood-goflexhome.dts line 127

Quoted 10 lines
arch/arm/boot/dts/kirkwood-goflexhome.dts new file +10 -0
+		reg = <0>;
+	};
+};
+
+&eth0 {
+	status = "okay";
+	ethernet0-port at 0 {
+		phy-handle = <&ethphy0>;
+	};
+};

Is there a power-off GPIO on this board ?

Regards,

Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151105/08cee255/attachment-0001.sig>

#8 lore raw

PATCH 3/4 ARM: dts: kirkwood: add Seagate GoFlex Home

In reply to Luka Perkov

Hi Luka,

I tested your patch on the GoFlex Home.

Quoted 8 lines
arch/arm/boot/dts/kirkwood-goflexhome.dts new file +8 -0
+	gpio-leds {
+		compatible = "gpio-leds";
+
+		health {
+			label = "status:green:health";
+			gpios = <&gpio1 14 1>;
+			linux,default-trigger = "default-on";
+		};

arch/arm/boot/dts/kirkwood-goflexhome.dts line 66

Quoted 10 lines
arch/arm/boot/dts/kirkwood-goflexhome.dts new file +10 -0
+		fault {
+			label = "status:orange:fault";
+			gpios = <&gpio1 15 1>;
+		};
+		misc {
+			label = "status:white:misc";
+			gpios = <&gpio1 8 1>;
+			linux,default-trigger = "ide-disk";
+		};
+	};

I noticed green and orange leds were working fine (0 == off, 1 == on). But white led polarity is inverted (1 == off, 0 == on).

arch/arm/boot/dts/kirkwood-goflexhome.dts line 106

Quoted 4 lines
arch/arm/boot/dts/kirkwood-goflexhome.dts new file +4 -0
+	partition at 500000 {
+		label = "pogoplug";
+		reg = <0x0500000 0x2000000>;
+	};

I don't think pogoplug is the proper label for this partition. It seems duplicated from "kirkwood-goflexnet.dts" I guess you could label it "data" for instance.

Yoann

#9 lore raw

PATCH 3/4 ARM: dts: kirkwood: add Seagate GoFlex Home

Hi Luka,

Did you have the time to look at those issues ?

Yoann

Le 06/11/2015 17:05, Yoann Sculo a ?crit :

Quoted 38 lines

Hi Luka,

I tested your patch on the GoFlex Home.

Quoted 8 lines
arch/arm/boot/dts/kirkwood-goflexhome.dts new file +8 -0
+    gpio-leds {
+        compatible = "gpio-leds";
+
+        health {
+            label = "status:green:health";
+            gpios = <&gpio1 14 1>;
+            linux,default-trigger = "default-on";
+        };

arch/arm/boot/dts/kirkwood-goflexhome.dts line 66

Quoted 10 lines
arch/arm/boot/dts/kirkwood-goflexhome.dts new file +10 -0
+        fault {
+            label = "status:orange:fault";
+            gpios = <&gpio1 15 1>;
+        };
+        misc {
+            label = "status:white:misc";
+            gpios = <&gpio1 8 1>;
+            linux,default-trigger = "ide-disk";
+        };
+    };

I noticed green and orange leds were working fine (0 == off, 1 == on). But white led polarity is inverted (1 == off, 0 == on).

arch/arm/boot/dts/kirkwood-goflexhome.dts line 106

Quoted 4 lines
arch/arm/boot/dts/kirkwood-goflexhome.dts new file +4 -0
+    partition at 500000 {
+        label = "pogoplug";
+        reg = <0x0500000 0x2000000>;
+    };

I don't think pogoplug is the proper label for this partition. It seems duplicated from "kirkwood-goflexnet.dts" I guess you could label it "data" for instance.

Yoann

#10 lore raw

PATCH 4/4 ARM: dts: kirkwood: add ZyXEL NSA310s

In reply to a message not in the archive

Based on dts files from OpenWrt.

---
 .../devicetree/bindings/arm/marvell,kirkwood.txt   |   1 +
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/kirkwood-nsa310s.dts             | 282 +++++++++++++++++++++
 3 files changed, 284 insertions(+)
 create mode 100644 arch/arm/boot/dts/kirkwood-nsa310s.dts
Documentation/devicetree/bindings/arm/marvell,kirkwood.txt +1 -0
index 37bd190..8a1a7f7 100644
@@ -101,3 +101,4 @@ board. Currently known boards are:
 "usi,topkick-1281P2"
 "zyxel,nsa310"
 "zyxel,nsa310a"
+"zyxel,nsa310s"
arch/arm/boot/dts/Makefile +1 -0
index 1d6fb0d..b2ea55f 100644
@@ -196,6 +196,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += \
 	kirkwood-ns2mini.dtb \
 	kirkwood-nsa310.dtb \
 	kirkwood-nsa310a.dtb \
+	kirkwood-nsa310s.dtb \
 	kirkwood-openblocks_a6.dtb \
 	kirkwood-openblocks_a7.dtb \
 	kirkwood-openrd-base.dtb \
arch/arm/boot/dts/kirkwood-nsa310s.dts new file +282 -0

282 lines not on this page · raw message

Signature · 1 line
2.6.2