Skip to contentSkip to conversation

bind: fix intermittent build issues with high BR2_JLEVEL

PATCH New Jan Heylen 3 participants 7 messages Nov 5, 2015 – Feb 5, 2016

lore
Share & tools
lore

Jan Heylen

author
#0 lore raw

PATCH 1/1 bind: fix intermittent build issues with high BR2_JLEVEL

From: Peter Korsgaard <[email protected]>

Build sometimes breaks with:

libtool: link: `unix/os.lo' is not a valid libtool object make[3]: *** [rndc-confgen] Error 1
make[3]: *** Waiting for unfinished jobs....
make[4]: Leaving directory `/scratch/peko/build/bind-9.6-ESV-R4/bin/rndc/unix'

So disable parallel builds.

[Jan Heylen: This patch was removed with commit c36b5d89c5616f7ca0a7295cbb5c231606beb71e by Gustavo Zacarias <[email protected]> but the problem still occurs, so disabling parallel builds again]

---
 package/bind/bind.mk | 1 +
 1 file changed, 1 insertion(+)
package/bind/bind.mk +1 -0
index e93b356..3601d42 100644
@@ -6,6 +6,7 @@
 
 BIND_VERSION = 9.9.8
 BIND_SITE = ftp://ftp.isc.org/isc/bind9/$(BIND_VERSION)
+BIND_MAKE = $(MAKE1)
 BIND_INSTALL_STAGING = YES
 BIND_CONFIG_SCRIPTS = bind9-config isc-config.sh
 BIND_LICENSE = ISC
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 bind: fix intermittent build issues with high BR2_JLEVEL

Dear Jan Heylen,

Thanks for your patch!

Quoted 1 line · Jan Heylen

From: Peter Korsgaard <[email protected]>

I am not sure it is appropriate to send a patch in the name of someone else. Maybe you're taking one of Peter's previous commit, and re-applying it, but the context is different, so I believe it should be under your own name.

Quoted 9 lines

Build sometimes breaks with:

libtool: link: `unix/os.lo' is not a valid libtool object make[3]: *** [rndc-confgen] Error 1
make[3]: *** Waiting for unfinished jobs....
make[4]: Leaving directory `/scratch/peko/build/bind-9.6-ESV-R4/bin/rndc/unix'

So disable parallel builds.

I've been trying to reproduce the parallel build issue, and I haven't been able to do so. It seems our autobuilders also didn't catch it.

How often are you able to reproduce it ? On what type of build machine ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 bind: fix intermittent build issues with high BR2_JLEVEL

Hi,

Quoted 4 lines · Thomas Petazzoni

Dear Jan Heylen,

Thanks for your patch!

Quoted 8 lines
Quoted 1 line · Jan Heylen

From: Peter Korsgaard <[email protected]>

I am not sure it is appropriate to send a patch in the name of someone else. Maybe you're taking one of Peter's previous commit, and re-applying it, but the context is different, so I believe it should be under your own name.

OK, just wanted to point out it is the same issue (and the same solution).

Quoted 8 lines
Quoted 8 lines

Build sometimes breaks with:

libtool: link: `unix/os.lo' is not a valid libtool object make[3]: *** [rndc-confgen] Error 1
make[3]: *** Waiting for unfinished jobs.... make[4]: Leaving directory

Quoted 7 lines

`/scratch/peko/build/bind-9.6-ESV-R4/bin/rndc/unix'

Quoted 2 lines

So disable parallel builds.

I've been trying to reproduce the parallel build issue, and I haven't been able to do so. It seems our autobuilders also didn't catch it.

Example of the output (paths shrink-ed):

<during compilation of bind>
libtool: link: `unix/os.lo' is not a valid libtool object make[3]: *** [named] Error 1
make[3]: *** Waiting for unfinished jobs....
make[4]: Leaving directory <CUT>/output/build/bind-9.9.7/bin/named/unix' make[3]: Leaving directory <CUT>/output/build/bind-9.9.7/bin/named' make[2]: *** [subdirs] Error 1
make[2]: Leaving directory `<CUT>/output/build/bind-9.9.7/bin' make[1]: *** [subdirs] Error 1
make[1]: Leaving directory `<CUT>/output/build/bind-9.9.7'
make: *** [<CUT>/output/build/bind-9.9.7/.stamp_built] Error 2

How often are you able to reproduce it ? On what type of build machine ?

Quoted 1 line

We are on the 2015.05, Released May 31st, 2015 Buildroot release.

We build a couple of times a day on a centos 7 environment: 8 cores, 32G mem.

processor : 7
vendor_id : GenuineIntel
cpu family : 6
model : 60
model name : Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
stepping : 3
microcode : 0x1c
cpu MHz : 3390.171
cache size : 8192 KB
physical id : 0
siblings : 8
core id : 3
cpu cores : 4
apicid : 7
initial apicid : 7
fpu : yes
fpu_exception : yes
cpuid level : 13
wp : yes
flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc aperfmperf eagerfpu pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm ida arat epb xsaveopt pln pts dtherm tpr_shadow vnmi flexpriority ept vpid fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid
bogomips : 6784.08
clflush size : 64
cache_alignment : 64
address sizes : 39 bits physical, 48 bits virtual
power management:

So nothing special?

BR2_JLEVEL is set to '0' (so auto)

We do build multiple defconfigs (up to 8) (in separate buildroot working folders) at once on the same machine. But I see from the buildroot output that BR2_JLEVEL is set to '9' (cores +1) for each of these jobs?

Quoted 1 line
Quoted 1 line
Quoted 1 line

bind 9.9.7 Building

PATH="<CUT>/output/host/bin:<CUT>/output/host/sbin:<CUT>/output/host/usr/bin:<CUT>/output/host/usr/sbin:/usr/local/bin:/usr/bin"
/usr/bin/make -j9 -C <CUT>/output/build/bind-9.9.7/
make[1]: Entering directory `<CUT>/output/build/bind-9.9.7'
making all in <CUT>/output/build/bind-9.9.7/make

Maybe the exact condition is to have multiple buildroot jobs (8) on 8 cores with BR2_JLEVEL set to 8 (so 8*8 = 64 'jobs').

So we might optimize that on our side ;-), but still it shouldn't trigger this error?

Jan

Quoted 8 lines

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20151106/6ff79e76/attachment.html>

author
#3 lore raw

PATCH 1/1 bind: fix intermittent build issues with high BR2_JLEVEL

Quoted 50 lines · Jan Heylen

Hi,

Quoted 4 lines · Thomas Petazzoni

Dear Jan Heylen,

Thanks for your patch!

Quoted 8 lines
Quoted 1 line · Jan Heylen

From: Peter Korsgaard <[email protected]>

I am not sure it is appropriate to send a patch in the name of someone else. Maybe you're taking one of Peter's previous commit, and re-applying it, but the context is different, so I believe it should be under your own name.

OK, just wanted to point out it is the same issue (and the same solution).

Quoted 8 lines
Quoted 8 lines

Build sometimes breaks with:

libtool: link: `unix/os.lo' is not a valid libtool object make[3]: *** [rndc-confgen] Error 1
make[3]: *** Waiting for unfinished jobs.... make[4]: Leaving directory

Quoted 7 lines

`/scratch/peko/build/bind-9.6-ESV-R4/bin/rndc/unix'

Quoted 2 lines

So disable parallel builds.

I've been trying to reproduce the parallel build issue, and I haven't been able to do so. It seems our autobuilders also didn't catch it.

Example of the output (paths shrink-ed):

<during compilation of bind>
libtool: link: `unix/os.lo' is not a valid libtool object make[3]: *** [named] Error 1
make[3]: *** Waiting for unfinished jobs....
make[4]: Leaving directory <CUT>/output/build/bind-9.9.7/bin/named/unix' make[3]: Leaving directory <CUT>/output/build/bind-9.9.7/bin/named' make[2]: *** [subdirs] Error 1
make[2]: Leaving directory `<CUT>/output/build/bind-9.9.7/bin' make[1]: *** [subdirs] Error 1
make[1]: Leaving directory `<CUT>/output/build/bind-9.9.7'
make: *** [<CUT>/output/build/bind-9.9.7/.stamp_built] Error 2

Quoted 8 lines

How often are you able to reproduce it ? On what type of build machine ?

Quoted 1 line

We are on the 2015.05, Released May 31st, 2015 Buildroot release.

We build a couple of times a day on a centos 7 environment: 8 cores, 32G mem.

To be correct: 4 physical, 8 virtual cores

Quoted 42 lines

processor : 7
vendor_id : GenuineIntel
cpu family : 6
model : 60
model name : Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
stepping : 3
microcode : 0x1c
cpu MHz : 3390.171
cache size : 8192 KB
physical id : 0
siblings : 8
core id : 3
cpu cores : 4
apicid : 7
initial apicid : 7
fpu : yes
fpu_exception : yes
cpuid level : 13
wp : yes
flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc aperfmperf eagerfpu pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm ida arat epb xsaveopt pln pts dtherm tpr_shadow vnmi flexpriority ept vpid fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid
bogomips : 6784.08
clflush size : 64
cache_alignment : 64
address sizes : 39 bits physical, 48 bits virtual
power management:

So nothing special?

BR2_JLEVEL is set to '0' (so auto)

We do build multiple defconfigs (up to 8) (in separate buildroot working folders) at once on the same machine. But I see from the buildroot output that BR2_JLEVEL is set to '9' (cores +1) for each of these jobs?

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

bind 9.9.7 Building

PATH="<CUT>/output/host/bin:<CUT>/output/host/sbin:<CUT>/output/host/usr/bin:<CUT>/output/host/usr/sbin:/usr/local/bin:/usr/bin" /usr/bin/make -j9 -C <CUT>/output/build/bind-9.9.7/ make[1]: Entering directory `<CUT>/output/build/bind-9.9.7'
making all in <CUT>/output/build/bind-9.9.7/make

Maybe the exact condition is to have multiple buildroot jobs (8) on 8 cores with BR2_JLEVEL set to 8 (so 8*8 = 64 'jobs').

To be correct: 8 jobs * -j9 = 72 'jobs'

Quoted 16 lines

So we might optimize that on our side ;-), but still it shouldn't trigger this error?

Jan

Quoted 8 lines

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20151106/fa9645dc/attachment.html>

#4 lore raw

PATCH 1/1 bind: fix intermittent build issues with high BR2_JLEVEL

In reply to Jan Heylen

Jan,

Quoted 6 lines · Jan Heylen
Quoted 5 lines

I am not sure it is appropriate to send a patch in the name of someone else. Maybe you're taking one of Peter's previous commit, and re-applying it, but the context is different, so I believe it should be under your own name.

OK, just wanted to point out it is the same issue (and the same solution).

OK.

Quoted 7 lines

make[1]: Leaving directory `<CUT>/output/build/bind-9.9.7'
make: *** [<CUT>/output/build/bind-9.9.7/.stamp_built] Error 2

How often are you able to reproduce it ? On what type of build machine ?

Quoted 1 line

We are on the 2015.05, Released May 31st, 2015 Buildroot release.

On master, we updated bind to 9.9.8. Do you also reproduce the issue with bind 9.9.8 ?

What I find weird is that our autobuilder infrastructure generally catches pretty well the parallel build issues. And we currently have zero failures on bind 9.9.7 and bind 9.9.8:

http://autobuild.buildroot.org/?reason=bind-9.9.7
http://autobuild.buildroot.org/?reason=bind-9.9.8

Quoted 3 lines

We do build multiple defconfigs (up to 8) (in separate buildroot working folders) at once on the same machine. But I see from the buildroot output that BR2_JLEVEL is set to '9' (cores +1) for each of these jobs?

That's expected if you have left BR2_JLEVEL to its default of 0.

Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

bind 9.9.7 Building

PATH="<CUT>/output/host/bin:<CUT>/output/host/sbin:<CUT>/output/host/usr/bin:<CUT>/output/host/usr/sbin:/usr/local/bin:/usr/bin"
/usr/bin/make -j9 -C <CUT>/output/build/bind-9.9.7/
make[1]: Entering directory `<CUT>/output/build/bind-9.9.7'
making all in <CUT>/output/build/bind-9.9.7/make

Quoted 5 lines

Maybe the exact condition is to have multiple buildroot jobs (8) on 8 cores with BR2_JLEVEL set to 8 (so 8*8 = 64 'jobs').

So we might optimize that on our side ;-), but still it shouldn't trigger this error?

It should trigger this error indeed.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#5 lore raw

PATCH 1/1 bind: fix intermittent build issues with high BR2_JLEVEL

Hi Thomas,

Quoted 4 lines · Thomas Petazzoni

Jan,

On Fri, 6 Nov 2015 08:04:35 +0100, Jan Heylen wrote:

Quoted 14 lines
Quoted 6 lines
Quoted 5 lines

I am not sure it is appropriate to send a patch in the name of someone else. Maybe you're taking one of Peter's previous commit, and re-applying it, but the context is different, so I believe it should be under your own name.

OK, just wanted to point out it is the same issue (and the same solution).

OK.

Quoted 4 lines

make[1]: Leaving directory `<CUT>/output/build/bind-9.9.7'
make: *** [<CUT>/output/build/bind-9.9.7/.stamp_built] Error 2

How often are you able to reproduce it ? On what type of build machine ?

We saw this issue from time to time. Definitely not always, but also definitely more than once. I don't have exact figures.

Quoted 28 lines
Quoted 3 lines
Quoted 1 line

We are on the 2015.05, Released May 31st, 2015 Buildroot release.

On master, we updated bind to 9.9.8. Do you also reproduce the issue with bind 9.9.8 ?

What I find weird is that our autobuilder infrastructure generally catches pretty well the parallel build issues. And we currently have zero failures on bind 9.9.7 and bind 9.9.8:

http://autobuild.buildroot.org/?reason=bind-9.9.7
http://autobuild.buildroot.org/?reason=bind-9.9.8

Quoted 3 lines

We do build multiple defconfigs (up to 8) (in separate buildroot working folders) at once on the same machine. But I see from the buildroot output that BR2_JLEVEL is set to '9' (cores +1) for each of these jobs?

That's expected if you have left BR2_JLEVEL to its default of 0.

Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

bind 9.9.7 Building

PATH="<CUT>/output/host/bin:<CUT>/output/host/sbin:<CUT>/output/host/usr/bin:<CUT>/output/host/usr/sbin:/usr/local/bin:/usr/bin"
/usr/bin/make -j9 -C <CUT>/output/build/bind-9.9.7/
make[1]: Entering directory `<CUT>/output/build/bind-9.9.7'
making all in <CUT>/output/build/bind-9.9.7/make

Quoted 7 lines
Quoted 5 lines

Maybe the exact condition is to have multiple buildroot jobs (8) on 8 cores with BR2_JLEVEL set to 8 (so 8*8 = 64 'jobs').

So we might optimize that on our side ;-), but still it shouldn't trigger this error?

It should trigger this error indeed.

From the bind website:
https://kb.isc.org/article/AA-00291/46/Im-trying-to-compile-BIND-9-and-make-is-failing-due-to-files-not-being-found.-Why-.html

"Using a parallel or distributed "make" to build BIND 9 is not supported, and doesn't work. If you are using one of these, use normal make or gmake instead."

Based on our observed failures and the above upstream message that parallel make is not supported, shouldn't we take that into account in buildroot (and thus applying this patch) ?

Thanks,
Thomas

#6 lore raw

PATCH 1/1 bind: fix intermittent build issues with high BR2_JLEVEL

Quoted 65 lines · Thomas De Schampheleire

Hi Thomas,

Quoted 4 lines · Thomas Petazzoni

Jan,

On Fri, 6 Nov 2015 08:04:35 +0100, Jan Heylen wrote:

Quoted 14 lines
Quoted 6 lines
Quoted 5 lines

I am not sure it is appropriate to send a patch in the name of someone else. Maybe you're taking one of Peter's previous commit, and re-applying it, but the context is different, so I believe it should be under your own name.

OK, just wanted to point out it is the same issue (and the same solution).

OK.

Quoted 4 lines

make[1]: Leaving directory `<CUT>/output/build/bind-9.9.7'
make: *** [<CUT>/output/build/bind-9.9.7/.stamp_built] Error 2

How often are you able to reproduce it ? On what type of build machine ?

We saw this issue from time to time. Definitely not always, but also definitely more than once. I don't have exact figures.

Quoted 28 lines
Quoted 3 lines
Quoted 1 line

We are on the 2015.05, Released May 31st, 2015 Buildroot release.

On master, we updated bind to 9.9.8. Do you also reproduce the issue with bind 9.9.8 ?

What I find weird is that our autobuilder infrastructure generally catches pretty well the parallel build issues. And we currently have zero failures on bind 9.9.7 and bind 9.9.8:

http://autobuild.buildroot.org/?reason=bind-9.9.7
http://autobuild.buildroot.org/?reason=bind-9.9.8

Quoted 3 lines

We do build multiple defconfigs (up to 8) (in separate buildroot working folders) at once on the same machine. But I see from the buildroot output that BR2_JLEVEL is set to '9' (cores +1) for each of these jobs?

That's expected if you have left BR2_JLEVEL to its default of 0.

Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

bind 9.9.7 Building

PATH="<CUT>/output/host/bin:<CUT>/output/host/sbin:<CUT>/output/host/usr/bin:<CUT>/output/host/usr/sbin:/usr/local/bin:/usr/bin"
/usr/bin/make -j9 -C <CUT>/output/build/bind-9.9.7/
make[1]: Entering directory `<CUT>/output/build/bind-9.9.7'
making all in <CUT>/output/build/bind-9.9.7/make

Quoted 7 lines
Quoted 5 lines

Maybe the exact condition is to have multiple buildroot jobs (8) on 8 cores with BR2_JLEVEL set to 8 (so 8*8 = 64 'jobs').

So we might optimize that on our side ;-), but still it shouldn't trigger this error?

It should trigger this error indeed.

From the bind website:
https://kb.isc.org/article/AA-00291/46/Im-trying-to-compile-BIND-9-and-make-is-failing-due-to-files-not-being-found.-Why-.html

Quoted 8 lines

"Using a parallel or distributed "make" to build BIND 9 is not supported, and doesn't work. If you are using one of these, use normal make or gmake instead."

Based on our observed failures and the above upstream message that parallel make is not supported, shouldn't we take that into account in buildroot (and thus applying this patch) ?

Ping... I think this should go in for the release.
I should have discussed this on the Buildroot days, but forgot...