Skip to contentSkip to conversation

unicore32: nb0916: Use PWM lookup table

PATCH In review Thierry Reding 1 participant 2 messages Oct 5, 2015 – Nov 6, 2015 PWM

lore
Share & tools
lore

Thierry Reding

author
#0 lore raw

PATCH 1/1 unicore32: nb0916: Use PWM lookup table

Use a PWM lookup table to provide the PWM to the pwm-backlight device. The driver has a legacy code path that is required only because boards still use the legacy method of requesting PWMs by global ID. Replacing these usages allows that legacy fallback to be removed.

Cc Guan Xuetao <[email protected]>
Signed-off-by Thierry Reding <[email protected]>
---
 arch/unicore32/kernel/puv3-nb0916.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
arch/unicore32/kernel/puv3-nb0916.c +8 -1
index 46ebfdccbc31..af3962d90def 100644
@@ -19,6 +19,7 @@
 #include <linux/reboot.h>
 #include <linux/interrupt.h>
 #include <linux/i2c.h>
+#include <linux/pwm.h>
 #include <linux/pwm_backlight.h>
 #include <linux/gpio.h>
 #include <linux/gpio_keys.h>

@@ -49,8 +50,12 @@ static struct resource puv3_i2c_resources[] = {
 	}
 };
 
+static struct pwm_lookup nb0916_pwm_lookup[] = {
+	PWM_LOOKUP("PKUnity-v3-PWM", 0, "pwm-backlight", NULL, 0,
+		   PWM_POLARITY_NORMAL),
+};
+
 static struct platform_pwm_backlight_data nb0916_backlight_data = {
-	.pwm_id		= 0,
 	.max_brightness	= 100,
 	.dft_brightness	= 100,
 	.pwm_period_ns	= 70 * 1024,

@@ -112,6 +117,8 @@ int __init mach_nb0916_init(void)
 	platform_device_register_simple("PKUnity-v3-I2C", -1,
 			puv3_i2c_resources, ARRAY_SIZE(puv3_i2c_resources));
 
+	pwm_add_table(nb0916_pwm_lookup, ARRAY_SIZE(nb0916_pwm_lookup));
+
 	platform_device_register_data(NULL, "pwm-backlight", -1,
 			&nb0916_backlight_data, sizeof(nb0916_backlight_data));
Signature · 1 line
2.5.0
author
#1 lore raw
Quoted 10 lines · Thierry Reding

Use a PWM lookup table to provide the PWM to the pwm-backlight device. The driver has a legacy code path that is required only because boards still use the legacy method of requesting PWMs by global ID. Replacing these usages allows that legacy fallback to be removed.

Cc Guan Xuetao <[email protected]>
Signed-off-by Thierry Reding <[email protected]>
---
 arch/unicore32/kernel/puv3-nb0916.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Guan, I've applied this to my PWM tree since you haven't responded to this. The change is low-risk and badly needed to clean up PWM consumer drivers.

Thierry