Skip to contentSkip to conversation

staging: lustre: lnet: klnds: socklnd: Move extern declarations to header

PATCH In review Amitoj Kaur Chawla 2 participants 2 messages Nov 6, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: lustre: lnet: klnds: socklnd: Move extern declarations to header

This patch moves extern declarations in socklnd_lib.c to the respective header file, 'socklnd.h'.

This patch also removes extern keyword from function declarations since functions have the extern specifier by default.

---
 drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h     | 3 +++
 drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c | 2 --
 2 files changed, 3 insertions(+), 2 deletions(-)
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h +3 -0
index b349847..f4fa725 100644
@@ -679,6 +679,9 @@ int ksocknal_lib_recv_kiov(ksock_conn_t *conn);
 int ksocknal_lib_get_conn_tunables(ksock_conn_t *conn, int *txmem,
 				   int *rxmem, int *nagle);
 
+void ksocknal_read_callback(ksock_conn_t *conn);
+void ksocknal_write_callback(ksock_conn_t *conn);
+
 int ksocknal_tunables_init(void);
 
 void ksocknal_lib_csum_tx(ksock_tx_t *tx);
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c +0 -2
index 679785b..04a4653 100644
@@ -580,8 +580,6 @@ ksocknal_lib_push_conn(ksock_conn_t *conn)
 	ksocknal_connsock_decref(conn);
 }
 
-extern void ksocknal_read_callback(ksock_conn_t *conn);
-extern void ksocknal_write_callback(ksock_conn_t *conn);
 /*
  * socket call back in Linux
  */
Signature · 1 line
1.9.1
Acked-by James Simmons on v1 1/1
#1 lore raw
Quoted 8 lines

From: lustre-devel [mailto:lustre-devel-bounces at lists.lustre.org] On Behalf Of Amitoj Kaur Chawla
Sent: Friday, November 06, 2015 9:57 AM
To: oleg.drokin at intel.com; andreas.dilger at intel.com; gregkh at linuxfoundation.org; lustre-devel at lists.lustre.org; devel at driverdev.osuosl.org; linux-kernel at vger.kernel.org
Subject: [lustre-devel] [PATCH] staging: lustre: lnet: klnds: socklnd: Move extern declarations to header

This patch moves extern declarations in socklnd_lib.c to the respective header file, 'socklnd.h'.

Quoted 8 lines

This patch also removes extern keyword from function declarations since functions have the extern specifier by default.

---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 3 +++
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c | 2 --

2 files changed, 3 insertions(+), 2 deletions(-)
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h +3 -0
index b349847..f4fa725 100644
@@ -679,6 +679,9 @@ int ksocknal_lib_recv_kiov(ksock_conn_t *conn);
 int ksocknal_lib_get_conn_tunables(ksock_conn_t *conn, int *txmem,
 				   int *rxmem, int *nagle);
 
+void ksocknal_read_callback(ksock_conn_t *conn);
+void ksocknal_write_callback(ksock_conn_t *conn);
+
 int ksocknal_tunables_init(void);
 
 void ksocknal_lib_csum_tx(ksock_tx_t *tx);
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c +0 -2
index 679785b..04a4653 100644
@@ -580,8 +580,6 @@ ksocknal_lib_push_conn(ksock_conn_t *conn)
 	ksocknal_connsock_decref(conn);
 }
 
-extern void ksocknal_read_callback(ksock_conn_t *conn);
-extern void ksocknal_write_callback(ksock_conn_t *conn);
 /*
  * socket call back in Linux
  */
Signature · 6 lines
1.9.1

_______________________________________________
lustre-devel mailing list
lustre-devel at lists.lustre.org
http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org