Skip to contentSkip to conversation

chromium: fix gcc5 compile issues

PATCH Superseded Max Krummenacher 6 participants 10 messages Nov 4, 2015 – Dec 1, 2015

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 chromium: fix gcc5 compile issues

A chromium build with gcc5 fails with warnings treated as errors.

bignum.cc, image_util.cc: strict-overflow warning

Compiles and runs on qemux86-64 with gcc 5.2.0 and still compiles on armv7a with gcc linaro-4.9.4.

---
 .../0001-bignum.cc-fix-warning-from-gcc-5.patch    | 56 ++++++++++++++++++++++
 ...-image_util.cc-disable-warning-from-gcc-5.patch | 37 ++++++++++++++
 recipes-browser/chromium/chromium_40.0.2214.91.bb  |  3 ++
 3 files changed, 96 insertions(+)
 create mode 100644 recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch
 create mode 100644 recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch
recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch new file +56 -0
new file mode 100644
index 0000000..f3d7f77
@@ -0,0 +1,56 @@
+From 689576b2f5c6398f6ef5203fe52edcf86b452790 Mon Sep 17 00:00:00 2001
+From: Max Krummenacher <[email protected]>
+Date: Tue, 3 Nov 2015 20:51:04 +0100
+Subject: [PATCH 1/2] bignum.cc: fix warning from gcc 5
+
+Refactoring the source seems to workaround the compiler warning.
+
+addresses:
+  ../../third_party/WebKit/Source/wtf/dtoa/bignum.cc:105:10: error: assuming
+  signed overflow does not occur when assuming that (X + c) < X is always
+  false [-Werror=strict-overflow]
+      void Bignum::AssignDecimalString(Vector<const char> value) {
+           ^
+
+Signed-off-by: Max Krummenacher <[email protected]>
+Upstream-Status: Pending
+
+---
+ third_party/WebKit/Source/wtf/dtoa/bignum.cc | 15 +++++++--------
+ 1 file changed, 7 insertions(+), 8 deletions(-)
+
+diff --git a/third_party/WebKit/Source/wtf/dtoa/bignum.cc b/third_party/WebKit/Source/wtf/dtoa/bignum.cc
+index a000b46..e5426dd 100644
+--- a/third_party/WebKit/Source/wtf/dtoa/bignum.cc
++++ b/third_party/WebKit/Source/wtf/dtoa/bignum.cc
+@@ -105,20 +105,19 @@ namespace double_conversion {
+     void Bignum::AssignDecimalString(Vector<const char> value) {
+         // 2^64 = 18446744073709551616 > 10^19
+         const int kMaxUint64DecimalDigits = 19;
++        int currentLen;
+         Zero();
+         int length = value.length();
+         int pos = 0;
+         // Let's just say that each digit needs 4 bits.
+-        while (length >= kMaxUint64DecimalDigits) {
+-            uint64_t digits = ReadUInt64(value, pos, kMaxUint64DecimalDigits);
+-            pos += kMaxUint64DecimalDigits;
+-            length -= kMaxUint64DecimalDigits;
+-            MultiplyByPowerOfTen(kMaxUint64DecimalDigits);
++        while (length > 0) {
++            currentLen = length > kMaxUint64DecimalDigits ? kMaxUint64DecimalDigits : length;
++            uint64_t digits = ReadUInt64(value, pos, currentLen);
++            MultiplyByPowerOfTen(currentLen);
+             AddUInt64(digits);
++            pos += currentLen;
++            length -= currentLen;
+         }
+-        uint64_t digits = ReadUInt64(value, pos, length);
+-        MultiplyByPowerOfTen(length);
+-        AddUInt64(digits);
+         Clamp();
+     }
+ 
+-- 
+1.8.4.5
+
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +37 -0
new file mode 100644
index 0000000..d62645b
@@ -0,0 +1,37 @@
+From 2f674d980a116075dc7123a3e243b1451e4a732d Mon Sep 17 00:00:00 2001
+From: Max Krummenacher <[email protected]>
+Date: Tue, 3 Nov 2015 22:13:40 +0100
+Subject: [PATCH 2/2] image_util.cc: disable warning from gcc 5
+
+addresses:
+  ../../ui/gfx/image/image_util.cc:50:6: error: assuming signed overflow does
+  not occur when assuming that (X - c) <= X is always true
+  [-Werror=strict-overflow]
+  bool VisibleMargins(const ImageSkia& image, int* leading, int* trailing) {
+       ^
+
+Signed-off-by: Max Krummenacher <[email protected]>
+Upstream-Status: Pending
+
+---
+ ui/gfx/image/image_util.cc | 3 +++
+ 1 file changed, 3 insertions(+)
+
+diff --git a/ui/gfx/image/image_util.cc b/ui/gfx/image/image_util.cc
+index 89a3f8c..d595da3 100644
+--- a/ui/gfx/image/image_util.cc
++++ b/ui/gfx/image/image_util.cc
+@@ -68,7 +68,10 @@ bool VisibleMargins(const ImageSkia& image, int* leading, int* trailing) {
+   int inner_min = bitmap.width();
+   for (int x = 0; x < bitmap.width(); ++x) {
+     for (int y = 0; y < bitmap.height(); ++y) {
++#pragma GCC diagnostic push
++#pragma GCC diagnostic warning "-Wstrict-overflow"
+       if (SkColorGetA(bitmap.getColor(x, y)) > kMinimumVisibleOpacity) {
++#pragma GCC diagnostic pop
+         inner_min = x;
+         break;
+       }
+-- 
+1.8.4.5
+
recipes-browser/chromium/chromium_40.0.2214.91.bb +3 -0
index 8bc05ee..3e00b8d 100644
@@ -28,7 +28,10 @@ SRC_URI = "\
         file://google-chrome.desktop \
         file://chromium-40/fix-build-error-with-GCC-in-Debug-mode.patch \
         file://chromium-40/add_missing_stat_h_include.patch \
+        file://chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch \
+        file://chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch \
 "
+
 #
 # * use-egl : Without this packageconfig, the Chromium build will use GLX for creating an OpenGL context in X11,
 #             and regular OpenGL for painting operations. Neither are desirable on embedded platforms. With this
Signature · 1 line
1.8.4.5
#1 lore raw
Quoted 10 lines · Max Krummenacher

A chromium build with gcc5 fails with warnings treated as errors.

bignum.cc, image_util.cc: strict-overflow warning

Compiles and runs on qemux86-64 with gcc 5.2.0 and still compiles on armv7a with gcc linaro-4.9.4.

this is ok

Quoted 137 lines

---

.../0001-bignum.cc-fix-warning-from-gcc-5.patch    | 56 ++++++++++++++++++++++
...-image_util.cc-disable-warning-from-gcc-5.patch | 37 ++++++++++++++
recipes-browser/chromium/chromium_40.0.2214.91.bb  |  3 ++
3 files changed, 96 insertions(+)

create mode 100644 recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch create mode 100644 recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch

recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch new file +56 -0
new file mode 100644
index 0000000..f3d7f77
@@ -0,0 +1,56 @@
+From 689576b2f5c6398f6ef5203fe52edcf86b452790 Mon Sep 17 00:00:00 2001
+From: Max Krummenacher <[email protected]>
+Date: Tue, 3 Nov 2015 20:51:04 +0100
+Subject: [PATCH 1/2] bignum.cc: fix warning from gcc 5
+
+Refactoring the source seems to workaround the compiler warning.
+
+addresses:
+  ../../third_party/WebKit/Source/wtf/dtoa/bignum.cc:105:10: error: assuming
+  signed overflow does not occur when assuming that (X + c) < X is always
+  false [-Werror=strict-overflow]
+      void Bignum::AssignDecimalString(Vector<const char> value) {
+           ^
+
+Signed-off-by: Max Krummenacher <[email protected]>
+Upstream-Status: Pending
+
+---
+ third_party/WebKit/Source/wtf/dtoa/bignum.cc | 15 +++++++--------
+ 1 file changed, 7 insertions(+), 8 deletions(-)
+
+diff --git a/third_party/WebKit/Source/wtf/dtoa/bignum.cc b/third_party/WebKit/Source/wtf/dtoa/bignum.cc
+index a000b46..e5426dd 100644
+--- a/third_party/WebKit/Source/wtf/dtoa/bignum.cc
++++ b/third_party/WebKit/Source/wtf/dtoa/bignum.cc
+@@ -105,20 +105,19 @@ namespace double_conversion {
+     void Bignum::AssignDecimalString(Vector<const char> value) {
+         // 2^64 = 18446744073709551616 > 10^19
+         const int kMaxUint64DecimalDigits = 19;
++        int currentLen;
+         Zero();
+         int length = value.length();
+         int pos = 0;
+         // Let's just say that each digit needs 4 bits.
+-        while (length >= kMaxUint64DecimalDigits) {
+-            uint64_t digits = ReadUInt64(value, pos, kMaxUint64DecimalDigits);
+-            pos += kMaxUint64DecimalDigits;
+-            length -= kMaxUint64DecimalDigits;
+-            MultiplyByPowerOfTen(kMaxUint64DecimalDigits);
++        while (length > 0) {
++            currentLen = length > kMaxUint64DecimalDigits ? kMaxUint64DecimalDigits : length;
++            uint64_t digits = ReadUInt64(value, pos, currentLen);
++            MultiplyByPowerOfTen(currentLen);
+             AddUInt64(digits);
++            pos += currentLen;
++            length -= currentLen;
+         }
+-        uint64_t digits = ReadUInt64(value, pos, length);
+-        MultiplyByPowerOfTen(length);
+-        AddUInt64(digits);
+         Clamp();
+     }
+
+--
+1.8.4.5
+
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +37 -0
new file mode 100644
index 0000000..d62645b
@@ -0,0 +1,37 @@
+From 2f674d980a116075dc7123a3e243b1451e4a732d Mon Sep 17 00:00:00 2001
+From: Max Krummenacher <[email protected]>
+Date: Tue, 3 Nov 2015 22:13:40 +0100
+Subject: [PATCH 2/2] image_util.cc: disable warning from gcc 5
+
+addresses:
+  ../../ui/gfx/image/image_util.cc:50:6: error: assuming signed overflow does
+  not occur when assuming that (X - c) <= X is always true
+  [-Werror=strict-overflow]
+  bool VisibleMargins(const ImageSkia& image, int* leading, int* trailing) {
+       ^
+
+Signed-off-by: Max Krummenacher <[email protected]>
+Upstream-Status: Pending
+
+---
+ ui/gfx/image/image_util.cc | 3 +++
+ 1 file changed, 3 insertions(+)
+
+diff --git a/ui/gfx/image/image_util.cc b/ui/gfx/image/image_util.cc
+index 89a3f8c..d595da3 100644
+--- a/ui/gfx/image/image_util.cc
++++ b/ui/gfx/image/image_util.cc
+@@ -68,7 +68,10 @@ bool VisibleMargins(const ImageSkia& image, int* leading, int* trailing) {
+   int inner_min = bitmap.width();
+   for (int x = 0; x < bitmap.width(); ++x) {
+     for (int y = 0; y < bitmap.height(); ++y) {
++#pragma GCC diagnostic push
++#pragma GCC diagnostic warning "-Wstrict-overflow"
+       if (SkColorGetA(bitmap.getColor(x, y)) > kMinimumVisibleOpacity) {
++#pragma GCC diagnostic pop
+         inner_min = x;
+         break;
+       }
+--
+1.8.4.5
+
recipes-browser/chromium/chromium_40.0.2214.91.bb +2 -0
index 8bc05ee..3e00b8d 100644
@@ -28,7 +28,10 @@ SRC_URI = "\
        file://google-chrome.desktop \
        file://chromium-40/fix-build-error-with-GCC-in-Debug-mode.patch \
        file://chromium-40/add_missing_stat_h_include.patch \
+        file://chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch \
+        file://chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch \

"
+
#
# * use-egl : Without this packageconfig, the Chromium build will use GLX for creating an OpenGL context in X11,
# and regular OpenGL for painting operations. Neither are desirable on embedded platforms. With this
--
1.8.4.5

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#2 lore raw

Why not using pragma in both cases?
See the discussion on the issue in Chromium upstream:

https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/3uwBwunIa7g

Z

Quoted 182 lines · Khem Raj
Quoted 2 lines

On Nov 4, 2015, at 1:50 PM, Max Krummenacher <[email protected]>

Quoted 8 lines · wrote:

A chromium build with gcc5 fails with warnings treated as errors.

bignum.cc, image_util.cc: strict-overflow warning

Compiles and runs on qemux86-64 with gcc 5.2.0 and still compiles on armv7a with gcc linaro-4.9.4.

this is ok

Quoted 3 lines

---
.../0001-bignum.cc-fix-warning-from-gcc-5.patch | 56

++++++++++++++++++++++

Quoted 4 lines

...-image_util.cc-disable-warning-from-gcc-5.patch | 37 ++++++++++++++ recipes-browser/chromium/chromium_40.0.2214.91.bb | 3 ++

3 files changed, 96 insertions(+)

create mode 100644

recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch

Quoted 1 line

create mode 100644

recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch

Quoted 2 lines

diff --git

a/recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch b/recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch

Quoted 4 lines

new file mode 100644
index 0000000..f3d7f77
--- /dev/null
+++

b/recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch

recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch line 9

Quoted 10 lines
recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch new file +9 -0
@@ -0,0 +1,56 @@
+From 689576b2f5c6398f6ef5203fe52edcf86b452790 Mon Sep 17 00:00:00 2001
+From: Max Krummenacher <[email protected]>
+Date: Tue, 3 Nov 2015 20:51:04 +0100
+Subject: [PATCH 1/2] bignum.cc: fix warning from gcc 5
+
+Refactoring the source seems to workaround the compiler warning.
+
+addresses:
+  ../../third_party/WebKit/Source/wtf/dtoa/bignum.cc:105:10: error:

assuming

Review line 10

Quoted 1 line
(quoted diff) +1 -0
+  signed overflow does not occur when assuming that (X + c) < X is

always

recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch

Quoted 12 lines
recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch new file +12 -0
+  false [-Werror=strict-overflow]
+      void Bignum::AssignDecimalString(Vector<const char> value) {
+           ^
+
+Signed-off-by: Max Krummenacher <[email protected]>
+Upstream-Status: Pending
+
+---
+ third_party/WebKit/Source/wtf/dtoa/bignum.cc | 15 +++++++--------
+ 1 file changed, 7 insertions(+), 8 deletions(-)
+
+diff --git a/third_party/WebKit/Source/wtf/dtoa/bignum.cc

b/third_party/WebKit/Source/wtf/dtoa/bignum.cc

Quoted 4 lines
recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch new file +4 -0
+index a000b46..e5426dd 100644
+--- a/third_party/WebKit/Source/wtf/dtoa/bignum.cc
++++ b/third_party/WebKit/Source/wtf/dtoa/bignum.cc
+@@ -105,20 +105,19 @@ namespace double_conversion {

recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch

Quoted 10 lines
recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch new file +10 -0
+     void Bignum::AssignDecimalString(Vector<const char> value) {
+         // 2^64 = 18446744073709551616 > 10^19
+         const int kMaxUint64DecimalDigits = 19;
++        int currentLen;
+         Zero();
+         int length = value.length();
+         int pos = 0;
+         // Let's just say that each digit needs 4 bits.
+-        while (length >= kMaxUint64DecimalDigits) {
+-            uint64_t digits = ReadUInt64(value, pos,

kMaxUint64DecimalDigits);

recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch

Quoted 5 lines
recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch new file +5 -0
+-            pos += kMaxUint64DecimalDigits;
+-            length -= kMaxUint64DecimalDigits;
+-            MultiplyByPowerOfTen(kMaxUint64DecimalDigits);
++        while (length > 0) {
++            currentLen = length > kMaxUint64DecimalDigits ?

kMaxUint64DecimalDigits : length;

Quoted 15 lines
recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch new file +15 -0
++            uint64_t digits = ReadUInt64(value, pos, currentLen);
++            MultiplyByPowerOfTen(currentLen);
+             AddUInt64(digits);
++            pos += currentLen;
++            length -= currentLen;
+         }
+-        uint64_t digits = ReadUInt64(value, pos, length);
+-        MultiplyByPowerOfTen(length);
+-        AddUInt64(digits);
+         Clamp();
+     }
+
+--
+1.8.4.5
+
Quoted 1 line

diff --git

a/recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch b/recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch

Quoted 4 lines

new file mode 100644
index 0000000..d62645b
--- /dev/null
+++

b/recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch

recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch line 7

Quoted 8 lines
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +7 -0
@@ -0,0 +1,37 @@
+From 2f674d980a116075dc7123a3e243b1451e4a732d Mon Sep 17 00:00:00 2001
+From: Max Krummenacher <[email protected]>
+Date: Tue, 3 Nov 2015 22:13:40 +0100
+Subject: [PATCH 2/2] image_util.cc: disable warning from gcc 5
+
+addresses:
+  ../../ui/gfx/image/image_util.cc:50:6: error: assuming signed

overflow does

recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch

Quoted 3 lines
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +3 -0
+  not occur when assuming that (X - c) <= X is always true
+  [-Werror=strict-overflow]
+  bool VisibleMargins(const ImageSkia& image, int* leading, int*

trailing) {

Quoted 4 lines
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +4 -0
+       ^
+
+Signed-off-by: Max Krummenacher <[email protected]>
+Upstream-Status: Pending

recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch

Quoted 10 lines
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +10 -0
+
+---
+ ui/gfx/image/image_util.cc | 3 +++
+ 1 file changed, 3 insertions(+)
+
+diff --git a/ui/gfx/image/image_util.cc b/ui/gfx/image/image_util.cc
+index 89a3f8c..d595da3 100644
+--- a/ui/gfx/image/image_util.cc
++++ b/ui/gfx/image/image_util.cc
+@@ -68,7 +68,10 @@ bool VisibleMargins(const ImageSkia& image, int*

leading, int* trailing) {

recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch

Quoted 6 lines
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +6 -0
+   int inner_min = bitmap.width();
+   for (int x = 0; x < bitmap.width(); ++x) {
+     for (int y = 0; y < bitmap.height(); ++y) {
++#pragma GCC diagnostic push
++#pragma GCC diagnostic warning "-Wstrict-overflow"
+       if (SkColorGetA(bitmap.getColor(x, y)) > kMinimumVisibleOpacity)

{

Review

Quoted 8 lines
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +7 -0
++#pragma GCC diagnostic pop
+         inner_min = x;
+         break;
+       }
+--
+1.8.4.5
+
(quoted diff) +0 -0

b/recipes-browser/chromium/chromium_40.0.2214.91.bb

recipes-browser/chromium/chromium_40.0.2214.91.bb SRC_URI = "\ · line 32

Quoted 9 lines

index 8bc05ee..3e00b8d 100644

recipes-browser/chromium/chromium_40.0.2214.91.bb +2 -0
@@ -28,7 +28,10 @@ SRC_URI = "\
        file://google-chrome.desktop \
        file://chromium-40/fix-build-error-with-GCC-in-Debug-mode.patch \
        file://chromium-40/add_missing_stat_h_include.patch \
+        file://chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch \
+

file://chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch \

Quoted 4 lines

"
+
#
# * use-egl : Without this packageconfig, the Chromium build will use

GLX for creating an OpenGL context in X11,

Quoted 1 line

# and regular OpenGL for painting operations. Neither are

desirable on embedded platforms. With this

Quoted 8 lines

--
1.8.4.5

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 5 lines
Zoltan Kuscsik

Senior Software Developer, Linaro Digital Home Group
email: [email protected]
IRC: zoli_ on irc.linaro.org
#3 lore raw

Hi Zoltan, Khem

2015-11-05 7:31 GMT+01:00 Zoltan Kuscsik <[email protected]>:

Quoted 1 line

Why not using pragma in both cases?

Because I started bignum.cc and found a quick fix without the pragma. And in the second case I did not.

I will rework the patch to silence the warning with a pragma in both cases without touching the code.

Quoted 3 lines

See the discussion on the issue in Chromium upstream:

https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/3uwBwunIa7g

I looked at the upstream git repo and googled but did not find the discussion already going on.

I'll will rework the upstream status to point to this URL also.

Quoted 18 lines

Z

Quoted 13 lines · Khem Raj
Quoted 2 lines

On Nov 4, 2015, at 1:50 PM, Max Krummenacher <[email protected]>

Quoted 8 lines · wrote:

A chromium build with gcc5 fails with warnings treated as errors.

bignum.cc, image_util.cc: strict-overflow warning

Compiles and runs on qemux86-64 with gcc 5.2.0 and still compiles on armv7a with gcc linaro-4.9.4.

this is ok

Thanks.

Quoted 174 lines
Quoted 162 lines
Quoted 4 lines

---
.../0001-bignum.cc-fix-warning-from-gcc-5.patch | 56

++++++++++++++++++++++

Quoted 4 lines

...-image_util.cc-disable-warning-from-gcc-5.patch | 37 ++++++++++++++ recipes-browser/chromium/chromium_40.0.2214.91.bb | 3 ++

3 files changed, 96 insertions(+)

create mode 100644

recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch

Quoted 1 line

create mode 100644

recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch

Quoted 2 lines

diff --git

a/recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch b/recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch

Quoted 4 lines

new file mode 100644
index 0000000..f3d7f77
--- /dev/null
+++

b/recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch

recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch line 9

Quoted 10 lines
recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch new file +9 -0
@@ -0,0 +1,56 @@
+From 689576b2f5c6398f6ef5203fe52edcf86b452790 Mon Sep 17 00:00:00 2001
+From: Max Krummenacher <[email protected]>
+Date: Tue, 3 Nov 2015 20:51:04 +0100
+Subject: [PATCH 1/2] bignum.cc: fix warning from gcc 5
+
+Refactoring the source seems to workaround the compiler warning.
+
+addresses:
+  ../../third_party/WebKit/Source/wtf/dtoa/bignum.cc:105:10: error:

assuming

Review line 10

Quoted 1 line
(quoted diff) +1 -0
+  signed overflow does not occur when assuming that (X + c) < X is

always

recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch

Quoted 12 lines
recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch new file +12 -0
+  false [-Werror=strict-overflow]
+      void Bignum::AssignDecimalString(Vector<const char> value) {
+           ^
+
+Signed-off-by: Max Krummenacher <[email protected]>
+Upstream-Status: Pending
+
+---
+ third_party/WebKit/Source/wtf/dtoa/bignum.cc | 15 +++++++--------
+ 1 file changed, 7 insertions(+), 8 deletions(-)
+
+diff --git a/third_party/WebKit/Source/wtf/dtoa/bignum.cc

b/third_party/WebKit/Source/wtf/dtoa/bignum.cc

Quoted 4 lines
recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch new file +4 -0
+index a000b46..e5426dd 100644
+--- a/third_party/WebKit/Source/wtf/dtoa/bignum.cc
++++ b/third_party/WebKit/Source/wtf/dtoa/bignum.cc
+@@ -105,20 +105,19 @@ namespace double_conversion {

recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch

Quoted 10 lines
recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch new file +10 -0
+     void Bignum::AssignDecimalString(Vector<const char> value) {
+         // 2^64 = 18446744073709551616 > 10^19
+         const int kMaxUint64DecimalDigits = 19;
++        int currentLen;
+         Zero();
+         int length = value.length();
+         int pos = 0;
+         // Let's just say that each digit needs 4 bits.
+-        while (length >= kMaxUint64DecimalDigits) {
+-            uint64_t digits = ReadUInt64(value, pos,

kMaxUint64DecimalDigits);

recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch

Quoted 5 lines
recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch new file +5 -0
+-            pos += kMaxUint64DecimalDigits;
+-            length -= kMaxUint64DecimalDigits;
+-            MultiplyByPowerOfTen(kMaxUint64DecimalDigits);
++        while (length > 0) {
++            currentLen = length > kMaxUint64DecimalDigits ?

kMaxUint64DecimalDigits : length;

Quoted 15 lines
recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch new file +15 -0
++            uint64_t digits = ReadUInt64(value, pos, currentLen);
++            MultiplyByPowerOfTen(currentLen);
+             AddUInt64(digits);
++            pos += currentLen;
++            length -= currentLen;
+         }
+-        uint64_t digits = ReadUInt64(value, pos, length);
+-        MultiplyByPowerOfTen(length);
+-        AddUInt64(digits);
+         Clamp();
+     }
+
+--
+1.8.4.5
+
Quoted 1 line

diff --git

a/recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch b/recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch

Quoted 4 lines

new file mode 100644
index 0000000..d62645b
--- /dev/null
+++

b/recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch

recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch line 7

Quoted 8 lines
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +7 -0
@@ -0,0 +1,37 @@
+From 2f674d980a116075dc7123a3e243b1451e4a732d Mon Sep 17 00:00:00 2001
+From: Max Krummenacher <[email protected]>
+Date: Tue, 3 Nov 2015 22:13:40 +0100
+Subject: [PATCH 2/2] image_util.cc: disable warning from gcc 5
+
+addresses:
+  ../../ui/gfx/image/image_util.cc:50:6: error: assuming signed

overflow does

recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch

Quoted 3 lines
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +3 -0
+  not occur when assuming that (X - c) <= X is always true
+  [-Werror=strict-overflow]
+  bool VisibleMargins(const ImageSkia& image, int* leading, int*

trailing) {

Quoted 4 lines
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +4 -0
+       ^
+
+Signed-off-by: Max Krummenacher <[email protected]>
+Upstream-Status: Pending

recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch

Quoted 10 lines
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +10 -0
+
+---
+ ui/gfx/image/image_util.cc | 3 +++
+ 1 file changed, 3 insertions(+)
+
+diff --git a/ui/gfx/image/image_util.cc b/ui/gfx/image/image_util.cc
+index 89a3f8c..d595da3 100644
+--- a/ui/gfx/image/image_util.cc
++++ b/ui/gfx/image/image_util.cc
+@@ -68,7 +68,10 @@ bool VisibleMargins(const ImageSkia& image, int*

leading, int* trailing) {

recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch

Quoted 6 lines
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +6 -0
+   int inner_min = bitmap.width();
+   for (int x = 0; x < bitmap.width(); ++x) {
+     for (int y = 0; y < bitmap.height(); ++y) {
++#pragma GCC diagnostic push
++#pragma GCC diagnostic warning "-Wstrict-overflow"
+       if (SkColorGetA(bitmap.getColor(x, y)) > kMinimumVisibleOpacity)

{

Review

Quoted 8 lines
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +7 -0
++#pragma GCC diagnostic pop
+         inner_min = x;
+         break;
+       }
+--
+1.8.4.5
+
(quoted diff) +0 -0

b/recipes-browser/chromium/chromium_40.0.2214.91.bb

recipes-browser/chromium/chromium_40.0.2214.91.bb SRC_URI = "\ · line 32

Quoted 9 lines

index 8bc05ee..3e00b8d 100644

recipes-browser/chromium/chromium_40.0.2214.91.bb +2 -0
@@ -28,7 +28,10 @@ SRC_URI = "\
        file://google-chrome.desktop \
        file://chromium-40/fix-build-error-with-GCC-in-Debug-mode.patch \
        file://chromium-40/add_missing_stat_h_include.patch \
+        file://chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch \
+

file://chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch \

Quoted 4 lines

"
+
#
# * use-egl : Without this packageconfig, the Chromium build will use

GLX for creating an OpenGL context in X11,

Quoted 1 line

# and regular OpenGL for painting operations. Neither are

desirable on embedded platforms. With this

Quoted 8 lines

--
1.8.4.5

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Quoted 7 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
Zoltan Kuscsik

Quoted 8 lines

Senior Software Developer, Linaro Digital Home Group
email: [email protected]
IRC: zoli_ on irc.linaro.org
--
_______________________________________________
Openembedded-devel mailing list [email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Regards
Max

#4 lore raw
Quoted 11 lines · Max Krummenacher

Hi Zoltan, Khem

2015-11-05 7:31 GMT+01:00 Zoltan Kuscsik <[email protected]>:

Quoted 1 line

Why not using pragma in both cases?

Because I started bignum.cc and found a quick fix without the pragma. And in the second case I did not.

I will rework the patch to silence the warning with a pragma in both cases without touching the code.

Quoted 8 lines
Quoted 3 lines

See the discussion on the issue in Chromium upstream:

https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/3uwBwunIa7g

I looked at the upstream git repo and googled but did not find the discussion already going on.

I'll will rework the upstream status to point to this URL also.

After long time first successful chromium build in bitbake world.. Thanks!

Can you apply the same fix for cef3 recipes?
http://errors.yoctoproject.org/Errors/Details/21442/

cef3 for qemux86-64 doesn't even configure:
http://errors.yoctoproject.org/Errors/Details/21501/

Quoted 208 lines
Quoted 8 lines · Khem Raj
Quoted 7 lines
Quoted 3 lines

On Nov 4, 2015, at 1:50 PM, Max Krummenacher <[email protected]>

Quoted 3 lines · wrote:

A chromium build with gcc5 fails with warnings treated as errors.

Quoted 7 lines
Quoted 7 lines
Quoted 5 lines

bignum.cc, image_util.cc: strict-overflow warning

Compiles and runs on qemux86-64 with gcc 5.2.0 and still compiles on armv7a with gcc linaro-4.9.4.

this is ok

Thanks.

Quoted 174 lines
Quoted 162 lines
Quoted 4 lines

---
.../0001-bignum.cc-fix-warning-from-gcc-5.patch | 56

++++++++++++++++++++++

Quoted 4 lines

...-image_util.cc-disable-warning-from-gcc-5.patch | 37 ++++++++++++++ recipes-browser/chromium/chromium_40.0.2214.91.bb | 3 ++

3 files changed, 96 insertions(+)

create mode 100644

recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch

Quoted 1 line

create mode 100644

recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch

Quoted 2 lines

diff --git

a/recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch b/recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch

Quoted 4 lines

new file mode 100644
index 0000000..f3d7f77
--- /dev/null
+++

b/recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch

recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch line 9

Quoted 10 lines
recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch new file +9 -0
@@ -0,0 +1,56 @@
+From 689576b2f5c6398f6ef5203fe52edcf86b452790 Mon Sep 17 00:00:00 2001
+From: Max Krummenacher <[email protected]>
+Date: Tue, 3 Nov 2015 20:51:04 +0100
+Subject: [PATCH 1/2] bignum.cc: fix warning from gcc 5
+
+Refactoring the source seems to workaround the compiler warning.
+
+addresses:
+  ../../third_party/WebKit/Source/wtf/dtoa/bignum.cc:105:10: error:

assuming

Review line 10

Quoted 1 line
(quoted diff) +1 -0
+  signed overflow does not occur when assuming that (X + c) < X is

always

recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch

Quoted 12 lines
recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch new file +12 -0
+  false [-Werror=strict-overflow]
+      void Bignum::AssignDecimalString(Vector<const char> value) {
+           ^
+
+Signed-off-by: Max Krummenacher <[email protected]>
+Upstream-Status: Pending
+
+---
+ third_party/WebKit/Source/wtf/dtoa/bignum.cc | 15 +++++++--------
+ 1 file changed, 7 insertions(+), 8 deletions(-)
+
+diff --git a/third_party/WebKit/Source/wtf/dtoa/bignum.cc

b/third_party/WebKit/Source/wtf/dtoa/bignum.cc

Quoted 4 lines
recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch new file +4 -0
+index a000b46..e5426dd 100644
+--- a/third_party/WebKit/Source/wtf/dtoa/bignum.cc
++++ b/third_party/WebKit/Source/wtf/dtoa/bignum.cc
+@@ -105,20 +105,19 @@ namespace double_conversion {

recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch

Quoted 10 lines
recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch new file +10 -0
+     void Bignum::AssignDecimalString(Vector<const char> value) {
+         // 2^64 = 18446744073709551616 > 10^19
+         const int kMaxUint64DecimalDigits = 19;
++        int currentLen;
+         Zero();
+         int length = value.length();
+         int pos = 0;
+         // Let's just say that each digit needs 4 bits.
+-        while (length >= kMaxUint64DecimalDigits) {
+-            uint64_t digits = ReadUInt64(value, pos,

kMaxUint64DecimalDigits);

recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch

Quoted 5 lines
recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch new file +5 -0
+-            pos += kMaxUint64DecimalDigits;
+-            length -= kMaxUint64DecimalDigits;
+-            MultiplyByPowerOfTen(kMaxUint64DecimalDigits);
++        while (length > 0) {
++            currentLen = length > kMaxUint64DecimalDigits ?

kMaxUint64DecimalDigits : length;

Quoted 15 lines
recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch new file +15 -0
++            uint64_t digits = ReadUInt64(value, pos, currentLen);
++            MultiplyByPowerOfTen(currentLen);
+             AddUInt64(digits);
++            pos += currentLen;
++            length -= currentLen;
+         }
+-        uint64_t digits = ReadUInt64(value, pos, length);
+-        MultiplyByPowerOfTen(length);
+-        AddUInt64(digits);
+         Clamp();
+     }
+
+--
+1.8.4.5
+
Quoted 1 line

diff --git

a/recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch b/recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch

Quoted 4 lines

new file mode 100644
index 0000000..d62645b
--- /dev/null
+++

b/recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch

recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch line 7

Quoted 8 lines
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +7 -0
@@ -0,0 +1,37 @@
+From 2f674d980a116075dc7123a3e243b1451e4a732d Mon Sep 17 00:00:00 2001
+From: Max Krummenacher <[email protected]>
+Date: Tue, 3 Nov 2015 22:13:40 +0100
+Subject: [PATCH 2/2] image_util.cc: disable warning from gcc 5
+
+addresses:
+  ../../ui/gfx/image/image_util.cc:50:6: error: assuming signed

overflow does

recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch

Quoted 3 lines
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +3 -0
+  not occur when assuming that (X - c) <= X is always true
+  [-Werror=strict-overflow]
+  bool VisibleMargins(const ImageSkia& image, int* leading, int*

trailing) {

Quoted 4 lines
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +4 -0
+       ^
+
+Signed-off-by: Max Krummenacher <[email protected]>
+Upstream-Status: Pending

recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch

Quoted 10 lines
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +10 -0
+
+---
+ ui/gfx/image/image_util.cc | 3 +++
+ 1 file changed, 3 insertions(+)
+
+diff --git a/ui/gfx/image/image_util.cc b/ui/gfx/image/image_util.cc
+index 89a3f8c..d595da3 100644
+--- a/ui/gfx/image/image_util.cc
++++ b/ui/gfx/image/image_util.cc
+@@ -68,7 +68,10 @@ bool VisibleMargins(const ImageSkia& image, int*

leading, int* trailing) {

recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch

Quoted 6 lines
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +6 -0
+   int inner_min = bitmap.width();
+   for (int x = 0; x < bitmap.width(); ++x) {
+     for (int y = 0; y < bitmap.height(); ++y) {
++#pragma GCC diagnostic push
++#pragma GCC diagnostic warning "-Wstrict-overflow"
+       if (SkColorGetA(bitmap.getColor(x, y)) > kMinimumVisibleOpacity)

{

Review

Quoted 8 lines
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +7 -0
++#pragma GCC diagnostic pop
+         inner_min = x;
+         break;
+       }
+--
+1.8.4.5
+
(quoted diff) +0 -0

b/recipes-browser/chromium/chromium_40.0.2214.91.bb

recipes-browser/chromium/chromium_40.0.2214.91.bb SRC_URI = "\ · line 32

Quoted 9 lines

index 8bc05ee..3e00b8d 100644

recipes-browser/chromium/chromium_40.0.2214.91.bb +2 -0
@@ -28,7 +28,10 @@ SRC_URI = "\
        file://google-chrome.desktop \
        file://chromium-40/fix-build-error-with-GCC-in-Debug-mode.patch \
        file://chromium-40/add_missing_stat_h_include.patch \
+        file://chromium-40/0001-bignum.cc-fix-warning-from-gcc-5.patch \
+

file://chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch \

Quoted 4 lines

"
+
#
# * use-egl : Without this packageconfig, the Chromium build will use

GLX for creating an OpenGL context in X11,

Quoted 1 line

# and regular OpenGL for painting operations. Neither are

desirable on embedded platforms. With this

Quoted 8 lines

--
1.8.4.5

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Quoted 7 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
Zoltan Kuscsik

Quoted 8 lines

Senior Software Developer, Linaro Digital Home Group
email: [email protected]
IRC: zoli_ on irc.linaro.org
--
_______________________________________________
Openembedded-devel mailing list [email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Regards
Max

Signature · 4 lines
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#5 lore raw

Hi
Am Freitag, den 06.11.2015, 18:17 +0100 schrieb Martin Jansa:

Quoted 9 lines

After long time first successful chromium build in bitbake world.. Thanks!

Can you apply the same fix for cef3 recipes?
http://errors.yoctoproject.org/Errors/Details/21442/

cef3 for qemux86-64 doesn't even configure:
http://errors.yoctoproject.org/Errors/Details/21501/

I'll try to fix this.

It looks like this never worked for x86-64 because of a missing config file.
One probably can reuse the i568 one.

There seem to be additional errors to the one fixed with the packages. So
maybe I won't be able to fix it.

Regards
Max

#6 lore raw
Quoted 14 lines · Max Krummenacher

Hi
Am Freitag, den 06.11.2015, 18:17 +0100 schrieb Martin Jansa:

Quoted 9 lines

After long time first successful chromium build in bitbake world.. Thanks!

Can you apply the same fix for cef3 recipes?
http://errors.yoctoproject.org/Errors/Details/21442/

cef3 for qemux86-64 doesn't even configure:
http://errors.yoctoproject.org/Errors/Details/21501/

I'll try to fix this.

Quoted 7 lines

It looks like this never worked for x86-64 because of a missing config file.
One probably can reuse the i568 one.

There seem to be additional errors to the one fixed with the packages. So
maybe I won't be able to fix it.

Send a complete patchset and we apply them all ;-)

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#7 lore raw

I'm getting segfaults when I run google-chrome on my nitrogen6x after the new updates. Compiles great, just segfaults. Anyone else noticing similar problems? I'll be digging into it more, thought I'd reach out first though.

Thanks,
-Ian

Quoted 36 lines · Otavio Salvador
Quoted 14 lines · Max Krummenacher

Hi
Am Freitag, den 06.11.2015, 18:17 +0100 schrieb Martin Jansa:

Quoted 9 lines

After long time first successful chromium build in bitbake world.. Thanks!

Can you apply the same fix for cef3 recipes?
http://errors.yoctoproject.org/Errors/Details/21442/

cef3 for qemux86-64 doesn't even configure:
http://errors.yoctoproject.org/Errors/Details/21501/

I'll try to fix this.

Quoted 7 lines

It looks like this never worked for x86-64 because of a missing config file.
One probably can reuse the i568 one.

There seem to be additional errors to the one fixed with the packages. So
maybe I won't be able to fix it.

Send a complete patchset and we apply them all ;-)

--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#8 lore raw
Quoted 3 lines · Ian Coolidge

I'm getting segfaults when I run google-chrome on my nitrogen6x after the new updates. Compiles great, just segfaults. Anyone else noticing similar problems? I'll be digging into it more, thought I'd reach out first though.

are you using gcc5 ?

Quoted 48 lines

Thanks,
-Ian

Quoted 26 lines · Otavio Salvador
Quoted 14 lines · Max Krummenacher

Hi
Am Freitag, den 06.11.2015, 18:17 +0100 schrieb Martin Jansa:

Quoted 9 lines

After long time first successful chromium build in bitbake world.. Thanks!

Can you apply the same fix for cef3 recipes?
http://errors.yoctoproject.org/Errors/Details/21442/

cef3 for qemux86-64 doesn't even configure:
http://errors.yoctoproject.org/Errors/Details/21501/

I'll try to fix this.

Quoted 7 lines

It looks like this never worked for x86-64 because of a missing config file.
One probably can reuse the i568 one.

There seem to be additional errors to the one fixed with the packages. So
maybe I won't be able to fix it.

Send a complete patchset and we apply them all ;-)

Quoted 10 lines

--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#9 lore raw

Yes. Building through Yocto Jethro, uses GCC 5.2

Quoted 63 lines · Khem Raj
Quoted 3 lines · Ian Coolidge

I'm getting segfaults when I run google-chrome on my nitrogen6x after the new updates. Compiles great, just segfaults. Anyone else noticing similar problems? I'll be digging into it more, thought I'd reach out first

though.

are you using gcc5 ?

Quoted 43 lines

Thanks,
-Ian

Quoted 26 lines · Otavio Salvador
Quoted 14 lines · Max Krummenacher

Hi
Am Freitag, den 06.11.2015, 18:17 +0100 schrieb Martin Jansa:

Quoted 9 lines

After long time first successful chromium build in bitbake world.. Thanks!

Can you apply the same fix for cef3 recipes?
http://errors.yoctoproject.org/Errors/Details/21442/

cef3 for qemux86-64 doesn't even configure:
http://errors.yoctoproject.org/Errors/Details/21501/

I'll try to fix this.

Quoted 7 lines

It looks like this never worked for x86-64 because of a missing config file.
One probably can reuse the i568 one.

There seem to be additional errors to the one fixed with the packages. So
maybe I won't be able to fix it.

Send a complete patchset and we apply them all ;-)

Quoted 10 lines

--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel