Skip to contentSkip to conversation

system: Fix warning when selecting systemd

PATCH New Maxime Hadjinlian 4 participants 5 messages Nov 6, 2015 – Nov 9, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 system: Fix warning when selecting systemd

With systemd and a custom skeleton, you end up with the following warning:
warning: (BR2_INIT_SYSTEMD) selects BR2_ROOTFS_MERGED_USR which has unmet direct dependencies (BR2_ROOTFS_SKELETON_DEFAULT)

---
 system/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
system/Config.in +1 -1
index 4d07010..92712a8 100644
@@ -92,7 +92,7 @@ config BR2_INIT_SYSTEMD
 	depends on BR2_USE_MMU
 	depends on !BR2_STATIC_LIBS
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
-	select BR2_ROOTFS_MERGED_USR
+	select BR2_ROOTFS_MERGED_USR if BR2_ROOTFS_SKELETON_DEFAULT
 	select BR2_PACKAGE_SYSTEMD
 
 comment "systemd needs (e)glibc toolchain, headers >= 3.10"
Signature · 1 line
2.6.1
#1 lore raw

PATCH 1/1 system: Fix warning when selecting systemd

Maxime, All,

On 2015-11-06 19:23 +0100, Maxime Hadjinlian spake thusly:

Quoted 6 lines

With systemd and a custom skeleton, you end up with the following warning:
warning: (BR2_INIT_SYSTEMD) selects BR2_ROOTFS_MERGED_USR which has unmet direct dependencies (BR2_ROOTFS_SKELETON_DEFAULT)

Regards,
Yann E. MORIN.

Quoted 20 lines
---
 system/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
system/Config.in +1 -1
index 4d07010..92712a8 100644
@@ -92,7 +92,7 @@ config BR2_INIT_SYSTEMD
 	depends on BR2_USE_MMU
 	depends on !BR2_STATIC_LIBS
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
-	select BR2_ROOTFS_MERGED_USR
+	select BR2_ROOTFS_MERGED_USR if BR2_ROOTFS_SKELETON_DEFAULT
 	select BR2_PACKAGE_SYSTEMD
 
 comment "systemd needs (e)glibc toolchain, headers >= 3.10"
Signature · 1 line
2.6.1
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 system: Fix warning when selecting systemd

In reply to Maxime Hadjinlian

Dear Maxime Hadjinlian,

Quoted 9 lines · Maxime Hadjinlian

With systemd and a custom skeleton, you end up with the following warning:
warning: (BR2_INIT_SYSTEMD) selects BR2_ROOTFS_MERGED_USR which has unmet direct dependencies (BR2_ROOTFS_SKELETON_DEFAULT)

---
 system/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 system: Fix warning when selecting systemd

In reply to Maxime Hadjinlian
Quoted 17 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Maxime" == Maxime Hadjinlian <[email protected]> writes:

With systemd and a custom skeleton, you end up with the following warning:
warning: (BR2_INIT_SYSTEMD) selects BR2_ROOTFS_MERGED_USR which has unmet direct dependencies (BR2_ROOTFS_SKELETON_DEFAULT)

---
 system/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
system/Config.in +0 -0
index 4d07010..92712a8 100644

system/Config.in config BR2_INIT_SYSTEMD · line 95

Quoted 5 lines
system/Config.in +1 -1
@@ -92,7 +92,7 @@ config BR2_INIT_SYSTEMD
 	depends on BR2_USE_MMU
 	depends on !BR2_STATIC_LIBS
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
-	select BR2_ROOTFS_MERGED_USR
+	select BR2_ROOTFS_MERGED_USR if BR2_ROOTFS_SKELETON_DEFAULT

Hmm, we have a number of workarounds for merged /usr under package/, so those packages will break with a custom skeleton (that contains a merged /usr as required by systemd) as those workarounds are not performed.

Perhaps we should instead introduce a hidden BR2_ROOTFS_MERGED_USR kconfig option for the !BR2_ROOTFS_SKELETON_DEFAULT case?

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/1 system: Fix warning when selecting systemd

Peter, All,

On 2015-11-09 21:31 +0100, Peter Korsgaard spake thusly:

Quoted 27 lines
Quoted 17 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Maxime" == Maxime Hadjinlian <[email protected]> writes:

With systemd and a custom skeleton, you end up with the following warning:
warning: (BR2_INIT_SYSTEMD) selects BR2_ROOTFS_MERGED_USR which has unmet direct dependencies (BR2_ROOTFS_SKELETON_DEFAULT)

---
 system/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
system/Config.in +0 -0
index 4d07010..92712a8 100644

system/Config.in config BR2_INIT_SYSTEMD · line 95

Quoted 5 lines
system/Config.in +1 -1
@@ -92,7 +92,7 @@ config BR2_INIT_SYSTEMD
 	depends on BR2_USE_MMU
 	depends on !BR2_STATIC_LIBS
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
-	select BR2_ROOTFS_MERGED_USR
+	select BR2_ROOTFS_MERGED_USR if BR2_ROOTFS_SKELETON_DEFAULT

Hmm, we have a number of workarounds for merged /usr under package/, so those packages will break with a custom skeleton (that contains a merged /usr as required by systemd) as those workarounds are not performed.

Quoted 2 lines

Perhaps we should instead introduce a hidden BR2_ROOTFS_MERGED_USR kconfig option for the !BR2_ROOTFS_SKELETON_DEFAULT case?

Hmm... Good point. I'll see to work on it...

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'