Skip to contentSkip to conversation

package/mpg123: fix static linking issue with alsa

PATCH New Bernd Kuhls 2 participants 2 messages Nov 8, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/mpg123: fix static linking issue with alsa

As opposed to the other audio backends, the configure script does NOT use pkg-config to figure out how to link with alsa, breaking static linking as alsa uses pthreads.

This patch uses the same fix from Peter used for portaudio:
http://git.buildroot.net/buildroot/commit/package/mpg123/mpg123.mk?id=dea306c78b5d4c571555c50512e212a725b594b9

Fixes
http://autobuild.buildroot.net/results/796/79613fda3f51e969ecd46ae1151bd4c3316639c3/
http://autobuild.buildroot.net/results/b0a/b0a99ff1516602ed42c0cc14d9d2922a01cdf88f/
http://autobuild.buildroot.net/results/5bd/5bdfd2aa9de568d0f7be27ffb18d4541b0e1be0c/
and many others

---
 package/mpg123/mpg123.mk | 3 +++
 1 file changed, 3 insertions(+)
package/mpg123/mpg123.mk +3 -0
index efd510d..f6bb297 100644
@@ -67,6 +67,9 @@ ifeq ($(BR2_PACKAGE_ALSA_LIB),y)
 MPG123_AUDIO += alsa
 MPG123_CONF_OPTS += --with-default-audio=alsa
 MPG123_DEPENDENCIES += alsa-lib
+# configure script does NOT use pkg-config to figure out how to link
+# with alsa, breaking static linking as alsa uses pthreads
+MPG123_CONF_ENV += LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs alsa`"
 endif
 
 MPG123_CONF_OPTS += --with-audio=$(subst $(space),$(comma),$(MPG123_AUDIO))
Signature · 1 line
2.6.2
#1 lore raw

PATCH 1/1 package/mpg123: fix static linking issue with alsa

Dear Bernd Kuhls,

Quoted 13 lines · Bernd Kuhls

As opposed to the other audio backends, the configure script does NOT use pkg-config to figure out how to link with alsa, breaking static linking as alsa uses pthreads.

This patch uses the same fix from Peter used for portaudio:
http://git.buildroot.net/buildroot/commit/package/mpg123/mpg123.mk?id=dea306c78b5d4c571555c50512e212a725b594b9

Fixes
http://autobuild.buildroot.net/results/796/79613fda3f51e969ecd46ae1151bd4c3316639c3/
http://autobuild.buildroot.net/results/b0a/b0a99ff1516602ed42c0cc14d9d2922a01cdf88f/
http://autobuild.buildroot.net/results/5bd/5bdfd2aa9de568d0f7be27ffb18d4541b0e1be0c/
and many others

Quoted 4 lines
---
 package/mpg123/mpg123.mk | 3 +++
 1 file changed, 3 insertions(+)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com