chromium/cef3: fix gcc build errors
v2 cover chromium/cef3: fix gcc build errors
v2:
Review Zoltan Kuscsik:
- prefer #pragma silencing of error over code refactoring
- add link to upstream discussion
Review Martin Jansa:
- port fixes to cef3 also
Max Krummenacher (5):
chromium: fix gcc5 compile issues
cef3_280796.bb: change indent to 4 spaces
cef3: fix gcc5 compile issues
cef3: fix build of x86-64
cef3: fix build with gcc 4.9.4
...0001-bignum.cc-disable-warning-from-gcc-5.patch | 39 ++++++++++++++++++++ ...-image_util.cc-disable-warning-from-gcc-5.patch | 40 ++++++++++++++++++++ ...-test.h-disable-warning-unused-definition.patch | 43 ++++++++++++++++++++++ ...ithmetic.h-put-parentheses-to-silence-war.patch | 39 ++++++++++++++++++++ recipes-browser/chromium/cef3_280796.bb | 33 ++++++++++++----- ...0001-bignum.cc-disable-warning-from-gcc-5.patch | 39 ++++++++++++++++++++ ...-image_util.cc-disable-warning-from-gcc-5.patch | 40 ++++++++++++++++++++ recipes-browser/chromium/chromium_40.0.2214.91.bb | 3 ++ 8 files changed, 266 insertions(+), 10 deletions(-) create mode 100644 recipes-browser/chromium/cef3/0001-bignum.cc-disable-warning-from-gcc-5.patch create mode 100644 recipes-browser/chromium/cef3/0002-image_util.cc-disable-warning-from-gcc-5.patch create mode 100644 recipes-browser/chromium/cef3/0003-gtest-typed-test.h-disable-warning-unused-definition.patch create mode 100644 recipes-browser/chromium/cef3/0004-SaturatedArithmetic.h-put-parentheses-to-silence-war.patch create mode 100644 recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-disable-warning-from-gcc-5.patch create mode 100644 recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch
Signature · 1 line
1.8.4.5
PATCH v2 1/5 chromium: fix gcc5 compile issues
A chromium build with gcc5 fails with warnings treated as errors.
bignum.cc, image_util.cc: strict-overflow warning
Compiles and runs on qemux86-64 with gcc 5.2.0 and still compiles on armv7a with gcc linaro-4.9.4.
--- ...0001-bignum.cc-disable-warning-from-gcc-5.patch | 39 +++++++++++++++++++++ ...-image_util.cc-disable-warning-from-gcc-5.patch | 40 ++++++++++++++++++++++ recipes-browser/chromium/chromium_40.0.2214.91.bb | 3 ++ 3 files changed, 82 insertions(+) create mode 100644 recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-disable-warning-from-gcc-5.patch create mode 100644 recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch
recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-disable-warning-from-gcc-5.patch new file +39 -0
@@ -0,0 +1,39 @@ +From 5b8c53a6bb11c8aa9b575b5a8155c25c5085f349 Mon Sep 17 00:00:00 2001 +From: Max Krummenacher <[email protected]> +Date: Fri, 6 Nov 2015 12:22:35 +0100 +Subject: [PATCH] bignum.cc: disable warning from gcc 5 + +addresses: + ../../third_party/WebKit/Source/wtf/dtoa/bignum.cc:105:10: error: assuming + signed overflow does not occur when assuming that (X + c) < X is always + false [-Werror=strict-overflow] + void Bignum::AssignDecimalString(Vector<const char> value) { + ^ + +Signed-off-by: Max Krummenacher <[email protected]> + +Upstream-Status: Pending +See the discussion on the issue in Chromium upstream: +https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/3uwBwunIa7g +--- + third_party/WebKit/Source/wtf/dtoa/bignum.cc | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/third_party/WebKit/Source/wtf/dtoa/bignum.cc b/third_party/WebKit/Source/wtf/dtoa/bignum.cc +index a000b46..6c6d336 100644 +--- a/third_party/WebKit/Source/wtf/dtoa/bignum.cc ++++ b/third_party/WebKit/Source/wtf/dtoa/bignum.cc +@@ -109,7 +109,10 @@ namespace double_conversion { + int length = value.length(); + int pos = 0; + // Let's just say that each digit needs 4 bits. ++#pragma GCC diagnostic push ++#pragma GCC diagnostic warning "-Wstrict-overflow" + while (length >= kMaxUint64DecimalDigits) { ++#pragma GCC diagnostic pop + uint64_t digits = ReadUInt64(value, pos, kMaxUint64DecimalDigits); + pos += kMaxUint64DecimalDigits; + length -= kMaxUint64DecimalDigits; +-- +1.8.4.5 +
recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +40 -0
@@ -0,0 +1,40 @@ +From 2f674d980a116075dc7123a3e243b1451e4a732d Mon Sep 17 00:00:00 2001 +From: Max Krummenacher <[email protected]> +Date: Tue, 3 Nov 2015 22:13:40 +0100 +Subject: [PATCH] image_util.cc: disable warning from gcc 5 + +addresses: + ../../ui/gfx/image/image_util.cc:50:6: error: assuming signed overflow does + not occur when assuming that (X - c) <= X is always true + [-Werror=strict-overflow] + bool VisibleMargins(const ImageSkia& image, int* leading, int* trailing) { + ^ + +Signed-off-by: Max Krummenacher <[email protected]> + +Upstream-Status: Pending +See the discussion on the issue in Chromium upstream: +https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/3uwBwunIa7g + +--- + ui/gfx/image/image_util.cc | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/ui/gfx/image/image_util.cc b/ui/gfx/image/image_util.cc +index 89a3f8c..d595da3 100644 +--- a/ui/gfx/image/image_util.cc ++++ b/ui/gfx/image/image_util.cc +@@ -68,7 +68,10 @@ bool VisibleMargins(const ImageSkia& image, int* leading, int* trailing) { + int inner_min = bitmap.width(); + for (int x = 0; x < bitmap.width(); ++x) { + for (int y = 0; y < bitmap.height(); ++y) { ++#pragma GCC diagnostic push ++#pragma GCC diagnostic warning "-Wstrict-overflow" + if (SkColorGetA(bitmap.getColor(x, y)) > kMinimumVisibleOpacity) { ++#pragma GCC diagnostic pop + inner_min = x; + break; + } +-- +1.8.4.5 +
recipes-browser/chromium/chromium_40.0.2214.91.bb +3 -0
@@ -28,7 +28,10 @@ SRC_URI = "\ file://google-chrome.desktop \ file://chromium-40/fix-build-error-with-GCC-in-Debug-mode.patch \ file://chromium-40/add_missing_stat_h_include.patch \ + file://chromium-40/0001-bignum.cc-disable-warning-from-gcc-5.patch \ + file://chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patch \ " + # # * use-egl : Without this packageconfig, the Chromium build will use GLX for creating an OpenGL context in X11, # and regular OpenGL for painting operations. Neither are desirable on embedded platforms. With this
Signature · 1 line
1.8.4.5
PATCH v2 2/5 cef3_280796.bb: change indent to 4 spaces
In reply to Max Krummenacher--- recipes-browser/chromium/cef3_280796.bb | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
recipes-browser/chromium/cef3_280796.bb +10 -10
@@ -31,21 +31,21 @@ export BUILD_TARGET_ARCH="${TARGET_ARCH}" export GYP_DEFINES="${GYP_ARCH_DEFINES} release_extra_cflags='-Wno-error=unused-local-typedefs' sysroot=''" do_configure_append() { - export PATH=${WORKDIR}/depot_tools:"$PATH" - # End of LD Workaround - #----------------------- - # Configure cef - #------------------------ - cd cef - ./cef_create_projects.sh -I ${BUILD_TARGET_ARCH}_ozone.gypi --depth ../ - cd - + export PATH=${WORKDIR}/depot_tools:"$PATH" + # End of LD Workaround + #----------------------- + # Configure cef + #------------------------ + cd cef + ./cef_create_projects.sh -I ${BUILD_TARGET_ARCH}_ozone.gypi --depth ../ + cd - } # Workaround to disable qa_configure do_qa_configure() { - echo "do_qa_configure" + echo "do_qa_configure" } do_compile() { - ninja -C out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS} cefsimple + ninja -C out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS} cefsimple }
Signature · 1 line
1.8.4.5
PATCH v2 3/5 cef3: fix gcc5 compile issues
In reply to Max KrummenacherA cef3 build with gcc5 fails with warnings treated as errors.
bignum.cc, image_util.cc: strict-overflow warninggtest-typed-test.h: unused-variable warningSaturatedArithmetic.h: parentheses warning
Compiles for qemux86 with gcc 5.2.0 and still compiles on armv7a with gcc linaro-4.9.4.
Note that the resulting binary has not been tested on a target.
--- ...0001-bignum.cc-disable-warning-from-gcc-5.patch | 39 ++++++++++++++++++++ ...-image_util.cc-disable-warning-from-gcc-5.patch | 40 ++++++++++++++++++++ ...-test.h-disable-warning-unused-definition.patch | 43 ++++++++++++++++++++++ ...ithmetic.h-put-parentheses-to-silence-war.patch | 39 ++++++++++++++++++++ recipes-browser/chromium/cef3_280796.bb | 4 ++ 5 files changed, 165 insertions(+) create mode 100644 recipes-browser/chromium/cef3/0001-bignum.cc-disable-warning-from-gcc-5.patch create mode 100644 recipes-browser/chromium/cef3/0002-image_util.cc-disable-warning-from-gcc-5.patch create mode 100644 recipes-browser/chromium/cef3/0003-gtest-typed-test.h-disable-warning-unused-definition.patch create mode 100644 recipes-browser/chromium/cef3/0004-SaturatedArithmetic.h-put-parentheses-to-silence-war.patch
recipes-browser/chromium/cef3/0001-bignum.cc-disable-warning-from-gcc-5.patch new file +39 -0
@@ -0,0 +1,39 @@ +From 5b8c53a6bb11c8aa9b575b5a8155c25c5085f349 Mon Sep 17 00:00:00 2001 +From: Max Krummenacher <[email protected]> +Date: Fri, 6 Nov 2015 12:22:35 +0100 +Subject: [PATCH] bignum.cc: disable warning from gcc 5 + +addresses: + ../../third_party/WebKit/Source/wtf/dtoa/bignum.cc:105:10: error: assuming + signed overflow does not occur when assuming that (X + c) < X is always + false [-Werror=strict-overflow] + void Bignum::AssignDecimalString(Vector<const char> value) { + ^ + +Signed-off-by: Max Krummenacher <[email protected]> + +Upstream-Status: Pending +See the discussion on the issue in Chromium upstream: +https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/3uwBwunIa7g +--- + third_party/WebKit/Source/wtf/dtoa/bignum.cc | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/third_party/WebKit/Source/wtf/dtoa/bignum.cc b/third_party/WebKit/Source/wtf/dtoa/bignum.cc +index a000b46..6c6d336 100644 +--- a/third_party/WebKit/Source/wtf/dtoa/bignum.cc ++++ b/third_party/WebKit/Source/wtf/dtoa/bignum.cc +@@ -109,7 +109,10 @@ namespace double_conversion { + int length = value.length(); + int pos = 0; + // Let's just say that each digit needs 4 bits. ++#pragma GCC diagnostic push ++#pragma GCC diagnostic warning "-Wstrict-overflow" + while (length >= kMaxUint64DecimalDigits) { ++#pragma GCC diagnostic pop + uint64_t digits = ReadUInt64(value, pos, kMaxUint64DecimalDigits); + pos += kMaxUint64DecimalDigits; + length -= kMaxUint64DecimalDigits; +-- +1.8.4.5 +
recipes-browser/chromium/cef3/0002-image_util.cc-disable-warning-from-gcc-5.patch new file +40 -0
@@ -0,0 +1,40 @@ +From 2f674d980a116075dc7123a3e243b1451e4a732d Mon Sep 17 00:00:00 2001 +From: Max Krummenacher <[email protected]> +Date: Tue, 3 Nov 2015 22:13:40 +0100 +Subject: [PATCH] image_util.cc: disable warning from gcc 5 + +addresses: + ../../ui/gfx/image/image_util.cc:50:6: error: assuming signed overflow does + not occur when assuming that (X - c) <= X is always true + [-Werror=strict-overflow] + bool VisibleMargins(const ImageSkia& image, int* leading, int* trailing) { + ^ + +Signed-off-by: Max Krummenacher <[email protected]> + +Upstream-Status: Pending +See the discussion on the issue in Chromium upstream: +https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/3uwBwunIa7g + +--- + ui/gfx/image/image_util.cc | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/ui/gfx/image/image_util.cc b/ui/gfx/image/image_util.cc +index 89a3f8c..d595da3 100644 +--- a/ui/gfx/image/image_util.cc ++++ b/ui/gfx/image/image_util.cc +@@ -68,7 +68,10 @@ bool VisibleMargins(const ImageSkia& image, int* leading, int* trailing) { + int inner_min = bitmap.width(); + for (int x = 0; x < bitmap.width(); ++x) { + for (int y = 0; y < bitmap.height(); ++y) { ++#pragma GCC diagnostic push ++#pragma GCC diagnostic warning "-Wstrict-overflow" + if (SkColorGetA(bitmap.getColor(x, y)) > kMinimumVisibleOpacity) { ++#pragma GCC diagnostic pop + inner_min = x; + break; + } +-- +1.8.4.5 +
recipes-browser/chromium/cef3/0003-gtest-typed-test.h-disable-warning-unused-definition.patch new file +43 -0
43 lines not on this page · raw message
recipes-browser/chromium/cef3/0004-SaturatedArithmetic.h-put-parentheses-to-silence-war.patch new file +39 -0
@@ -0,0 +1,39 @@ +From 947380c31305163b3cea2c7352c6a9f38922749c Mon Sep 17 00:00:00 2001 +From: Max Krummenacher <[email protected]> +Date: Sat, 7 Nov 2015 00:52:23 +0100 +Subject: [PATCH] SaturatedArithmetic.h: put parentheses to silence warning + +In file included from ../../third_party/WebKit/Source/platform/LayoutUnit.h:36:0, + from ../../third_party/WebKit/Source/platform/animation/AnimationUtilities.h:29, + from ../../third_party/WebKit/Source/platform/graphics/Color.h:29, + from ../../third_party/WebKit/Source/platform/ColorSuggestion.h:34, + from ../../third_party/WebKit/Source/platform/ColorChooserClient.h:34, + from ../../third_party/WebKit/Source/platform/ColorChooserClient.cpp:32: +../../third_party/WebKit/Source/wtf/SaturatedArithmetic.h: In function 'int32_t saturatedAddition(int32_t, int32_t)': +../../third_party/WebKit/Source/wtf/SaturatedArithmetic.h:45:26: error: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' [-Werror=parentheses] + if (!((ua ^ ub) >> 31) & (result ^ ua) >> 31) + +Signed-off-by: Max Krummenacher <[email protected]> + +Upstream-Status: Pending +Seems to be fixed in current chromium sources. +--- + third_party/WebKit/Source/wtf/SaturatedArithmetic.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/third_party/WebKit/Source/wtf/SaturatedArithmetic.h b/third_party/WebKit/Source/wtf/SaturatedArithmetic.h +index 981276f..19c6157 100644 +--- a/third_party/WebKit/Source/wtf/SaturatedArithmetic.h ++++ b/third_party/WebKit/Source/wtf/SaturatedArithmetic.h +@@ -42,7 +42,7 @@ ALWAYS_INLINE int32_t saturatedAddition(int32_t a, int32_t b) + + // Can only overflow if the signed bit of the two values match. If the signed + // bit of the result and one of the values differ it did overflow. +- if (!((ua ^ ub) >> 31) & (result ^ ua) >> 31) ++ if ((!((ua ^ ub) >> 31)) & (result ^ ua) >> 31) + result = std::numeric_limits<int>::max() + (ua >> 31); + + return result; +-- +1.8.4.5 +
recipes-browser/chromium/cef3_280796.bb +4 -0
@@ -15,6 +15,10 @@ SRC_URI = "http://people.linaro.org/~zoltan.kuscsik/chromium-browser/chromium_re git://chromium.googlesource.com/chromium/tools/depot_tools.git;protocol=https;destsuffix=depot_tools;branch=master;name=tools \ file://01_get_svn_version_from_LASTCHANGE.patch \ file://cef-simple \ + file://0001-bignum.cc-disable-warning-from-gcc-5.patch \ + file://0002-image_util.cc-disable-warning-from-gcc-5.patch \ + file://0003-gtest-typed-test.h-disable-warning-unused-definition.patch \ + file://0004-SaturatedArithmetic.h-put-parentheses-to-silence-war.patch \ " SRC_URI[md5sum] = "9efbb50283b731042e62b9bd5e312b2f" SRC_URI[sha256sum] = "f608e97dadf6ea4d885b24fd876896d46840fa39bf743ea2025075aee9fb348d"
Signature · 1 line
1.8.4.5
PATCH v2 4/5 cef3: fix build of x86-64
In reply to Max KrummenacherUse gypi file for i586 to create the configuration for the x86-64 architecture.
Upstream-Status: Inappropriate configuration
--- recipes-browser/chromium/cef3_280796.bb | 5 +++++ 1 file changed, 5 insertions(+)
recipes-browser/chromium/cef3_280796.bb +5 -0
@@ -34,6 +34,11 @@ export GYP_GENERATORS="ninja" export BUILD_TARGET_ARCH="${TARGET_ARCH}" export GYP_DEFINES="${GYP_ARCH_DEFINES} release_extra_cflags='-Wno-error=unused-local-typedefs' sysroot=''" +do_configure_prepend() { + # there is no rule for the x86-64 architecture, recycle the i586 one + cp cef/i586_ozone.gypi cef/x86_64_ozone.gypi +} + do_configure_append() { export PATH=${WORKDIR}/depot_tools:"$PATH" # End of LD Workaround
Signature · 1 line
1.8.4.5
PATCH v2 5/5 cef3: fix build with gcc 4.9.4
In reply to Max KrummenacherDuring the final link we get errors like this:
.../4.9.4/ld: warning: hidden symbol 'sqlite3_temp_directory' in obj/.../sqlite.sqlite3.o) is referenced by DSO .../usr/lib/libsoftokn3.so .../4.9.4/ld: error: treating warnings as errors
collect2: error: ld returned 1 exit status
Use chromium.bb solution to not treat linker warnings as errors.
Upstream-Status: Inappropriate configuration
--- recipes-browser/chromium/cef3_280796.bb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
recipes-browser/chromium/cef3_280796.bb +5 -1
@@ -34,6 +34,10 @@ export GYP_GENERATORS="ninja" export BUILD_TARGET_ARCH="${TARGET_ARCH}" export GYP_DEFINES="${GYP_ARCH_DEFINES} release_extra_cflags='-Wno-error=unused-local-typedefs' sysroot=''" +EXTRA_OEGYP = " \ + -Ddisable_fatal_linker_warnings=1 \ +" + do_configure_prepend() { # there is no rule for the x86-64 architecture, recycle the i586 one cp cef/i586_ozone.gypi cef/x86_64_ozone.gypi
@@ -46,7 +50,7 @@ do_configure_append() { # Configure cef #------------------------ cd cef - ./cef_create_projects.sh -I ${BUILD_TARGET_ARCH}_ozone.gypi --depth ../ + ./cef_create_projects.sh -I ${BUILD_TARGET_ARCH}_ozone.gypi --depth ../ ${EXTRA_OEGYP} cd - }
Signature · 1 line
1.8.4.5
Re: [meta-browser][PATCH v2 5/5] cef3: fix build with gcc 4.9.4
Quoted 8 lines · Max Krummenacher
During the final link we get errors like this:
.../4.9.4/ld: warning: hidden symbol 'sqlite3_temp_directory' inobj/.../sqlite.sqlite3.o) is referenced by DSO .../usr/lib/libsoftokn3.so .../4.9.4/ld: error: treating warnings as errors
collect2: error: ld returned 1 exit status
This is gold linker specific so you should disable these warning when ld-is-gold is in DISTRO_FEATURES. Its a big broad brush so lets try to make it small as we can.
Quoted 42 lines
Use chromium.bb solution to not treat linker warnings as errors.
Signed-off-by Max Krummenacher <[email protected]>Upstream-Status: Inappropriate configuration
Signed-off-by Max Krummenacher <[email protected]>---
recipes-browser/chromium/cef3_280796.bb | 6 +++++-1 file changed, 5 insertions(+), 1 deletion(-)recipes-browser/chromium/cef3_280796.bb +0
-0@@ -34,6 +34,10 @@ export GYP_GENERATORS="ninja"export BUILD_TARGET_ARCH="${TARGET_ARCH}"
export GYP_DEFINES="${GYP_ARCH_DEFINES} release_extra_cflags='-Wno-error=unused-local-typedefs' sysroot=''"recipes-browser/chromium/cef3_280796.bb +4
-0+EXTRA_OEGYP = " \ + -Ddisable_fatal_linker_warnings=1 \ +" +
do_configure_prepend(){# there is no rule for the x86-64 architecture, recycle the i586 one cp cef/i586_ozone.gypi cef/x86_64_ozone.gypirecipes-browser/chromium/cef3_280796.bb +1
-2@@ -46,7 +50,7 @@ do_configure_append() { # Configure cef #------------------------ cd cef - ./cef_create_projects.sh -I ${BUILD_TARGET_ARCH}_ozone.gypi --depth ../ + ./cef_create_projects.sh -I ${BUILD_TARGET_ARCH}_ozone.gypi --depth ../ ${EXTRA_OEGYP} cd - } --1.8.4.5
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [meta-browser][PATCH v2 5/5] cef3: fix build with gcc 4.9.4
Max,
Quoted 9 lines · Khem Raj
Quoted 6 lines · Max Krummenacher
During the final link we get errors like this:
.../4.9.4/ld: warning: hidden symbol 'sqlite3_temp_directory' inobj/.../sqlite.sqlite3.o) is referenced by DSO .../usr/lib/libsoftokn3.so .../4.9.4/ld: error: treating warnings as errors
collect2: error: ld returned 1 exit statusThis is gold linker specific so you should disable these warning when ld-is-gold is in
DISTRO_FEATURES. Its a big broad brush so lets try to make it small as we can.
I ended applying it before seeing Khem's comment; can you make the change as he proposes and send a new patch?
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
Re: [meta-browser][PATCH v2 5/5] cef3: fix build with gcc 4.9.4
Hi Otavio,
2015-11-09 11:51 GMT+01:00 Otavio Salvador <[email protected]>:
Quoted 10 lines
Max,
Quoted 7 lines · Khem Raj
Quoted 6 lines · Max Krummenacher
During the final link we get errors like this:
.../4.9.4/ld: warning: hidden symbol 'sqlite3_temp_directory' inobj/.../sqlite.sqlite3.o) is referenced by DSO .../usr/lib/libsoftokn3.so .../4.9.4/ld: error: treating warnings as errors
collect2: error: ld returned 1 exit status
Quoted 5 lines
Quoted 2 lines
This is gold linker specific so you should disable these warning when ld-is-gold is in
DISTRO_FEATURES. Its a big broad brush so lets try to make it small as we can.I ended applying it before seeing Khem's comment; can you make the change as he proposes and send a new patch?
sure, I will put up a patch tonight and send a new patch just for that issue.
Max
Quoted 8 lines · Max Krummenacher
v2:
Review Zoltan Kuscsik:
- prefer #pragma silencing of error over code refactoring
- add link to upstream discussionReview Martin Jansa:
- port fixes to cef3 also
Quoted 6 lines
Max Krummenacher (5):
chromium: fix gcc5 compile issues
cef3_280796.bb: change indent to 4 spaces
cef3: fix gcc5 compile issues
cef3: fix build of x86-64
cef3: fix build with gcc 4.9.4
Fixed both issues for qemux86 as well as qemux86-64.
They built in "bitbake world" probably for first time since they were introduced, Thanks!
Lets get this merged before jethro branch is created.
Quoted 24 lines
...0001-bignum.cc-disable-warning-from-gcc-5.patch | 39 ++++++++++++++++++++ ...-image_util.cc-disable-warning-from-gcc-5.patch | 40 ++++++++++++++++++++ ...-test.h-disable-warning-unused-definition.patch | 43 ++++++++++++++++++++++ ...ithmetic.h-put-parentheses-to-silence-war.patch | 39 ++++++++++++++++++++ recipes-browser/chromium/cef3_280796.bb | 33 ++++++++++++----- ...0001-bignum.cc-disable-warning-from-gcc-5.patch | 39 ++++++++++++++++++++ ...-image_util.cc-disable-warning-from-gcc-5.patch | 40 ++++++++++++++++++++ recipes-browser/chromium/chromium_40.0.2214.91.bb | 3 ++ 8 files changed, 266 insertions(+), 10 deletions(-) create mode 100644 recipes-browser/chromium/cef3/0001-bignum.cc-disable-warning-from-gcc-5.patch create mode 100644 recipes-browser/chromium/cef3/0002-image_util.cc-disable-warning-from-gcc-5.patch create mode 100644 recipes-browser/chromium/cef3/0003-gtest-typed-test.h-disable-warning-unused-definition.patch create mode 100644 recipes-browser/chromium/cef3/0004-SaturatedArithmetic.h-put-parentheses-to-silence-war.patch create mode 100644 recipes-browser/chromium/chromium/chromium-40/0001-bignum.cc-disable-warning-from-gcc-5.patch create mode 100644 recipes-browser/chromium/chromium/chromium-40/0002-image_util.cc-disable-warning-from-gcc-5.patchSignature · 7 lines
1.8.4.5 -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]